From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64548C433F5 for ; Thu, 20 Jan 2022 18:26:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4F636B009C; Thu, 20 Jan 2022 13:26:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BD7156B009E; Thu, 20 Jan 2022 13:26:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A51B86B00A0; Thu, 20 Jan 2022 13:26:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0224.hostedemail.com [216.40.44.224]) by kanga.kvack.org (Postfix) with ESMTP id 92DCA6B009C for ; Thu, 20 Jan 2022 13:26:04 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3B550951BA for ; Thu, 20 Jan 2022 18:26:04 +0000 (UTC) X-FDA: 79051494648.06.A815CDD Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) by imf17.hostedemail.com (Postfix) with ESMTP id DB2F54000A for ; Thu, 20 Jan 2022 18:26:03 +0000 (UTC) Received: by mail-il1-f172.google.com with SMTP id r15so5717213ilj.7 for ; Thu, 20 Jan 2022 10:26:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VM3tBp/CA+4wTCBfmyWMTm1eADRMbsKEHQheO5QR1dg=; b=kjWd/gluHnZp28leoLrw9gVa9JtC0gx9dMDDSiGyx17HhEXqLHPyCYCzdGIexOoC8W 4G7du2uwS/k0/bIytNp0rc0EgcgQAZOWNTcelWkw1KWz8v25VxHJv8bBaEu+xev52pr0 yDCNIMUZtZFYIhSqsr8nRFoqnYiBUWRDmCSYVDp42bEEPcVGUv98j6uMJhzrhqkjmY1A 0sUNXlpXKp9uDnK24r1+W+twtCQJHhJ0fpOGJ6Aml6R0tKZ3uJu/b/xwW1bfHrjxIUWK dUTOLmDhjr/FzvCK5yRQJJEgKC7rlQODvqDIN9S3XcNzqprC79Wf9xJ3mvKxxxX7Fk/p +KQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VM3tBp/CA+4wTCBfmyWMTm1eADRMbsKEHQheO5QR1dg=; b=fzqWb535nNOOAj7SlMmVw9+/R8RRRzv4DFvp+RZeceEAxyk+zX24r41B/OMOwEWmVF U4WbCYcPKL7g+Wapdwc32n6A0NeHk9x8TD1Bj1u/zBhTLltVrW0uBYEeDEhtV7zCY9Y8 r0886P0TWEUgZwMj//0rALXjxDOE3EZfwevfdIXivKrpn0BwUGW927SGhyL8TQNewT9v 0BtCNl4pavFrVm2KUCfx5lkoY2kXYoJYWl2iKE9nOQwzrgQiXcvXou3aLNprt60mJ0zO fjc3NHwwWxRqD1VI9Orh7TtOwW5gUHg6i0SvDERUObDwCIB+G9p1IvQsU5LQt+MXw6gv 7Lqw== X-Gm-Message-State: AOAM5323XrrFuTMai2raOVRYajoX49sMX0Yg1q3eWtOPyOuna9PDdm6L C7gHGvc07U1yh+dmmCS0ZkCzaLEspZkmBRqv1fwubQ== X-Google-Smtp-Source: ABdhPJyQ3HkdPr2dC0EIXetDOosxZkhDjZaOvxxWcA/Q1gWYGTNgeHnozQdeSnPQOpPK5nbkCvbWVSiPRWzUg5y1bYI= X-Received: by 2002:a05:6e02:1847:: with SMTP id b7mr135351ilv.300.1642703163043; Thu, 20 Jan 2022 10:26:03 -0800 (PST) MIME-Version: 1.0 References: <20220120042513.1648831-1-pasha.tatashin@soleen.com> <20220120042513.1648831-4-pasha.tatashin@soleen.com> In-Reply-To: <20220120042513.1648831-4-pasha.tatashin@soleen.com> From: Wei Xu Date: Thu, 20 Jan 2022 10:25:52 -0800 Message-ID: Subject: Re: [PATCH 3/3] mm/page_table_check: use unsigned long for page counters To: Pasha Tatashin Cc: Linux Kernel Mailing List , Linux MM , Andrew Morton , David Rientjes , Paul Turner , Greg Thelen , mingo@redhat.com, will@kernel.org, rppt@kernel.org, Dave Hansen , hpa@zytor.com, aneesh.kumar@linux.ibm.com, jirislaby@kernel.org, songmuchun@bytedance.com, qydwhotmail@gmail.com, Hugh Dickins , Zi Yan , anshuman.khandual@arm.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: DB2F54000A X-Stat-Signature: ywhnc57xsezhcd5fz5hnhpx1nsiwpzqs Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="kjWd/glu"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of weixugc@google.com designates 209.85.166.172 as permitted sender) smtp.mailfrom=weixugc@google.com X-Rspamd-Server: rspam02 X-HE-Tag: 1642703163-337254 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 19, 2022 at 8:25 PM Pasha Tatashin wrote: > > For the consistency, use "unsigned long" for all page counters. > > Signed-off-by: Pasha Tatashin > --- > mm/page_table_check.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/page_table_check.c b/mm/page_table_check.c > index 2341ac382cd5..22dd285ab8d5 100644 > --- a/mm/page_table_check.c > +++ b/mm/page_table_check.c > @@ -86,8 +86,8 @@ static void page_table_check_clear(struct mm_struct *mm, unsigned long addr, > { > struct page_ext *page_ext; > struct page *page; > + unsigned long i; > bool anon; > - int i; > > if (!pfn_valid(pfn)) > return; > @@ -121,8 +121,8 @@ static void page_table_check_set(struct mm_struct *mm, unsigned long addr, > { > struct page_ext *page_ext; > struct page *page; > + unsigned long i; > bool anon; > - int i; > > if (!pfn_valid(pfn)) > return; > @@ -186,10 +186,10 @@ static void pmd_clear_level(struct mm_struct *mm, unsigned long addr, > void __page_table_check_zero(struct page *page, unsigned int order) > { > struct page_ext *page_ext = lookup_page_ext(page); > - int i; > + unsigned long i; > > BUG_ON(!page_ext); > - for (i = 0; i < (1 << order); i++) { > + for (i = 0; i < (1ul << order); i++) { > struct page_table_check *ptc = get_page_table_check(page_ext); > > BUG_ON(atomic_read(&ptc->anon_map_count)); > -- > 2.34.1.703.g22d0c6ccf7-goog > Reviewed-by: Wei Xu