From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8E4CD2069A for ; Wed, 16 Oct 2024 05:29:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C135E6B007B; Wed, 16 Oct 2024 01:29:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC2C56B0082; Wed, 16 Oct 2024 01:29:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB1786B0083; Wed, 16 Oct 2024 01:29:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8F5C06B007B for ; Wed, 16 Oct 2024 01:29:27 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 384C8AAB5B for ; Wed, 16 Oct 2024 05:29:08 +0000 (UTC) X-FDA: 82678337238.27.90F3CB5 Received: from mail-vs1-f45.google.com (mail-vs1-f45.google.com [209.85.217.45]) by imf08.hostedemail.com (Postfix) with ESMTP id B1538160003 for ; Wed, 16 Oct 2024 05:29:19 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=K5XLT3KC; spf=pass (imf08.hostedemail.com: domain of weixugc@google.com designates 209.85.217.45 as permitted sender) smtp.mailfrom=weixugc@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729056421; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZHCRbjbdAz/4L9m7QyVF8NK+nNXYwETwyMu84SQLi/s=; b=asGZFQFFDKYQSZp5Z5poH/NIk0J1Tsca3eilxIbxGYnFBkySjxhz4qJWyoMahLTYuSYS1O DdeA9webUHjLxVXRAAZG1qOC8EVjhgxYKlrXlOdCH2WCskmQBPQe/iJDiIjs/bm6xK9Zo7 X7/MKh0M3Jir2tLNl6piFf7WMfftIDs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729056421; a=rsa-sha256; cv=none; b=bYkWliUYwkqgYIXRaRHd8kR7aMGkgRLHeeh7UtrG6jSxLcCRLtBHpLw9i+V7UBoWTvdl9P JenIsxlHxIlhFMgiIv6VkNsaiuHHw8uzreSbXXT0TFVB4QkPHShb0vk1inMN2jz19s6d5V wd7El45ywS0iAGKbimr+y2OXOV8zwUs= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=K5XLT3KC; spf=pass (imf08.hostedemail.com: domain of weixugc@google.com designates 209.85.217.45 as permitted sender) smtp.mailfrom=weixugc@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-vs1-f45.google.com with SMTP id ada2fe7eead31-4a482407e84so1133605137.0 for ; Tue, 15 Oct 2024 22:29:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729056564; x=1729661364; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZHCRbjbdAz/4L9m7QyVF8NK+nNXYwETwyMu84SQLi/s=; b=K5XLT3KCh131OLK65Jv+/kCgnH0MCZgzbHTwS/3/exfPMpkJcVYDjn0CIu9lP+gvWM z3yz8/q4KJaALMrvG002jILy7aAjAUIEK4b9NK/ria/JGJ2BxYrbM4K3QmlwoYbrFfFP fQzrBpeZlI+4lciGeCK97zv1DsBz7PoaOSUbxVRlOUr9kp9p3KO2loY4VJxBmGZEglv8 MEjYb96yireAGv770Q7i13Cqa1ewys7w8hdjztEHxMQeRVRek6pwgzWa8WBXgFSPkwQM DcN8gvTcC8mLl4WTkejErX+IxrDbbG+7tw/18yDUACNM4iKXT1DNQzBpUHlKG+l2Osdq D1OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729056564; x=1729661364; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZHCRbjbdAz/4L9m7QyVF8NK+nNXYwETwyMu84SQLi/s=; b=JJxWVVp4PIcRiX25+nTd7O9whHGGz01KRzME10k1njuC5q2ciL8Z/w+WxUsGVIBeXU DJoZ9fjKET1TdOdlCBSsxJyzk6JZxOda3bQ/SGWN3/Xx/cUozgONjLjrEq/qY2dvJayc 0MGIDzI33LUxVei/fRdQMkvYlF25fTQFUoG7qmYhG8AfBXyxiSEV3kUxmpDn5RGA39J3 k0WEskyfK8xmTtgu9RmBEIbWCMeh3U1Qfdbo5Lt6+1nC0fQ1FF6YySNQgZHlkDdLnj08 xHDa6urJbjNvWlSxBnZ7KDrRxZb9OwqF8tXc0B5IbismnUnSjsV7ScQdYwq48HC18txE FDeQ== X-Forwarded-Encrypted: i=1; AJvYcCUD1EL2XUdMCuTCOXO/R0ICYRLOzjzH+fnaKyznbtEVzsTF8r4SckJ/gO2Z+eZT9TRPGJrscs0oxw==@kvack.org X-Gm-Message-State: AOJu0YyRaxfvPwuWv6dfJP33R0EcgGduASazcAMW0yenxekAnwwA/Dfz hxbTooTqb1vpL9hk7eNRoZgJ6wJI0loIPDm2hPmQ8ZYAoJUKH22yaCQs9PowdCasOEge9OrSteN 5Zy2F2kun3F0aVHKIcpgyPA3ryynXX1R+azpIAas9GasUXQefRw== X-Google-Smtp-Source: AGHT+IHe063J7pXhFLpixFxwYFCOgLDVW7uXhaRIBHNBeflbwaAODLbf8/XMUnernCGwtqA/8rd9MVqwcmkmr63VSIY= X-Received: by 2002:a05:6102:ccd:b0:4a4:8a29:a902 with SMTP id ada2fe7eead31-4a5b59394aemr2515524137.3.1729056564306; Tue, 15 Oct 2024 22:29:24 -0700 (PDT) MIME-Version: 1.0 References: <20241014221211.832591-1-weixugc@google.com> In-Reply-To: From: Wei Xu Date: Tue, 15 Oct 2024 22:29:11 -0700 Message-ID: Subject: Re: [PATCH 1/2] mm/mglru: only clear kswapd_failures if reclaimable To: Yu Zhao Cc: Andrew Morton , Axel Rasmussen , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B1538160003 X-Stat-Signature: j5kii4bs7rr7c7tjjo9p91pjn6kkkxuu X-HE-Tag: 1729056559-111608 X-HE-Meta: U2FsdGVkX18aFfRKwyJCLVpV+9WtC2JRCOszFVtBuedctLtlR4CliKacfMgrWP88LdlK6hedA/wDSy5TKDSGzp/h2uavPgNcw92quGtY4ejG2Relxs53KrkoBNLPgQdxnXJYIyit511oYOLDwZ9RYc/sSNqQxtmlP6TS+PRrVCTwnHLG9z9fgzFvxGSugXycW3rMnjJU93uiHqhy7ANjLq2+WJLVDG4sP3dm57woNWIv5zutNU8+ezyGWEUikZmcRIkvqDPzQUHFBorQZDLraMZbpghjtYRasHUm+xLRM4S7ZR/iTD32f5Oz019EqKQTqDsQxP4wCKNvO91shRZdF34wf4QhV62Ne5Xr9nsdF+JmUqOpDz0DHknGlDfMHbb7nPhbJHcbj20BdmSnxEBFUZy8NWBP6F+JRyQGZAMPTK38tIo23f3ugI/hIT08SwVrwiGNmBF3YXnju4KIDzjQD/NPuhy9J2D7lxRSGQrCcbdGaTvbR7bDpkJg5E3UWJO73AXTndbfe3BK0OIxC7SzRhNGlg7KZBWL/GwGVzlLPQp/nwVNoNzNmomOZhpM7SIryyrpckpQ/KNw5nxDnYl873PATDGoG0XFfiN6KIckfAwOtTr2FqvklsEzNQ5uUrK9CetNb8NBkdJiLY85JqYeUyW4V18Dya+sxHp6CRguJVd5JEK7pvDY4DRPiiLPwnVpgP9BnUjmMam+7DAM8t1L7Wqiq5vpy6e+lT6GCkeezN15mcEg2hdl72R320OSsolJvfeAvk5vHXc5yaiBYBmJ/Bk9wIIzqc+L16SK6NkWXo6AjwwauWhukleWbyLC10KHHiYTgoYtdwLVznBRNc4k95in1yYpbMPQn2tU+CcI+gwUxy4oiUfdtchq9uqEZfWvLxxYIG0/XiA6mhgTluZQkdEoLz5DghC0l4s6GjZFAWUsKecE2lmlR6vZjsJPypqmK32HgMLPilWMfj7RF1o J2R4/zd1 JLS8d2eKi5sKw/cAswtuhGfndLKRKFcQt5to9cP8vwF2Ib6BxW1RBbxt0//0J5v9RuRojmbbD9cGNCxnkiDxc7GLim+lz5jBJxqPxDCzo8KxDFvceTfRUJED5ScWtHy03+K18ILqpdeGnTET+nb+2GDDBMN/z7xJktu7i3OOAmmZi00V14JNUiOshkqqNQGDkRdozvOAWpkkaC4NIQPJuvdFmUe3zMKyh48K+T7zW9RWAdWirep2yQce+C4eFShPw2Ax1sHNCNbFKYWE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000244, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 15, 2024 at 9:57=E2=80=AFPM Yu Zhao wrote: > > On Mon, Oct 14, 2024 at 4:12=E2=80=AFPM Wei Xu wrote= : > > > > lru_gen_shrink_node() unconditionally clears kswapd_failures, which > > can prevent kswapd from sleeping and cause 100% kswapd cpu usage even > > when kswapd repeatedly fails to make progress in reclaim. > > > > Only clear kswap_failures in lru_gen_shrink_node() if reclaim makes > > some progress, similar to shrink_node(). > > > > Fixes: e4dde56cd208 ("mm: multi-gen LRU: per-node lru_gen_folio lists") > > Signed-off-by: Wei Xu > > --- > > mm/vmscan.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index 50dc06d55b1d..9d1e1c4e383d 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -4970,8 +4970,8 @@ static void lru_gen_shrink_node(struct pglist_dat= a *pgdat, struct scan_control * > > > > blk_finish_plug(&plug); > > done: > > Nit: the "done:" isn't used anymore, so better just remove it. > "goto done" is still used at the beginning of lru_gen_shrink_node(). We can refactor the code to remove it. But it is better to be handled in a separate change. > > - /* kswapd should never fail */ > > - pgdat->kswapd_failures =3D 0; > > + if (sc->nr_reclaimed > reclaimed) > > + pgdat->kswapd_failures =3D 0; > > } > > > > /*********************************************************************= ********* > > -- > > 2.47.0.rc1.288.g06298d1525-goog > > > >