From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E299C433F5 for ; Fri, 22 Apr 2022 20:32:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 124B56B0073; Fri, 22 Apr 2022 16:32:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D5A26B0074; Fri, 22 Apr 2022 16:32:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB6596B0075; Fri, 22 Apr 2022 16:32:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id DBF966B0073 for ; Fri, 22 Apr 2022 16:32:41 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id B477F80D14 for ; Fri, 22 Apr 2022 20:32:41 +0000 (UTC) X-FDA: 79385663322.08.BE2D6E6 Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com [209.85.222.43]) by imf01.hostedemail.com (Postfix) with ESMTP id 06D1740027 for ; Fri, 22 Apr 2022 20:32:38 +0000 (UTC) Received: by mail-ua1-f43.google.com with SMTP id i16so840409uat.5 for ; Fri, 22 Apr 2022 13:32:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Z7l1siJ5Z2fXTsLPc04ivVbBuS3c9PMnxxuVpF86Xzs=; b=IIo57g2PIuT0TvD4bSVMcYrJl+6VE3sP8KhJktIn+xmBDyQuNInfkEWId6ES9YYH/2 wUd/ofdCTjanaKSZW7IxdjZcO03qfDhbio9LnGBAKEd3/kt4cVXZ8y+l9qx89zQHAkA+ Z7D7NSyj0670eg9sdw8/y638r/O+DRZSVNCsVTEK2n0iAcJ9RaOs8SkxU29Lj+DgTIUt h55VNvhWwv/iXNB06BL8q3GnU5rgWacC1pamJA6tOPHyGog9wh+y66fANtiSw/p3i548 0GX3wn3gBgdUAIY/0HgbGHzvIISAtuYePXflkG8S7dkrvVX/4HAJyiq/nzCOoVMcc9qj 4fzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z7l1siJ5Z2fXTsLPc04ivVbBuS3c9PMnxxuVpF86Xzs=; b=sGaySVDPiBPaQizi4Wq1dkLRJytxSjpPpZTyXxQ3VxTauGBeL1iSjLZG4VOx6t0ffv OmWBEG7P6t/rg+oRJuYYcljp9HiTkmKObIA5ti7gzoqQqZm5d2FrfpaO9RVZfMFJD/53 ZXG/zBtkWJR67Mjba12xCJOOEcRi4JMtpog9jszdCxdhU9b3g5a3N7Yk21S7vGsAGbdO LdAlnE28YZfdnc/hfhYT2kB+AdKvnnbG9xnHCHQ7FseuQ9ik/QcSemwl4T4lwNipQy/M p601Sa5jX8psD/0FGFb0sw7SZbX54UyULcdTXS6QXUnEHYUddDX1zY4QDZo/HacartTO XF5g== X-Gm-Message-State: AOAM532A6fefPSHcwmAf6Cyg+dLCD95Q9KSw/nOA62/FwLWhzrjEK/UA dntaaDCivlaAq/GnOnR2uW0FzvSq2+DaxAiN0NtzSg== X-Google-Smtp-Source: ABdhPJxVykdcIn3WVbtHm5IZKYZ2b7ht5iGQlarXHMqHwHtAYcGofKLyCRwTcQILqNllL8yPFcHqRJ/ct594Gx94lpU= X-Received: by 2002:a9f:356c:0:b0:359:5bee:d1f8 with SMTP id o99-20020a9f356c000000b003595beed1f8mr2372276uao.60.1650659560491; Fri, 22 Apr 2022 13:32:40 -0700 (PDT) MIME-Version: 1.0 References: <20220422195516.10769-1-jvgediya@linux.ibm.com> <20220422195516.10769-4-jvgediya@linux.ibm.com> In-Reply-To: <20220422195516.10769-4-jvgediya@linux.ibm.com> From: Wei Xu Date: Fri, 22 Apr 2022 13:32:29 -0700 Message-ID: Subject: Re: [PATCH v3 3/7] drivers/base/node: Add support to write node_states[] via sysfs To: Jagdish Gediya Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, dave.hansen@linux.intel.com, ying.huang@intel.com, aneesh.kumar@linux.ibm.com, shy828301@gmail.com, gthelen@google.com, dan.j.williams@intel.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 06D1740027 X-Stat-Signature: z4qpx8x4b8r45m41qyemdzfcjqmosgj4 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=IIo57g2P; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of weixugc@google.com designates 209.85.222.43 as permitted sender) smtp.mailfrom=weixugc@google.com X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1650659558-733226 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 22, 2022 at 12:55 PM Jagdish Gediya wrote: > > Current /sys/devices/system/node/* interface doesn't support > to write node_states[], however write support is needed in case > users want to set them manually e.g. when user want to override > default N_DEMOTION_TARGETS found by the kernel. > > Rename existing _NODE_ATTR to _NODE_ATTR_RO and introduce new > _NODE_ATTR_RW which can be used for node_states[] which can > be written from sysfs. > > It may be necessary to validate written values and take action > based on them in a state specific way so a callback 'write' is > introduced in 'struct node_attr'. > > A new function demotion_targets_write() is added to validate > the input nodes for N_DEMOTION_TARGETS which should be subset > of N_MEMORY and to build new demotion list based on new nodes. > > Signed-off-by: Jagdish Gediya Acked-by: Wei Xu > --- > drivers/base/node.c | 62 +++++++++++++++++++++++++++++++++++---------- > 1 file changed, 49 insertions(+), 13 deletions(-) > > diff --git a/drivers/base/node.c b/drivers/base/node.c > index 6eef22e6413e..e03eedbc421b 100644 > --- a/drivers/base/node.c > +++ b/drivers/base/node.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > > static struct bus_type node_subsys = { > .name = "node", > @@ -1013,6 +1014,7 @@ void unregister_one_node(int nid) > struct node_attr { > struct device_attribute attr; > enum node_states state; > + int (*write)(nodemask_t nodes); > }; > > static ssize_t show_node_state(struct device *dev, > @@ -1024,23 +1026,57 @@ static ssize_t show_node_state(struct device *dev, > nodemask_pr_args(&node_states[na->state])); > } > > -#define _NODE_ATTR(name, state) \ > - { __ATTR(name, 0444, show_node_state, NULL), state } > +static ssize_t store_node_state(struct device *s, > + struct device_attribute *attr, > + const char *buf, size_t count) > +{ > + nodemask_t nodes; > + struct node_attr *na = container_of(attr, struct node_attr, attr); > + > + if (nodelist_parse(buf, nodes)) > + return -EINVAL; > + > + if (na->write) { > + if (na->write(nodes)) > + return -EINVAL; > + } else { > + node_states[na->state] = nodes; > + } > + > + return count; > +} > + > +static int demotion_targets_write(nodemask_t nodes) > +{ > + if (nodes_subset(nodes, node_states[N_MEMORY])) { > + node_states[N_DEMOTION_TARGETS] = nodes; > + set_migration_target_nodes(); > + return 0; > + } > + > + return -EINVAL; > +} > + > +#define _NODE_ATTR_RO(name, state) \ > + { __ATTR(name, 0444, show_node_state, NULL), state, NULL } > + > +#define _NODE_ATTR_RW(name, state, write_fn) \ > + { __ATTR(name, 0644, show_node_state, store_node_state), state, write_fn } > > static struct node_attr node_state_attr[] = { > - [N_POSSIBLE] = _NODE_ATTR(possible, N_POSSIBLE), > - [N_ONLINE] = _NODE_ATTR(online, N_ONLINE), > - [N_NORMAL_MEMORY] = _NODE_ATTR(has_normal_memory, N_NORMAL_MEMORY), > + [N_POSSIBLE] = _NODE_ATTR_RO(possible, N_POSSIBLE), > + [N_ONLINE] = _NODE_ATTR_RO(online, N_ONLINE), > + [N_NORMAL_MEMORY] = _NODE_ATTR_RO(has_normal_memory, N_NORMAL_MEMORY), > #ifdef CONFIG_HIGHMEM > - [N_HIGH_MEMORY] = _NODE_ATTR(has_high_memory, N_HIGH_MEMORY), > + [N_HIGH_MEMORY] = _NODE_ATTR_RO(has_high_memory, N_HIGH_MEMORY), > #endif > - [N_MEMORY] = _NODE_ATTR(has_memory, N_MEMORY), > - [N_CPU] = _NODE_ATTR(has_cpu, N_CPU), > - [N_GENERIC_INITIATOR] = _NODE_ATTR(has_generic_initiator, > - N_GENERIC_INITIATOR), > - [N_DEMOTION_TARGETS] = _NODE_ATTR(demotion_targets, > - N_DEMOTION_TARGETS), > - > + [N_MEMORY] = _NODE_ATTR_RO(has_memory, N_MEMORY), > + [N_CPU] = _NODE_ATTR_RO(has_cpu, N_CPU), > + [N_GENERIC_INITIATOR] = _NODE_ATTR_RO(has_generic_initiator, > + N_GENERIC_INITIATOR), > + [N_DEMOTION_TARGETS] = _NODE_ATTR_RW(demotion_targets, > + N_DEMOTION_TARGETS, > + demotion_targets_write), > }; > > static struct attribute *node_state_attrs[] = { > -- > 2.35.1 >