From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 133B3C433ED for ; Sat, 10 Apr 2021 04:10:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 88ED161185 for ; Sat, 10 Apr 2021 04:10:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88ED161185 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DC8226B006C; Sat, 10 Apr 2021 00:10:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D655E6B006E; Sat, 10 Apr 2021 00:10:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C075C6B0070; Sat, 10 Apr 2021 00:10:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0032.hostedemail.com [216.40.44.32]) by kanga.kvack.org (Postfix) with ESMTP id A29216B006C for ; Sat, 10 Apr 2021 00:10:34 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4986718295477 for ; Sat, 10 Apr 2021 04:10:34 +0000 (UTC) X-FDA: 78015130788.19.9FA6B01 Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) by imf28.hostedemail.com (Postfix) with ESMTP id 97ECF2000242 for ; Sat, 10 Apr 2021 04:10:34 +0000 (UTC) Received: by mail-io1-f44.google.com with SMTP id j26so7963766iog.13 for ; Fri, 09 Apr 2021 21:10:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BKAvJDJpixiodyXdGAtmOzYV+aUqoGHeW4SHKi5+c6A=; b=ChU5bwjDor51WkS1j2wI24x9YETvq4RsPXESxZ2Aw896qAzrpNIkCo6umVMY8os5K4 tB3f/N9yF37+Tpow9JN0mFCWgjjI2Ow0yycmjaSckCw8eJKbxRSToEXQVHanw4qwyBat Ho8SmOhT9L2dhLQ9fqWt/oNE+00CGHoW9rt3vFNcSorprwk0iygiQgiXhGYXmVKrLwsq bgCyEOeRJTPZ4phuKxCQoeXomCu8X3O841q8HRF8cfMuzuS+WW89y1k3YaW5fnUsdluw NjS1EGD+CGjJyz7vQmKT6DveIzOiKRLB/gAu6c5aTY8QtptBdJXd9EtauNukDFpmYcpd rwFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BKAvJDJpixiodyXdGAtmOzYV+aUqoGHeW4SHKi5+c6A=; b=eNdJi+gZbCaJNoCq2hElpmXD/Iq5FKDm0WwkxTztW5RJICPX9MnV4an33YjBnNvmTX rBKr3xUKQ8ymx2aQLn9uDwtCBDryEtT0ceojii0bQiXjyFbJehP8VIK03/NSSt6zObG7 2u9Z8rZ4OwpN00mutBMBOxZoU4WmoM0Nt9QvMaMQaHnKHDdzapCV4DRhUOI2KD0h+7In bL8cJh7bn0iITgfjNrmcmlNdf05uYnl3XnOvtUc0kvzdDFpwpDJGP6BWYJL7VoWNEgOr TxnhWl25AbH33Ta20rBrT/8/KcOc1Q/rxN/vszEkrEZav+zuvVkoP7ygU0sRuRteYXxv j/Kw== X-Gm-Message-State: AOAM5316Kt8gfPQ6wfRQBbDDVHjApTVEuNC06edzNUu1qxMGhUqI8WQ9 kH64HVvILKrAIJ2EHgPDzXvjTnrrfevUY/7E5/2ELQ== X-Google-Smtp-Source: ABdhPJz7UP91zKepWccuBuz4ccEnrvffKtIu7vZDqGGd4ab+dFazMOWxfufBjGZryAXz2dNP2izlSu8TYgfSyWjC+BQ= X-Received: by 2002:a05:6638:210d:: with SMTP id n13mr17839165jaj.100.1618027833041; Fri, 09 Apr 2021 21:10:33 -0700 (PDT) MIME-Version: 1.0 References: <20210401183216.443C4443@viggo.jf.intel.com> <20210401183235.BCC49E8B@viggo.jf.intel.com> In-Reply-To: <20210401183235.BCC49E8B@viggo.jf.intel.com> From: Wei Xu Date: Fri, 9 Apr 2021 21:10:21 -0700 Message-ID: Subject: Re: [PATCH 10/10] mm/migrate: new zone_reclaim_mode to enable reclaim migration To: Dave Hansen Cc: Linux MM , Linux Kernel Mailing List , Yang Shi , David Rientjes , Huang Ying , Dan Williams , David Hildenbrand , Oscar Salvador Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 97ECF2000242 X-Stat-Signature: 8uicq3tgoc657xej3y5nhert9whjg3kk Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf28; identity=mailfrom; envelope-from=""; helo=mail-io1-f44.google.com; client-ip=209.85.166.44 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618027834-873822 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 1, 2021 at 11:35 AM Dave Hansen wrote: > This proposes extending the existing "zone_reclaim_mode" (now > now really node_reclaim_mode) as a method to enable it. Nit: now now -> now > We are open to any alternative that allows end users to enable > this mechanism or disable it it workload harm is detected (just > like traditional autonuma). Nit: it it -> it if > diff -puN mm/vmscan.c~RECLAIM_MIGRATE mm/vmscan.c > --- a/mm/vmscan.c~RECLAIM_MIGRATE 2021-03-31 15:17:40.339000190 -0700 > +++ b/mm/vmscan.c 2021-03-31 15:17:40.357000190 -0700 > @@ -1074,6 +1074,9 @@ static bool migrate_demote_page_ok(struc > VM_BUG_ON_PAGE(PageHuge(page), page); > VM_BUG_ON_PAGE(PageLRU(page), page); > > + if (!(node_reclaim_mode & RECLAIM_MIGRATE)) > + return false; > + As I commented on an earlier patch in this series, the RECLAIM_MIGRATE check needs to be added to other new callers of next_demotion_node() as well to avoid unnecessarily splitting THP pages when neither swap nor RECLAIM_MIGRATE is enabled. It can be too late to check RECLAIM_MIGRATE only in migrate_demote_page_ok().