From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1028CC433EF for ; Fri, 22 Apr 2022 20:29:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 965BE6B0073; Fri, 22 Apr 2022 16:29:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9138F6B0074; Fri, 22 Apr 2022 16:29:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B4536B0075; Fri, 22 Apr 2022 16:29:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 69A606B0073 for ; Fri, 22 Apr 2022 16:29:35 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 44B4E93F for ; Fri, 22 Apr 2022 20:29:35 +0000 (UTC) X-FDA: 79385655510.24.2725914 Received: from mail-vs1-f45.google.com (mail-vs1-f45.google.com [209.85.217.45]) by imf13.hostedemail.com (Postfix) with ESMTP id 693A020033 for ; Fri, 22 Apr 2022 20:29:31 +0000 (UTC) Received: by mail-vs1-f45.google.com with SMTP id m14so8495134vsp.11 for ; Fri, 22 Apr 2022 13:29:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PLxWgfNIqb0f6MOCKWhoyP5UgmjbIvJbEaB9oK2PBEI=; b=KmWunHFwmhZ7+/Z0zkVhdm6bYlodk2R4jIYhIdJ6TpI7Ncz4EEZv2P5/ZKRin+K3CY LEW2VPEsRB9iu9U1wVrDx7H2ZCsP0X+PwNoiQxWuLBXC9iefYrWR5t7bwmyHfk69wuWW 4xvMPSD5UpI88QZKV32T0JqeArgRbKqUeVQqJ971ag1+dUKy1Qr5odxP375OcM/gabpc ObNCGU3a9bXSrWXKXimjbFYaaWDdU5LDkfqHpHjktW5joHj6DTM2j60L4V+h33qn5D0q lEuny2FIILqyXyJ/9I2br9SYrobHi2UnXKujmJFPKRAYYh/ul/5irlOqb7vyELRB8O6u eZ0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PLxWgfNIqb0f6MOCKWhoyP5UgmjbIvJbEaB9oK2PBEI=; b=8LQuWchuLKKaXkIyfSSNf0SJNqSK9L3SnEIN8s6EtdXRB2l3UTIML0gpxrGWqixUbL ZcrwKADj6E7G46go0Iqr+NSHXuOxYzvT3MZZWjjiD2HYs5Mql3h1gPZDaq2k5EneU7m2 S1+CtYdkDNlAejonj688KL5ItnohGWgPAaXVu8mnXQsQc8tguOF6NLzSt+HwoTI4R9li 6D7igv9j8dqbE2XzV3DodRuH20fYAVjnRqeOfEoumKuxh/kv/XV2kD73jjsG9ljb0hU5 A02VUn+8JR4vDum1EYdW7lbYyl4xalV1m58Wb+3eeJVEawefVMKWq/HkE57sbA2PL6Hb 9q1g== X-Gm-Message-State: AOAM531LSVMcCJivsNfquxNaHvqTp1qeawlZ2x+wSpOenmQZY3RYINKF UCCD1a40vlAiDO5PCPaYwkOgBauzI5EJmRk/pRZ1Pg== X-Google-Smtp-Source: ABdhPJxiQkyNiLVcGmbpo7Dg+U6BVB6SXJai1P6lBBfFMBRonhtgSnpYJpjNKAc7LY5s1oAGhuEevZr/abqxUfffNCs= X-Received: by 2002:a05:6102:3106:b0:32a:18c8:1633 with SMTP id e6-20020a056102310600b0032a18c81633mr2070333vsh.51.1650659373899; Fri, 22 Apr 2022 13:29:33 -0700 (PDT) MIME-Version: 1.0 References: <20220422195516.10769-1-jvgediya@linux.ibm.com> <20220422195516.10769-3-jvgediya@linux.ibm.com> In-Reply-To: <20220422195516.10769-3-jvgediya@linux.ibm.com> From: Wei Xu Date: Fri, 22 Apr 2022 13:29:22 -0700 Message-ID: Subject: Re: [PATCH v3 2/7] mm: demotion: Add new node state N_DEMOTION_TARGETS To: Jagdish Gediya Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, dave.hansen@linux.intel.com, ying.huang@intel.com, aneesh.kumar@linux.ibm.com, shy828301@gmail.com, gthelen@google.com, dan.j.williams@intel.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 693A020033 X-Stat-Signature: 3gzw3cgcenqrhb79n55w9fqjawnidsct Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=KmWunHFw; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of weixugc@google.com designates 209.85.217.45 as permitted sender) smtp.mailfrom=weixugc@google.com X-Rspam-User: X-HE-Tag: 1650659371-77580 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 22, 2022 at 12:55 PM Jagdish Gediya wrote: > > Some systems(e.g. PowerVM) have DRAM(fast memory) only NUMA node > which are N_MEMORY as well as slow memory(persistent memory) only > NUMA node which are also N_MEMORY. As the current demotion target > finding algorithm works based on N_MEMORY and best distance, it can > choose DRAM only NUMA node as demotion target instead of persistent > memory node on such systems. If DRAM only NUMA node is filled with > demoted pages then at some point new allocations can start falling > to persistent memory, so basically cold pages are in fast memory > (due to demotion) and new pages are in slow memory, this is why > persistent memory nodes should be utilized for demotion and dram node > should be avoided for demotion so that they can be used for new > allocations. > > Add new state N_DEMOTION_TARGETS, node_states[N_DEMOTION_TARGETS] > then can be used to hold the list of nodes which can be used > as demotion targets, later patches in the series builds demotion > targets based on nodes available in node_states[N_DEMOTION_TARGETS]. > > Signed-off-by: Aneesh Kumar K.V > Signed-off-by: Jagdish Gediya > --- > drivers/base/node.c | 4 ++++ > include/linux/nodemask.h | 1 + > 2 files changed, 5 insertions(+) > Acked-by: Wei Xu > diff --git a/drivers/base/node.c b/drivers/base/node.c > index ec8bb24a5a22..6eef22e6413e 100644 > --- a/drivers/base/node.c > +++ b/drivers/base/node.c > @@ -1038,6 +1038,9 @@ static struct node_attr node_state_attr[] = { > [N_CPU] = _NODE_ATTR(has_cpu, N_CPU), > [N_GENERIC_INITIATOR] = _NODE_ATTR(has_generic_initiator, > N_GENERIC_INITIATOR), > + [N_DEMOTION_TARGETS] = _NODE_ATTR(demotion_targets, > + N_DEMOTION_TARGETS), > + > }; > > static struct attribute *node_state_attrs[] = { > @@ -1050,6 +1053,7 @@ static struct attribute *node_state_attrs[] = { > &node_state_attr[N_MEMORY].attr.attr, > &node_state_attr[N_CPU].attr.attr, > &node_state_attr[N_GENERIC_INITIATOR].attr.attr, > + &node_state_attr[N_DEMOTION_TARGETS].attr.attr, > NULL > }; > > diff --git a/include/linux/nodemask.h b/include/linux/nodemask.h > index 567c3ddba2c4..17844300fd57 100644 > --- a/include/linux/nodemask.h > +++ b/include/linux/nodemask.h > @@ -400,6 +400,7 @@ enum node_states { > N_MEMORY, /* The node has memory(regular, high, movable) */ > N_CPU, /* The node has one or more cpus */ > N_GENERIC_INITIATOR, /* The node has one or more Generic Initiators */ > + N_DEMOTION_TARGETS, /* Nodes that should be considered as demotion targets */ > NR_NODE_STATES > }; > > -- > 2.35.1 >