From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBB15C4332F for ; Tue, 18 Oct 2022 06:27:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 517926B0072; Tue, 18 Oct 2022 02:27:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C8286B0075; Tue, 18 Oct 2022 02:27:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3685E6B0078; Tue, 18 Oct 2022 02:27:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 24D396B0072 for ; Tue, 18 Oct 2022 02:27:32 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F418F1A05BD for ; Tue, 18 Oct 2022 06:27:31 +0000 (UTC) X-FDA: 80033088702.01.38BFCFC Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf17.hostedemail.com (Postfix) with ESMTP id A2CF140030 for ; Tue, 18 Oct 2022 06:27:30 +0000 (UTC) Received: by mail-pl1-f176.google.com with SMTP id k9so12475112pll.11 for ; Mon, 17 Oct 2022 23:27:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=q699QGXKZPP5tLSAWNbWZWtXZvr64ruvsRxzqBsxGlU=; b=d73puV54G7egHHTdlgFkNU8+FTggHwPVX8JVynh6lEG2Xe9FOo8qHw3AvkznqOVxej oGdymJyhqDd+G3J1AXWTZLkopAxAtLKMzHaITaltYQ39ymEt3w4oEAikzRhrkfDuM217 87BZl+KScj+TRHXcw6RHtw83xWpSt3MuF66gzzl//yH+mv2wf/dM1jdkSWVr1fY9nOSQ xCm8q1TjHVvnZCM78RMp7A4Lg8I0kDpiu88a0cyRIqFJbcni2tCLP60VaFFXQWjdM8pC 1ZR2QSpQ0ceHDAlQe5CsYlCnQvCq+nR4s5fOlEV9t7kINxCtsdtEcdvXNgFHFf0BJTgL u+Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=q699QGXKZPP5tLSAWNbWZWtXZvr64ruvsRxzqBsxGlU=; b=i5+oPV95RQwVfqctYjSfxGisgvFPAWyhhR2QCGpFAgeIZfk+GgTNcxdUXwiHYBrFqR FbAYedCL730nbs+UT61CQFvRoJE0/k63vRjQgVH4W0IF1tV8YCsyTxSm6CSQwpbIgBGf CUgI+ZQ+W1YP4XSx8NsWOeg+Dp5Rtbj0cQNTrrlLO5HlSY7UV7ibMdZuN+syuqGpYb0O 8pOKUSkxvEGCHQxvrejdAky+rm9c+Oj1EH09vQHPLUz1jJh/ck6zZyiZAkDnjCn5EICP CC6TWVsa3SJeRH7JhMQrAGj/Kc7hmiEzlP6ihLpb5fiTkQ/nJAyJgpCCZEL/3Uz5WWMo GiGQ== X-Gm-Message-State: ACrzQf1MoBFYI6wDkMNQJOHEJi5zYvCNLfOOU4N2cdnBwgggQSex3iez AuKw7xkV42e+xIKQ6pvYSHnTt5VWOMmk6qULPyQdwg== X-Google-Smtp-Source: AMsMyM4bOfBo+4XlFvKJ//x0hzlMlaNtjxoBOdlKxPIe1HN1mfQj7okaMTNVNpvmRgnuZT/VL9tgB3RWCEEP070bo74= X-Received: by 2002:a17:902:6b88:b0:17e:f177:400 with SMTP id p8-20020a1709026b8800b0017ef1770400mr1564149plk.72.1666074449309; Mon, 17 Oct 2022 23:27:29 -0700 (PDT) MIME-Version: 1.0 References: <20221018052541.265708-1-ying.huang@intel.com> In-Reply-To: <20221018052541.265708-1-ying.huang@intel.com> From: Wei Xu Date: Mon, 17 Oct 2022 23:27:18 -0700 Message-ID: Subject: Re: [RFC] memory tier, sysfs: rename attribute "nodes" to "nodes_list" To: Huang Ying Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , "Aneesh Kumar K . V" , Alistair Popple , Bharata B Rao , Dan Williams , Dave Hansen , Davidlohr Bueso , Hesham Almatary , Jagdish Gediya , Johannes Weiner , Jonathan Cameron , Michal Hocko , Tim Chen , Yang Shi Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=d73puV54; spf=pass (imf17.hostedemail.com: domain of weixugc@google.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=weixugc@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666074450; a=rsa-sha256; cv=none; b=52/4pbMm88s/K4lg4BxGMn6t9cG0Dki9mIRR1UfnxtqT2UGBrNeByDr5bKMOelRlzmFPIC 59VU0k84JIRLk0o8uG18W6M/f77PwjrQNZW8kK38KBTVTWmdZ+fQvQIi7gqXujFRLWob6t FF8eaAXDigLhGhx3PkTrxRhZRokix1Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666074450; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q699QGXKZPP5tLSAWNbWZWtXZvr64ruvsRxzqBsxGlU=; b=WKQVKRrxNDg82mZjNCn42GBXf1m/PaCm8zc5izugpZK5t63xDKhlvPNoHehL4MAA1lTt19 Dq+lh9A6yMK4tZniWD9AAqf5oFkwsGsH73Tu4xMik+iJJaX0C5cjORD1dD7uQS8eSWstzq c3Le97h8EZMh8onvAosjn9bquiq8U0k= X-Stat-Signature: 78tgxsr3ftfumnrapufyfnc5tx9bkeqe X-Rspamd-Queue-Id: A2CF140030 Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=d73puV54; spf=pass (imf17.hostedemail.com: domain of weixugc@google.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=weixugc@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1666074450-299460 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: How about "nodelist", instead of "nodes_list"? It is more concise and follows the convention of: /sys/devices/system/nodes/node0/cpulist Wei On Mon, Oct 17, 2022 at 10:26 PM Huang Ying wrote: > > In sysfs, we use attribute name "cpus" for cpu mask and "cpus_list" > for cpu list. For example, in my system, > > $ cat /sys/devices/system/cpu/cpu2/topology/core_cpus > 0,00100004 > $ cat /sys/devices/system/cpu/cpu2/topology/core_cpus_list > 2,20 > > It looks reasonable to use "nodes" for node mask and "nodes_list" for > node list. So, rename the attribute to follow the naming convention. > > Signed-off-by: "Huang, Ying" > Cc: Aneesh Kumar K.V > Cc: Alistair Popple > Cc: Bharata B Rao > Cc: Dan Williams > Cc: Dave Hansen > Cc: Davidlohr Bueso > Cc: Hesham Almatary > Cc: Jagdish Gediya > Cc: Johannes Weiner > Cc: Jonathan Cameron > Cc: Michal Hocko > Cc: Tim Chen > Cc: Wei Xu > Cc: Yang Shi > --- > Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers | 4 ++-- > mm/memory-tiers.c | 8 ++++---- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers b/Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers > index 45985e411f13..af07e166f559 100644 > --- a/Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers > +++ b/Documentation/ABI/testing/sysfs-kernel-mm-memory-tiers > @@ -10,7 +10,7 @@ Description: A collection of all the memory tiers allocated. > > > What: /sys/devices/virtual/memory_tiering/memory_tierN/ > - /sys/devices/virtual/memory_tiering/memory_tierN/nodes > + /sys/devices/virtual/memory_tiering/memory_tierN/nodes_list > Date: August 2022 > Contact: Linux memory management mailing list > Description: Directory with details of a specific memory tier > @@ -21,5 +21,5 @@ Description: Directory with details of a specific memory tier > A smaller value of N implies a higher (faster) memory tier in the > hierarchy. > > - nodes: NUMA nodes that are part of this memory tier. > + nodes_list: NUMA nodes that are part of this memory tier. > > diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c > index f116b7b6333e..8dbfe9ec87d5 100644 > --- a/mm/memory-tiers.c > +++ b/mm/memory-tiers.c > @@ -131,8 +131,8 @@ static void memory_tier_device_release(struct device *dev) > kfree(tier); > } > > -static ssize_t nodes_show(struct device *dev, > - struct device_attribute *attr, char *buf) > +static ssize_t nodes_list_show(struct device *dev, > + struct device_attribute *attr, char *buf) > { > int ret; > nodemask_t nmask; > @@ -143,10 +143,10 @@ static ssize_t nodes_show(struct device *dev, > mutex_unlock(&memory_tier_lock); > return ret; > } > -static DEVICE_ATTR_RO(nodes); > +static DEVICE_ATTR_RO(nodes_list); > > static struct attribute *memtier_dev_attrs[] = { > - &dev_attr_nodes.attr, > + &dev_attr_nodes_list.attr, > NULL > }; > > -- > 2.35.1 >