From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFABCC83F03 for ; Wed, 9 Jul 2025 17:12:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AB6E6B0144; Wed, 9 Jul 2025 13:12:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 434BD6B0145; Wed, 9 Jul 2025 13:12:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D55C6B0146; Wed, 9 Jul 2025 13:12:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 159006B0144 for ; Wed, 9 Jul 2025 13:12:30 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8B1BDB818D for ; Wed, 9 Jul 2025 17:12:29 +0000 (UTC) X-FDA: 83645370018.20.BA328A4 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by imf13.hostedemail.com (Postfix) with ESMTP id 9EF1320014 for ; Wed, 9 Jul 2025 17:12:27 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OceJ90RA; spf=pass (imf13.hostedemail.com: domain of suresh.k.chandrappa@gmail.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=suresh.k.chandrappa@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752081147; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Bfzz1lzTjbwwqCHrAihGRYn8adQnKpTHPDp6tDasl0M=; b=fixNVbZ1KtoL0ehVOd/8KysEPh2ThLFu9YS1X/mrTiQwqXogH9VrzDxWWss57Go69LYoaI dFmnTqt2XCTQVo8jTj6OtkX22c6pa2h2i2rri+mDvjg+EyxhN1HPiVq9j7vLrInXFf4hM9 L1X71tZ9/1uN7C7Hoj/2FiS4xcjEn2o= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OceJ90RA; spf=pass (imf13.hostedemail.com: domain of suresh.k.chandrappa@gmail.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=suresh.k.chandrappa@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752081147; a=rsa-sha256; cv=none; b=hhQN/Cnk0BlDUjyv3e4Umu5ju76oms6CzJsw00Dt8UFyxP9kMIh2Pg4GhB+RZ76BwD16pV tmAZIwEA3KU9TrRjhsKTfzmcRO2p7kHltUs1tYgcfsvxNgJbkKSBERFaLNj5vaf85QB2r5 ONdQoYg0uyHzCL5X4EKSc6B5MPVFXD4= Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-3a4f379662cso177224f8f.0 for ; Wed, 09 Jul 2025 10:12:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752081146; x=1752685946; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Bfzz1lzTjbwwqCHrAihGRYn8adQnKpTHPDp6tDasl0M=; b=OceJ90RA2EjxKbx/5IwA3GoSXaKgGbnk5bdfAW6aL4CERpyi3K6JkJUaDq5XJk1FKi v6YcCVYs9jmc/EhSf1nb/VxCsrlhhGMqT7ll3DTIlpgfMWFi/avWJd5btABPwy9oG4my NdB2XT08Mg2SwVIDWRwDExC1Fxc0D1hS3EXXpsm+8FPGhlIbY5Q7Uqy38vmjRH12gBbi IWRFpL85eHxl7H7JkRjW2dfA4b6v6l+SFtXGELr7EwrTTxrjX/iMdY9DaT95pIyvLcAc Tdg9MDW7eamk1t44Yl7ssQ8OKQ/94/E3w6tt4Ww6HgIM9bomnuqdEe7D7M+/Zxr/6pbi WXeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752081146; x=1752685946; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Bfzz1lzTjbwwqCHrAihGRYn8adQnKpTHPDp6tDasl0M=; b=C6PiQSOmE84Yb1qOrmyjgQAZs9jAEBjYqgo1PX6L5ubqUAZZUq3uPD2lfoGDXn895p Kb6WujFGTmdFmyH44I4mVYqtnKiOX9YHg2ddJm/0ZMZv0wW21tMtNWRfRvBjiCVEsTuZ Sp4deUNd1ceq3L1OsotVpofxPeDnAAOq2ydnE3tHUglxy9l9CSEJn1ezSbQ0Mq8mxiEW 4+WBz8vW0ebG8e7xpBSxLaEvauVlL+ClDI4GyNDL01rrO/2d8qz1CgY8flDrKpSoEljm zhssgmcaTpXyiD5pzhKXyv/YLVFrLxMr9daXoEj1EPvf6qVadMZPOFl31UJuUyL5t2Hq E4qg== X-Forwarded-Encrypted: i=1; AJvYcCWxgUiPY1h11ZNPs7qtm3tt+J7Xw+CctrnzknYTGAbJcFmCfPln5102zpihm2+9rIkEdqZbBNqD3A==@kvack.org X-Gm-Message-State: AOJu0YxvmA3ZM2c41JSFTsFlRCHzjkLdI/ZUOQ+w33ebj7fiSutXmr7X lPZTZbjnMGRjcfZm1/9oFewqZ8abopWapTQyzku5eMiwL/7HGYgbQ8NX+vrDv2lI5yMgM0YGia9 oeIVdabSWQxQkoCvd2mvOysI8GzKYIVA= X-Gm-Gg: ASbGncuy6m5vMypsniP4PdD0Rlo8GEbQQRmXy6u1ay3tSbcWE9kvu4g1dZMPg3+yvXB Al/yFVGbvRCPGC1AWaRtywsl8P9BBagMvxMDPF2WRNn819Bj4JH50xz7jtldqiuard5Xsw/fSCW GZAs0K1U1MWNzjwJt2B3JWq+GCdftOOtWt21vIGMHJfi7O X-Google-Smtp-Source: AGHT+IF6M+fOBDIRihrvfISlUD3tE/+bPrIH+anLCkCTSQFtJ+QfQNT+6HDrr4IY7aNtkujLLRXDk2K8DLyZpQYstQs= X-Received: by 2002:a05:6000:710:b0:3a4:ef36:1f4d with SMTP id ffacd0b85a97d-3b5e45221f8mr2647157f8f.38.1752081145654; Wed, 09 Jul 2025 10:12:25 -0700 (PDT) MIME-Version: 1.0 References: <20250709170403.2453228-1-joshua.hahnjy@gmail.com> In-Reply-To: <20250709170403.2453228-1-joshua.hahnjy@gmail.com> From: Suresh Chandrappa Date: Wed, 9 Jul 2025 22:42:15 +0530 X-Gm-Features: Ac12FXw28Wsmqym-AtErL8W4erxwox61XR_GdBHSDUBjmG74CDA3rTtCEjD5CiM Message-ID: Subject: Re: [PATCH v2 1/2] selftests: cachestat: add tests for mmap To: Joshua Hahn Cc: nphamcs@gmail.com, hannes@cmpxchg.org, shuah@kernel.org, linux-mm@kvack.org Content-Type: multipart/alternative; boundary="0000000000004df2010639822e9a" X-Rspamd-Queue-Id: 9EF1320014 X-Stat-Signature: 5d1qtmy9hf91u1xu6q6attsheumfdo9h X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1752081147-394658 X-HE-Meta: U2FsdGVkX1/5ZOzg06xcMs6MYI4zKODXssp35khQVWGJUWJ5MwmmDj5I1g3vKYQVMQnkT0D14qgZ/P0jLTLdzJgwe0VW704pM16dbFPcqHgnGGVcszrfEeV2Vnr/aNcM5Ch9D5/7uA26O8Jp7ig2vFyHkRn278SGwtUOR0G9Q1B3DqTnB7iX7sIIC1ewFkgAPyEEwQ3ijFZDAnJqD/7um0aWYGHpOhICJl/Ukk1BqkzaKddmyk5nyvJ/7BhDNPN8GWoWE0WNYZe+129BDwW1U1zx24b0Y+K5mEgl6Yt7ge3rzsXh8Ok6cZCt3CcglQcXJsgEg/heNXwUFjs40HKSHq3SIzTwGywZIMUPVQiinurtsHmfeceOnhGYPiubjMAq7nfVuSQSM5XdkO0MlBFi8w/UdP6ZTvU3ogOewKHr24fxd17oS99cKW3+JsLXDhqD/cYkVOXCi8MFwKSgMVcy23xOy+DWfmQpNOkRgu24vrJaXtii0nxmkPmyYzn78dzfMEt1lvq0uGBDCa74E0qKZdCwKHkCMYGp4sKyhl/w3+v6hTx0ngs3rq4xPwvHxzsa+BPg3GliCQhoou8cXDZNoffZgM9Twyo6NrvyFrGDlUsn4TirNr98tW0uJ966j8UqyI/CDadnBgbZR1IesD2Nqbu3pJ9yZxjVb7piQmnwTEWm/t9aERcc97GgvqAs6R9BfQYlF8sfBEo2i9AWRx6qGBX4RVfOycGxn/tbG5KTZkE5sG6CYvYg4nV47U7x1hww2P0m2OGF4Yr4FRYJzx2YhXJ/ep5j4iSpPvSrTFjcpOm5RoiK34Y3H1sZw22PG00n6S0G0g/PiXBem3HPl9aex1uHHViCp3VSY06lHvU+iLunlvEhI9yIZ0peunKX1P5pKSlwwJJc+rLDD4eNXWb9+tOVt6fg5xIuo63tHL5gTFtitu8E4KDl+2IBQ7D+my5sDk0lzbPzsIirGFo/c56 lXpXQiZa dFZZ6Vu7wKGmHZSQooPiZIOxvU83sResQQdzv/xh2xGdJ25KLYU0VEnJ6laxw3bbw+uWbBgKlTamYHbJrdraxm1T0iMK0Qnr0HRkREE2AahASzs5VvXNTKamPo3XdXn2V4OkWDEbU/Q0CMdvTzU3AR7HNl8LX42kBCYdMH9g7ha2ehmYSTGACLEMpOazsfI+/KVc0IFCbNax9wm73JmjoKAZNPcEeMPlgVOVooZcUqC3QQExFVv3q0v/NwVSM7YaniHhuaYAtUJzSS8P/yvnie0gTA9tfzyXiU54C0zWEcQFw4IjQcZF86xdgwi/mUm+fizLnPJv5IiZIlltYnWrDRI1rXAr3H9lev8ss1DLbIiA7tkTLqszeqlCt2d94LgHb6XIvYxfk9bOg9tovO4V6iescL9oipxMQx/nQseJHxwsn+ADnc6Ya+BagOe1UYhwW1CilfD7RUbcxf0r8FN4jykzKRXQ51PTJI+5dbjzLUhr4fGdwEzdd92tcWpv3ygQfb4YMLXCa8ZXdxnaom0A8Z5LRuyMFHMssjATWpasnfLXVWxBv4xGlCMO1/1NtnYPqwf+1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --0000000000004df2010639822e9a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Joshua Thanks for the feedback! I=E2=80=99ll go ahead and create a new patch that = merges the two, as suggested. Appreciate your input, looking forward to sharing the next version soon. Thanks Suresh K C On Wed, Jul 9, 2025 at 10:34=E2=80=AFPM Joshua Hahn wrote: > On Tue, 8 Jul 2025 23:13:01 +0530 Suresh Chandrappa < > suresh.k.chandrappa@gmail.com> wrote: > > > Hi Joshua, > > > > Thanks for the feedback! In the first patch, both shmem and mmap > operations > > are present, but I hadn=E2=80=99t introduced any logic to distinguish b= etween > them > > yet. That distinction is added in the second patch through a new API. > > Hi Suresh, > > Yes, this makes sense to me. I think what I was getting at was that we > could > still make a conditional statement like > > if (type =3D=3D FILE_SHMEM) > ksft_print_msg("Unable to create shmem file.\n")' > else if (type =3D=3D FILE_MMAP) > ksft_print_msg("Unable to create mmap file.\n"); > > (or use a switch statement) > > ... > > And just refactor it in patch 2, as opposed to changing the behavior. > But this is mostly a nit. If you are planning to merge both patches in on= e > patch in the next version, then all of these comments shouldn't matter : = -) > > Looking forward to the next version, have a great day! > Joshua > > Sent using hkml (https://github.com/sjp38/hackermail) > --0000000000004df2010639822e9a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Joshua

Thanks for the feedback!= I=E2=80=99ll go ahead and create a new patch that merges the two, as sugge= sted. Appreciate your input, looking forward to sharing the next version so= on.

Thanks
Suresh K C

On Wed, Jul 9, 2025 at 10:34=E2=80=AFPM Joshua Hahn <joshua.hahnjy@gmail.com> wrote:
=
On Tue, 8 Jul 2025 = 23:13:01 +0530 Suresh Chandrappa <suresh.k.chandrappa@gmail.com> wrote:
> Hi Joshua,
>
> Thanks for the feedback! In the first patch, both shmem and mmap opera= tions
> are present, but I hadn=E2=80=99t introduced any logic to distinguish = between them
> yet. That distinction is added in the second patch through a new API.<= br>
Hi Suresh,

Yes, this makes sense to me. I think what I was getting at was that we coul= d
still make a conditional statement like

if (type =3D=3D FILE_SHMEM)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 ksft_print_msg("Unable to create shmem fil= e.\n")'
else if (type =3D=3D FILE_MMAP)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 ksft_print_msg("Unable to create mmap file= .\n");

(or use a switch statement)

...

And just refactor it in patch 2, as opposed to changing the behavior.
But this is mostly a nit. If you are planning to merge both patches in one<= br> patch in the next version, then all of these comments shouldn't matter = : -)

Looking forward to the next version, have a great day!
Joshua

Sent using hkml (https://github.com/sjp38/hackermail)
--0000000000004df2010639822e9a--