From: "Yan, Zheng" <ukernel@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-mm@kvack.org,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
"Linux F2FS DEV,
Mailing List" <linux-f2fs-devel@lists.sourceforge.net>,
Jaegeuk Kim <jaegeuk@kernel.org>,
ceph-devel <ceph-devel@vger.kernel.org>,
"Yan, Zheng" <zyan@redhat.com>, Ilya Dryomov <idryomov@gmail.com>
Subject: Re: [PATCH 13/15] ceph: Use pagevec_lookup_range_nr_tag()
Date: Mon, 18 Sep 2017 13:35:50 +0800 [thread overview]
Message-ID: <CAAM7YAnHjkGRhzeUUXOMnux70UKqnQ3kG6x0jRpzasSNeyAVCg@mail.gmail.com> (raw)
In-Reply-To: <20170914131819.26266-14-jack@suse.cz>
On Thu, Sep 14, 2017 at 9:18 PM, Jan Kara <jack@suse.cz> wrote:
> Use new function for looking up pages since nr_pages argument from
> pagevec_lookup_range_tag() is going away.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> fs/ceph/addr.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> index e57e9d37bf2d..87789c477381 100644
> --- a/fs/ceph/addr.c
> +++ b/fs/ceph/addr.c
> @@ -869,11 +869,9 @@ static int ceph_writepages_start(struct address_space *mapping,
> max_pages = wsize >> PAGE_SHIFT;
>
> get_more_pages:
> - pvec_pages = min_t(unsigned, PAGEVEC_SIZE,
> - max_pages - locked_pages);
> - pvec_pages = pagevec_lookup_range_tag(&pvec, mapping, &index,
> + pvec_pages = pagevec_lookup_range_nr_tag(&pvec, mapping, &index,
> end, PAGECACHE_TAG_DIRTY,
> - pvec_pages);
> + max_pages - locked_pages);
> dout("pagevec_lookup_range_tag got %d\n", pvec_pages);
> if (!pvec_pages && !locked_pages)
> break;
> --
> 2.12.3
>
Reviewed-by: "Yan, Zheng" <zyan@redhat.com>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-09-18 5:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 13:18 [PATCH 0/15 v1] Ranged pagevec tagged lookup Jan Kara
2017-09-14 13:18 ` [PATCH 01/15] mm: Implement find_get_pages_range_tag() Jan Kara
2017-09-14 13:18 ` [PATCH 02/15] btrfs: Use pagevec_lookup_range_tag() Jan Kara
2017-09-14 17:57 ` David Sterba
2017-09-14 13:18 ` [PATCH 03/15] ceph: " Jan Kara
2017-09-14 13:18 ` [PATCH 04/15] ext4: " Jan Kara
2017-09-14 13:18 ` [PATCH 05/15] f2fs: " Jan Kara
2017-09-15 13:33 ` [f2fs-dev] " Chao Yu
2017-09-14 13:18 ` [PATCH 06/15] f2fs: Simplify page iteration loops Jan Kara
2017-09-15 13:37 ` [f2fs-dev] " Chao Yu
2017-09-14 13:18 ` [PATCH 07/15] f2fs: Use find_get_pages_tag() for looking up single page Jan Kara
2017-09-15 13:43 ` [f2fs-dev] " Chao Yu
2017-09-18 7:52 ` Jan Kara
2017-09-14 13:18 ` [PATCH 08/15] gfs2: Use pagevec_lookup_range_tag() Jan Kara
2017-09-14 13:18 ` [PATCH 09/15] nilfs2: " Jan Kara
2017-09-14 13:18 ` [PATCH 10/15] mm: Use pagevec_lookup_range_tag() in __filemap_fdatawait_range() Jan Kara
2017-09-14 13:18 ` [PATCH 11/15] mm: Use pagevec_lookup_range_tag() in write_cache_pages() Jan Kara
2017-09-14 13:18 ` [PATCH 12/15] mm: Add variant of pagevec_lookup_range_tag() taking number of pages Jan Kara
2017-09-14 13:18 ` [PATCH 13/15] ceph: Use pagevec_lookup_range_nr_tag() Jan Kara
2017-09-18 5:35 ` Yan, Zheng [this message]
2017-09-18 7:53 ` Jan Kara
2017-09-14 13:18 ` [PATCH 14/15] mm: Remove nr_pages argument from pagevec_lookup_{,range}_tag() Jan Kara
2017-09-14 13:18 ` [PATCH 15/15] afs: Use find_get_pages_range_tag() Jan Kara
2017-09-27 16:03 [PATCH 0/15 v2] Ranged pagevec tagged lookup Jan Kara
2017-09-27 16:03 ` [PATCH 13/15] ceph: Use pagevec_lookup_range_nr_tag() Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAM7YAnHjkGRhzeUUXOMnux70UKqnQ3kG6x0jRpzasSNeyAVCg@mail.gmail.com \
--to=ukernel@gmail.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=zyan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox