From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CFB2C7EE23 for ; Mon, 15 May 2023 16:45:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28470900003; Mon, 15 May 2023 12:45:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 23462900002; Mon, 15 May 2023 12:45:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FD08900003; Mon, 15 May 2023 12:45:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F2D34900002 for ; Mon, 15 May 2023 12:45:24 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CB70C1C7C87 for ; Mon, 15 May 2023 16:45:24 +0000 (UTC) X-FDA: 80793064968.15.7770297 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) by imf18.hostedemail.com (Postfix) with ESMTP id 166B81C0011 for ; Mon, 15 May 2023 16:45:22 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="EDIK7Pc/"; spf=pass (imf18.hostedemail.com: domain of dionnaglaze@google.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=dionnaglaze@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684169123; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zRf1suCxpp2xw9xVtC6+jBhjPv+ukUhidKZm42V6ybU=; b=yzWNhORutH4O0MijKRnki14Abo02moIKdmSl7Pog1CCdBo6HzwrHJx5Qom4QHjJHBV7jdS uPmf75qDJQ+fwKXYqk2S8xQ3mr1oqewYdb5IZVG65lJH8aTXwGYJZsqZb5+6cSRdf3EQf8 eZiFYbBY4kgE8nO9dvx72Y5SW8mRJNg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684169123; a=rsa-sha256; cv=none; b=dogS01+QcuOD5Dm4RSXQYAoe+2TWKb0UoxKKWvvk7LBBQrIX6ZBVFZw5FiqFiYoclMw+pV UgxmND6SYaveI/pPoaSzmT5Lv5J3n0mnVKgpSToy1J/eNzzCGRA6tkYJPbwUI1X8bPE89+ UbwaFezvCGJLalJP8rP07EuV2RV240U= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="EDIK7Pc/"; spf=pass (imf18.hostedemail.com: domain of dionnaglaze@google.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=dionnaglaze@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-3f51ea3a062so265911cf.1 for ; Mon, 15 May 2023 09:45:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1684169122; x=1686761122; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zRf1suCxpp2xw9xVtC6+jBhjPv+ukUhidKZm42V6ybU=; b=EDIK7Pc/86wryFh04RCHc696LTO8e7WBVjartdOINZOy20P8SDN8FxNtn6AilVWdDJ qplWuDdd5lGpudBSOsNa6OtkgIfzsB1eE3m9Lz9jwt0A7SGm1KHD+bVxe7ba8YJCzgix pDK/Y1fX6/d0Z/3gceRYPDj/4YsT9gpdTuFL0i7mGT/AQWNw+0YAxKOVMGp/HP7RNbyE ldupBjv3mNrUNl76wZi15yBT8Nk2Yw9AXWOL2I6CLO4jQTn+MQkw2agqf0aQXHYl9Pp9 74JixFrx7e9SWXEAs+6xBUIsPOEuCLml3za3UZTShdbIxXM5CzjTNNDOcPyjcbYEoerk iR0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684169122; x=1686761122; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zRf1suCxpp2xw9xVtC6+jBhjPv+ukUhidKZm42V6ybU=; b=lq6LwS1ETDKRe0glTDvv7vwZYVUF9M+tPuiFQR0UDTm4cCO4TRSMsh/h2cwKPU7pIs OvV8NDu5RFJCWwZwzkZzO83lD4nZ7zwSOUktHKL5/o26XVpeII0w66J0yhlGA7F0ZwYD +SGMZ4NvrCvyJNWqnxtSIbT0rcp1/cFEBdLN1UwbKMEumbgNtwWvLd0DrX3lz5jtQ1fu JJkZeMQ9a3UxW1e30lndQyIG30d+olNbyLmz2znEMPFzGUr9lg4vJX4ZGE4g4Pwr5zFE L5c/vu75YMVpq3JA2X49sRz0/WD8Giir2jfXsDA9jIpjXk27xCG6BkJ6hnCHfVDLV54Z aqnQ== X-Gm-Message-State: AC+VfDzQ7ZyWOXyfDiyzGERZmpH2EMsQwE8NcnV+VXUVKbnbqtzhku6p GzjB4GGFVJzJUVWr5RDK/fJZVtwnCvSH+MAiLZSGEQ== X-Google-Smtp-Source: ACHHUZ6WL2yHBGGSTjCR/zNcMyHw7JQQk7RuXqLGbndgXVi0BaKjhZ4zIXUc8BriMv7vS24UmRRZQDqx5sUvWOA/tBw= X-Received: by 2002:a05:622a:1456:b0:3ed:6bde:9681 with SMTP id v22-20020a05622a145600b003ed6bde9681mr1323105qtx.0.1684169121825; Mon, 15 May 2023 09:45:21 -0700 (PDT) MIME-Version: 1.0 References: <385016f9-e948-4f7f-8db3-24a0c0543b3d@amd.com> <55e5f02f-4c1f-e6b0-59ba-07abc4d3408f@amd.com> <81037a58-6b5c-cde4-79fe-3686d9b8a551@amd.com> <7fb25176-3752-1be3-66d4-a7f5a0e1617a@amd.com> <682c0bf9-ccf7-9660-21fe-925ef63c5fbb@amd.com> <4c642bd1-5f1c-292e-398f-eed699db590d@amd.com> <65cb8f0f-7e8b-6df6-6bb1-a9f1add027bb@amd.com> In-Reply-To: From: Dionna Amalie Glaze Date: Mon, 15 May 2023 09:45:10 -0700 Message-ID: Subject: Re: [PATCH RFC v7 52/64] KVM: SVM: Provide support for SNP_GUEST_REQUEST NAE event To: Sean Christopherson Cc: Tom Lendacky , Alexey Kardashevskiy , Ashish Kalra , Michael Roth , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, harald@profian.com, Brijesh Singh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: m7boopyrxu85kfzxck4jpipqjwnnigcr X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 166B81C0011 X-HE-Tag: 1684169122-693994 X-HE-Meta: U2FsdGVkX18OxbLY2wpVl+V7I6JKbPTZMs9Sl3Yl0+a6tan0zlZeLIOsA58eVhNsfv6pI+iLDBNsMN+33/FNa5arqS7Zk0VW+jld4kHVhxOJ27HFnfIwuSe9XmPwEjlES6IipvDlmVeoyhKzhMI2wvr8ddvtOV59u87VyF9uq9rxaQNp54cB9p+k+7REsGely5G+WZEsBpjzNYCs9s8SOsaRmZsZPmrKPTCYWXEbItfqhiKvYgs+Xoe9kOm/JI2tQ8LOdMBznrSH99Xt0tXR4Y4D5K7Skc/+qVE6Q/CYYyX5aBDqCC10fOLf9p04fwUCGNMCM3IBn2UDI7kEz/D3ciTzFxs6Z3Bdtqz343pFzjbmfPcx4TZSjHXOei7kKCvuupViydjyB+tpyIwOTZhm3P4JpYRymLHShwUG8vKftlxHzbOtBU+qAaRUYHAnfHMYjuRGjXly20KcO920tJhPrxWZvhAa9QtUplMbAIeYWTh4rTIckesJIq1UTkXpg+gIC1iVFaMzVxqnSXbLbT0Fjx1zvL7FxzeyUJGce+TPx5kYQXszLHu8JuhXcHK9bBDjq/kve8eRYeuUVIYclaELqbf6BrUb7INQTLwIHFTWy7/i+4KHYgd3k2+rp/NMGRiO4qzpNFnbj1ncJT22lfV+xSFRHIy5+PhFVz+G00h8LKSlA8Qd2IOsfV1+Emg2EIH0u7syUXXgnPosFw2zPVIbFlIm9A/dnxIlOY+V1vRpOi4VQcyFFSFnGfNder8EZ7bx+Fs38EAN+1Iv4jF1ltsKcTM7Qs9G+Q9Vv/JyfKNcRnKJJ1PVIMhVGyQJi1AYStmMGBMyiyh2VhszIeMK1T3Bnv+9i/kEhpuBnmQ6z/NP1QCFx2kf/M2IhFuH9d/9QsZsjxDsIxn8OXESnwT3MJ/QBUbbfFCcvGFVL2PECKWcJ51mT642MeGdBaDZwQGhezFWpSO8nohWNUIVvT+C2a1 h0oZVtW6 GElyc+GH+4QKYhsNXgoc9Xm9folzfMUMq928C9mNwBKCRDUDFfC5wGef2bdsG61Cmxd5rlRj7fw860eNUPS0AJGsj7Lr5CqjENt2quGoO+v07ZCegsIaGjYkCkwYjTPVfDQNJiYIVkbKq2uxNuHW+eS4PlmHIcD/M2rkfTa1fLM0ysM0jMwnGgMgGgq0Qx0X3YNbWbOmT5RuFcTVbh40YqQ6gtib1/R0AClH5A/w6b+SjTboE31WIT3Frv6u7iicVwo40ZnWaMnidIws2AI8Eu44HIIbxwCSLfiF1TK5Lny9w7LLdZ5Rsa5WYOkfsU4tN5uKmCYvEh4O/BrH90K+1t5B1JAdqtpQmK5ktNHWJeYh9ubU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000014, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 11, 2023 at 4:33=E2=80=AFPM Sean Christopherson wrote: > > On Thu, May 11, 2023, Dionna Amalie Glaze wrote: > > Would it be okay to request that we add a KVM stat for how often there > > are GUEST_REQUEST_NAE exits? I think it'd be good for service > > operators to get a better idea how valued the feature is. > > Heh, it's always ok to request something, but sometimes the answer will b= e no. > > And in the case, the answer is likely "no stat for you". A year or so ag= o, in the > context of us (Google) trying to upstream a pile of stats, we (KVM folks)= came to > a rough consensus that KVM should only add upstream stats if they are rel= atively > generic and (almost) universally useful[*]. IMO, a one-off stat for a sp= ecific exit > reason is too narrowly focused, e.g. collecting information on all exit r= easons is > superior. And no, that won't be accepted upstream either, because for so= me environments > gathering detailed information on all exits is too much overhead (also co= vered in > the link). > > FWIW, we (GCE) plan on carrying stats like this in out-of-tree patches, i= .e. your > request for stats is likely something that would get accepted internally = (if it > isn't already captured through our generic stats collection). > > [*] https://lore.kernel.org/all/87czp0voqg.wl-maz@kernel.org Thanks Sean, noted :) --=20 -Dionna Glaze, PhD (she/her)