From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DD2DC004D4 for ; Thu, 19 Jan 2023 18:49:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E1AE6B0080; Thu, 19 Jan 2023 13:49:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B8356B0081; Thu, 19 Jan 2023 13:49:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A7FE6B0082; Thu, 19 Jan 2023 13:49:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 09F086B0080 for ; Thu, 19 Jan 2023 13:49:58 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B839B80DCF for ; Thu, 19 Jan 2023 18:49:57 +0000 (UTC) X-FDA: 80372438034.20.4083D74 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by imf06.hostedemail.com (Postfix) with ESMTP id 2EE4F180010 for ; Thu, 19 Jan 2023 18:49:55 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=JCfzsF2f; spf=pass (imf06.hostedemail.com: domain of dionnaglaze@google.com designates 209.85.215.170 as permitted sender) smtp.mailfrom=dionnaglaze@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674154196; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xNVXfWTFHPUTtkdhJd1rvFQYW6suzNo+IYrlxBerVjw=; b=5CfUBiLR7++bc8sXM7DZdE0D6jDRvy2uDJxWKACUd4PP5uRIthaJ0cjoxGHHKP5Akd5sBk G/WsZEgMdHZhy2xTv71EM6+TOCT/EFEeHbTjFKMRp0GbeVcSBEpXr1myRL5Xc8VMwK2E1x uArLfYNyJ6OjfKLJRI1d88J0p/oTgrk= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=JCfzsF2f; spf=pass (imf06.hostedemail.com: domain of dionnaglaze@google.com designates 209.85.215.170 as permitted sender) smtp.mailfrom=dionnaglaze@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674154196; a=rsa-sha256; cv=none; b=kj9BCCFkK31Jd4BdIaYeAbz/v8A4QrJkyOQqkU+IkK3bFDx5Oao38vegwMMjUB28WzDUPh C1F7IlDmsHnBdixyzgs5lacX5y0R1EXWtleipJzRTeDw+KWw04ilZ5SDzG5fgvHzY9TOS4 rqRsoMXxidlsc3XcJ+k8rOyC4S6TAK8= Received: by mail-pg1-f170.google.com with SMTP id g68so2256244pgc.11 for ; Thu, 19 Jan 2023 10:49:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=xNVXfWTFHPUTtkdhJd1rvFQYW6suzNo+IYrlxBerVjw=; b=JCfzsF2f0L14x6DnDb97ikzDMd+kmDUm+hY4g0ikovS6VCInjBWJHaf/91emjlkbvv 7wIBq95BwSi0sYX+qpZD/SDvgq6Rh0mChGWHNsKn3x3hLmQ8FzFzJ8/ZbJBpvglwgQ4P DCgQbf4DC/hZmnSwoV0J3qJIQ2CUCL3azLbW7iE8ZYMMJf7aB+WsETKfdqrzzfEJ6ojU vsPAh6PoOnotNaQto+c0+ylg5pDTEUWQjzlqfqHA4n+xq9Aj/eYU3tjl8BclPsCxy96X tvpdUK9qzbs7kasSXAsdoo6MSNp8cPe7grioN6SM05rjDR6+YxuYdpreH2mSGn1YnH2i 7GNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xNVXfWTFHPUTtkdhJd1rvFQYW6suzNo+IYrlxBerVjw=; b=7d9ARZQzHZntM9o9q53fwRQnYNXCRJopX4tLd/52HQ4BwCuHXEzHi+3lQrw6v2Klse Gq3saJaPDBXAr0cbW1jXw1qBiiz93MoXtr+Z9kQExyUduc4N6oZvdZIQq/RF8SY0z5OB NGYOZDVJRpnWWi5kw6qU7ljaQJjalFvo4uE3h0CKd1fjT8d9Q5L5udWjEJHT1CQ165F8 6LkjaodkN2ntW5Z62NgqINUVsTZlr1baPNWqDNVQvMkEpGXul4Cn3ivCCv8riRT9+fk2 BJnSR5VgXoPH1MbcDiQDOyAAfALF57lF7z4AOt0PmaRsKSeFAS30D3NjX0PvOjUavbV6 XasQ== X-Gm-Message-State: AFqh2krCDQfA8cbJHvwQEv9bYfckTwgOa60acOr/avV8Z0mO/fQPYLO3 vBcIuqx+poOM0cVYMAftrJwxaucVFwNSQXmQGfITbg== X-Google-Smtp-Source: AMrXdXs6HTI9i0wEtQHX5RB47auesuGHCq06fYXVQ7aeMwYLK4yjX/E0p+7CcZlE0F4L6rvrtuk8H7gqPyauTnlR1T4= X-Received: by 2002:a63:d455:0:b0:478:ae53:a299 with SMTP id i21-20020a63d455000000b00478ae53a299mr956491pgj.260.1674154194728; Thu, 19 Jan 2023 10:49:54 -0800 (PST) MIME-Version: 1.0 References: <20221214194056.161492-1-michael.roth@amd.com> <20221214194056.161492-63-michael.roth@amd.com> In-Reply-To: <20221214194056.161492-63-michael.roth@amd.com> From: Dionna Amalie Glaze Date: Thu, 19 Jan 2023 10:49:43 -0800 Message-ID: Subject: Re: [PATCH RFC v7 62/64] x86/sev: Add KVM commands for instance certs To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, harald@profian.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: xwubbhs1bcsa1r973na9wurmokxdx7fd X-Rspamd-Queue-Id: 2EE4F180010 X-HE-Tag: 1674154195-540756 X-HE-Meta: U2FsdGVkX19pmXPaAQ+2AU3L6tVhOx+hoGRNuIrolVaK5bMxka+URobmuhRyQEKEJ02NdCXIQKWZvgli+fJJj6k+lSISsERWpe8c3kXuIn6Izec+IWmNxgbuZwZMKEz1uLmmWAieTyd2GIcV87orFWOn5StG98LbhDrNbUy61k6cZawK9sJnLKIt22uMx2Hrs094HT51IEPMq+BGB3mKMWgJJ4wOXpZ1Kabi/8heAmkMGOjgfr672agT/RzZs14uOKNJdLvLKbQh7UWwRiL8bSurpV3y0ppGSjUovbWifanqzxaatroG4sTkZ7Jib39XVHY9A9/imqOHylgsmnIGI9gxoo5a3SJJK6GoPGPfTQA8pWOE3oLsShSSkNW6cPI7A1TX65gC7JKhbx0iFpjl7H2Qy7fLY7w6LV4Uxn4MSgWHX+KwH0NNLWJi/NhcvffZnJkkl2sIjlEq0SIj9fdz4uuGr4ZoExUnw+ezADj5QFN2gY4pyv8JjbGhcSeXPDeBRXHTlyofR0De7lVj/v7qQVHL/IbbTdMsfUSKJ1dTMeKmAQs8kxMNetVjgmNoBgLrUToGEFIt6UfsDL3KlTUSEqTdL95osAkCgEiZ7sFBvbVr+oo+AsA8WBYLVmrIJfhe1dKZC0ijgYLntTESKCXAWkBRUAexFKnuLMnqaUPdQ5azSfwTlJ8QU3v5MXqzZnC219sIBn9YBSKIc9ZPxLMX7ARHJUv0jfCVARMs9mLAY4SlpQCNCF3pBH6HOCxU6Sov9OwEPxpdptIxC0k7Itn5zTojkxsvoLgoarSnaAbK3vwFIV5tBN2xgp3JNPyXRVAAE/PA3hpZVzXvlbH35qIW+oWV1lX8INJ/+nwOoSDYxm+RCmdQ5BkyowIhBLXJJH4kD1PHr35HEFDYHq5LwG0rRlCfzEJ0vk14QAUAQ7CriBOmAlgohCd/0cjVxrRNEhCW9Nh7Z48IsC+vtwPrOnV SXrA8uo9 u6HEGMPX4yKG/0ho= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > + > + /* Page-align the length */ > + length = (params.certs_len + PAGE_SIZE - 1) & PAGE_MASK; > + I believe Ashish wanted this to be PAGE_ALIGN(params.certs_len) -- -Dionna Glaze, PhD (she/her)