From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAC9EC004D4 for ; Thu, 19 Jan 2023 20:36:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 01F386B0074; Thu, 19 Jan 2023 15:36:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F115C6B0075; Thu, 19 Jan 2023 15:36:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD94A6B0078; Thu, 19 Jan 2023 15:36:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CDE8D6B0074 for ; Thu, 19 Jan 2023 15:36:07 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6D3D7C09DD for ; Thu, 19 Jan 2023 20:36:07 +0000 (UTC) X-FDA: 80372705574.18.28802DD Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by imf16.hostedemail.com (Postfix) with ESMTP id B30AB180016 for ; Thu, 19 Jan 2023 20:36:05 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Iz5otatI; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of dionnaglaze@google.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=dionnaglaze@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674160565; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=geNr1E6VfBEr6rNDuNt5xZRGvMS8AANNdGRpDjlpRuU=; b=C+ACbGksnOC6FLVfXWaCgXy8TmjYRdBEtO70CZ3r3/HT1IQYNHlCHv/FvrJTb/Azaf+b3I TTbavs8XHeNWoXXWhM6W4How1bsJYJu6CdTc8EekenaGW3U5LGciY01CTpQ/q21oX0dPUB eZmUnw3H7Z/B6j1PT42TNMPG6sCzabg= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Iz5otatI; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of dionnaglaze@google.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=dionnaglaze@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674160565; a=rsa-sha256; cv=none; b=QqZpAfoNz6CEKOYIfiOvmcRYTNaUUX/6rbnNfuAKzMYaWyjrEIOdswvXAd6Qeip9BjAvkA TPnHVpiGm1hJHoq9ICpkF8fcOVR4LQ/rxU9FY19YQplb5pO1PtdFk6JV0d22YDMajkfZ15 wtLhdvvJ9VyIHO+Joo8CFY1W+sjlabs= Received: by mail-pf1-f175.google.com with SMTP id a184so2419800pfa.9 for ; Thu, 19 Jan 2023 12:36:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=geNr1E6VfBEr6rNDuNt5xZRGvMS8AANNdGRpDjlpRuU=; b=Iz5otatIxfEwMlDKOapnMMO592tFYuufDvsRgepbG9Lwd4QGlufz5Dl1lYejAJruJq 33/30rrzenH9TRxIlCwvCDHh1iqm1pIZOAxmy+FKb6tZhdlMuWznkISuuSDd7d0oq6zg RJ7JJJq26Mrw5WNdK8ic6xb9E74jiaVpl3Tes0OdEvZoxOwjsuEbFeM08H0sgxXZe9U1 zr0+8YSVECHB0GYTME1UzvOcbTbZ2dRJIPlOZ6euEk6w8iFtuAW+Cv9xFFz2N31nMN7G ZcGaeLWfARNbBlBsNW+Cq8XSbrVzVMR2/TlJZpqqsj3z1nvE3nsLxTGbaodzsE93w9cA QGWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=geNr1E6VfBEr6rNDuNt5xZRGvMS8AANNdGRpDjlpRuU=; b=VkXllFsW39IbwWsJTzqGLLONiPjDU30r6kk2bfOKu7A5Zss91GbPIYtYJYuvDAHjrV mjNse4uwlJY38h3lteKMATspskWHi7EgMN7iun6J8P4/4X8TyqqCuvdAuMJ99Ura3ftQ DMhGqYGTR78oSghLX7YwkkwDlbX7rvvhm2Sjwmg4q5lk7wn+GAtCR3WjdZjKHGbKRqOb 8eJloh5L/ocep1KlMd90FmmRph3XwKOJbAKsWxa6nhkwVT2B04G195prO+5Hh9l/1Fsd Mb8HbtQPWpof3EUlvY6GRg01FzkKAeBxpCvejhUFbp1EJyiB49uitGlz5v7ZGD/9nAfq fUaw== X-Gm-Message-State: AFqh2kq6JIg4/9mLsaXKWvkeAaaTlk20Yd/bGLUicyGjmTLLjwxC8AF6 6yc+EAM1HyXihTlA/eXvRg2glG3/mf2JabxOIQWtEQ== X-Google-Smtp-Source: AMrXdXuXWIkBvjeABJVhFjJg/BU1DXB+KocDp8hkIozqTT9DBpOmCElWzlT4csdohivH2Pe8ccTDvANtE0IQdxcA/rw= X-Received: by 2002:a63:2447:0:b0:4be:c5ec:93e1 with SMTP id k68-20020a632447000000b004bec5ec93e1mr1074292pgk.213.1674160564313; Thu, 19 Jan 2023 12:36:04 -0800 (PST) MIME-Version: 1.0 References: <20221214194056.161492-1-michael.roth@amd.com> <20221214194056.161492-53-michael.roth@amd.com> In-Reply-To: <20221214194056.161492-53-michael.roth@amd.com> From: Dionna Amalie Glaze Date: Thu, 19 Jan 2023 12:35:52 -0800 Message-ID: Subject: Re: [PATCH RFC v7 52/64] KVM: SVM: Provide support for SNP_GUEST_REQUEST NAE event To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, harald@profian.com, Brijesh Singh Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: B30AB180016 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: zn7ky68x1ib1jdpycihnigt7ws38wt13 X-HE-Tag: 1674160565-807624 X-HE-Meta: U2FsdGVkX1+a0NeUKI5HFMeddTh0qDuw1d6FWtSEK1Ogz7N7GWZqPA0o2JDdDLV6iiBdGj8PRtafpFdHfcD3tX5vcVlHfEOvAD0fGKW6uq3gQ/qUdkn8Hk4WD0ktQrhfpn4fON3VIUF3PtTgOa4aAHONyu9LxfcuwxLluKTVR/pbrjB1caIfI8ET0/hJhLcSQej78VvjPWONYlmo6QzVCdPY8iC1bKNaD/JiknmS2l4gfu7UoV9nQACexjgqJqUXAL6a41HS6XAZdoOJcXEnSc44d6aIa2hUymy8umFybfNOIXNiQAK10ottHlRS2C6sIZBWbjFhpGgqE9kIYOqOZ6TvbIsoaJuREr1tLUM9g5rK5CJFI+XwN/NXDpZCd7d7gdlBqcYCfLaTZk/9cf7dRn3sx9KxGhN00Rxz7bwvMNfWd3tUYLYEyXImKDwZBVZe3oW4APZ56lK/yKIeXDMkI4n5vmFw4yCeUX9phlUjZa/8HWdwoZgq+/0SLJDWcWLtVIX7MecCkRBxG1g5Dm9uTFwtHV+Yfo6lZwCjeRN1jKSiaWORuADxG7aHSXMck2fX1DmDKEIUfpjPa7Ms/IzjIEATgDFu5O78Ls8Eq/Y6Q/Nt5CWvXuw2hPDtfxj/6r/89wp7IFGu0jVsBuKHRYKPY7scXKPJ2f+huc6XDT4ENQr0cZnWSCuJz5XLNhfZfxw7S+Wb1tWNREqSM8kNxzAJdCjhMptd5Ghh9/4aMrAKi7jpTjJT0MDP1vX0ywymzrGZnjX48bYowofSeHUP97+1i/7FMWbKIfu+Zi8i9eovcNnH95avSOnXb5y9qlEO7g51LkEJ/rXkSVSI/PiP7I9Op7gJCcqT/Wz3tszDPgYe9wtVJ+Aq/2LdS494B7jI5k3Ay8VlvTc7zdte6E+XjZxMpuXAI39oB1C6Qrv4mPvNjloUnlKBbgL5gGSPTZxQxb0kCgWxIWt75vokO6s7S8t eQyZ8xuB 0IQTHuShYf4k2mgSL/KkRtZnMdltFnKzuB/Ll0Fxxzhm4aF9hmQjJ3JcAWdH/l6oLW+TxE/J2qmZ3SL2GA/eH+6BnbxesbYq9k46ZPZNvIdKoxMwFz26BKrg3oNa/3MGj40aRXd6v8vakgS2suADEXEqMOWkOJbCHFGjd/G67Z3a8qyIzLPxq+xJR3GlI80o/SDlElbi9htL1R50ug1G5DHpnY9ydqtMAZg3YZLqfVGKNK35oayIgaAnAkBtloL8jr8O/eDZqatc5pf0Jk0b98ziJNoAde3IBv5cKaAdq1eFU2MbaJqwdgPZJc9jLjiQ/r9lMmwU7LrUGGOuPIBFex1qgoukT5tKyeKIxej/vTdnbSYiEb2W+t2iaBnuzt25SXDqczK9d89yw1MAWnNppzngsu67x3ZHfCN0QP6IUnQKFRz3NKBAvCwz2hZiCHGg4At8JOTpkgjaXDlO+4L9JP4DJ+TAntBHoSP0wy4uyWJ/X575kAlpvpB/GfnhMf5xIWqAv/GSdicIB45U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > + > +static void snp_handle_guest_request(struct vcpu_svm *svm, gpa_t req_gpa, gpa_t resp_gpa) > +{ Both regular, > + > +static void snp_handle_ext_guest_request(struct vcpu_svm *svm, gpa_t req_gpa, gpa_t resp_gpa) > +{ and extended guest requests should be subject to rate limiting, since they take a lock on the shared resource that is the AMD-SP (psp?). I proposed a mechanism with empirically chosen defaults in [PATCH v2 0/2] kvm: sev: Add SNP guest request throttling [PATCH v2 1/2] kvm: sev: Add SEV-SNP guest request throttling [PATCH v2 2/2] kvm: sev: If ccp is busy, report throttled to guest http://129.79.113.48/hypermail/linux/kernel/2211.2/03107.html http://129.79.113.48/hypermail/linux/kernel/2211.2/03110.html http://129.79.113.48/hypermail/linux/kernel/2211.2/03111.html But I don't see these on lore. Would you like me to repost these? -- -Dionna Glaze, PhD (she/her)