From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF04CC678D6 for ; Fri, 20 Jan 2023 01:40:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43FFE6B0072; Thu, 19 Jan 2023 20:40:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EFF96B0073; Thu, 19 Jan 2023 20:40:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B8306B0075; Thu, 19 Jan 2023 20:40:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 185206B0072 for ; Thu, 19 Jan 2023 20:40:26 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D67CEAB346 for ; Fri, 20 Jan 2023 01:40:25 +0000 (UTC) X-FDA: 80373472410.01.9053CE5 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf04.hostedemail.com (Postfix) with ESMTP id 2168A40007 for ; Fri, 20 Jan 2023 01:40:23 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=tmyKvc9Y; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of dionnaglaze@google.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=dionnaglaze@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674178824; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B93pafDYiLEzdeFpoSwk6ASMlzCL9xGgaEmz8elDYkE=; b=J/xpKGEl1Srpv4Qor10ES2r7sXH56IbixGBACVEhkrm0ZNm0rJ3oglS+owml2IGe1nRiNg Aneq0iunWhyHoZOGxVLc7lrhX8sedczb3tapBunwtbhiZUaWyKRmzqfV4bUtoehTB1Z8sD tZqac+ziGWW5Z2cu6TezsR0KM8SdNcU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=tmyKvc9Y; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of dionnaglaze@google.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=dionnaglaze@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674178824; a=rsa-sha256; cv=none; b=Cm0597rdgPai3luQAEAu3ouwLDbrxrVgWFcjAbLscQPppYoj5QoWOONkwLgnOVuoVfFbEr Ksfb4MEK5y3uf409ZZLLQ6Ikdbrl7dJxPNQoi35iRtiZ+33JkrOUCr3nBn0x4XfDO3UwfF +WzKGLvWOIqbbQOF3hOBQdJC4VwtIc4= Received: by mail-pf1-f177.google.com with SMTP id s3so2897438pfd.12 for ; Thu, 19 Jan 2023 17:40:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=B93pafDYiLEzdeFpoSwk6ASMlzCL9xGgaEmz8elDYkE=; b=tmyKvc9Yi6bdrHRRM3gAqJqs1CzR1XX05zMF9AHW7o1g8CWfq25rGeVC46PYzv+QQb G+FFXjaoKNOC9lUG9nQ8YldisNIgUf+da+3wUYpfXHWDv6Hekx4GBTnTEmhVY2u6xY27 z3yUKZ3I9m2D7TUe5q/k6SAPomZVlbLzyYhz3IxiySZb6xMMQEPi8rvCXbqTVAytxDjJ dTsJPiH5Mr/IutzNznAv9WQcTlADk4CLKkyza6j3e9NO7NHS1fwemD3AD/19E9hb+3kw zmi7mYUAc+q8GwjrleYQng8J8+I8VZ7OKV3ycKnnxrmzR13hfdso8R+4itSyFIG8EXlk g3+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B93pafDYiLEzdeFpoSwk6ASMlzCL9xGgaEmz8elDYkE=; b=GMpl5YkTnKgDc/1AJQowdrfc60ymMyCyIRXNnvI7sa9SWzp8CSYw1bQ7fI0OzB3080 GHSLi8H75PFfqvVxrv/YgV5FKUs8Wa9+0aESeSOOSg/ddAexhHJ9fbwHkSfOspRowsos kX469mrYdN86jgrejRgXmepi1zaOJD9EIx5px2e/GiO446xvG7pnOLQhb5oDkGKTMx7Z 31LvREGj2KOs1G/zH5k6Icksk7b94srTFIlcMXZ2W9TbXCBg3SaReEX6Owr0GcXJcb0Y d/vTYteCM1PfL5oDI5Cxnf+gdk8SKnf8x8kmZwqpDOO8Mdsm8GuZcIjWhFKjiniv+aqo KE/g== X-Gm-Message-State: AFqh2kqL4dRCvJM9bRpT5u0dKG0x7en52QCULc0jVZg/Mz0apJiUByy7 JFV/CfxHI94AKtTaZFCzqhmlWm3PVq1efw6hZlqufw== X-Google-Smtp-Source: AMrXdXtX2ox98SuCBvArhlrqg1uXGxl5FHrJkf+XqM9+ca+Dt/RYaG6/dAfE1iGhutrPd+ArCj6PYRCWWDT4bL8xKQc= X-Received: by 2002:a05:6a00:4c14:b0:580:f2b8:213c with SMTP id ea20-20020a056a004c1400b00580f2b8213cmr1309897pfb.8.1674178822730; Thu, 19 Jan 2023 17:40:22 -0800 (PST) MIME-Version: 1.0 References: <20221214194056.161492-1-michael.roth@amd.com> <20221214194056.161492-63-michael.roth@amd.com> In-Reply-To: From: Dionna Amalie Glaze Date: Thu, 19 Jan 2023 17:40:10 -0800 Message-ID: Subject: Re: [PATCH RFC v7 62/64] x86/sev: Add KVM commands for instance certs To: "Kalra, Ashish" Cc: Michael Roth , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, harald@profian.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 2168A40007 X-Stat-Signature: otzmj8gcnjis8psyd933e8bp6b8xnnca X-HE-Tag: 1674178823-604324 X-HE-Meta: U2FsdGVkX19Yx7+rUKS4Zh0Q/dpTuduPfrZkOUofIi0QLxkpleWR0p+/Y9LJhUNV1UdmtKEKJyxJi8vY3yTb5u4syVKyxcOwc/vgSG+8wZq/PquDwwZ9TOjcNbR90FaY0GNeIYqP4MvgCSEPTc8uBUNBvR3XIJX5GvP5PkG1XEew1XVILPpLMPTz7c6JukkFZqujfhXq83C86iw79OgH8I2mrtJGFhRSuUe6GrWs7y1Hc9DJtZvCXALqT2w6CtnPZ2K9H6y/xO277t3FkTvafRmwaPxEQQaMS6YCADRkdM9hop+w5jtqDDfNHkV0nfNPhHZhcLpEZlK32PuXGSbMgSGXGb5aJHgR+Sa5VHKALcwCCQjktU4wp9+Qq7glfJIlN4FX3LhKXXdW52RYajT8rWU93CWFX4qVENDo8hvXL2D1sGe9vTC/U7G9Xb6gBJooLQaTop6EnW6ySPLB/kikre/2UoDnGkWnor3J5ZaxeBUPZvI9EwnUSqDA86Q7vd9nr9uxwJyj16uY/Fx2ITbdW+nfntODl9Cvz3EFTYQ3td2+hxr18rRWjioU+rE0JOVB5tBdwSCrowzJYkuMvhI5oUTPFGvj7I9IcuZrMhgYVQUxen7GZYa//tYqUwueFcUGJ66uHhB6YiJTLb0aF9z/zK8KwA275ZdfEVWk+9ZH7edNIzmwdkqXXDmaChXpJg7bKxlUb4IGxstl2TivnTetsE6eCPwl4ef43tGhwrVuB6v4BVlfxXSVBn/veTBMpIIdKaXuOGE1NGapmMFee5+XLvmNfa7IaR9msFoWX1AsAimaK6bqt88TyzDIN1XHqHOWzRiDsjxe0o6KQzmKRknGrx38senonMGDISOJghC5TBUKI2YR803JAzak2vo9RUyjMKdr0gS59PQiyycq02csJT71sBLrKQeHD5BSOR7xKha/VqNoFBZZ/XXXthK4yltD6Ofh8+y9JXDO2TTmnoM bFibmgaB wuMYw6VzkatYsuiY30OtsChE7r5Eco6gLUnnJzfU8aNOd9IXh1u/ayc6y+umWIvedN8qmq8xfqe4Skrqf5n4Y5fdbqNBK7c7hVl4yhH86WBE+dBRG1zq+P0k/VjCZPKmc6gkRsw/BGqpdeystqXKM/lWXQHASYnpiLjvIHJoJPNin6U2KUY5PmeM1Mk+phmdzRsSagl04aoJEwhHgcad0FZvZxuwKTcFWyW5L6Ck/HL25AYrbuje/OvcR7UeeSa43oF74HqHPewuuSMU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 19, 2023 at 2:18 PM Kalra, Ashish wrote: > > Hello Dionna, > > Do you also have other updates to this patch with regard to review > comments from Dov ? > Apart from the PAGE_ALIGN change, the result of the whole discussion appears to only need the following immediately before the copy_from_user of certs_uaddr in the snp_set_instance_certs function: /* The size could shrink and leave garbage at the end. */ memset(sev->snp_certs_data, 0, SEV_FW_BLOB_MAX_SIZE); I don't believe there is an off-by-one with the page shifting for the number of pages because snp_certs_len is already rounded up to the nearest page size. Any other change wrt the way the blob size is decided between the guest and host should come later. -- -Dionna Glaze, PhD (she/her)