From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 533EBC433E1 for ; Thu, 20 Aug 2020 17:34:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 157EB207DE for ; Thu, 20 Aug 2020 17:34:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="WJVp6uka" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 157EB207DE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 96F3E8D004B; Thu, 20 Aug 2020 13:34:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9209A8D0002; Thu, 20 Aug 2020 13:34:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 836388D004B; Thu, 20 Aug 2020 13:34:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0054.hostedemail.com [216.40.44.54]) by kanga.kvack.org (Postfix) with ESMTP id 6FB598D0002 for ; Thu, 20 Aug 2020 13:34:06 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 28106180AD806 for ; Thu, 20 Aug 2020 17:34:06 +0000 (UTC) X-FDA: 77171645292.21.spot06_5115f3527032 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id EB41E180442C3 for ; Thu, 20 Aug 2020 17:34:05 +0000 (UTC) X-HE-Tag: spot06_5115f3527032 X-Filterd-Recvd-Size: 6165 Received: from mail-ej1-f65.google.com (mail-ej1-f65.google.com [209.85.218.65]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Thu, 20 Aug 2020 17:34:05 +0000 (UTC) Received: by mail-ej1-f65.google.com with SMTP id o18so3466299eje.7 for ; Thu, 20 Aug 2020 10:34:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=++DU+mGMau0wCVk26WL7BRudLdRoW/TdcNVBaFfSVeo=; b=WJVp6ukadTpNcM9SYJpDROIRN+tD3gRH5NoPQs0+HAsQmLtJTImp5dRFMc7wGC3HgN R/lFt0vUnPt7BGWZ9GyHNRaZ0vNwnvZs2Kqg3u8nexS2ZBfKmw9OlPBaaVZioiS7BHsl YQ4r7w5vrJPUKxgqdugvjbGIbRfRLzSot++CY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=++DU+mGMau0wCVk26WL7BRudLdRoW/TdcNVBaFfSVeo=; b=a5YPDd6v5c/fB+m2tu5QnhEvA9ouKOaAyf6f/mQK5OJZN8hw3ESTdVF0OwTh7cdKkU WVMH4UKEHyMzrnijBC2w8S+UDXgclknDgQoonbAxfOzKhRDyMmHnfgv2IH+/myHDYyXQ txSXqpbcctFDUeuH3XoqfvI1QzDwQkhdpJPhnWf588fF/SZZ9jyxFS1xLiWxVh8u4HJW 9FMBuxXL2cw2W5sUMVI1DCoAkhLt/X0VGPVIef75yr3LYhhd1x2fb+c0Fq+6Xrjh1ZGE 8p68K9uMHV94Ij/sxGhU4JHqpPV1BupNsi+uEyT/F0nlBxdWpeQTTmyIeYZFDEfk6iFI GMnw== X-Gm-Message-State: AOAM532jhhFaCWfJpvorwwU3OaYjOGa5w/GAqAfK+BoKY3+gR3urGhP9 1d6XZMXaCXQ+4NRbcPsDQcCBsUB9xKaHLQ== X-Google-Smtp-Source: ABdhPJxMRa0QvgRzzDJhsXjyGR0dTa1qYwXg8WgDC8aINoDZdYrkT+t/snGbmOJgrT3NNL/igYU3Jg== X-Received: by 2002:a17:906:cecd:: with SMTP id si13mr4395342ejb.96.1597944843740; Thu, 20 Aug 2020 10:34:03 -0700 (PDT) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com. [209.85.221.45]) by smtp.gmail.com with ESMTPSA id lc18sm1826823ejb.29.2020.08.20.10.34.02 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Aug 2020 10:34:02 -0700 (PDT) Received: by mail-wr1-f45.google.com with SMTP id f1so2836938wro.2 for ; Thu, 20 Aug 2020 10:34:02 -0700 (PDT) X-Received: by 2002:adf:ec4f:: with SMTP id w15mr4013793wrn.385.1597944841643; Thu, 20 Aug 2020 10:34:01 -0700 (PDT) MIME-Version: 1.0 References: <20200819065555.1802761-1-hch@lst.de> <20200819065555.1802761-6-hch@lst.de> <20200819135454.GA17098@lst.de> <20200820044347.GA4533@lst.de> <20200820052004.GA5305@lst.de> <20200820165407.GD12693@lst.de> In-Reply-To: <20200820165407.GD12693@lst.de> From: Tomasz Figa Date: Thu, 20 Aug 2020 19:33:48 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT To: Christoph Hellwig Cc: alsa-devel@alsa-project.org, linux-ia64@vger.kernel.org, Linux Doc Mailing List , nouveau@lists.freedesktop.org, linux-nvme@lists.infradead.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , linux-mm@kvack.org, linux-samsung-soc , Joonyoung Shim , linux-scsi@vger.kernel.org, Kyungmin Park , Ben Skeggs , Matt Porter , Linux Media Mailing List , Tom Lendacky , Pawel Osciak , Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, netdev@vger.kernel.org, Seung-Woo Kim , Linux Kernel Mailing List , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: EB41E180442C3 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 20, 2020 at 6:54 PM Christoph Hellwig wrote: > > On Thu, Aug 20, 2020 at 12:05:29PM +0200, Tomasz Figa wrote: > > The UAPI and V4L2/videobuf2 changes are in good shape and the only > > wrong part is the use of DMA API, which was based on an earlier email > > guidance anyway, and a change to the synchronization part . I find > > conclusions like the above insulting for people who put many hours > > into designing and implementing the related functionality, given the > > complexity of the videobuf2 framework and how ill-defined the DMA API > > was, and would feel better if such could be avoided in future > > communication. > > It wasn't meant to be too insulting, but I found this out when trying > to figure out how to just disable it. But it also ends up using > the actual dma attr flags for it's own consistency checks, so just > not setting the flag did not turn out to work that easily. > Yes, sadly the videobuf2 ended up becoming quite counterintuitive after growing for the long years and that is reflected in the design of this feature as well. I think we need to do something about it. > But in general it helps to add a few more people to the Cc list for > such things that do stranger things. Especially if you think you did > it based on the advice of those people. Indeed, we should have CCed you and other DMA folks. Sergey who worked on this series is quite new to these areas of the kernel (although not to the kernel itself) and it's my fault for not explicitly letting him know to do that. Best regards, Tomasz