From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3720C433E6 for ; Tue, 1 Sep 2020 15:12:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A3FF1208CA for ; Tue, 1 Sep 2020 15:12:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="lCL5SLaM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3FF1208CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 437C96B009D; Tue, 1 Sep 2020 11:12:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E9286B009E; Tue, 1 Sep 2020 11:12:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D7196B009F; Tue, 1 Sep 2020 11:12:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0127.hostedemail.com [216.40.44.127]) by kanga.kvack.org (Postfix) with ESMTP id 182B76B009D for ; Tue, 1 Sep 2020 11:12:07 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 97ED1180ACEE6 for ; Tue, 1 Sep 2020 15:12:06 +0000 (UTC) X-FDA: 77214833052.19.cork78_2b0762527099 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 721421ACC31 for ; Tue, 1 Sep 2020 15:12:01 +0000 (UTC) X-HE-Tag: cork78_2b0762527099 X-Filterd-Recvd-Size: 5997 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Tue, 1 Sep 2020 15:11:49 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id j2so1952251wrx.7 for ; Tue, 01 Sep 2020 08:11:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BIr3FRHLWeYI5mpm2jHeXhPihRGMNnmHYOmMOMeHpR4=; b=lCL5SLaMFPqoPftiV2X8nocTTBdKqARvrqI17ufYPS0DtjiIyaSIs4CniiHZ/VEW8n WoqCHbvQzPHbcjvAM7+zD7U98QNr5oxI5U75nYwYeOtUdaj7M9sptx5fdS3otDiC5uUz 5071XY7IwhHNlm+8JmyRZFrwvyyMI1Xxx/Jf4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BIr3FRHLWeYI5mpm2jHeXhPihRGMNnmHYOmMOMeHpR4=; b=XETDJjuJLHMv0alGFnOUPneSGpph/WANuVfMxrdObsq/Tht11S5qLQiocHn1ZY6k1a zACNBdFjtwTAtQIOYy32SHuu8e1UjdEY93o8nc8bMGrysC1GPerBXbSaj0BrCrdwSsJa Ih3/2XKCfo8NFymGLvC6ryiQE5wkmlVwo2bZxrnVNf4w5fF0ihimHkzqpehldgTWFlpa FX1oI1VHQx6nXcwL2tWfrWUlT9iOjVn0N96P2eep8UESS6PBxNEg45WhTNARnM5qgXBg TSvU7H/tt8HHlgavOozW7xmrnGYoGPALnTSc9/PeC5LNfYBmD2D2GJ1uKbFddcXN977T 2Obw== X-Gm-Message-State: AOAM531qDvgJNtMxYeS6REm86ZfPVWNjF/2Wv6KV07rt7iNuAMY5sQtv StYj4bxstgyM2HSIslerXBHLkufb6LwVzw== X-Google-Smtp-Source: ABdhPJxJy600EZqpaXQ+yuKonlv+qTeKBhnfJHgP4JLf+mY6ipq2iL+Ym+d5rfBDRWm5riJwhmeiQg== X-Received: by 2002:a17:906:ce4b:: with SMTP id se11mr1743619ejb.386.1598972571526; Tue, 01 Sep 2020 08:02:51 -0700 (PDT) Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com. [209.85.221.43]) by smtp.gmail.com with ESMTPSA id y25sm1320010edv.15.2020.09.01.08.02.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2020 08:02:50 -0700 (PDT) Received: by mail-wr1-f43.google.com with SMTP id o5so1891842wrn.13 for ; Tue, 01 Sep 2020 08:02:49 -0700 (PDT) X-Received: by 2002:a5d:5150:: with SMTP id u16mr2332024wrt.197.1598972568491; Tue, 01 Sep 2020 08:02:48 -0700 (PDT) MIME-Version: 1.0 References: <20200819065555.1802761-1-hch@lst.de> <20200819065555.1802761-6-hch@lst.de> <20200819135454.GA17098@lst.de> <20200820044347.GA4533@lst.de> <20200820052004.GA5305@lst.de> <20200820165407.GD12693@lst.de> <20200901110617.GA13232@lst.de> In-Reply-To: <20200901110617.GA13232@lst.de> From: Tomasz Figa Date: Tue, 1 Sep 2020 17:02:20 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT To: Christoph Hellwig Cc: alsa-devel@alsa-project.org, linux-ia64@vger.kernel.org, Linux Doc Mailing List , nouveau@lists.freedesktop.org, linux-nvme@lists.infradead.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , linux-mm@kvack.org, linux-samsung-soc , Joonyoung Shim , linux-scsi@vger.kernel.org, Kyungmin Park , Ben Skeggs , Matt Porter , Linux Media Mailing List , Tom Lendacky , Pawel Osciak , Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, netdev@vger.kernel.org, Seung-Woo Kim , Linux Kernel Mailing List , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 721421ACC31 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 1, 2020 at 1:06 PM Christoph Hellwig wrote: > > On Thu, Aug 20, 2020 at 07:33:48PM +0200, Tomasz Figa wrote: > > > It wasn't meant to be too insulting, but I found this out when trying > > > to figure out how to just disable it. But it also ends up using > > > the actual dma attr flags for it's own consistency checks, so just > > > not setting the flag did not turn out to work that easily. > > > > > > > Yes, sadly the videobuf2 ended up becoming quite counterintuitive > > after growing for the long years and that is reflected in the design > > of this feature as well. I think we need to do something about it. > > So I'm about to respin the series and wonder how we should proceed. > I've failed to come up with a clean patch to keep the flag and make > it a no-op. Can you or your team give it a spin? > Okay, I'll take a look. > Also I wonder if the flag should be renamed from NON_CONSISTENT > to NON_COHERENT - the consistent thing is a weird wart from the times > the old PCI DMA API that is mostly gone now. It originated from the DMA_ATTR_NON_CONSISTENT flag, but agreed that NON_COHERENT would be more consistent (pun not intended) with the rest of the DMA API given the removal of that flag. Let me see if we can still change it. Best regards, Tomasz