From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3452C433DF for ; Wed, 19 Aug 2020 14:12:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B16B72076E for ; Wed, 19 Aug 2020 14:12:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="dV/u8lgz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B16B72076E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2606D8D0029; Wed, 19 Aug 2020 10:12:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 210C86B00AC; Wed, 19 Aug 2020 10:12:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FE9C8D0029; Wed, 19 Aug 2020 10:12:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0101.hostedemail.com [216.40.44.101]) by kanga.kvack.org (Postfix) with ESMTP id EA9256B00AB for ; Wed, 19 Aug 2020 10:12:13 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 36D2B180AD822 for ; Wed, 19 Aug 2020 14:12:13 +0000 (UTC) X-FDA: 77167507746.18.day78_2d13da027028 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id D66EF100ED0F5 for ; Wed, 19 Aug 2020 14:12:12 +0000 (UTC) X-HE-Tag: day78_2d13da027028 X-Filterd-Recvd-Size: 6520 Received: from mail-ej1-f66.google.com (mail-ej1-f66.google.com [209.85.218.66]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Wed, 19 Aug 2020 14:12:12 +0000 (UTC) Received: by mail-ej1-f66.google.com with SMTP id bo3so26427996ejb.11 for ; Wed, 19 Aug 2020 07:12:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/Js4y14Ghs6Bq4zdQYDVHKruVAGVzHlKISQN4bMebSg=; b=dV/u8lgzRJf9R13RTyQNVA0z7K0gpop908KdbH7mh1lom7wOwawyDuMH4lJJUnAt3N ER1Hz91rD7vCxhZyzb6LHpsKYbaB2LKK6Ns95j0nfjmJX5hZXauljIjL3//YJqgWaxRv 97QHf+SgHVXKKphnPxr8+LnwmzFET6Ce2ARqc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/Js4y14Ghs6Bq4zdQYDVHKruVAGVzHlKISQN4bMebSg=; b=txn86nCMzJ/CP3tG+9xoSLsLGnJjGc0KaLXWJC+cYOXk94210j7sapFceQ79zyhSBs 4LSl8OY3Wxf83DnGQZdKyIn+aezpSzG4GCxgHTIfnsGSMlWlzmYoqTT0Kz2MZZ9/LJlr Oy7UUPqlWdz2DTnyqnA2MZ6avJfxCX9P8xrObB2e5+VAadLrnTlBUeWJae15DMeDxqTR JWNIl1fkPktlM9YIxvD1JTAx4aP+C7yHLklsop6z8tulfe8d0jRkQpR46v+zZ8OttkMQ qN+aB0LAuJaNbtuCgx3ZBhci0u+2fUTUMOKQKpbdI2UVbuMh5KjxxZRApb59eaUSc88V 8OVQ== X-Gm-Message-State: AOAM532cVH7uUm0G/pzWh8jYJHz+AvhJ5Im6wyA6iWaHBI+2C45jLful /4JTempkINzaLkC3jMFCRWyC+RySF1BLwQ== X-Google-Smtp-Source: ABdhPJxG/YqujmVtXozmG/OCSzvOS7NBzG5/N4QaNoydHktnstZ+Pr0yacG40JwJ5xzPFbQ4s0pwYg== X-Received: by 2002:a17:906:4f0f:: with SMTP id t15mr24756172eju.337.1597846330726; Wed, 19 Aug 2020 07:12:10 -0700 (PDT) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com. [209.85.221.47]) by smtp.gmail.com with ESMTPSA id v22sm17951984edq.35.2020.08.19.07.12.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Aug 2020 07:12:09 -0700 (PDT) Received: by mail-wr1-f47.google.com with SMTP id f1so21708898wro.2 for ; Wed, 19 Aug 2020 07:12:09 -0700 (PDT) X-Received: by 2002:adf:ec4f:: with SMTP id w15mr24104550wrn.385.1597846328915; Wed, 19 Aug 2020 07:12:08 -0700 (PDT) MIME-Version: 1.0 References: <20200819065555.1802761-1-hch@lst.de> <20200819065555.1802761-6-hch@lst.de> <62e4f4fc-c8a5-3ee8-c576-fe7178cb4356@arm.com> <20200819135738.GB17098@lst.de> In-Reply-To: <20200819135738.GB17098@lst.de> From: Tomasz Figa Date: Wed, 19 Aug 2020 16:11:52 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT To: Christoph Hellwig Cc: Robin Murphy , alsa-devel@alsa-project.org, linux-ia64@vger.kernel.org, Linux Doc Mailing List , nouveau@lists.freedesktop.org, linux-nvme@lists.infradead.org, Linux Kernel Mailing List , "James E.J. Bottomley" , linux-mm@kvack.org, Marek Szyprowski , linux-samsung-soc , Joonyoung Shim , linux-scsi@vger.kernel.org, Kyungmin Park , Ben Skeggs , Matt Porter , Linux Media Mailing List , Tom Lendacky , Pawel Osciak , Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS" , Joerg Roedel , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, netdev@vger.kernel.org, Seung-Woo Kim , linux-mips@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: D66EF100ED0F5 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 19, 2020 at 3:57 PM Christoph Hellwig wrote: > > On Wed, Aug 19, 2020 at 02:49:01PM +0200, Tomasz Figa wrote: > > With the default config it doesn't, but with > > CONFIG_DMA_NONCOHERENT_CACHE_SYNC enabled it makes dma_pgprot() keep > > the pgprot value as is, without enforcing coherence attributes. > > Which isn't selected on arm64, and that is for a good reason. > > > AFAIK dma_cache_sync() isn't the only way to perform the cache > > synchronization. > > Yes, it is the only documented way to do it. And if you read the whole > series instead of screaming you'd see that it provides a proper way > to deal with non-coherent memory which will also work with arm64. > instead of screaming > I'm sorry if I have offended you in any way, but would also appreciate it if a less aggressive tone was directed towards me as well. I have valid reasons to object to this patch, as stated in my previous emails. The fact that the original feature has problems is of course another story and, as I mentioned too, I'm willing to look into fixing them. I'm of course happy to review the rest of the series and even more happy to help migrating this code to whatever is added there, as long as the functionality is preserved. > > By the way, as a videobuf2 reviewer, I'd appreciate being CC'd on any > > series related to the subsystem-facing DMA API changes, since > > videobuf2 is one of the biggest users of it. > > The cc list is too long - I cc lists and key maintainers. As a reviewer > should should watch your subsystems lists closely. Well, I guess we can disagree on this, because there is no clear policy. I'm listed in the MAINTAINERS file for the subsystem and I believe the purpose of the file is to list the people to CC on relevant patches. We're all overloaded with work and having to look through the huge volume of mailing lists like linux-media doesn't help and thus I'd still appreciate being added on CC. Best regards, Tomasz