From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A96B9C433DF for ; Wed, 19 Aug 2020 14:17:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 535C920639 for ; Wed, 19 Aug 2020 14:17:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="m4IkKgPl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 535C920639 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EE1B96B00B2; Wed, 19 Aug 2020 10:17:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E90D38D0041; Wed, 19 Aug 2020 10:17:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D596E6B00B4; Wed, 19 Aug 2020 10:17:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0045.hostedemail.com [216.40.44.45]) by kanga.kvack.org (Postfix) with ESMTP id B7E666B00B2 for ; Wed, 19 Aug 2020 10:17:52 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 64E743637 for ; Wed, 19 Aug 2020 14:17:52 +0000 (UTC) X-FDA: 77167521984.18.stone19_1b1659327028 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id DC30B100ED9DE for ; Wed, 19 Aug 2020 14:17:50 +0000 (UTC) X-HE-Tag: stone19_1b1659327028 X-Filterd-Recvd-Size: 5442 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Wed, 19 Aug 2020 14:17:50 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id a5so21722648wrm.6 for ; Wed, 19 Aug 2020 07:17:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6xkguvOzsgzZf/2nZcmiUdLktaalZbMKG8kwCTKJnbQ=; b=m4IkKgPlDJh9Ow/m1Q5dtgZrYLnaRCS7od5vd7CevPl4aSkNJcXDYSbofI9IVrnSM1 T0Nk8lAEv28vGxYfqJpLVc+ygPg3eNS610ZSiKpYmXTIZXUzbw+fr6qoGPkql89ad0SH sz82upHUpsjkfyqDK6oYGAHuFg3NLWv3KpWnw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6xkguvOzsgzZf/2nZcmiUdLktaalZbMKG8kwCTKJnbQ=; b=ZVKx597eOWxGVo0U0NIJWbtaOOwJizUtdgRwA5mqH0MdXBmXF7wSubGim+BJj5Gm4T XAvXzLDefeARoLWJggJosXfwQxseDMHWZQsrDLl9E1p9jYWLqe49MJ+LKofOTwrUCoTY 5nuZTZtnB34dVtdG2p/WXQZfCgpuaCaFizDnTmTDhsBP9omrSN7AMs+FqpoKrSUz3X+I Ex9m77zjz73x8iz69mDQwjp5byZ3e6/9maI23M2Exv9FepRP73qJDDo/zx9XOEvKbpIF KjZTwC+CJZ9dFOQR/93AXGgqiNhhc3N3ekEonwmrbJQjWOwOc7yiqnpzzU3iBaWTv2xL PyvQ== X-Gm-Message-State: AOAM532SsvBqRPGdmVwQ+5t476h92TmHLlWTxipMAO8fVB2boidPOtJU 60uO8BKyIfsTZU0GzIatchFLaTfKNz5X1g== X-Google-Smtp-Source: ABdhPJyrHYwSOKwmdmCnDzIJvLBo6CSKIhb4a5fNoW1kiFs9fEdjkt7DOvANjLxilT7ryz9/4+or9w== X-Received: by 2002:a17:906:289a:: with SMTP id o26mr24913628ejd.309.1597845948567; Wed, 19 Aug 2020 07:05:48 -0700 (PDT) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com. [209.85.128.47]) by smtp.gmail.com with ESMTPSA id gh25sm18488363ejb.109.2020.08.19.07.05.48 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Aug 2020 07:05:48 -0700 (PDT) Received: by mail-wm1-f47.google.com with SMTP id k8so2346224wma.2 for ; Wed, 19 Aug 2020 07:05:48 -0700 (PDT) X-Received: by 2002:a1c:5581:: with SMTP id j123mr5137250wmb.11.1597845489930; Wed, 19 Aug 2020 06:58:09 -0700 (PDT) MIME-Version: 1.0 References: <20200819065555.1802761-1-hch@lst.de> <20200819065555.1802761-6-hch@lst.de> <20200819135454.GA17098@lst.de> In-Reply-To: <20200819135454.GA17098@lst.de> From: Tomasz Figa Date: Wed, 19 Aug 2020 15:57:53 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT To: Christoph Hellwig Cc: Mauro Carvalho Chehab , Thomas Bogendoerfer , "James E.J. Bottomley" , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Ben Skeggs , Pawel Osciak , Marek Szyprowski , Matt Porter , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Tom Lendacky , alsa-devel@alsa-project.org, linux-samsung-soc , linux-ia64@vger.kernel.org, linux-scsi@vger.kernel.org, linux-parisc@vger.kernel.org, Linux Doc Mailing List , nouveau@lists.freedesktop.org, Linux Kernel Mailing List , linux-nvme@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Linux Media Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: DC30B100ED9DE X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 19, 2020 at 3:55 PM Christoph Hellwig wrote: > > On Wed, Aug 19, 2020 at 01:16:51PM +0200, Tomasz Figa wrote: > > Hi Christoph, > > > > On Wed, Aug 19, 2020 at 8:56 AM Christoph Hellwig wrote: > > > > > > The V4L2-FLAG-MEMORY-NON-CONSISTENT flag is entirely unused, > > > > Could you explain what makes you think it's unused? It's a feature of > > the UAPI generally supported by the videobuf2 framework and relied on > > by Chromium OS to get any kind of reasonable performance when > > accessing V4L2 buffers in the userspace. > > Because it doesn't do anything except on PARISC and non-coherent MIPS, > so by definition it isn't used by any of these media drivers. It's still an UAPI feature, so we can't simply remove the flag, it must stay there as a no-op, until the problem is resolved. Also, it of course might be disputable as an out-of-tree usage, but selecting CONFIG_DMA_NONCOHERENT_CACHE_SYNC makes the flag actually do something on other platforms, including ARM64. Best regards, Tomasz