From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FC70C433FE for ; Mon, 28 Nov 2022 08:58:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B45426B0072; Mon, 28 Nov 2022 03:58:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AF7326B0073; Mon, 28 Nov 2022 03:58:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9969C6B0074; Mon, 28 Nov 2022 03:58:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 892866B0072 for ; Mon, 28 Nov 2022 03:58:18 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4C61440CCA for ; Mon, 28 Nov 2022 08:58:18 +0000 (UTC) X-FDA: 80182249476.05.418705E Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf08.hostedemail.com (Postfix) with ESMTP id C8517160008 for ; Mon, 28 Nov 2022 08:58:17 +0000 (UTC) Received: by mail-lf1-f49.google.com with SMTP id d6so16278478lfs.10 for ; Mon, 28 Nov 2022 00:58:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=iRo5DYRndKCx9sGSXzsZxPr88K/zqtuLTLl1O32mcFE=; b=XOKEpyQaMH8DtU4ghoeum5LLPSyZKKSeL9ukREYJEhE5Pet4ng53VcgxrNVIVOiN3z qM9BvX69vBwubqV7gI66eEPgV5zFoyHzRXj6Y/c3o1k6BVytkDV23dS8hW9lN3urO8Q7 YycsWj1XAMOHph6L7v2J+A4VSfKO7i7WBHunk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iRo5DYRndKCx9sGSXzsZxPr88K/zqtuLTLl1O32mcFE=; b=WEAmO1yoZss+G14lo8wT1DUnJwvSf1px+yH68GU79w6L94vMZpg8LFmS1d1ISJ0HE1 W36d/P6+jhjWue1V0HkzBYt1pu7151E+HumaYFSGn5KUAy0QUN5dULP87hBIQ4TVa15t b38kv4iC+6MgFYlImESscjRr1vYIwyY8C/E3Z15ZWG/4NUD9fvjU2zchPk8E9gaBTklu tNiIExKRX8Z5RXI67pLf7e+EyImjpjIJboZZZYKu2e9dGV9EvmNsjyw3E/USvLjsI+HO LTCWdBz1jgrvg1C4NOxGW8NSYX368QB6q3r+7o6dN3M5TEsi3DF8jWb5y1bwQJRdog5H fSyw== X-Gm-Message-State: ANoB5pm5pk+A5t4IIhf0dcjK0UCblSrXc7MrowS86RfH1+6v25mnDShf yv6sKUUumFCDPSx11FzIKmK0Z1zu8bcjIQ== X-Google-Smtp-Source: AA0mqf44jWZmK/xZcVfWBA9cGHrX9R+yerTOyvsZczJCNy9q1hnHC9Qu33AEfIXNAC55ueMdG974sA== X-Received: by 2002:ac2:43d8:0:b0:4a2:45ce:a169 with SMTP id u24-20020ac243d8000000b004a245cea169mr17634708lfl.51.1669625895837; Mon, 28 Nov 2022 00:58:15 -0800 (PST) Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com. [209.85.208.182]) by smtp.gmail.com with ESMTPSA id r5-20020ac25c05000000b004b4f3c0d9f8sm1647658lfp.283.2022.11.28.00.58.14 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 00:58:15 -0800 (PST) Received: by mail-lj1-f182.google.com with SMTP id z24so12334680ljn.4 for ; Mon, 28 Nov 2022 00:58:14 -0800 (PST) X-Received: by 2002:aa7:db98:0:b0:46a:d57:d9d0 with SMTP id u24-20020aa7db98000000b0046a0d57d9d0mr25216647edt.113.1669625884043; Mon, 28 Nov 2022 00:58:04 -0800 (PST) MIME-Version: 1.0 References: <20221116102659.70287-1-david@redhat.com> <20221116102659.70287-17-david@redhat.com> <81fb0fa3-2e06-b765-56ac-a7d981194e59@redhat.com> <08b65ac6-6786-1080-18f8-d2be109c85fc@xs4all.nl> <9d0bf98a-3d6a-1082-e992-1338e1525935@redhat.com> In-Reply-To: <9d0bf98a-3d6a-1082-e992-1338e1525935@redhat.com> From: Tomasz Figa Date: Mon, 28 Nov 2022 17:57:51 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage To: David Hildenbrand Cc: Hans Verkuil , linux-kernel@vger.kernel.org, Andrew Morton , x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, Linus Torvalds , Jason Gunthorpe , John Hubbard , Peter Xu , Greg Kroah-Hartman , Andrea Arcangeli , Hugh Dickins , Nadav Amit , Vlastimil Babka , Matthew Wilcox , Mike Kravetz , Muchun Song , Shuah Khan , Lucas Stach , David Airlie , Oded Gabbay , Arnd Bergmann , Christoph Hellwig , Alex Williamson , Marek Szyprowski , Mauro Carvalho Chehab Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669625897; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iRo5DYRndKCx9sGSXzsZxPr88K/zqtuLTLl1O32mcFE=; b=HOYk0PfXJE9gKTPXphzFxdEV5Sb4k26fNlAzmWeEvqA7OobFR9cMPHBoUjpQcpvAvfaJhQ hk72Iy0FKHmSvukyTJhI96LDERo+va37Nw3A6CiBNcX1gVjr+ywjfYlvG5vuguAdQ7vP/6 QX4gJuSrQtt657i5BCR163OfOyXWwbE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=XOKEpyQa; spf=pass (imf08.hostedemail.com: domain of tfiga@chromium.org designates 209.85.167.49 as permitted sender) smtp.mailfrom=tfiga@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669625898; a=rsa-sha256; cv=none; b=sKUNWy+QDCyESnkoQkHP78nnm/CzthRi2toHR+XqORV+WqSFSA7aK0NHcpgbfxOj/f2xlj iXWQo04b7laokb1sXT4z08eg5OjiuM9C/y9nAis98fiQ2X4SjffIGFKV5z+etNjAAvnrII 1qrrvgquVntkEQsx6BFpydAQysMDqYw= X-Stat-Signature: dxmn7g3s1d7pwjz9pm6r5tnbwr6m1pzh X-Rspamd-Queue-Id: C8517160008 Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=XOKEpyQa; spf=pass (imf08.hostedemail.com: domain of tfiga@chromium.org designates 209.85.167.49 as permitted sender) smtp.mailfrom=tfiga@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1669625897-325981 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 28, 2022 at 5:19 PM David Hildenbrand wrote: > > On 28.11.22 09:17, Hans Verkuil wrote: > > Hi David, > > > > On 27/11/2022 11:35, David Hildenbrand wrote: > >> On 16.11.22 11:26, David Hildenbrand wrote: > >>> FOLL_FORCE is really only for ptrace access. According to commit > >>> 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers are always > >>> writable"), get_vaddr_frames() currently pins all pages writable as a > >>> workaround for issues with read-only buffers. > >>> > >>> FOLL_FORCE, however, seems to be a legacy leftover as it predates > >>> commit 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers are > >>> always writable"). Let's just remove it. > >>> > >>> Once the read-only buffer issue has been resolved, FOLL_WRITE could > >>> again be set depending on the DMA direction. > >>> > >>> Cc: Hans Verkuil > >>> Cc: Marek Szyprowski > >>> Cc: Tomasz Figa > >>> Cc: Marek Szyprowski > >>> Cc: Mauro Carvalho Chehab > >>> Signed-off-by: David Hildenbrand > >>> --- > >>> drivers/media/common/videobuf2/frame_vector.c | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/drivers/media/common/videobuf2/frame_vector.c b/drivers/media/common/videobuf2/frame_vector.c > >>> index 542dde9d2609..062e98148c53 100644 > >>> --- a/drivers/media/common/videobuf2/frame_vector.c > >>> +++ b/drivers/media/common/videobuf2/frame_vector.c > >>> @@ -50,7 +50,7 @@ int get_vaddr_frames(unsigned long start, unsigned int nr_frames, > >>> start = untagged_addr(start); > >>> ret = pin_user_pages_fast(start, nr_frames, > >>> - FOLL_FORCE | FOLL_WRITE | FOLL_LONGTERM, > >>> + FOLL_WRITE | FOLL_LONGTERM, > >>> (struct page **)(vec->ptrs)); > >>> if (ret > 0) { > >>> vec->got_ref = true; > >> > >> > >> Hi Andrew, > >> > >> see the discussion at [1] regarding a conflict and how to proceed with > >> upstreaming. The conflict would be easy to resolve, however, also > >> the patch description doesn't make sense anymore with [1]. > > > > Might it be easier and less confusing if you post a v2 of this series > > with my patch first? That way it is clear that 1) my patch has to come > > first, and 2) that it is part of a single series and should be merged > > by the mm subsystem. > > > > Less chances of things going wrong that way. > > > > Just mention in the v2 cover letter that the first patch was added to > > make it easy to backport that fix without being hampered by merge > > conflicts if it was added after your frame_vector.c patch. > > Yes, that's the way I would naturally do, it, however, Andrew prefers > delta updates for minor changes. > > @Andrew, whatever you prefer! > > Thanks! > However you folks proceed with taking this patch, feel free to add my Acked-by. Thanks! Best regards, Tomasz > -- > Thanks, > > David / dhildenb >