From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29E5EC77B7C for ; Wed, 10 May 2023 09:03:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3C466B0071; Wed, 10 May 2023 05:03:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C6116B0072; Wed, 10 May 2023 05:03:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 866E86B0074; Wed, 10 May 2023 05:03:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6E5776B0071 for ; Wed, 10 May 2023 05:03:19 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3B177160932 for ; Wed, 10 May 2023 09:03:19 +0000 (UTC) X-FDA: 80773756518.09.F62C835 Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) by imf15.hostedemail.com (Postfix) with ESMTP id 60548A0009 for ; Wed, 10 May 2023 09:03:17 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=MuuFEvVR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of rick.wertenbroek@gmail.com designates 209.85.210.48 as permitted sender) smtp.mailfrom=rick.wertenbroek@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683709397; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tMjeCMC/4Q3TMdYdgIMW1QMW7kWGP2cWpwPZAIpQS9Q=; b=gk57kkEfcMBSzRoNBwJkk1C5u1stdtDTL90PI2qGzT7TJ3S3nNaWLl3rBrDImToPq01iaF +Mei28Thv7dajnOYTnJ8SMmnDJ5EZ6IzxJLxNt+MSRG11SbYYaJjPczXjVkCC6LVYxpg/V ITDVnTbTQL2hc1ieH/04Bq/vkheklqk= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=MuuFEvVR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of rick.wertenbroek@gmail.com designates 209.85.210.48 as permitted sender) smtp.mailfrom=rick.wertenbroek@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683709397; a=rsa-sha256; cv=none; b=Txy4Fap6W/ZCEbQybBU+nbjgWFaZYWlLj42Av9uiDddX1txMLR3/mhdNCj8lRPc1FqYHzv H2AdQ8IltB116bqggHEzGTI5W/8LZqLZ8SMlwxpNH/9x5rbdaBNJXPSzk1qci6tPsXixT1 F9zvdEz3oeMNDcfKXya8LahDs5X5l2s= Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-6ab074ef787so1300371a34.0 for ; Wed, 10 May 2023 02:03:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683709396; x=1686301396; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tMjeCMC/4Q3TMdYdgIMW1QMW7kWGP2cWpwPZAIpQS9Q=; b=MuuFEvVREOXCGJXlminekYSdnWKsfo3jTOQOaquCe3bs/J7dPBu9z1XXIXiHwVkQ2C TKrjNsUtVnTjWP5m66UdkOEWCnIdfC1T7p4Ay4q7BL/WZBYC7CwIebNhQV3UciiR81Bt kIYLPpqR+R71WfQHfg+cf1af6VHgQA27x4bxuDiY3qjZy9Kbo9v2NOQLePclg/euDrfz C8Kaw/7pGS0wDjb2RwDSiYZXvQswLc1N8HYGKmqW9TFjFeN1mTDJTPDq6bo1gMV+V/S0 NgfTfqiHFwYTEJufxn0xIhWG3yVJXYFruPKWGtK3MDFCRgJJuPnR2xMkeQYr30fA79TX exxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683709396; x=1686301396; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tMjeCMC/4Q3TMdYdgIMW1QMW7kWGP2cWpwPZAIpQS9Q=; b=TgDB4c/gQP2hAW7ZfNBUlax4CMS+fcK4UD4JOwHzCdodurBvoRpx/y164/F1/TwBfg 7Gau0w9NnqUV88Dthr97UfHud9/upResabm7gYdBzh9J/7SrS/T1/sZyvzGQxRaxn293 +LmKtSiF00mH+yCvsdwzJ1MPhjciyGy8Mkm1bDX5Bo/5nfcllUcKXW2MGyHPzDlf7tjo xW9BR5g3120lBjNLdk4MYz1mVAOT/AnkrIKYMW3eaIKh7FFaTL3G4dT4KGpbSZF/luY2 Q7rXDupnIs8conYKcLcGmVV7f6Nr5tWv5Yq6E8AU300z5IN/F4nGL9c6IhizBSlYx0PE m76Q== X-Gm-Message-State: AC+VfDx6KzYEmMr+lUSEkFjo4lzhRqMk0dB4xO66SO5gKp9QJdNTaGBj V45xQyE70Ytn4d0tghzwkfdRAHYOo0mlkynD6nE= X-Google-Smtp-Source: ACHHUZ5q/i4IuYgLDjHeL/Nh7DaCl+7p/egM0PY/LxatYrUi4pUvSvDMyUTKd+Bk8MQtN9QkiWYhsJ9GQZYfCaCfvsU= X-Received: by 2002:a05:6808:1d8:b0:392:2f89:6a1b with SMTP id x24-20020a05680801d800b003922f896a1bmr2689808oic.41.1683709396376; Wed, 10 May 2023 02:03:16 -0700 (PDT) MIME-Version: 1.0 References: <20230510084713.3528908-1-rick.wertenbroek@gmail.com> In-Reply-To: <20230510084713.3528908-1-rick.wertenbroek@gmail.com> From: Rick Wertenbroek Date: Wed, 10 May 2023 11:02:40 +0200 Message-ID: Subject: Re: [PATCH] mm: memory_hotplug: Fix format string in __add_pages warning To: rick.wertenbroek@heig-vd.ch Cc: David Hildenbrand , Oscar Salvador , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: nepfhyuk7ctmhg9emik6rnyhq8e8yary X-Rspam-User: X-Rspamd-Queue-Id: 60548A0009 X-Rspamd-Server: rspam07 X-HE-Tag: 1683709397-89450 X-HE-Meta: U2FsdGVkX1+nnrG2D70GtIkBa3/Xhh+zQFRQNUaJrfYfeRt9Jw03SHkTQz3zzfvHtGEhnCy1zWmoMdgBxTo+R1clER9sH9XENrNmExmuzJG5deopCByRCNL+R8UuXajnK9GtcZkixKfHSBO9HUkJYuWpAX5Gp6bhzuPDNHMRTwCoRTOJT63Mzwn97tSaOpOpJmVfI1ZWSBsMAIF5kcVugL6t85AqZEIJg6Q1R5nGtbtkksShqqWLXA18g/3dOig4/xk6NcBODxbaClY3bCjdfSpguNWEJIpzWdMTqlwVs+t21noUOnkN3qHWCvBgvYORhPw+hTIZfc5uh8wGqwLiFjEOPcWw6c/wfH0xTTeLKiTiXb2byJ0oDqGukKVzAwPJEpZ8IODo9lrwnP5VXnX+8VXLwGcXIXApytsxqnsGP1cOP9LAGbRbu5sq0PmnxZWC8ZDt0rLPtV6DVPSVCS1WPFCfA9NXL8cKwxZ+r8VI3F7wTXtTjf+g0p02nMa/KIKa0I7rKCN42qBura/gsSMb1RsPqhAvYhCFl2DTgsbua28UaSgOVGA02BHI5dWFeuVftyboI5hSfDRtV8p8IeQvo7fo1NV3Hjg4z6Q4YrBjxpXeZxmgD0k8QiqFjdmJePB2RvAMK8Hy50OBwlXwxBPgm0B5sg0mJadwwG3midsV/GXmDPv8SzPQg7N891CGj4Eox+cXqdfblkpB4ev4p8hbFrDZOFeFbYa6yyrV/mFM2n8JanLH8MU1G1GodkpFmi9pH89jm7Mj51o7T0WRowK2v7lw7M7zS4SnLV/l3Qf3pVQN49ibHBQpY6lk5T2gaHSxqGGcaNOJkbwy0F3Vq+X5EjlxjBXsT2+HAiEusHzZlnaoOeZ73smZMo3o7iQ56dErLCIAeTElTJKJ/vh82nSBd81dB4s4XtPyF+tMoXNuSKKFmwHeIxRIjnzIbIJdLOMKIDui9hkG8z5Ui9JmY3l e24umwPs ORckamFNsQZxXbIclguZ28zNzNsplgrZoQ8ujkSgH6eC8WZd3vNjkBecVTXNqZZCl8EiQtHBqifnI8QjTCIq3ItUOzoJExqM/wBxISgaiS3/ptcw8V7dM55UJsLHcnWmQLN7lSM6pwOssbJQDuk4vHIwij1exVmMbChI6IdNHV2iaCDOX8D7tGhVRv/jH4VKqvBgNPDVhQJtplmOK8vs+9WxQ0z/bT2LXo2OhRE5gxB3URWoRY3T8hd9fBJtaAcT6ODjJihalgHfCZYJ6D/fpNEuNf0IDSZCx5ea4+6a81f+3Lz/ODRlFniVps/HAt6ykMFaK6LcHG5nyj7vcHKe8SfqVYKCVEjri2cBK8dhu6dF3WXlbaA34w2EBBcDRhcb6Kd4mKaLXncJVhzp/gAmGt1RHM1IOU8ySSJGUDFMmde2S+x7C0T0ci/+u0Xo2UWX4vCOz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 10, 2023 at 10:47=E2=80=AFAM Rick Wertenbroek wrote: > > The format string has a typo and prints e.g., > "Misaligned __add_pages start: 0xfc605 end: #fc609" instead > of "Misaligned __add_pages start: 0xfc605 end: 0xfc609" > Fix "#%lx" =3D> "%#lx" > > Signed-off-by: Rick Wertenbroek The issue appears in the __remove_pages format string as well, sorry didn't notice that right away. I'll send a new patch. Rick > --- > mm/memory_hotplug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 8e0fa209d533..446abb088b51 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -325,7 +325,7 @@ int __ref __add_pages(int nid, unsigned long pfn, uns= igned long nr_pages, > } > > if (check_pfn_span(pfn, nr_pages)) { > - WARN(1, "Misaligned %s start: %#lx end: #%lx\n", __func__= , pfn, pfn + nr_pages - 1); > + WARN(1, "Misaligned %s start: %#lx end: %#lx\n", __func__= , pfn, pfn + nr_pages - 1); > return -EINVAL; > } > > -- > 2.25.1 >