From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3E7CC4829E for ; Mon, 12 Feb 2024 20:15:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 363846B0072; Mon, 12 Feb 2024 15:15:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EC0F6B0089; Mon, 12 Feb 2024 15:15:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18C796B008C; Mon, 12 Feb 2024 15:15:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 041536B0072 for ; Mon, 12 Feb 2024 15:15:13 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B0D6D80255 for ; Mon, 12 Feb 2024 20:15:12 +0000 (UTC) X-FDA: 81784256064.02.526A830 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by imf06.hostedemail.com (Postfix) with ESMTP id F39B518001D for ; Mon, 12 Feb 2024 20:15:10 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CIC8O6Fw; spf=pass (imf06.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707768911; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VaXyLf0rlgT3ERwoRMW+FZewiXwcvNDh+cVWPKZgz40=; b=S3ifbo0AVBCF3V5qaob66HPyP+yI55OJa3XDFErdSOfwbwHpQY3MF3b1MqPRt6Z73mx+8s uEnnixa/Tyh3hNgKpKFnz5HCZv9gqlcmAKGPyaqiU7yBP+qpu3/GDhS49z8mhLCnURyGwm 5eQSv3vzrctqwF4bESdp0FkMxTI3r3A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707768911; a=rsa-sha256; cv=none; b=lyz4ULLoVGdipK/26d0nwHYJDX9+1kq1YHYnBw7hWDiwN9WbJVOSQQYr0uwb+xEL8L1Ir8 zzkToVYVqRNyw2Zo0L5u9Ji8oJUf6+dmzg5DeOtoIqwm1zeH8pD+hw0IF6lqOajBAKj2ID RwXGR4L0eTnvFOWZFcLb3n8iBgFyxSU= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CIC8O6Fw; spf=pass (imf06.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3394ca0c874so2519108f8f.2 for ; Mon, 12 Feb 2024 12:15:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707768909; x=1708373709; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VaXyLf0rlgT3ERwoRMW+FZewiXwcvNDh+cVWPKZgz40=; b=CIC8O6Fww7Tbvs71Byat7tARrdfuTQ6mhVSwtMS36QUTqdjcT03udDdMIsMgVSLTC3 658BdK4igadmwQkc/3H3fd2W78euYC3MUX7f/mcABhrelimTpu2GDRQ2VKRR34YU6WJf eVn6Dp3DPA6iKGjxpNbG9nxdgzoXZ+Ljv+T98gfCusTnRjoVnIqP9/DwR75tdQRKStPH EELSCTISkJTEM8rSXj7MgV/YCN/NXJbGBwpUGaUdh4EBOpZz50ZrDqr7wgdkLMz5ueBV U3fANunIsdvMZ75AiTC1sl2fI7heGDnmjjd3fWjtam4mYJvGv7/Sw1ZaPobLDbC1CR6V wXtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707768909; x=1708373709; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VaXyLf0rlgT3ERwoRMW+FZewiXwcvNDh+cVWPKZgz40=; b=Ctzo12wWaNt/01n3vzlhFeni34F0Xh1yEYgR3JiEUt+gCgb/Zzv3kqPhPvrVPlLI6X NdFoYbnh6TgXvxgs1irrPwx/p/XCN4gbnpkKO5OCaJ2DeQB5PcLnsa2T29EkEwmwbZDR RwzXJwAvRZSATUk6wAgPLzUXViLQndVbxuaH23hWI2qkUHR72d5C/hIsIeJe8N6cJ0Js dcb/zmM7fT4jBbwsX52aLFSPSaQvsYlAD8Nzi/RiDgrVNk3vWEZjvR5HvcyHhOvulAAk TJh9kMklh+gPlk4O1halITUkhvimkec7gLJT7TpgH1hkhcO1nCldPV8vTRPpBIQZx34w 11+A== X-Forwarded-Encrypted: i=1; AJvYcCX+/rkTOngkziyrRk7usgrbSNZ/c9EDIjPH4Ip+yKCvPQ+IySRQ5Kz7gmOop/Edg+/3QqQtr2f6wYxtrPgBo666Nxg= X-Gm-Message-State: AOJu0Yw5lTjxehDfqNp0iVhRwtbVAvxTVWZEV/57hwtzwGaOTpeB9H0x krqqbIK2qoJmyYZB+62ER4jiycEXZa2ufnLYG+h4xyqv9FGcCdy6GjhdXFITaGhL0XXAZpRViOB UonBwrToORN+1/+LJ7F9eWLtJSTM= X-Google-Smtp-Source: AGHT+IHpOp2YAL/4T7pXJ3ADMzkd3FmSJ1znP94djoyRBiFToNx3U3/SAYWlk1OcRcRw7giKQF99XDLBrGg9cagP3gQ= X-Received: by 2002:a5d:5449:0:b0:33b:643b:d86c with SMTP id w9-20020a5d5449000000b0033b643bd86cmr5898005wrv.54.1707768909245; Mon, 12 Feb 2024 12:15:09 -0800 (PST) MIME-Version: 1.0 References: <20240209040608.98927-1-alexei.starovoitov@gmail.com> <20240209040608.98927-13-alexei.starovoitov@gmail.com> <59623808ebfd5ecd48cdb4c07a28326d777e7769.camel@gmail.com> In-Reply-To: <59623808ebfd5ecd48cdb4c07a28326d777e7769.camel@gmail.com> From: Alexei Starovoitov Date: Mon, 12 Feb 2024 12:14:58 -0800 Message-ID: Subject: Re: [PATCH v2 bpf-next 12/20] libbpf: Add support for bpf_arena. To: Eduard Zingerman Cc: bpf , Daniel Borkmann , Andrii Nakryiko , Kumar Kartikeya Dwivedi , Tejun Heo , Barret Rhoden , Johannes Weiner , Lorenzo Stoakes , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , linux-mm , Kernel Team Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: pbitnxpkpenpb4uewt7r88wn149rxewj X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: F39B518001D X-Rspam-User: X-HE-Tag: 1707768910-712458 X-HE-Meta: U2FsdGVkX1/MFxIC0XrHcIyCT/JUVKtQqw6tZf3HOZIGtN/Icz8A2+kEjHMXtnRnGFJjfVUAVbnMDk5Kp/LgkQqGYgl39K3LCmSqD2ryxvuBF2Gkoeu+wZzh0FtOIU+OtrU6EydHw4FbGEradKA/mfLWaPGXEqp57rCZyE8hj89Wnh3VnLm2gs/R7fqoJ+zpOTsalmFevClsCDU2n1Ozq7x6Mym3nccaI5STNKBs4FYh6ZpXBwlr3ijrArV16OR326UfRE/f3f08oPWnR93xWdAUr8qW1tS4KpfH925d8I8G1jDMusdlJuna0AesLDwvtR8phoxzXgPUErBsP2Cykir95aTxmbsPXWfl/MD5/P0qjdf5p0awbEQ0Us/Sp2OG6u9CuAUBJjPKuvNccEKR62oKTXeDLh3+8SA7w1yQPoPzH6gLFqhrTl1SFa7332PRUsODqLwdhgdgI+y2EMULhChP3EfCIZO1SHaLo6pBrGkIgtC/+usSUQSkJzovlwtYr7XKD8Bro+1rbdMCRlDFp1X5Vr+L7jgaU2RXm/4X4prUuG9Z1WgPRivH4dAHUvgO7Mwt4yqTBNgCIpwJuFvUewnCu0DqSL3IFFwMoKliUFUiJrW0m4PeUtwA26UNiqFN1Wmb/eF2OYfRqKRghPaVJ3mN+C53YXV68R4voG5rne0bSz6InhoBhI86YF73sTdmAmv5p7O8XRysccEV1QSrZz6kClKoLSsPZa7a2OR6hOYJMzxV1pJbNtMItY8BJOK1nlTAdyAtq7EReg8BUHy0mZ8g4oznb4aKLBfQDNWR0pdLmPAPSn+bp+sys7BqcobZqGJq6zHzYQIBJUmb10LLUJi1cfyKuaCIpWOqO+2oWvZwBtgYAB+V006P1Lv1VCxTGhZeiNwwf0d0Ffh+EAviP6/KwD1DS2ZcBJHgCRLHQb/i8rzygxGRILxAKWV0uvJMqy46ZCFP05LS5txr1er zwcFD6kA /z9n5mYUvDq0E6s2XyBieEDLtyFwGP5JFHvWOtor+PenJR4Cy+ZBUT4v52U4m9hWCok/MYWiJnt/djgupHYQ9JXIVfWUoFpBZDp4Yt28yOuxNJ9g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 12, 2024 at 10:12=E2=80=AFAM Eduard Zingerman wrote: > > On Thu, 2024-02-08 at 20:06 -0800, Alexei Starovoitov wrote: > [...] > > > @@ -9830,8 +9861,8 @@ int bpf_map__set_value_size(struct bpf_map *map, = __u32 size) > > int err; > > size_t mmap_old_sz, mmap_new_sz; > > > > - mmap_old_sz =3D bpf_map_mmap_sz(map->def.value_size, map-= >def.max_entries); > > - mmap_new_sz =3D bpf_map_mmap_sz(size, map->def.max_entrie= s); > > + mmap_old_sz =3D bpf_map_mmap_sz(map); > > + mmap_new_sz =3D __bpf_map_mmap_sz(size, map->def.max_entr= ies); > > err =3D bpf_map_mmap_resize(map, mmap_old_sz, mmap_new_sz= ); > > if (err) { > > pr_warn("map '%s': failed to resize memory-mapped= region: %d\n", > > I think that as is bpf_map__set_value_size() won't work for arenas. It doesn't and doesn't work for ringbuf either. I guess we can add a filter by map type, but I'm not sure how big this can of worms (extra checks) will be. There are probably many libbpf apis that can be misused. Like bpf_map__set_type()