From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D406CC433FE for ; Tue, 11 Jan 2022 17:56:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54D836B009E; Tue, 11 Jan 2022 12:56:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FC966B009F; Tue, 11 Jan 2022 12:56:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EBDE6B00A0; Tue, 11 Jan 2022 12:56:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0004.hostedemail.com [216.40.44.4]) by kanga.kvack.org (Postfix) with ESMTP id 30A386B009E for ; Tue, 11 Jan 2022 12:56:27 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D1C6A181C9BB0 for ; Tue, 11 Jan 2022 17:56:26 +0000 (UTC) X-FDA: 79018760772.05.0833E4E Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf12.hostedemail.com (Postfix) with ESMTP id 9C9CC40008 for ; Tue, 11 Jan 2022 17:56:26 +0000 (UTC) Received: by mail-pl1-f175.google.com with SMTP id p14so18391556plf.3 for ; Tue, 11 Jan 2022 09:56:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zTUAjWLiQz0DN+OfMSSCgL6ymIMr4NUd4ibX0nci4yg=; b=MC8yq1kv4dZAJdK3PyewQYsig/4b8/Dk/ApO+qzKCxYNIL7jz1ATetGmE63ZffZDTj yW91OydpFlJ4rPqzz/NiQtfML2B2BPBgZIt6VrxEFGjYjajoszemFHiTgxklMbk7lTYC 6wjhnofGN3h2+DkxXr4tISi9sd9DH5kVI24GUOsv1bXTcMpuFfpvGHmYalKpCrOJerlI gmW2zh4hMP+Tog7Zyg10a/aYkXJ9yJZgG4g2DyPegNjnLoCncGEKDguNct1IeNBcwsAf dsm1s5TJZByzqaWjGc+RWuovKeJ3LrWvoXHYavmTNAD5WVZG+h3ktfkiwC32cV6NfrxU l42g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zTUAjWLiQz0DN+OfMSSCgL6ymIMr4NUd4ibX0nci4yg=; b=W3FM3S4awmBXZmsSU9lVKbyRhwZ2uWkBMXd8O9tyqCDPi9bRIbajZfCyuknrFa7+nf fbf6deXTcjIOsMVIiXbCNFOsumQOEaknuDMStzPT7mlxXbAZ20epXWJqfS+v4VWoX+jK wAOfmNIvgQL1k5KvpTjEqaLpgNKzoE72kh23LfrX3hzsD9GCBYAdMou06RGkzqhRMRC9 Isl9Ftah4LuBgIKHGndclddWDVdnsZ2ADmhgYSmM7BqrG7TmyZjiUEL14m3MPE9MZHLN GB9cVs37+hIKycEjulCcraBdy43cKrFAeu2OGYpB5pocQ2pm2Y5fWD4Tn416Ri028kvC QCdA== X-Gm-Message-State: AOAM531gL9BXLNw9SwQmw99lsJP1qYGTr8QEwbdrTbwpuFnAoSv1J7hW vdbgnXFVbx+zMvLmgKYFjzoQvM1nKLOilXFt8OE= X-Google-Smtp-Source: ABdhPJyXB/iU2RhlEyTJMuFT2RDvdj0UGIxGc0mGp0zgMQ9ItaUEISL+d1TIwsat6ZK8PHjdC/xo9bXKFUr7OXhQaSY= X-Received: by 2002:a63:7c50:: with SMTP id l16mr5013006pgn.95.1641923785518; Tue, 11 Jan 2022 09:56:25 -0800 (PST) MIME-Version: 1.0 References: <202201060848.nagWejwv-lkp@intel.com> <20220108005854.658596-1-christylee@fb.com> <20220111094835.GJ1978@kadam> In-Reply-To: <20220111094835.GJ1978@kadam> From: Alexei Starovoitov Date: Tue, 11 Jan 2022 09:56:14 -0800 Message-ID: Subject: Re: [PATCH bpf-next] Fix incorrect integer literal used for marking scratched registers in verifier logs To: Dan Carpenter Cc: Christy Lee , Song Liu , Christy Lee , Alexei Starovoitov , kbuild-all@lists.01.org, kbuild@lists.01.org, Linux-MM , bpf , Kernel Team , kernel test robot Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 9C9CC40008 X-Stat-Signature: mso1nh1kcr9aj4pnrimwj8imrno7hss8 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=MC8yq1kv; spf=pass (imf12.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam07 X-HE-Tag: 1641923786-7613 X-Bogosity: Ham, tests=bogofilter, spamicity=0.007588, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 11, 2022 at 1:49 AM Dan Carpenter wrote: > > On Mon, Jan 10, 2022 at 02:12:58PM -0800, Christy Lee wrote: > > On Mon, Jan 10, 2022 at 1:52 PM Song Liu wrote: > > > > > > On Fri, Jan 7, 2022 at 4:59 PM Christy Lee wrote: > > > > > > > > env->scratched_stack_slots is a 64-bit value, we should use ULL > > > > instead of UL literal values. > > > > > > > > Reported-by: kernel test robot > > > > Reported-by: Dan Carpenter > > > > Signed-off-by: Christy Lee > > > > > > The fix looks good to me. Thus: > > > > > > Acked-by: Song Liu > > > > > > However, the patch looks corrupted. Also, the subject is probably too > > > long (./scripts/checkpatch.pl should complain about it). > > > > > > > I just checked that even with an absurdly long subject (more than 200 > > characters), ./scripts/checkpatch.pl doesn't complain. It only complains > > when the commit message body has longer than 75 characters but not the > > subject line. What's the maximum subject line length? > > > > People say 50 characters but that just seems more aspirational than > realistic. This patch needs a subsystem prefix as well. I fixed patch subj and applied to bpf tree. Thanks everyone.