From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96C0AC433F5 for ; Sat, 4 Dec 2021 16:45:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E20F96B007E; Sat, 4 Dec 2021 11:45:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DD3396B0080; Sat, 4 Dec 2021 11:45:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C98C76B0081; Sat, 4 Dec 2021 11:45:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id BADA46B007E for ; Sat, 4 Dec 2021 11:45:09 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 626B218194D6C for ; Sat, 4 Dec 2021 16:44:59 +0000 (UTC) X-FDA: 78880686318.02.A2613C0 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by imf24.hostedemail.com (Postfix) with ESMTP id 0AFDEB0000A0 for ; Sat, 4 Dec 2021 16:44:58 +0000 (UTC) Received: by mail-pg1-f169.google.com with SMTP id m15so6186486pgu.11 for ; Sat, 04 Dec 2021 08:44:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0pJd316SntFE8CJG8ZCyQl9bn0yi8tTdr3ZLeWI3me0=; b=iqDgKWpZ8/yGsyIc1QVsUbdjKIcOGhY306eHV8Xue00e+0UNFR+PYukXpJr3aReD/D aXV99tRptOmdDvPczpKDaTFwg2CyOe76eGtRVp89T6LH5XE9mB6MTl6nH8td/chG6OH2 YodeKvj7BB0cmf3O8iq2ZSfVymebaM9+2OidYFpxLUe0YJwBGQqsXGngzX96nLCjjpaL y04LXK/aFShnoDVTvy1DY6MHELbRkTu8Jh0J3dP4mzCUKxIxqX6xG9vbBznm2SLiH94W gzZY0jS4vBx5FiVzxCuSBV3G/3PYMjouuQtaIOzbesCQSWp5XPhefRiXs/aPKOJ+kVz5 eH4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0pJd316SntFE8CJG8ZCyQl9bn0yi8tTdr3ZLeWI3me0=; b=qD0eHctNnxaHxId1O2qBg00DXPuK7dANtvTfYiJdWhzWnrMnFIFj3QlzyvOUeuhSAi ng8OVx3b1uQFK8hFC91zgUHvGKZN0DmEs7HZSDOcFkitiVe6a5FrBiKVKGkkq2Nh+7aK Ve8VRVt+GtGVzrZ4tkQaOlGiGjl1XtieVVqT5L+hbq+gX7cQIUBTsX+thEVq5rUt8U9Y TFJc15sMw8VtL9ALtDu3J8GJhnLKxKjJlF7JA15ENTe2gO/e8yyXYsBw6hZTkpUfjCGU pOWnPjvOgFAtCmNRekHJJ2/As/yGrXHaFXB1edxqEV0f9yAET+mlA+zVo5D83Z1dsN3I T3cw== X-Gm-Message-State: AOAM533e8UYi+nFvDkFvbPH+dFjLB3srrTPDKJeu3/4gNu9nKj/okx6J kQpHCrfcoF7j0fsUGphBOID9GoMleDfMW6WgqMw= X-Google-Smtp-Source: ABdhPJxyPZhkNrj88wcz0m7CaY2bBbLI9Vc3tBg7UND42s+Qqzyjc3Vwwi+fAgQizw3zp7zWD23+pDsDAAmJ8AhZMCk= X-Received: by 2002:a63:6881:: with SMTP id d123mr9847445pgc.497.1638636297919; Sat, 04 Dec 2021 08:44:57 -0800 (PST) MIME-Version: 1.0 References: <20211204095256.78042-1-laoar.shao@gmail.com> <20211204095256.78042-6-laoar.shao@gmail.com> In-Reply-To: <20211204095256.78042-6-laoar.shao@gmail.com> From: Alexei Starovoitov Date: Sat, 4 Dec 2021 08:44:46 -0800 Message-ID: Subject: Re: [PATCH -mm 5/5] bpf/progs: replace hard-coded 16 with TASK_COMM_LEN To: Yafang Shao Cc: Andrew Morton , Steven Rostedt , Kees Cook , Petr Mladek , david@redhat.com, Arnaldo Carvalho de Melo , Andrii Nakryiko , linux-mm , bpf , linux-perf-users@vger.kernel.org, Linux-Fsdevel , LKML , Mathieu Desnoyers , Michal Miroslaw , Peter Zijlstra , Matthew Wilcox , Al Viro Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0AFDEB0000A0 X-Stat-Signature: byfbkmte3f7btxpfu56587e41mbthb6m Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=iqDgKWpZ; spf=pass (imf24.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.215.169 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1638636298-383946 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Dec 4, 2021 at 1:53 AM Yafang Shao wrote: > > static int process_sample(void *ctx, void *data, size_t len) > { > - struct sample *s = data; > + struct sample_ringbuf *s = data; This is becoming pointless churn. Nack. > index 145028b52ad8..7b1bb73c3501 100644 > --- a/tools/testing/selftests/bpf/progs/test_core_reloc_kernel.c > +++ b/tools/testing/selftests/bpf/progs/test_core_reloc_kernel.c > @@ -1,8 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0 > // Copyright (c) 2019 Facebook > > -#include > -#include > +#include > #include > #include > #include > @@ -23,11 +22,11 @@ struct core_reloc_kernel_output { > int comm_len; > }; > > -struct task_struct { > +struct task_struct_reloc { Churn that is not even compile tested.