From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15CF1C5475B for ; Fri, 8 Mar 2024 03:49:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 827A06B032C; Thu, 7 Mar 2024 22:49:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D71E6B032D; Thu, 7 Mar 2024 22:49:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 677F76B032E; Thu, 7 Mar 2024 22:49:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 52A7E6B032C for ; Thu, 7 Mar 2024 22:49:31 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1D991120E0A for ; Fri, 8 Mar 2024 03:49:31 +0000 (UTC) X-FDA: 81872492142.30.482D9D2 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf23.hostedemail.com (Postfix) with ESMTP id 6639B14000E for ; Fri, 8 Mar 2024 03:49:29 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DHEz0tL4; spf=pass (imf23.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709869769; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e8ZzEOeqwXaF+/K/gLza7Lv335pwHs3+S/P5LcnAwfs=; b=dUSGXc1OrSJPDGx0dK3y/M5Ha+3xKBvpH2UCaPUmILoRG/J0mCRFIgaYUIxrMAepNn/duw JmJK9G9tETrSP3Mb1qNPN+PduL+kAoQiSwGlUtRkI93rSIEKjH92XYwz/sZXPmQR6Hr4Zb Vw5XNR9NU/oZeJErscAJ2A8hUSxsm68= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709869769; a=rsa-sha256; cv=none; b=TIcHRvwVDY2//UK5JKGzNfM86LNLcUkBNzN0N1CAtE4TdkSiTVV/Y+an9tNn2e6QEbmtAV yQ3f1UA86g1umFc1QMXUVAUdFzWMnUfD0DtdpqetfmWsz/R3P2NZdf6oD9PfWEHQe6wCrb oCPilPxFzMxAtgzo7OWCLXKwqc/8hRE= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DHEz0tL4; spf=pass (imf23.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a36126ee41eso229916366b.2 for ; Thu, 07 Mar 2024 19:49:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709869768; x=1710474568; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=e8ZzEOeqwXaF+/K/gLza7Lv335pwHs3+S/P5LcnAwfs=; b=DHEz0tL4MWO9UF8p6TAUfSinC9LyR0n/lIyBQwZUTY2Sw1Y7PbTqGIQdFwU1Xno2nH uQUynihXRzQ6yvrdQtF2MRZzcecMLlAS5BTf9ijtn2e1UyGkvsdvRsexj8TfXI+UDfHz P2p7YzApd1bSk188Udzf/whzXzGyXRXS6gWz1d8RqdEHVD79HKJIKe+khDaZ1y2XynvH 872vOij3WqlF9x+KBioPr9e+MwR+OZGQXJcnhcn6XV2SDokkFLq25CJnkOovzpf8eNhS LIVuqVE7T4jSgyKAzCO2U3WY0LaEXum0BdmAOIc9cfsFVJEOT5STbpGrn1IlMfSqrcWY VpLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709869768; x=1710474568; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=e8ZzEOeqwXaF+/K/gLza7Lv335pwHs3+S/P5LcnAwfs=; b=EnAkSvJ4YETRglpgwyYJnOyxDSoyfW+mUhUrtuSS2kBofBgUa0wGplN7G9Tsni7nO9 4W6fLK+l2rl0jCiotASCVrqYYu+v/1bWGf+qdnMkxih/BsnlLy7jK9mlT62NwjW0gJjb 7os2BrapJuiQkurvWPMbowR4qa9QYzZZEJmBQgnFkje56svXx2s44gkCXG+/XJMv1Grx KewBxQBJNYXDOFlV6fi6R4nq73325NapB8Cb4wiTdQMTC6h2OrYftQxM57CBYie0TUqG d59YOIkO0Ai0inTx/H8uoq3Nxb0cUr4PGiFX12Iz3eWnUrMip4/IJWr8kQCyWe4ldw4u sA3Q== X-Forwarded-Encrypted: i=1; AJvYcCXXtrAfiEy93NxZkJMw9YreIjfkgYMOn7SUXZjFqgovDYss81O9tXssEVNZu5SwkcbnzyYHHCvPd4J2XzaPNKndZvs= X-Gm-Message-State: AOJu0Yy4Gu/nOxUxc/ndReWVISAlsG/n0GGMX6cddHjg5IeR7lziDwzB 4BIgv6G5D6Brx8tiOGtHsKEPVhHdoY31e/8BDKymaoyI06/ROcNR9az1QzeRrUFs78LO7G52Y3A oJvpEqLn3ci+dGguc/DjHhXN4o7U= X-Google-Smtp-Source: AGHT+IEz3ttpI0orlvLB4AJ+nczG2zehj++7TffijNDU0t/tCUA5dTFH+dzs38O3DWeWHMtb93KUEZ6RhDCAs5+at2o= X-Received: by 2002:a17:906:364d:b0:a3e:a712:ba9d with SMTP id r13-20020a170906364d00b00a3ea712ba9dmr13521012ejb.4.1709869767603; Thu, 07 Mar 2024 19:49:27 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alexei Starovoitov Date: Thu, 7 Mar 2024 19:49:16 -0800 Message-ID: Subject: Re: vm_area at addr ffffffffc0800000 is not marked as VM_IOREMAP To: Miguel Ojeda , Christoph Hellwig , Linus Torvalds , linux-mm , Andrew Morton Cc: Catalin Marinas , Will Deacon , Linux ARM , Daniel Borkmann , bpf , Bjorn Helgaas , linux-pci@vger.kernel.org Content-Type: multipart/mixed; boundary="0000000000001c584e06131e1443" X-Rspamd-Queue-Id: 6639B14000E X-Rspam-User: X-Stat-Signature: c46npw96ydtr79h8ngxogjg4oxjwceci X-Rspamd-Server: rspam03 X-HE-Tag: 1709869769-871724 X-HE-Meta: U2FsdGVkX1+qwrCrm7u4XsmejpJU0ETqAZlyQzpxckR64Wum6Yt+Z6kLCqXhuV0gwkk2QYtTcxkXh6Wr/KT/rsULFAI828s/mO19hDrkRhO1PxvDFbgAQoLKkszWa3T84+coAiO6QflKaFa2tXCSjq+WrZhoUs50ILM0qXz/UhxKnCLJ9MJu2O2kjhJoMJJ7I4J+xAdyTAf4Z6C//VuMJNe/HX02HUp2dDuKBn52csGbxfHC9MCUVf+OvBwKjXrvKapN33xMgze6JA4OiKf3sitqueZYsvNdfwEM0nrC8bLTqwPhxCnoy3PtKTmmdr37p65Je44uM+CpOWqAUSFIsCSIB854+2EkO1jtDRb5Ljgb6rXudlEGgx9S/AzmTFwIw3x/H0cLl+WTW/RIhH0B/uy+wL9NKuCaVdQ0hAwqieDJ4PNSRLFrNAFL7q7uJwQXHexJQeh/2Di9itc5ZEOqmG/exsLfYYUoqT9OkbJf/iMPF3etbK/v1lQfTuM+p3FQB3lZ/PzxOIHOfbVmYVl+Bncy2Op+0LJIy8n0iLiMuZce78hsAmjJBrKvbvm1oayHco8m2sRbm4v7GtTBpHSNMvTfq2b8BbGA+e3NlhKhs4apNf2qePWyJBlLp+lK/8QfmmQKtncVy6XklWWjP3bwTTuCj6sXtn734ouesQdHTbPGadmpCWmePSeYe8Q+09fKonEDvPHtR3Uz5bn4ElA7MGCBl2XHc1idQufKAKAwEHbFNH7xyOm+A9XrGpMRCQQdB4Ya6wNLZ+WtisVHImw0lUod0JO0eU36HdoFdB+hZ4+LgWVn/H+IQ2PVQlwmCIpWPhJWIYatUyQlfYBWiSiZGuRfPO/V96FZHci2KlU5048Ob0EA+aSpT6xssLt0yZH2DH6o2qDilcgWNIwdfHOzwRmJevkxMUlwa6SDJxGnLRM1AOauLIelOykvlTzPwTxrVMsj68q/j+h4ojUdrJH Wvu7vu9V PGpwHGALdjqJT6cpK+6J54Wn/7xfjSd1qoNuMcRcsulkstJLCM1D1ic2ijWyQZSSeZ2ZKnoYpZYQd19J4g1OtyCfC2q7t6czGlkqDo3ZA8lZFxstD3cLt2ReNrWGW5IO4MRFzHRb2bPrErAGMWUiwwUetFMOYinbEQvFNVikbPAPRkcJZPN951pR98twTwoAKs6DDhZga1514RLWjidrSX1YPh4K9QmywQrcpGa49KdxXYppfAc76MpnbjtuzMlhvH74I X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --0000000000001c584e06131e1443 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 7, 2024 at 9:54=E2=80=AFAM Alexei Starovoitov wrote: > > On Thu, Mar 7, 2024 at 9:42=E2=80=AFAM Miguel Ojeda > wrote: > > > > Hi arm64/bpf/pci, > > > > In today's next-20240307 with a defconfig LLVM=3D1 I am seeing [1] unde= r > > QEMU virt, i.e. from > > https://lore.kernel.org/all/20240305030516.41519-2-alexei.starovoitov@g= mail.com/ > > applied to the bpf-next tree. > > > > Cheers, > > Miguel > > > > [1] > > > > [ 0.425177] pci-host-generic 4010000000.pcie: host bridge > > /pcie@10000000 ranges: > > [ 0.425886] pci-host-generic 4010000000.pcie: IO > > 0x003eff0000..0x003effffff -> 0x0000000000 > > [ 0.426534] pci-host-generic 4010000000.pcie: MEM > > 0x0010000000..0x003efeffff -> 0x0010000000 > > [ 0.426764] pci-host-generic 4010000000.pcie: MEM > > 0x8000000000..0xffffffffff -> 0x8000000000 > > [ 0.427324] ------------[ cut here ]------------ > > [ 0.427456] vm_area at addr ffffffffc0800000 is not marked as VM_IOR= EMAP > > [ 0.427944] WARNING: CPU: 0 PID: 1 at mm/vmalloc.c:315 > > ioremap_page_range+0x25c/0x2bc > > Great. Thanks for flagging. > Looks like this check found some misuse of ioremap_page_range. > > Note that without marking the address range as VM_IOREMAP > the vread_iter() will be bulk reading over IO and might > cause hard hangs and what not. > pci drivers need to mark their range as VM_IOREMAP. > That was the reason for the warning. > > I'll try to figure out which piece of code missed passing > VM_IOREMAP into vm_area. > I'm not familiar with pci, so help is greatly appreciated. Ok. I think I figured it out. Please try the attached patch. --0000000000001c584e06131e1443 Content-Type: application/octet-stream; name="0001-mm-Enforce-range-of-ioremap_page_range-when-it-s-ins.patch" Content-Disposition: attachment; filename="0001-mm-Enforce-range-of-ioremap_page_range-when-it-s-ins.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lti4ahb30 RnJvbSBiNDQ2NTM0ZjJkYzVjNDhkOGFiMDdjNjhlNzk2NDhmNDIyMzhmZWY4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4ZWkgU3Rhcm92b2l0b3YgPGFzdEBrZXJuZWwub3JnPgpE YXRlOiBUaHUsIDcgTWFyIDIwMjQgMTk6NDE6NDUgLTA4MDAKU3ViamVjdDogW1BBVENIIGJwZi1u ZXh0XSBtbTogRW5mb3JjZSByYW5nZSBvZiBpb3JlbWFwX3BhZ2VfcmFuZ2Ugd2hlbiBpdCdzCiBp bnNpZGUgdm1hbGxvYyByYW5nZQoKUENJIGFkZHJlc3MgcmFuZ2UgaXMgbWFuYWdlZCBpbmRlcGVu ZGVudGx5IGZyb20gdm1hbGxvYyByYW5nZS4KRW5mb3JjZSBmbGFncyBhbmQgcmFuZ2UgaW4gaW9y ZW1hcF9wYWdlX3JhbmdlKCkgb25seSB3aGVuCnRoZSBzdGFydCBhZGRyZXNzIGlzIHdpdGhpbiB2 bWFsbG9jIHJhbmdlIGFsbG9jYXRlZCBieSBnZXRfdm1fYXJlYSgpLgoKRml4ZXM6IDNlNDlhODY2 YzlkYyAoIm1tOiBFbmZvcmNlIFZNX0lPUkVNQVAgZmxhZyBhbmQgcmFuZ2UgaW4gaW9yZW1hcF9w YWdlX3JhbmdlLiIpClNpZ25lZC1vZmYtYnk6IEFsZXhlaSBTdGFyb3ZvaXRvdiA8YXN0QGtlcm5l bC5vcmc+Ci0tLQogbW0vdm1hbGxvYy5jIHwgMjMgKysrKysrKysrKysrKy0tLS0tLS0tLS0KIDEg ZmlsZSBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9tbS92bWFsbG9jLmMgYi9tbS92bWFsbG9jLmMKaW5kZXggZTViOGM3MDk1MGJjLi4xN2Vi MGY5NzRlMGYgMTAwNjQ0Ci0tLSBhL21tL3ZtYWxsb2MuYworKysgYi9tbS92bWFsbG9jLmMKQEAg LTMxMSwxNiArMzExLDE5IEBAIGludCBpb3JlbWFwX3BhZ2VfcmFuZ2UodW5zaWduZWQgbG9uZyBh ZGRyLCB1bnNpZ25lZCBsb25nIGVuZCwKIAlpbnQgZXJyOwogCiAJYXJlYSA9IGZpbmRfdm1fYXJl YSgodm9pZCAqKWFkZHIpOwotCWlmICghYXJlYSB8fCAhKGFyZWEtPmZsYWdzICYgVk1fSU9SRU1B UCkpIHsKLQkJV0FSTl9PTkNFKDEsICJ2bV9hcmVhIGF0IGFkZHIgJWx4IGlzIG5vdCBtYXJrZWQg YXMgVk1fSU9SRU1BUFxuIiwgYWRkcik7Ci0JCXJldHVybiAtRUlOVkFMOwotCX0KLQlpZiAoYWRk ciAhPSAodW5zaWduZWQgbG9uZylhcmVhLT5hZGRyIHx8Ci0JICAgICh2b2lkICopZW5kICE9IGFy ZWEtPmFkZHIgKyBnZXRfdm1fYXJlYV9zaXplKGFyZWEpKSB7Ci0JCVdBUk5fT05DRSgxLCAiaW9y ZW1hcCByZXF1ZXN0IFslbHgsJWx4KSBkb2Vzbid0IG1hdGNoIHZtX2FyZWEgWyVseCwgJWx4KVxu IiwKLQkJCSAgYWRkciwgZW5kLCAobG9uZylhcmVhLT5hZGRyLAotCQkJICAobG9uZylhcmVhLT5h ZGRyICsgZ2V0X3ZtX2FyZWFfc2l6ZShhcmVhKSk7Ci0JCXJldHVybiAtRVJBTkdFOworCWlmIChh cmVhKSB7CisJCWlmICghKGFyZWEtPmZsYWdzICYgVk1fSU9SRU1BUCkpIHsKKwkJCVdBUk5fT05D RSgxLCAidm1fYXJlYSBhdCBhZGRyICVseCBpcyBub3QgbWFya2VkIGFzIFZNX0lPUkVNQVBcbiIs CisJCQkJICBhZGRyKTsKKwkJCXJldHVybiAtRUlOVkFMOworCQl9CisJCWlmIChhZGRyICE9ICh1 bnNpZ25lZCBsb25nKWFyZWEtPmFkZHIgfHwKKwkJICAgICh2b2lkICopZW5kICE9IGFyZWEtPmFk ZHIgKyBnZXRfdm1fYXJlYV9zaXplKGFyZWEpKSB7CisJCQlXQVJOX09OQ0UoMSwgImlvcmVtYXAg cmVxdWVzdCBbJWx4LCVseCkgZG9lc24ndCBtYXRjaCB2bV9hcmVhIFslbHgsICVseClcbiIsCisJ CQkJICBhZGRyLCBlbmQsIChsb25nKWFyZWEtPmFkZHIsCisJCQkJICAobG9uZylhcmVhLT5hZGRy ICsgZ2V0X3ZtX2FyZWFfc2l6ZShhcmVhKSk7CisJCQlyZXR1cm4gLUVSQU5HRTsKKwkJfQogCX0K IAllcnIgPSB2bWFwX3JhbmdlX25vZmx1c2goYWRkciwgZW5kLCBwaHlzX2FkZHIsIHBncHJvdF9u eChwcm90KSwKIAkJCQkgaW9yZW1hcF9tYXhfcGFnZV9zaGlmdCk7Ci0tIAoyLjQzLjAKCg== --0000000000001c584e06131e1443--