From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9159FC3ABBC for ; Wed, 7 May 2025 01:25:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2E9F6B0085; Tue, 6 May 2025 21:25:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DCFC6B0088; Tue, 6 May 2025 21:25:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CC726B0089; Tue, 6 May 2025 21:25:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6CE616B0085 for ; Tue, 6 May 2025 21:25:55 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7888CC8BE5 for ; Wed, 7 May 2025 01:25:55 +0000 (UTC) X-FDA: 83414370270.15.FD4C5A6 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by imf11.hostedemail.com (Postfix) with ESMTP id B34EA40003 for ; Wed, 7 May 2025 01:25:53 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FKV7YRKc; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746581153; a=rsa-sha256; cv=none; b=YlQ7WJiTS5k+BglxFtHJwTNjhsoDh0u31Ys8MsU9nVA+zOQFLko26N9YUpEfsrv6R3E36A MvW8wTZjG8qOld2C0yMDq0dFtHN754HA4vxp+Tw9LM4saMqX22J73aZlhJfIS1DZNelcQI 91m3aEGH3ecYCrgfDHPrRUv8b0Jadcc= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FKV7YRKc; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746581153; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Mp6h0mXWLqOSoyEmt4D7rmRcGyjeYpketPR55zn1Xuw=; b=Wjv6ISutRK5h5Yrs1N6tPL3fVZuMU9hSMWDDE+Dg5vSYT+jbHDmJ6fACCV+EKIHjf4H6os +dnH3tvVZ9K2zPFjCxSednl0Rrr4neGfBrwif1ZMXBgocITznAeWeM4VBxdLe8/6jWv0yG b23236MgF/UlrUsOxb8rWaaRfam5CMY= Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-39c1ef4ae3aso259858f8f.1 for ; Tue, 06 May 2025 18:25:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746581152; x=1747185952; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Mp6h0mXWLqOSoyEmt4D7rmRcGyjeYpketPR55zn1Xuw=; b=FKV7YRKczGJdEGApM7HC8J33EgvRdHTDwdeQRJKzTVvvkgpoSnaJP9Ffbiv98rbvKC Lnug52ZgohEKtKtE8blXiKDe3EWRh5M6segmBZ3Z4F8THf8WDwbJxbZEIO/Lu8PzmdlR 24OTdX7+/SzcZyeiyLhiSx01I7jf7ogK40Jt07vXNKDtf+HXzM/5znohMDd2sSc+jjLJ yuC40Uo8eY1//H30DARRnzStK0nGucL9sWz1vfu8G9I27KAKqmKZE4bL9jZotyn3+jn6 WMtIepbXpGInLNBpJ++WwLm2ajb0wc8h0KwdbIKOtkRE6aoqB3M+HpWrcAqURdr2mdcS y34Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746581152; x=1747185952; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Mp6h0mXWLqOSoyEmt4D7rmRcGyjeYpketPR55zn1Xuw=; b=t7TimgXMwGmGlvXN6B+ImVKiOKbtG5e76xtT/asTQcVIX1lglQ0lGlvmosKLAzeg2t jD5PTvPSJwU4BUAuiafPaQxS7DJOkQGdNgiHXEz3QV7KBQ8UZ+2ijNd9yBoLwbnOjWkp Y2Nhf3AK/sHLnTQD1I+c+esw2P+gD4OUV+Q4GuOIuLaVpxkuaiXZyAWoIGEjyQoZZtNt db2a0TpNiUTu8iTIGJtgZ4vC87hMkpPGbdp9VKn6ctawrcWB5RRvhS9DWSZ2k0N1B/Wd t5eEN0eLFiP1uaV048ig1QN4N6AoIwKYe0toY98WJvXCWcxOY4+doUHokUv7YUThUDNr 5hkA== X-Forwarded-Encrypted: i=1; AJvYcCWGQ/k86oGc3wncy1TKYgyYTH8CpiVCR/8nC7DFUe6p8Fb13xUrwn+ItG1cvQumKHyUamfIKKrO7A==@kvack.org X-Gm-Message-State: AOJu0YwrmU2pMgm1xqwGONvJbVbhR/Bmvkki6DVl/SFsILWYGJOvPayZ 2nJXUbHfqWGMI+IRv2tMACbj1GkkEdu09TJ1+8zCZRSV7WHZEXVeYaSBTtKlSyKeJHdLLtk5YHH R6uHrv5Tm2dhkJ4WAsnobAUQQQlI= X-Gm-Gg: ASbGnct9Em04aDwRXfueGreOotxrtBTNh+Ma2F4A4YN40AOHVXUTeu555fsufZ4Hxom WrLVtNQr4VDq369usd4WNmSOyNBh4B5ChY+qaYTM5NXQWx4exBoDae4/tdJuVnMnDSdBOv3yDRz 5Wl85ECwrgWIdxcq9ftx4NqNdgEgWjBtJnPLISwBmqVhEwrZr/QQ== X-Google-Smtp-Source: AGHT+IHjRxqbuC6EWjG3w8Gjmy0g4xOqQcGK9GiSNAgLNFH1wYnmaZTW/evmeNmFuGppCwke7Ey/4Sm6ct+zw0Xt+1k= X-Received: by 2002:a05:6000:184f:b0:3a0:92d9:da4 with SMTP id ffacd0b85a97d-3a0b43afb7amr1554946f8f.6.1746581152230; Tue, 06 May 2025 18:25:52 -0700 (PDT) MIME-Version: 1.0 References: <20250501032718.65476-1-alexei.starovoitov@gmail.com> <20250501032718.65476-3-alexei.starovoitov@gmail.com> <9e19b706-4c3c-4d62-b7f2-5936ca842060@suse.cz> <1fd89e00-2d26-4f84-b8a3-5add508608c8@suse.cz> In-Reply-To: <1fd89e00-2d26-4f84-b8a3-5add508608c8@suse.cz> From: Alexei Starovoitov Date: Tue, 6 May 2025 18:25:41 -0700 X-Gm-Features: ATxdqUEJOSFOsiS3_A46OBaAuxrRJkkwJWKCpum10HyqXndyjSQQvLSwCXc_EMM Message-ID: Subject: Re: [PATCH 2/6] locking/local_lock: Expose dep_map in local_trylock_t. To: Vlastimil Babka Cc: bpf , linux-mm , Harry Yoo , Shakeel Butt , Michal Hocko , Sebastian Sewior , Andrii Nakryiko , Kumar Kartikeya Dwivedi , Andrew Morton , Peter Zijlstra , Steven Rostedt , Johannes Weiner , Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B34EA40003 X-Stat-Signature: a91qpn1mkcuk9hepbr9w7zs9m4panf4w X-HE-Tag: 1746581153-673488 X-HE-Meta: U2FsdGVkX190F9t2Hm578z/GV5yALEW2lWH+Iz7OYSOeRXj9SKkBRE5DsCZxNlfvHU3Fk0vhJ85GpRJPbqjqKq4leIvn3bz95+JqXRXvKFLtNykcG+PRJAuO6ff7TeYkd0W/sdJxnb5EAsD0rUwEgkrKef4/aVSmc+Z8DOtYEjPFbzcW1UUlm4KaKa1hi+NH6w7MEX+9FDF2hKz3Q0fobVSqI5Pb/uwQGKGSATuif5846URJRH5fkS1NpGU/ZAC+/qMJlJx19Nu92hLMDnFE4U4qbLLJ4PZVb/HJsNfZXxS+Qp4r4CjY0ipHjeTCXCvKy2P9F/twpJJWFJY/ksYQKyz8OOhYPmiFOUkQ/yc3/fcN/xWw3Yaac7rQOFrxK6FeH1/Ghaf3G+CEUfgw03NcBftCr/CWdcolUJCHS2aLcQ8Cc7Lda0rkBdw33Mg44OPytXzdh4qDovkD1RvUdlJUK/xHyvKBXbZzilp+zM++VQm9lOfrVOyIoGABNJ46CpQD0EqAWy54xFR/GHxC1fF+3bfQlTjkVl6339kGz6EiqCDvZoYe8yGxjwVkamXMGWL4nJHfRTkX4HZ1F2pyhLb+C7Ww058tB1LQQqsWgpMah7sUelC3RSoF/fSBPxhfgRCig6n2iqdEzBZldGtufDOMdz8N0qu3s5G4EE4dz2jJPDmsjasIaWrel+hgouMv82tKYjYb76p5TPdAmtJjqQjPbfa2BOAybgqhRjTfQVGNiczhmLrdQD2YZwjgMABoPfsXbzoOqmHygI1/S5thwuY/tkfdBjOM4TiA2Ls0UWJMeI3PsQD937GYeIf5+MstO0wv5VzHJw4sSB8H7OcJzYfjbnAgRFc5hwCyvZnR++BNERLxUL/sNgxnQ05W4eY+MzPHGQm6mQWtJdjuVL2OjX+dzNoUd+Ti6tDd6oxiQfOJC30FGGS4vv2meTM5hvHkcu7fqdTdi1joGHMH9S0RGyW xk2vX0Nl jtQBzr/QDQjBUN8pN1ViI72UGCNyy58UHg+7r2BXf99uG8N0QA+rNw6F94Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 6, 2025 at 7:55=E2=80=AFAM Vlastimil Babka wro= te: > > On 5/6/25 14:56, Vlastimil Babka wrote: > > On 5/1/25 05:27, Alexei Starovoitov wrote: > >> @@ -81,7 +84,7 @@ do { = \ > >> local_lock_debug_init(lock); \ > >> } while (0) > >> > >> -#define __local_trylock_init(lock) __local_lock_init(lock.llock) > >> +#define __local_trylock_init(lock) __local_lock_init((local_lock_t *)= lock) > > > > This cast seems unnecessary. Better not hide mistakes when using the > > local_trylock_init() macro. > > Nevermind, tested the wrong config, it's necessary. Sigh. Yep. lockdep assumption is deep. I see no other way of doing it.