From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 356D5C43334 for ; Wed, 6 Jul 2022 16:50:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2E738E0001; Wed, 6 Jul 2022 12:50:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DE8F6B007E; Wed, 6 Jul 2022 12:50:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CD7F8E0001; Wed, 6 Jul 2022 12:50:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7DFAE6B007D for ; Wed, 6 Jul 2022 12:50:28 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 4AB85120A74 for ; Wed, 6 Jul 2022 16:50:28 +0000 (UTC) X-FDA: 79657263336.20.EF19BDC Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by imf31.hostedemail.com (Postfix) with ESMTP id D86B820022 for ; Wed, 6 Jul 2022 16:50:27 +0000 (UTC) Received: by mail-ej1-f52.google.com with SMTP id o25so28126709ejm.3 for ; Wed, 06 Jul 2022 09:50:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AaCcNJUc/PsXyUHcRjXip0ZsV/ByK7ustJKLF8+SsWM=; b=RwclD5KFXWfbo/tSAqN6oS8Om8060BCLcvrdB4azIOAC1AMbjSwsfdmksIaBLM4aEK rT18R3/rTCPvpW1tQhOMkVhb55GXZ268C6TcQkSp3G66wacHJmGZL+9ukiqRaKNC7JUA 8ktoRxAuQqtANFXq/zeFsCPE1u3EIXHBKnp1ZO1fOdjkKqbcKwBWcETZuC1hVJelIcE4 qd+l0oNJ5aYqosLKg8bUWwgqtys7boWuxv8baeJG/tZAEtm2nlIjTCQEAx/MqWs0nspv klHtrp6YeFdQ+MYVDqHEUkmXLQh6dkMEUSaiIFe4bAN6/0JlxovbE7oCAl17l8uZIpCA EDvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AaCcNJUc/PsXyUHcRjXip0ZsV/ByK7ustJKLF8+SsWM=; b=Czm9RuhnXbFdexDSREMklGiFMQJrbKejSthisXHnSBSX3iDzNUqQaULbZfOfcLtGKU /SrJ+FE53NbfGjz73WNZkmBuXapYbq5M17CSqd0i3AkPTKzHxgbRq6zjzPf3ET5TVpXY DD0A8ERmyKf0iswvxC+vfZSgj+7TBWceKcSp8ydtxr2P1COi8jRmbTT6cb0vinXRkYMA xu2fixkfvxpkX+BzD7AuVD3hkaqsTOOLi8A2AIFB31uRm1aRCp6/KMKDuZQbsDRBRiUi 8X8gK4ggVN8am1GbRVG0DVL4xeD6xnQVIaRDU8AIQ3Ro8MwGKcB7ql6PiJp7eQe/c+WW zpyA== X-Gm-Message-State: AJIora85RLz0gwS+eNKMfsFeHdBxhpdKYUKDZ2FCR2527N6bfl7BKmEY hXaOyUJBvMc20fP4OLqaukdiIe0/alCO68EYBAo= X-Google-Smtp-Source: AGRyM1s56Krm+r4duhrMOBvrAx59qA+Knwvzznejo3C58kFdClv4PX0Lf4SApdHXBd7z5a7pi5acjte69nu9yebdGtA= X-Received: by 2002:a17:906:8444:b0:72a:7dda:5d71 with SMTP id e4-20020a170906844400b0072a7dda5d71mr30262560ejy.94.1657126226615; Wed, 06 Jul 2022 09:50:26 -0700 (PDT) MIME-Version: 1.0 References: <20220706155848.4939-1-laoar.shao@gmail.com> <20220706155848.4939-3-laoar.shao@gmail.com> In-Reply-To: <20220706155848.4939-3-laoar.shao@gmail.com> From: Alexei Starovoitov Date: Wed, 6 Jul 2022 09:50:15 -0700 Message-ID: Subject: Re: [PATCH bpf-next v2 2/2] bpf: Warn on non-preallocated case for missed trace types To: Yafang Shao Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Quentin Monnet , Roman Gushchin , Hao Luo , bpf , linux-mm Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657126227; a=rsa-sha256; cv=none; b=DJaGvunPsK2dsUwg/GRM6Lies4HfSc7DjFxvo6LpOd+X4U5sZWgvThLwjV7H+cU73tCpjl 1mNA34J1zZNfos+Yy9ie8FYIagzxOBW6eqwQbvUAFPtpzvOxkc5ou5tz9hMn0Nt8ARWjTN xc0kLjbOUoGrD3JmEKA77gdbAGcHXVU= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=RwclD5KF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf31.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657126227; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AaCcNJUc/PsXyUHcRjXip0ZsV/ByK7ustJKLF8+SsWM=; b=xmNHbI0vKMFgnLzKnd/gIR/WXAK98OYLfPYs+07HbiT+OsIwNy/a5Pdp+GdNJc3lWgt1gv wSe2hpwPEPIlpKwGmQIzDDKejN4EddO6Od9PL4N7vqbXyMByOEws6Y53oifLwgr9ZlT05e rS8+lTe2TaNquo8HXfn+uuDHJ1IRcAw= X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D86B820022 X-Rspam-User: Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=RwclD5KF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf31.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com X-Stat-Signature: m13csb7x7kte16m677ryb9ogwpgsmkc9 X-HE-Tag: 1657126227-964134 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000025, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 6, 2022 at 8:59 AM Yafang Shao wrote: > > BPF_PROG_TYPE_RAW_TRACEPOINT_WRITABLE and BPF_PROG_TYPE_TRACING are > trace type as well, which may also cause unexpected memory allocation if > we set BPF_F_NO_PREALLOC. > Let's also warn on both of them. > > Signed-off-by: Yafang Shao > --- > kernel/bpf/verifier.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c > index df3ec6b05f05..f9c0f4889a3a 100644 > --- a/kernel/bpf/verifier.c > +++ b/kernel/bpf/verifier.c > @@ -12570,6 +12570,8 @@ static bool is_tracing_prog_type(enum bpf_prog_type type) > case BPF_PROG_TYPE_TRACEPOINT: > case BPF_PROG_TYPE_PERF_EVENT: > case BPF_PROG_TYPE_RAW_TRACEPOINT: > + case BPF_PROG_TYPE_RAW_TRACEPOINT_WRITABLE: > + case BPF_PROG_TYPE_TRACING: BPF_TRACE_ITER should probably be excluded.