From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F90DC3ABBE for ; Wed, 7 May 2025 01:33:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A8796B008C; Tue, 6 May 2025 21:33:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9811F6B0092; Tue, 6 May 2025 21:33:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86CE76B0093; Tue, 6 May 2025 21:33:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 689CA6B008C for ; Tue, 6 May 2025 21:33:53 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1B57F5C1DD for ; Wed, 7 May 2025 01:33:54 +0000 (UTC) X-FDA: 83414390388.15.822B734 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by imf28.hostedemail.com (Postfix) with ESMTP id 28664C000C for ; Wed, 7 May 2025 01:33:51 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mBm+gYzV; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746581632; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=maTjyUiNxcd3tvQKfKzU0u/dUNDBsFElofAaKfOnP3A=; b=PV1SgDFNi8aqaY86HjZAS0M1a55o588CWVCoqRSCuILOhi6WWpMA+oKLesNa1d7ug+faJj e4tQr80Zv3gwqr9DBQfHFJVlXsT3yWkdMepP6wtsUArbF9KijQw/13aDceriDB+XcyKG1s ixQVLdLyqf0VmijGYQundyfc0WcKIWM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mBm+gYzV; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746581632; a=rsa-sha256; cv=none; b=xUbE5bAGF80mEXdSYfXDLGO17v7Of8kZTkUiAkJDZDDlc7ZxgZ9oOuQAlZnX5AoXjjGq4F 9gFmTZVY+WujfOjh1iSdh8tz6K0V4oK2U2UB9MMH8lautEo35xcn3CEvs2yz8Ljr6+jIdy zT6OB0+cdtUtpIWha7mjBUOOVDzcoPU= Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3a0b291093fso260627f8f.0 for ; Tue, 06 May 2025 18:33:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746581631; x=1747186431; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=maTjyUiNxcd3tvQKfKzU0u/dUNDBsFElofAaKfOnP3A=; b=mBm+gYzVJHuexXCo7EJUetqpV2F3XyWrMCTU12dvEuWe+c7aY8G3af8CI8NPxJOG1W 7JBlQcNnezprVH+7UtrmivgSh/qRHbI4j0ZB3CIcop6Z7qRVcflUhJeK7yMQEghg1ECf hIauH0iWlPnZZZHtQL5a8QSS6P2jo3UFDcOyni4bZHK5pQlLI91GROBtikdtJYTv5XIO AUxrtHSfIA5EMKtxOXeGvyRhHdc/WGrKgB0/BxoXg2s4G7tXyoPYIm0K7YzJ5jqXJ1WN jLdZfgbtWZ07AMWYj/nrYzWpXILB0/4h6NEzsr95XNiNnTc6b/HyQsVbw77jdtriS/98 0tEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746581631; x=1747186431; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=maTjyUiNxcd3tvQKfKzU0u/dUNDBsFElofAaKfOnP3A=; b=bl3A4txFOq0c8/wODeFf8RCbfnbcGtMgnRkgO34lCE8nNJXQDm2+Gicqw0h9XQ+PkI XLLN6P14Y7ABEiAcjC2ZJaRvYPsvYEWPD/B2JjJs/LnoqdZxRJUdhrrJDTrG3vxpBiC+ i+yMbLQrZWmxjm9dC9l5WTK87PQxNlNt9ULpKwwqa0C7Qg/o+KiiEW1c58WXABDd9DwI gMBOUUlJAjzngSC/BKJ0xSmBWd4BMF/rks9qVSJbHkItFYkXbAggp9R6f1kK26EmSMsB Fg/MFpecrxUkio4BjF5LgzaNpzr7vMCPUl4COjUs6mU9J35JmWA8Zmn85w+9k6m5FnWr /Ykw== X-Forwarded-Encrypted: i=1; AJvYcCXP13vbKOvbd2EjsCnN5/STYV8aRYEyrOp5xm1levYTzVWvYq7kR12Zh3cINdJUbo+De/8jiS+RLw==@kvack.org X-Gm-Message-State: AOJu0YyMC5bTYyJ2F72n5Fm6hQTw+sPAUhbseJl9RHr9utXKUgkW4pCf mEvHz2nesvDIiGvqgJuIXBTjAEkNeV3Em6gS1tVhzP0dR1nYN9MOQcB3pTOk3lA2rTtNEl2KHQ/ X4CchFSiLfJZ0ku8YvPn85Us5j9U= X-Gm-Gg: ASbGncsk8dgQv105b5czO+gTt+sXooUf+cNPU/e8137Ox32HpoOYNKqM/nE8/0faWwO oM+eALQyEEEvxOtzYmzgey3yZYTx4h1n70tz09jPUo5zZga9tS0DK6vdC2IWJXMeqjjdEuvOt/a lvfDELQRk5ya8BERi6Sk/YqNnENz6P7SCOuGg3BQ+y1IByjpBLrw== X-Google-Smtp-Source: AGHT+IFEPi7oh+x6E7M9tKFRCM84BhMer8ejItmikmAIiY4/nRMwLByQbAvDz2cXAmPujCmxo4haDkaveJriCcMJ2E4= X-Received: by 2002:a5d:5885:0:b0:3a0:9dda:c2e2 with SMTP id ffacd0b85a97d-3a0b53eb0b8mr903829f8f.22.1746581630461; Tue, 06 May 2025 18:33:50 -0700 (PDT) MIME-Version: 1.0 References: <20250501032718.65476-1-alexei.starovoitov@gmail.com> <20250501032718.65476-6-alexei.starovoitov@gmail.com> In-Reply-To: From: Alexei Starovoitov Date: Tue, 6 May 2025 18:33:39 -0700 X-Gm-Features: ATxdqUHp3PFOseewnhmEgL_lUuxY8YaPU7QqQjAt5xbagmP1UBdKa67T0T-AVSQ Message-ID: Subject: Re: [PATCH 5/6] mm: Allow GFP_ACCOUNT and GFP_COMP to be used in alloc_pages_nolock(). To: Vlastimil Babka Cc: bpf , linux-mm , Harry Yoo , Shakeel Butt , Michal Hocko , Sebastian Sewior , Andrii Nakryiko , Kumar Kartikeya Dwivedi , Andrew Morton , Peter Zijlstra , Steven Rostedt , Johannes Weiner , Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: hiyrniw7cxmwmjxqq7ypq8n3oeesquwz X-Rspamd-Queue-Id: 28664C000C X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1746581631-769771 X-HE-Meta: U2FsdGVkX1/maTSbzLp/+gpL8Dye4DYioDXb9GDSshtO82ITZ4PZ/65tqUS3ifp4pic1aBFEjVgn0180yBuEgTcMVdGWDViNK+DF1mjUcpvF5JE/a+0RRPScvg+oxvrLbsTvGILE5I1sDCXuuZ5F10jJhj/64WK/C64cBIGkBKwDWZGa1qPpNC0iY1tNfWSkOZqsi+bXkdTb2LGfctP4NPfbDS7mLR3ggTZnp1OZxl+ll0cLHaQPRuPQeshQlP/NIS6EufN7aluCKl3SqZPPpr4o4lnn1Ka5QuEoo5TRtc9lhyzKy0VfNMqEJRS14CfAm9CNioFM6OHE9Nj8QYFE7SvaZlwxQ0McJUjixCeyY6dPd8iNLUKpazz/vwoLyNClG5F5+1GCWkXfwLvfGHVhghrt/6T4Jask/vyZdbkLdlGgfZ2ZVTaWNippY9ZagSpqAKck/ETGfxPNdFjQ9SfBMhCowZir97524sLHwoWfWCu2ETYXVeuoFqXv89wCdDN129dqPA96o/PHMo8TPPC3UyajAgkW8iJKWFL6ABX71bdHiAe0fa/x15P1yORJ8Qu2osSJHZ/qvtQPJFKUVokpZ9iQc+VueG3OF1Dznqn9+Mj/wWDgm2c/8/Z0+Zwz9m1ZviChOBYPPRRgu5B/Hi2MNHa2lqV2gYkAbAQnitxtueESiQeg9N+jcTVZCaLss7+YoxprslYwZNl05wGmG2c+GxGUCLEJNnAWZ4QyFyuE3MaLUTkMA+hxtRGJNXfcOS3DGM4CG2K0a8xyrskDRm689/xtOFIX1vYHKUqYgiGFVClWRAwnYQLQ4Uo0UcXNH8+WC0DvlK6OyNmiu0GMbdZKl6bQ+15oHZIivy6Z0WQxD+J0GBW5l2G/CHI4PfMn/zoX89m0gnTdrL2IzEOgTxi+iq2thGQVgHnKDHON3D4w0gMqo/H2qZNEW5ze+FHrY5bIleZMTXEVoZJvYeKx2hF SLc9gn// zkPTXMZn8fiU3pU5aCi4MHoPblVklSqWp4+atIOBObAiAT7gQpo/IbHwH08vYOhOX9j4Lheq92gmTSD1kAVJHheESq0qkQzg8TabWb++YrexMsMMBNUWO1XHdPYBcgVkT/OO7uw+xgw8NZQ9QHEV8N8YhFPQe8kLpSKwjZJbxaDACyE7BnBh5HllN3mLlLa9zmVJuNLJQJxLB8SRcTkvmaoxHe6MrQNgf6pj5gzm6vCor7j2OidxRhEA1fJZpYOHl5byO802hjlsq+KIXVZFMelPavcSImmvdA9yhR5tLTdJwd+WvwXXxkWozoMnTl/1iq3btaZkVMzuGoYRovA7dgD8OhRAPVZB9CaU+uqCeyYJof/WwfIKqL9848OQZhIfJ+T5jVT+w9MbJtSa+l4/n34MDCJ5evHHwubQYJngOH5aYnXs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 6, 2025 at 1:55=E2=80=AFAM Vlastimil Babka wro= te: > > On 5/1/25 05:27, Alexei Starovoitov wrote: > > From: Alexei Starovoitov > > > > Allow __GFP_ACCOUNT and __GFP_COMP flags to be specified when calling > > alloc_pages_nolock(), since upcoming reentrant alloc_slab_page() needs > > to allocate __GFP_COMP pages while BPF infra needs __GFP_ACCOUNT. > > > > Signed-off-by: Alexei Starovoitov > > I would rather see __GFP_COMP implied as we don't need any new users of > high-order allocations that are not compound, and alloc_pages_nolock() is= a > new API. > > IIRC it would be more important in some early version where > free_pages_nolock() was different, now it just calls to ___free_pages() > which has the tricky code for freeing those non-compound allocations. > > But still, I'd really recommend that approach. Note __GFP_COMP is simply > ignored for order-0 so no need to filter it out. All makes sense to me. Will make __GFP_COMP a default for alloca_pages_nolock(). >From the bpf side there is no use case for order > 0. I'm adding support for __GFP_COMP and order > 0 only to call it from alloc_slab_page().