From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8F68E7717F for ; Thu, 12 Dec 2024 19:59:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41BEC6B009F; Thu, 12 Dec 2024 14:59:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CB9C6B00A0; Thu, 12 Dec 2024 14:59:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BBF16B00A2; Thu, 12 Dec 2024 14:59:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0A8946B009F for ; Thu, 12 Dec 2024 14:59:46 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B3F361406BE for ; Thu, 12 Dec 2024 19:59:45 +0000 (UTC) X-FDA: 82887371196.08.8CB3A73 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by imf12.hostedemail.com (Postfix) with ESMTP id 1630740012 for ; Thu, 12 Dec 2024 19:59:32 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TqNC9eOP; spf=pass (imf12.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734033567; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=59jmxjmmzbMhb46hk8UI9KqfQCYFwroIJNuQaYWTsAg=; b=Aemh2Vrn5fPygDxhaCEB7b5R8A8MUgbaVObDP4ftaYTz645QVKodCBRe9m1mJuwidCv1h6 ggWcZA3IDTDv2/Cq43jeKdFPyPBDlEUua1B12x5DY0Fhuv0tTZy6H2rK7MeNSHIb1+Iw91 SohlpNNd2F2wri+Jx0cRlcUMLmz6E8Q= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TqNC9eOP; spf=pass (imf12.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734033567; a=rsa-sha256; cv=none; b=i/jAcn+OQeP2xZTjsm3Tk+6WcCLc4JlBtrhqLlfoe5OmHyy5ZSJU/r4Ji5Xn8I2mVjQSrn wi+w1hsND388hQHnpZjwfczGPpCiFDUhtECoJyESQZ+QnFVwY4vX5Q9bPscaF6D2pwzZBR oms2XD4gJxVFKWMEQSSBwHX7xXofYDc= Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-385deda28b3so740835f8f.0 for ; Thu, 12 Dec 2024 11:59:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734033582; x=1734638382; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=59jmxjmmzbMhb46hk8UI9KqfQCYFwroIJNuQaYWTsAg=; b=TqNC9eOPYMCwnOKWuA3erB841RG0qYFmsy19TfhDO5p+xBOFHLYKOxAT9HQ5Czs4Dk bql9lc8VKv8Fpb8S4Ey11DJDaum2UCGZyNZ+1GuVj8vnRNWTZVgz/K/NRR4pe5afN2lq 4Iakb/03/Vkq/csdqXqTMb+TAojM/ezWwBlPG+VrvpnAEoX35wIOmPm4iJ2g3osqTtEO EA/jkJLvDji+E01borset+CEYUijmnh80vtlJwV/lnToPtUmgJ31/RwWObzeUCGYUufh XdH3ZRGYBhZBuJViqh44cekHge+4Gp0Zb7vkHOvPMo+fzCqJoe1WqoYLgtB5ygPjLDvu 1flQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734033582; x=1734638382; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=59jmxjmmzbMhb46hk8UI9KqfQCYFwroIJNuQaYWTsAg=; b=tBQYnS+VYHMPi4l/+BNBFQ8ezoOlTw/5KyFKRBIR9rrUD0rJYr2BctAT1MNMxpcIM1 rs4VMfI8mwYU87Sc4FBsJRRpC7iqkeuHIar0Qd2ZvlShHozTxNi5E9VJrpk6v1mMR8rT aLKr1p3u8b7B/IMpzDMmt9viX/5FhniPcmp/tW6Bs9ttqF+OAKUspa3N1Otx05qoEKjf PB7aK0a+qfQKA3W5uA6XvIRLlkcB6X/xa20HN7EIW4+hs/oiVOqyViaFHuGTh3PGKzKg KATBO3tzQDwd3rrjI9qGgyLdy6xphFLfaHLWQvm4Sa+qpKp8mTe3vcvCfV54edBnP86h e67A== X-Forwarded-Encrypted: i=1; AJvYcCXeTsI6E2pQwQmTV9l8Ewdio2XWaS3ycAU4FYpwKqnG7WBY9MctsQKWVjWB5C+u0o7IfIXERkDucQ==@kvack.org X-Gm-Message-State: AOJu0Ywp/8rzS2kkTgoI+t/gwCg2iGIjIX/fEnAG4YnCtUNwTF77k4ZA pFgI1O+pAqiDKjyqDbfGlyS6hKufiouZ0ksic7r51TbrhcXVGHbbPtkuEDX6LRaZaA/U/KX9R/F VdmhDkf/FaKb+2h1QEolMu6kBVaM= X-Gm-Gg: ASbGncsUWXpXy3HTv4zu3lSL5Up+jrPcLwisKXlrqahXweid5pAO4UeWWa9qlUfCiMf sfGomCGV462i9g5oca8Udr0vXdlrfvT3lI7pWpGbWIAIm2sBXGhWSGU5pL++4yKW+FD4K+g== X-Google-Smtp-Source: AGHT+IGwNuD6Ftp89eeMa5Cgwi3JSQH8HV7RA75uk5OAIGYfHDJ+0xlO19k/FBDSAaZ+UebluzVUoxQq+6snULBY8a0= X-Received: by 2002:a5d:5f56:0:b0:385:f60b:f5c4 with SMTP id ffacd0b85a97d-387876971fbmr3942557f8f.29.1734033582286; Thu, 12 Dec 2024 11:59:42 -0800 (PST) MIME-Version: 1.0 References: <20241210023936.46871-1-alexei.starovoitov@gmail.com> <20241210023936.46871-4-alexei.starovoitov@gmail.com> <20241212151529.oPNxM6JC@linutronix.de> In-Reply-To: <20241212151529.oPNxM6JC@linutronix.de> From: Alexei Starovoitov Date: Thu, 12 Dec 2024 11:59:31 -0800 Message-ID: Subject: Re: [PATCH bpf-next v2 3/6] locking/local_lock: Introduce local_trylock_irqsave() To: Sebastian Andrzej Siewior Cc: bpf , Andrii Nakryiko , Kumar Kartikeya Dwivedi , Andrew Morton , Peter Zijlstra , Vlastimil Babka , Steven Rostedt , Hou Tao , Johannes Weiner , shakeel.butt@linux.dev, Michal Hocko , Matthew Wilcox , Thomas Gleixner , Tejun Heo , linux-mm , Kernel Team Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Stat-Signature: kqi94kq4g6r17aj3b4kdizwhxpfxx741 X-Rspamd-Queue-Id: 1630740012 X-Rspam-User: X-HE-Tag: 1734033572-42770 X-HE-Meta: U2FsdGVkX1/kdxUg40UtenHTF0LJgmlHNoqF/9m1aJVT4fpMWurgDj4pof42RgP6gGdQxuvQnmrxLMTeEkl9ho+inI3pupRSotOTw9M+xJXAC4hRWrM5j3BHB5aFdsJZ11N4LkpO2nQYpQaPZBA1hZpI0TWDdoBHqoyo/B5IljCTvHMO5NUhYblZXl6C4PDE8wN0g6+3bAtQNuN5n/E5tW+ekuwQOGFL/t8nT51bh9zJhWlVOcFfUmejaWpqMH3JC9LlaQ94kMCL+wFIy4MGc4PQVHdAuSXXA7+Tfe7K5OYUg18ai5gVzodeC9I0jDQJdqqJIh8nhEgTnQ2pAVfs2mpmA7Z5Dt01IjI/bStbd+gUBu+h7voKlwqXVXz+dQMT/OXjLyZo9qmtpmBMOaPwhCwYd3IpYDhl0k6u7Kq2l9TJhlJ+v7lQEkUf/Tnspvstdx16+7jsfWPz9RbhJs/83sU9iTdyn786SQX6jHj1lfpXwZo2/xm0yYYI48bNet+SRGhyomsfZb3e/4wIzly6Gt06noYOgVu2y9o8aAaWZWDVMSnIzhL96X2JmFVGaXi1160a93XAE9podnz6PmnAH3FHCikxbFGrilH43KnbqpRprkL//V4GmY3Es+OBz8/ZgEMVH4TzGeEjxuY6bZXonx5dww4jNKaj1qXbWDN9RlL8pgktdJbOvOKCuEYSP7FNNe+pFKC0dyoskoLJt8mXrPI9wFR6xRdKweZA2LjvOWJL8FFDgSTwJzCO2nG5YpsSswaXIl0W7dLMB98aVpAESRmNf5Zag5+7z8kw/1gbHBqG4CYF1WKyuylYWXFThoE0Iv5FVlop5Oa/OIfcEuX9ps4+D+gE0LrEEsyAThIaGs/nEGs6IawQcQkWBfMPAuf+jt1KpsFjAa/WorsrWh7QHpNYsIvMK0Kl8mguGiYeT5iP94AHn3CprHvYktRo9EVP6UYp3JdaeOrNw03BHoP k5I4knbb XTgO8KahUsVGV3TM5E6vGYoneY/flCkswJdvzib85MU0jn8Yy4576oKIb05B9Hg1SK0FT5JbwFWkwyyQ5Wz9I3gIz8cFB5waRR+YbZkcopGejavpgXXYRLwEPhpniNgYpl/+XMUVT5pWeJTr9IrBO/2dcx8znJWUToYEZkh3TRmXpSkmVveRveUer6sizApzAgWqeBlLOYleet3eKT2m4ANqJmUl4+6A1klqDb0FmVDz/HiN02BIpJNBiSUCWKDuwrNA4NQ6TnVQZ8erHyt2fXzInPSAF3eLL+eqQPvfwOkuJsGujocs6OZG90p9YfVcXVgdwollWVohISdKG15j4VZqMpjyjRqVjrD2+Anmz0iE2PN3TornuxkOJBcVFfG8aZuHr4Aih/ULnhyb8s0WBVLC8dQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.048822, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 12, 2024 at 7:15=E2=80=AFAM Sebastian Andrzej Siewior wrote: > > > diff --git a/include/linux/local_lock_internal.h b/include/linux/local_= lock_internal.h > > index 8dd71fbbb6d2..2c0f8a49c2d0 100644 > > --- a/include/linux/local_lock_internal.h > > +++ b/include/linux/local_lock_internal.h > > @@ -148,6 +163,14 @@ typedef spinlock_t local_lock_t; > > __local_lock(lock); \ > > } while (0) > > > > +#define __local_trylock_irqsave(lock, flags) \ > > + ({ \ > > + typecheck(unsigned long, flags); \ > > + flags =3D 0; \ > > + migrate_disable(); \ > > + spin_trylock(this_cpu_ptr((__lock))); \ > > You should probably do a migrate_enable() here if the trylock fails. Great catch. Thanks!