From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B2FCC83F1A for ; Fri, 18 Jul 2025 00:09:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DE356B00A2; Thu, 17 Jul 2025 20:09:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 98FC76B00B8; Thu, 17 Jul 2025 20:09:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 87D886B00BA; Thu, 17 Jul 2025 20:09:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 75BE56B00A2 for ; Thu, 17 Jul 2025 20:09:22 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 21D15C027B for ; Fri, 18 Jul 2025 00:09:22 +0000 (UTC) X-FDA: 83675450964.21.E2DDE5F Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by imf03.hostedemail.com (Postfix) with ESMTP id 58CFB20002 for ; Fri, 18 Jul 2025 00:09:20 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Q+5BGREw; spf=pass (imf03.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752797360; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eFPWUEY/toVDVNd2k/LREoggH1XAsJ0FDgoZbNXOeEw=; b=fv8BNc8Hp8VTOt7jSNh4QZvLpPrsQ8+jYunPe9CeJiLyLQpQesUJnG99kuyumDsdUnPqJT NZQ+Sw2XI+g2JYA2zijV9H6t2Zh+9/8wL0Qk35fX3CYbfq0pk8K9zWPZaGYhnFQYOFz7he awvIYOdGDL6j3h6F5+XyVCY9N83SJ4w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752797360; a=rsa-sha256; cv=none; b=gqn+1MD45edNLSOURKYydxlojyWDgjxnC4O+zSkDy+NwkLhbLPwSdOtI/Em/Zay+2VHC0l eNfxK4AhvpYkCPfRT7FwzTrhL6qi6Sm0XAoqUWFpR4CrgwmPwqFSbj47fZt1jbucRWqYSn f1omKw+ajmwQVwxRUS6ABfwYuS9Qils= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Q+5BGREw; spf=pass (imf03.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-455e6fb8057so15688185e9.3 for ; Thu, 17 Jul 2025 17:09:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752797359; x=1753402159; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eFPWUEY/toVDVNd2k/LREoggH1XAsJ0FDgoZbNXOeEw=; b=Q+5BGREw0kKBmUNGCeWethEcXUs6pkqE8Rjc82T7NPMKcGKm0M3U/O69v7Hdv4Zcrn AvCA4cwewAxW6NLAsJJmbLj5aSIFcH/y/M88yB12ryrf5pH0y/bCL/n9cBOfGWHpgQP/ YnnlH1Mn9+gNuSn9iroPqKfuyJe08OK+JQKIi6oy6odwiUR6XHmrlgz0rwnuv38ScjZ9 Yd92l2KO+3MpCBmY0odrsYgpY5trkwafqL8LU526yj9RBOCqWaEAKup04a7berYxO9Vg gWG5LFViQZyK6SEdgGLSYcKe6c98AP27FyYgFjlnh/5CJSRRLdHPNyiWeIS+BA4Ny4TN aN2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752797359; x=1753402159; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eFPWUEY/toVDVNd2k/LREoggH1XAsJ0FDgoZbNXOeEw=; b=Sz5neZrjsIZG8ld7NtniRhTTqDvgwLxKmri2hGlaj9CrdgKFJSvaBB9hRnMrX2XgoF fJkPliCioaM4PJqoVqW4EF6S9XdaBVjUCpiwCvEVSpBftOxEd3jheWBVfPZRs3g/KLoo axKUr8cSnDkAuT1xtaDsnkpCa2jhXERHUjcEGt2CHpJ6K8Qfwj0BNZawnnLxC6L3oo2c Jo6W7tjT/Q01G8lkuUB/RDDJRE2gOJbulzhYv6IoAapQUBWgh8sRvisv0YLk1JDDhuxs gwFhVH0SbWWC5Qa9SHkYXUpWzN6QUHpGjyJn2pp/Y84q2GqPZtZSKtVnUpccIoUbONDQ aejg== X-Forwarded-Encrypted: i=1; AJvYcCWiHuSVdKILuNQsTzQcXIxbPlbFUQ61VkDLJujE5XGnmKFRrzsMQ8n6A1T5akRmHoK2VwTX8p6Ovw==@kvack.org X-Gm-Message-State: AOJu0YxrxveWM1YMn0K5tgG7uChDFII5RY0S/e/ltaVtP6ZhB4hqTHz6 rlGGx4vjl5V0vOvjMBDAKIXas4gql9sq+YaCOcyIvezOARC9FzejFsGcsA55UZit1mn8J9tF1y7 d8V+FT8NI2R2V9U+K2wdMLPfUHTvUATM= X-Gm-Gg: ASbGnct7MGMTuvl1P8Y7/kx7wA+svJkxA2TFyW8M2pshEIGJiBKdLyiddkEoe+hP2qP Cailrz0Er53KjL3OBiQjmBXIRlDMLaRB7dmUVaxtskfitoo9C+z4CW+hUxABbrfLjTcKo01hZiP yC/IGw4q1/q/02XOBTO3a38T7qSva+Ni+VvKHUb5u0Z9p5V9poL52p30FXJYsSS5MZd+Ild/3nd nVB5XR8kWkJVabPCOHEeYOgivh5EAvq+qG1 X-Google-Smtp-Source: AGHT+IGYVqyNSH5VcHb5xfEd4kdi0HK7d5DKZtBzqRjqBNAznkd+mV06DBV510d5MK9IAuovfULZzPgCJqPyRuMqsyM= X-Received: by 2002:a05:6000:4383:b0:3a5:27ba:479c with SMTP id ffacd0b85a97d-3b60e50ff53mr6669743f8f.43.1752797358393; Thu, 17 Jul 2025 17:09:18 -0700 (PDT) MIME-Version: 1.0 References: <20250716022950.69330-1-alexei.starovoitov@gmail.com> <20250716022950.69330-6-alexei.starovoitov@gmail.com> In-Reply-To: From: Alexei Starovoitov Date: Thu, 17 Jul 2025 17:09:07 -0700 X-Gm-Features: Ac12FXx_Iq-pygiU7pxgIINcF_KXSgBWin1TYT6Y-FBrGuzcHLrtq2k27mccSzc Message-ID: Subject: Re: [PATCH v3 5/6] slab: Introduce kmalloc_nolock() and kfree_nolock(). To: Vlastimil Babka Cc: bpf , linux-mm , Harry Yoo , Shakeel Butt , Michal Hocko , Sebastian Sewior , Andrii Nakryiko , Kumar Kartikeya Dwivedi , Andrew Morton , Peter Zijlstra , Steven Rostedt , Johannes Weiner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 58CFB20002 X-Stat-Signature: 491zyib38djxkuzk1w4qksywqwuccuko X-Rspam-User: X-HE-Tag: 1752797360-216830 X-HE-Meta: U2FsdGVkX1+Ix3eti2W5DzBvUf32UUXDlOrpuTqj/IDnd6d7Yv4NTj49T9fxgISNKYlsQKob/awJVRdg8BcQlRWFezdW1/AzoxhRoBSqs1CslaXfL35P7YTEBrw7mBdkKqU1G5K03nfMJenRWsU8IjyJtgFZFxjkMb5bWpVOgAaC8NtUFc3dfXaluJGLqL4Cjewh223YLtfEBEDuifQfmSruK76IYZL2PO8/5E83iL3rC8rrPHxAhOggLOU/8IyJTCaaJuliau9OT5KQxYQrxDHqonK+Im/84HPF7wC2U8dEeR4sh7umY1Dzr3HHbq4H6xFCcuZ+iEj+vWAcchbBm/7lsc36yZgWe6ljQcqevkrvSuqt51e0R+8j4JkW0MU6z5GvaOUzTMrjeiEpG6mNKtC7tWwWOMfQVY8YSQNjAna1v945OqeZm1UUf6PQUpTHPxwJLT5G3TVn0WQIreUWH6FmHhmiy0f/l1rQ9RT8dCFNE9AcgRw4Jwpjx3Q0jqiOg76zI/Whl9PlppOXS+N+wCKm0DY2sHQLxvn5PnpiMJozR6k+SMj6vja7lQ/BUvRC/O8uZw3CFbGZ8dVUytIFHUNmx+j9g+yJ5m5TQ3Ztvno0xxd+W0b/n6xSDQQ5UI2pcy4lquLqT8UXa0Ej9rYszN4xM+ObL/a+WNoKOmRN2knLbbpWmPIIgTiMtvHjBW9vXdyQ6c0qnGlnFH8yuzIHw4PwZp4hM0EhYNJ7SVwb76HO7GaQ13kcBmaFLl6MFoeMkos34XJzdq9ea+lFfSvxuAMQqxfaNFo8ZolsfA7SMKMIjxUH2aoLf5myWjXwF8JYri4ylBBQ2xqYkEn+ZydMV/WL2GBVV9J0XSH9FIyBCN9sZBn+GtQlTjQLJkV72S9VCxwRSQPneERnJlOVP0St0XgTjzd35DPjfpvg5K1qFgSPpCRrDjYjciLBcb0Ys6frzVjK0kucLXFmRnEpiAe YU7yGtLN oAkti6pEKG61thvVqKmSHf6/IyJQxUEsB8Mv7vtmu15rRvTpeqx0DYQBbNqAY5W1cPdLWXK5sawl6B6b2Dr3F8U/4YbgsKD7XNi90 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 16, 2025 at 7:50=E2=80=AFPM Alexei Starovoitov wrote: > > > > +#ifndef CONFIG_SLUB_TINY > > > + if (!in_nmi() || !local_lock_is_locked(&s->cpu_slab->lock)) > > > +#endif > > > + ret =3D __slab_alloc_node(s, alloc_gfp, node, _RET_IP_,= size); > > > > Nit: use IS_DEFINED(CONFIG_SLUB_TINY) to make this look better? > > ok. Will take it back. That doesn't work since s->cpu_slab doesn't exist with SLUB_TINY. So I kept the ifdef. Addressed the rest of comments and will send v4 soon.