From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFE04C54E49 for ; Thu, 7 Mar 2024 17:54:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 703846B024E; Thu, 7 Mar 2024 12:54:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B3796B024F; Thu, 7 Mar 2024 12:54:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57ADE6B0250; Thu, 7 Mar 2024 12:54:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 48E066B024E for ; Thu, 7 Mar 2024 12:54:49 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1998CC117E for ; Thu, 7 Mar 2024 17:54:49 +0000 (UTC) X-FDA: 81870993498.13.46569BF Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by imf05.hostedemail.com (Postfix) with ESMTP id 3610E100016 for ; Thu, 7 Mar 2024 17:54:45 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Goy8wp2G; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709834087; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TSuZ9uOkD/FjUsG2E5ZOB/LbYzDe67kxmR+IjAVxz7E=; b=bcbqEz+UM2crJLOKZYxsOlO67DRN01YBYVEZfgjqwsDCwNYVs4/mFfMLR753HAb+341Xvs Ci5civrAuJsb7EQQIq+YevbcMmmUnEeHWbkMMpMjiAKurjSyg5i3MhbQ4wJMWsE/cs3hUf E11F/iMk9J0I+UyRcpi+J3inxsHhQSc= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Goy8wp2G; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709834087; a=rsa-sha256; cv=none; b=bNZnN2LeAcqA5CmvSqZAds75FvoKre5u437yIFZBkeAYYsJFmucLhVGq4HdkcDeOAAWAh/ aouvpbuy2O7kdtgrdB7MOEwxryXIDoksn1UcDs1MoYYfdfy4zX6FuIANLdaRU0AmG0UVo0 IVw5LyCSvtQfG5x73iCpCC21Uq3O854= Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-33dcd8dec88so589910f8f.1 for ; Thu, 07 Mar 2024 09:54:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709834086; x=1710438886; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TSuZ9uOkD/FjUsG2E5ZOB/LbYzDe67kxmR+IjAVxz7E=; b=Goy8wp2Gw7tdsMIHMro+z3WnCXLJsJa9UYRUxrrWly0ORsJ5V5snPSmLNXwZtbCTYp zTcLcisXNdUWXy8iWYtFTz2wo+FKxKfG1w+NnDC0AFbVVsjqVG8rKrt9zup5uSoRIYMZ c0mXH8i+YVFqR37GKo453RF5sDbMsn2NQY865cBIslgBtaMedBCbhBfUnMIsZmCZm7EM U7kAE+phdUnNUlWtoTgIciFNkSHqHtKlY14sDjvcl4+rUr9+vALc9Qxfaedfm4RQNkJ3 DX67+sXRXMxnphGIaZnQ+qDuhJA6S7w5S0+dQlcvFjAVB/wPA8qefAFp7mUuwNH8wZPu BYeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709834086; x=1710438886; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TSuZ9uOkD/FjUsG2E5ZOB/LbYzDe67kxmR+IjAVxz7E=; b=SNbFLJZEAUOT2xnhZ/mtCHrU/6ljonfltY6xYMzFzjqWXTcyJqgbar6p+tgKA0l2Tw ATHqJ7BnK+y/zBEXzwEvcl2u2SxaOd3ww0232UciwsJL3TQ6Ov6zgNehJe9eGWMF458G JS8DjU36TAfW5lXiG733IxRGFjBjlm+YJWtYxrZDhvvwN4nXV7L5SqXdTIh0Iu4NVxVN Mv6FbcVlQ+dQTCg8pW9dyXIY1z+qzvNAnjRe8XCqZfWEKORX4HdJxCiV/nk6uZJa6kmK AUB8P4FWsL7f2HBUBVbjoKgxtodmnZBjuDrZhjoCXkqtoqf3OBQ2pSY/aU6/omxjweTx Mu6g== X-Forwarded-Encrypted: i=1; AJvYcCVeQp8oBNVzpNnxEoxR5CTaHMjZ80f8bqvrwwpX83OcfVE0HWJqlDkPTxa7aL47+h1muzPZeb0zN+41EhkdnDEqioE= X-Gm-Message-State: AOJu0YxB+gwutI2GNE4SCb99MUZ7DMsaHJXx4X7+iEEhIZqDjpeLhFvh V8xjyDQV4etpAKTZo/xAgPnqasUphYDDJDGy2AoK+B2Pf/GiV7Sbskk99BywnDJL/LwV/Ijdsa6 J60Z4xqUUzrpQkDbFWzENSfqHR6I= X-Google-Smtp-Source: AGHT+IELlMA7naIHOj4mLfsx+ssUuH58XPaMrNk3VD5C9cctlsAHYBGSGF3DhK3x1Niz0nBeuLiZC1m8+pzBcPe19cA= X-Received: by 2002:adf:cf0e:0:b0:33d:6301:91c5 with SMTP id o14-20020adfcf0e000000b0033d630191c5mr13604502wrj.3.1709834085521; Thu, 07 Mar 2024 09:54:45 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alexei Starovoitov Date: Thu, 7 Mar 2024 09:54:34 -0800 Message-ID: Subject: Re: vm_area at addr ffffffffc0800000 is not marked as VM_IOREMAP To: Miguel Ojeda , Christoph Hellwig , Linus Torvalds , linux-mm Cc: Catalin Marinas , Will Deacon , Linux ARM , Daniel Borkmann , bpf , Bjorn Helgaas , linux-pci@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3610E100016 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: i6ufafussb8rrsprq3uej64t8gbmsdrw X-HE-Tag: 1709834085-223307 X-HE-Meta: U2FsdGVkX18D9ICu922bEkmZZZG1DCowncH4j4+a5ZD77l/ynwUYkJhNga0GT8YfX+ZKWemGUGzcOSbUsgW560/YEcApntwxzUM8Fe34nqgBcCGjHllmgp6u0uzlLXjtIszzbHMweaXAKP/7BhFalsPONY5zyeEc00IJ5PbilG+jH3TsETwwuWYLtcMHcERqm1pMEwq8WfFS6DTBQyxJnQheV943yum9bPy7nwVd2J/t7LeZcp6cMrC771wKXyldQmzm/fyOUjN8byp/uAKjj82uK5752cx6958DVcCEmL5yioaW1Tv9l7JV/Fi6AuBbayISOa31nkHgFXhNYE+eeNYyP3hKIGPOOaIaxgnx+gHo0yiAi94q854Zeh0qcWg5Gof2arC1gEtwivAYayj5vgSYKr+TLFJ9BavNwH0aCiJTrRmuC0CZbbNXkfiY52JuAAZ0qw/VKy7sguDEcfaYoRPOOfTFQXO14OCTanCwueoJltK+9dVZP6AOQz+DxkAeIm4zMCOerQVW/H8QJ0ii4Lx7lRAJeA71M2tGTvHNtY2j48Jjdyn1ry8iXGhe9KHXyDR3p/CV8X2T63Ddp/zikQMQV01dW8XNi/pF3JcoqR1RDdjTBrzPCJCzRj05fsxreQi1GDjv7MjCZTKQECWppRZsF03BaElDgKI4Gl5V++kOwJTxNSH6EpfC52bSp6HEljN414fmEl2VJLSbgJB9AI1okJdsQ8/4ez/y0Nh4bgf1eC+GSpnO8JFhTwroZ4wP1jPVnjN8wTm/0wDk7x2RJHRu0kYvuRR3tDh/wAM7CqRQw53MgirEjDppA2MjWo16Gt5Fvj7bWvlUVxstUdrZzNhYQLIAZ7KJVAc92nHZE5RpJ12NekQRoXG7D8vAaUaqLZbuqG7t3PM0M3EjcIYTLylybTLh9Xxr5PyIX6wWlApEP9KcPYrf+VtsBQp0Mp1+rwb7cQFg70ZCMqMUsn/ UG9XvDnM MG8bw73ZFjm5kRBlN4DtRDm7NXynsveZpn827PSwFjH9pADOhh1NRMCrYe3Vp1FuXbNjHSsSWpagT3vbG4ejSEMFClfuJH8yBibdWv/Irve3ElBeSzCrIsG6Q+cAAaTo8nBwbfsz1I4LcpU9GmB+j8LeriwqiJIf8iwiaMu5K9y5SpaTAtU68S2QwkA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 7, 2024 at 9:42=E2=80=AFAM Miguel Ojeda wrote: > > Hi arm64/bpf/pci, > > In today's next-20240307 with a defconfig LLVM=3D1 I am seeing [1] under > QEMU virt, i.e. from > https://lore.kernel.org/all/20240305030516.41519-2-alexei.starovoitov@gma= il.com/ > applied to the bpf-next tree. > > Cheers, > Miguel > > [1] > > [ 0.425177] pci-host-generic 4010000000.pcie: host bridge > /pcie@10000000 ranges: > [ 0.425886] pci-host-generic 4010000000.pcie: IO > 0x003eff0000..0x003effffff -> 0x0000000000 > [ 0.426534] pci-host-generic 4010000000.pcie: MEM > 0x0010000000..0x003efeffff -> 0x0010000000 > [ 0.426764] pci-host-generic 4010000000.pcie: MEM > 0x8000000000..0xffffffffff -> 0x8000000000 > [ 0.427324] ------------[ cut here ]------------ > [ 0.427456] vm_area at addr ffffffffc0800000 is not marked as VM_IOREM= AP > [ 0.427944] WARNING: CPU: 0 PID: 1 at mm/vmalloc.c:315 > ioremap_page_range+0x25c/0x2bc Great. Thanks for flagging. Looks like this check found some misuse of ioremap_page_range. Note that without marking the address range as VM_IOREMAP the vread_iter() will be bulk reading over IO and might cause hard hangs and what not. pci drivers need to mark their range as VM_IOREMAP. That was the reason for the warning. I'll try to figure out which piece of code missed passing VM_IOREMAP into vm_area. I'm not familiar with pci, so help is greatly appreciated. > [ 0.429236] CPU: 0 PID: 1 Comm: swapper/0 Not tainted > 6.8.0-rc7-next-20240307 #1 > [ 0.429513] Hardware name: linux,dummy-virt (DT) > [ 0.429751] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYP= E=3D--) > [ 0.429946] pc : ioremap_page_range+0x25c/0x2bc > [ 0.430063] lr : ioremap_page_range+0x258/0x2bc > [ 0.432220] Call trace: > [ 0.432462] ioremap_page_range+0x25c/0x2bc > [ 0.432703] pci_remap_iospace+0x78/0x84 > [ 0.432854] devm_pci_remap_iospace+0x54/0x98 > [ 0.432979] devm_of_pci_bridge_init+0x2e0/0x48c > [ 0.433114] devm_pci_alloc_host_bridge+0xa4/0xbc > [ 0.433254] pci_host_common_probe+0x48/0x1a4 > [ 0.433363] platform_probe+0xa8/0xd0 > [ 0.433456] really_probe+0x130/0x2e4 > [ 0.433545] __driver_probe_device+0xa0/0x128 > [ 0.433647] driver_probe_device+0x3c/0x1f8 > [ 0.433742] __driver_attach+0xdc/0x1a4 > [ 0.433834] bus_for_each_dev+0xe8/0x140 > [ 0.433925] driver_attach+0x24/0x30 > [ 0.434011] bus_add_driver+0x154/0x240 > [ 0.434104] driver_register+0x68/0x100 > [ 0.434196] __platform_driver_register+0x24/0x30 > [ 0.434306] gen_pci_driver_init+0x1c/0x28 > [ 0.434407] do_one_initcall+0xbc/0x248 > [ 0.434533] do_initcall_level+0x94/0xb4 > [ 0.434632] do_initcalls+0x54/0x94 > [ 0.434721] do_basic_setup+0x50/0x60 > [ 0.434810] kernel_init_freeable+0x10c/0x178 > [ 0.434912] kernel_init+0x20/0x1a0 > [ 0.435003] ret_from_fork+0x10/0x20 > [ 0.435227] ---[ end trace 0000000000000000 ]---