From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E841CF6495 for ; Sun, 29 Sep 2024 17:05:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 994526B008A; Sun, 29 Sep 2024 13:05:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 941F88D0002; Sun, 29 Sep 2024 13:05:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E4066B028D; Sun, 29 Sep 2024 13:05:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 564ED6B008A for ; Sun, 29 Sep 2024 13:05:57 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 16C76AB3B7 for ; Sun, 29 Sep 2024 17:05:57 +0000 (UTC) X-FDA: 82618403154.01.34701BE Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by imf09.hostedemail.com (Postfix) with ESMTP id CFC2814001B for ; Sun, 29 Sep 2024 17:05:54 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=MdC2b6W+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727629453; a=rsa-sha256; cv=none; b=ehSjPYdW8ZHzEPoUWiPCapFc16v8lPgrHYjb/IV1Pbx8lnemYMU6zDz+f8jwmVvtW5NwGP 5WzDLV5wKNUa3rnwYI2mCQGxiAh4hFePYeI5mDAUPkQ/Qq6OuR6O0vx1VX8Guk1REzieDC aaUp0VxhuV85iGKe2OKx4DsQgXZsrdU= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=MdC2b6W+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727629453; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3PsHkwE+x8JT3hBupvf6LiFN5ijzuGAyqnqGRf6VWvU=; b=GSSLVNXnSTSEdHtFUB2pWSGkIDvduFE3IsHCXTlyayEhnaQfzrPKzZzxb94DhjRf6TmyZ4 HtnbPu6eiSkEBh99vXvERunX6XK5cgn4H9v00hGXd0Xbk3RBlwn4cpgnIgm4qG+MwFvZZt gDnyo6HVgd78EuI+yvYx7QOzI2OM4Mw= Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-37cd1ccaf71so1653575f8f.0 for ; Sun, 29 Sep 2024 10:05:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727629553; x=1728234353; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3PsHkwE+x8JT3hBupvf6LiFN5ijzuGAyqnqGRf6VWvU=; b=MdC2b6W+i0L+6VP31rjNYl0aLJj4vrpiHiiI6iP/e3NLsfBTDNTbreLIIpepiCO7V8 7jt00pNK61CJRVvmzJOKBqird/fP8IZU1bOCtvrbcHA47mk107GWYqbAhFH1e760MUUL yjxpYxoKDrWDOLxIW4TaYI5ngJvOnU4UYEDT5TtcuEu8q61BjbJtWgYUgV3UrK+9SglC oDwZXbG3RChzoaDGTU5a0TdJxF/puT96/XStHur4I4gSeHX7TmXI6Tz+iFUPTc6quj2d /H6nS4bCW45izZ4LIj2/XYZdJqKZVcZZjAETOrmgrfPM2Q7eC7GCwKmnXilo8d4C+7FO hetA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727629553; x=1728234353; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3PsHkwE+x8JT3hBupvf6LiFN5ijzuGAyqnqGRf6VWvU=; b=O3YMuxpLiffm0HXUc70edgwnH4ZRFso+EsMRLxAMtW8/uH8arNFfKS+tvltBh1x/Oq +mo+/xFr5nJerlwhHQzH41N3rJhSuciIa7Oe+uALJqFdUi4aZG1fHRGHl9GcjgOyYrQp iEWuc9zOTaMtN/bMJIIDG63xOAwNGw/Ez+9WH/RPpk1Z6inbIeHA0D250hEk5KB0mPZ5 fVXmpqS33abCb9+Lg/KcRSipv8ooWU3O/hCDbK41QLO77fQcGGHElnzLX0l7Tk7BJXSL 3m5Fxhe92zWEWaKrnnBG0m0tjHAVM3PeCrrP1PksSAgtgPuBWCXWaqPxy+AolHg/gmKV 7vBQ== X-Forwarded-Encrypted: i=1; AJvYcCWZK9gv8B5C/E3Q+3JfcsMm7hZy/tq2FogPvFYd7+byFEY0CZ5vspF7nGzxJOHOR2kBN1jpdWOC+A==@kvack.org X-Gm-Message-State: AOJu0YzCkgGrHBLBZTdCchOH2e6Tkg0AKVFb3L+wl/RpKkBMnW+DBV1K sU1Jaedyn72rcj/UywlupfCkPFSq+vfOM2sy7MM9DG14opDSjxm/bSx+t+RRUq/ons9qU5wcqRG MOpQmMf/fDpxzv/9Y3x5ghdI9GBc= X-Google-Smtp-Source: AGHT+IESQkCDQhwIOQ4tXcV3G5KgKbaYNyktnM/EGy/mvt5yRg16rArBeOUpxIDXvQqHh8wX8aNiB1bjlpRWUW4nbko= X-Received: by 2002:adf:fa43:0:b0:37c:ca20:52a with SMTP id ffacd0b85a97d-37cd568bc9bmr5832448f8f.8.1727629553206; Sun, 29 Sep 2024 10:05:53 -0700 (PDT) MIME-Version: 1.0 References: <20240927184133.968283-1-namhyung@kernel.org> <20240927184133.968283-3-namhyung@kernel.org> In-Reply-To: <20240927184133.968283-3-namhyung@kernel.org> From: Alexei Starovoitov Date: Sun, 29 Sep 2024 10:05:42 -0700 Message-ID: Subject: Re: [RFC/PATCH bpf-next 2/3] mm/bpf: Add bpf_get_kmem_cache() kfunc To: Namhyung Kim Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , LKML , bpf , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm , Arnaldo Carvalho de Melo Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CFC2814001B X-Stat-Signature: 1syerme5wh564kc7ud5gbro4sgdxdhhq X-Rspam-User: X-HE-Tag: 1727629554-402545 X-HE-Meta: U2FsdGVkX18U3LrmxKa0ml0P6N9BcDxapIyuAoVKbY160w+61QFNGR1uesnOWEYW5i9jeXkkE+mWIT8TiHSlFf26v7tgpwPfit0rqLfhpNUcmsOZ+I8couU1njXZaICLQ/N3rqiWWDGpFeEGm1GehcjawmIxbNkyS6XgmLlwPHkm36i+6SjP/1frjBoHYY3cEGwiYssfnMX26bCe7FUAiS/oyQtpMPpHq+RoPN4lEAe2YJkPh5ZPmsJzSrIFvs0y2OBHS7lMhKlOEbBlwSM59dbDbFSK9IJLJmiFzb08yTji2OcwFkIr/k/lwj4M39sui4Xo4OkI81axZqGkimwZxfeFSfoQWFCA2OH4+UhlbYFUTtGtGKljVaG6gr4gsoEyflkG8fpWBkNr2aW4RtoPj/iHV/lkUrdZIEdG5WqJiESgZMIF6zDgfq5uErtiBT9TMSNs0KrqxXyAO9VhEExNbGMGJb1ODP+qboNwCHlSKRXOy3mbWC4AxTXqlhasXPFgTbcD87ZqRIqrDFRCqrEeCl1pWyaXQv/20bH03F5d2kkDCAYKp8Jd5Ad/d0wf5vxnnaRUpoYhf5TspHLS+omrk9zdxvqoCfVicjQIaPZCRdL2ivvjkz7zeCdOL+BzyQVlm9rFfwtCSy1NQXNCq57An7FXa3BiyFBtdVgYi2ph33WQHmegPcBhGAQ57Bdlh0TEhMKvSv1m1AdAaSxNh1kcrv+2vYYqSwWxnSjJH5oIeIUOreznFa9b9QQcCR5uSe7yCp+BfPx9k69dglmfLMey6uzJL9vjaHxpUeqX2yo5dbU6WIZTzNEjkm8LQmpy5jMRGzdNm5WCvFOBcaFj/+gRZZU9qzoTS1y4f+LKN52GsON5dCdxzDWwgE2OjN41QyjnQdIscHWHcGgsV0hufTKEkq94/r06o+LgeJg9oKAvAH6v8rxeC8NXwbjLnSINSFlmAPFAwZ5Gmy11Wau4G7X llEdYvvI I1Z++IJ8hSHtUg74Yi2H4++rW912fprEAAQpe12Pqgy2E2AbQ+UqwRIkza8XKTIWXhwrN1X1o9TYKog7O7Zx5fUOrs5mr9Dc/Sm4U2EGbVp1VwYRPJ4YosxA/HsHbH3e4Sfgadx0yTZwEzG6FA0c04e3t8UrZjbI+VDQj6uzbsirn5kg1Qyezdv9f386UC865mE9+T4LJY7Q7aCT7md7dcnu9lSOP6vOTKQtueXA5rM7lrLe4CMeG8DEANORtRcYAT1J18fFw4e6Xo1hS1h2CeOnW8bqA9oNpMapQt65dqDv2gqNNUYj0dIqzyaPrx1Pnwc0Dhj8vk2yJnQGfbObWFfaVvckJdFyhQ4mDYaMA14CK1fNbRDQw4xrnzSQCB8bB5EAqdNP+eL/C/72hZv5pM5WEjuLw0XDHmwsOTd+wzrHpHIHErvyYQwtD73qPk/52B9SgpnaNVUVLOpqFJNcfhleX9nvEArLGYBWUQ5/zZQhI2uk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 27, 2024 at 11:41=E2=80=AFAM Namhyung Kim = wrote: > > +__bpf_kfunc struct kmem_cache *bpf_get_kmem_cache(u64 addr) > +{ > + struct slab *slab; > + > + slab =3D virt_to_slab((void *)(long)addr); > + return slab ? slab->slab_cache : NULL; > +} I think this needs more safety guards on 'addr'. It needs to check the valid range of 'addr' before doing virt_to_slab.