From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2FBDC5475B for ; Mon, 11 Mar 2024 22:44:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 342B76B0146; Mon, 11 Mar 2024 18:44:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F3FC6B0147; Mon, 11 Mar 2024 18:44:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BABC6B0148; Mon, 11 Mar 2024 18:44:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0CC826B0146 for ; Mon, 11 Mar 2024 18:44:46 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DF369120AEC for ; Mon, 11 Mar 2024 22:44:45 +0000 (UTC) X-FDA: 81886239330.04.C1EF5B6 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by imf08.hostedemail.com (Postfix) with ESMTP id 12023160010 for ; Mon, 11 Mar 2024 22:44:43 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ROD03CLm; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710197084; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cR2TwJcY4BxdmMnFQfZQdWddRgehusymX0Fv4xNTSsA=; b=EGXChehquNJR5G1fM2A1q14q+SyAf8VS9qpkP71Nd0JgXuoHJ5TiQZp5CoBlnBvVaf38C+ miQZVxm1psXF4Wd9Axg5IEu6X50AD2+80vsOZjtxC2QIpYA0S+fUsr0M/Ag9yzJDoNNnD5 RY+Ce0P8TvH9NqYAK+4W49wTWpWKUQU= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ROD03CLm; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710197084; a=rsa-sha256; cv=none; b=uIo4aNJhtvKMmVaiRquj+/D1Y5tm5Z2n3xgOy3IU4hnuJzGtcIvhSvZJxK76ZScEA/k7dx P9OGlO4/u94BAgg7PL4M+5NT2SaR9ePsuT4AZDnIWVy04VPXwmWVLQ+83J2bjsBsJVDMKL RQCLLNYRalZczV7m/jpET/BnwzvLuhM= Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4132ab0c302so10348605e9.3 for ; Mon, 11 Mar 2024 15:44:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710197082; x=1710801882; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cR2TwJcY4BxdmMnFQfZQdWddRgehusymX0Fv4xNTSsA=; b=ROD03CLmu8vXrC7YWjj/i0ZYOXi0BKpsO3cVLXkd5IN3495V1LR/i2UVyCB9tfneB8 fhKJFtqdjkyShVKhEFHx/lpIMmVRdbGh+KOPtrGBrVc1pxY7OrhKIeH/zd+c3GPfzdXL eY9vc9FAYAfVuueyU7pPGpGncm9t4mgumpYQv+S2Y0ewCzIreNemaFyBii0sp73PzXoE Vj2oAOdKUjCGSuZNTBNaAhM3CS85y8Mj1EiS2sok831WnSxvoyIwRqM58ckxeI37Smtw hK4wlZZZWOo3iabWqr59XcQL3HLebj27OsoRs0/YBbHNBsQ+KcJkAZD+dC5FB5JAmFro 0H9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710197082; x=1710801882; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cR2TwJcY4BxdmMnFQfZQdWddRgehusymX0Fv4xNTSsA=; b=ADlgkWCTvy0YXu9Ve5beeWJbHuSJ01x8IQhB0utzyodlMHibYlh6JkEV9ILLwcP4QO Py4Mqbe86Eo89oOdaAQkOdJDE7pRwEfsi/GEm91oHzipqvzatO7mwH2KWu21lPvYyTqB wfG8WuZDPN9PnqcR4v6dfn8+hrZm0Cy3DqubtmJtTJAZjcuQG8/DfNuYDbRKD8Bsj8Hf MHvR0Bj+3JqHQOc1JDvEd5RuvMwaFZ2riZEXIRACB0IDOsWqpQgTOW0ETc63CPFGj+6l X7RwripkeOJqPus45JGp6s9KZ7bTuCtdKal34cHM7Xa1ejnZNU+GB+Uj5xFD2/OFLQtI NnFw== X-Forwarded-Encrypted: i=1; AJvYcCXKyoL6yOMfowPwBgyzWI6Hc/OcecgFAS42SQ68nM/hdqgSp7Je7Y/mYDTVHATTRsnC50rvHTem0qde7OpcPL0N6OE= X-Gm-Message-State: AOJu0Yw4qxOo4Nfko2WYBLpY78YCc0tlsIwZrQBNEDW++KYgdvrD/TU3 1KP3vlpniGJ6C1bgAuQZAtfbj/PFSSlPre5pb1xxoHFCaj4JrXxnIVwT9gFlapUUPiKsaJ1c3y4 3tTw0v/NsDYvwKXVoFfllazQDfiw= X-Google-Smtp-Source: AGHT+IEP7fIKzFYFMsCLyjd667drldv7jiKoX2qbqYzPhgwtmhy9VZgqM25FnLaTIdw/xo1Bfnir3dxCXrReZRjKeHQ= X-Received: by 2002:a05:600c:c14:b0:413:2cbe:2398 with SMTP id fm20-20020a05600c0c1400b004132cbe2398mr2234983wmb.1.1710197082410; Mon, 11 Mar 2024 15:44:42 -0700 (PDT) MIME-Version: 1.0 References: <20240308010812.89848-1-alexei.starovoitov@gmail.com> <20240308010812.89848-4-alexei.starovoitov@gmail.com> In-Reply-To: From: Alexei Starovoitov Date: Mon, 11 Mar 2024 15:44:31 -0700 Message-ID: Subject: Re: [PATCH v3 bpf-next 03/14] bpf: Add x86-64 JIT support for PROBE_MEM32 pseudo instructions. To: Andrii Nakryiko Cc: bpf , Daniel Borkmann , Andrii Nakryiko , Linus Torvalds , Barret Rhoden , Johannes Weiner , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , linux-mm , Kernel Team Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 12023160010 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: gx7t5mki1x9td5eyig4e98exadf5wdwa X-HE-Tag: 1710197083-879830 X-HE-Meta: U2FsdGVkX19xcbDAnM/gFheXxd6vTy4NTVky0oUfZ795nKD3eDR+H1SjwsTACAEh3a9itJpikQO3ZkZ3Mxy9QyquF6LTCcM0yM3quaXoz8lg2M62nUTS9b0xlR/u9IWvo4+kiPWcK3ohEZHwfGQukzvHMsMTz0haNVamNHIqOPbRGyhmvffO8yWbgryWfDe4AQJGUz7SN6ivFflo3u2ZzlmiRTclmRguDyLqjFD0e2bDzqvTbhXGUBITDiKmblpujApBUGxCJtN7Zl2ZKib93P/aE7jr9fqIZM2qmGfq1fPJbVbPZDYhQJevKD8HgErOduPqnmxukad0TbfK/QUXGKi8bxpfm0h7uCfSz1tX++TrJIzyF8mdMWj6+kgUrZynhbNI4vKDz43j10tCv60czcd8XbYhk5XuPObASnjsbKH/woBjuDsRfbH9x+LYhoWVZ1UqgkS33Qiz/NEKEdikiTaNWrT1F5diCiQn1QQzpPONtR0fqjs3hTgVJkcSxzO/rzD12toeR68jfJWxYOeQSH8MTNclXCfMhNgLY4dyY6+TP5kiTh6JOlN1inKFJRh46SGPRQrWsxrKpjazxPpdRTKHqAE4vynzk2gBr7PvquA+QIz3P2Lu/4An+5sW/CRKP5u3NOP0fKGy2Ofa9Dnvx+ybw5UdZJLXvkcF7NTVnlEo4O2fKCX7n7ZPsPNCJ+CERi8K/jXN33L9cepsIeN2YtB2vvg/ActEW3XpqljiqzuY0NO+ZmWECtNSsU4x4rZV1Gr9+atwDRFciDJpqJBLMhQbyjy7CH0yoZGgBx2H3Jng+YFt0bevd2OvbwGrAMRng4jryp+LpvR/JXwFeEcICW3kHRNHmlU7wgy/CZaroBXN8+6478D5v+xf5TvPPXXaa13wfs2Ysw/PUxxgRwCoPqlTbmjnaTSUIsdxOJ1cpWi9q5SpHXd/HPrz5xO+PjPjlBOAJ1b1W35kwqAICUC Xgvqw2bj TgB73LaeZx/8KROz469fAGeMZ9uDrYcUKYgYRhaUlIT+0oAhtZOnNACuStAhiAw1iwqV0O3bbw23ZrNSzxKuVRJDuKSOh6jRm8RGSl4WFNR5eLd8WvFhcMSWCZj5WJhMMPelQTL3mrhASSSM+NhRRmCY7wfTFFf6PqgTaW5X87EVqZ3pzCKNxgO4Ady/We+2baSd2YC16CuTMjsh3h3H9ZwKMbjA11xDVHDZCimp60Rd96vkQcHAOizIYl2rewXZzDjf/+1f8EDicbhc1QhIH27P9l+dnlVV/Dkh3rZGSDVqttpPUirJEgWWL8DGSna8wqEGlPuOMigFa0kRs/WRoPYsbQ7yhewgFUdSI+i6KAqaMidDBMldjR0Y0uOr5Wa3CNKpJTXzdDCFQo4ORzWYTbUyauCxdACh6lwRJVJ96AySxsVIw1sHD+vbug6ia2YShqbgWu2lbDqSIo6HmYUb5k/F+zYhpSNZ3oV+jxNnvhpZWVKnKCLC4fqH8dfNkjbvgN87oqgoMaunE68E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.019517, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 11, 2024 at 3:06=E2=80=AFPM Andrii Nakryiko wrote: > > > > + arena_vm_start =3D bpf_arena_get_kern_vm_start(bpf_prog->aux->a= rena); > > and I'm guessing here you didn't want that check... I'd probably go > with explicit pointer checks, but ok, it's fine It's not only here. I expect all JITs will be calling it and explicit NULL check will be replicated. Hence I went with a NULL check inside that helper. Another reason is: __weak u64 bpf_arena_get_*() { return 0; } So simple code overall.