From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FF5FD0EE20 for ; Fri, 11 Oct 2024 18:44:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89CE26B00AD; Fri, 11 Oct 2024 14:44:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 84D4D6B00AE; Fri, 11 Oct 2024 14:44:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73BED6B00B1; Fri, 11 Oct 2024 14:44:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 596226B00AD for ; Fri, 11 Oct 2024 14:44:41 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9696AACA9F for ; Fri, 11 Oct 2024 18:44:31 +0000 (UTC) X-FDA: 82662197478.23.3410F2A Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by imf17.hostedemail.com (Postfix) with ESMTP id CD3AE40015 for ; Fri, 11 Oct 2024 18:44:36 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=D2zGz0VR; spf=pass (imf17.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728672095; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kJlY7D92eFxnBPuC/RCxAbsE1oWiZkxuTjE/D/iB8UE=; b=VS/wOarfHKnspSitnY5vp9Un40Oy6d9vLg2VMF3ozXlDqwk8kmXeXwptdfn8GHnsZTupNh lwtGOU1mU++k3BUDxEdCcRdBkrsoGe3nJ1+JC1C1dPeNm3fiCKSIxP4uvK8LgotMcfU/oe ft9nOBDjBS81Hoz7oZn+DU0sBYA8Zh4= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=D2zGz0VR; spf=pass (imf17.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728672095; a=rsa-sha256; cv=none; b=Arg+UIuVPm5O0XXI4mdtjOQyI32CpOdDPbfsKwGKmpiLIFDxGv16tJTJSApr/JY8ttQqOT NE7PBjXeAWNDT6TDcQkfdcqB+WhmF+tR5SQNMlLlNEfS+SJihejQg/ehEEljXzv2uSkPIW SU4hkICa+sb5VBx9FsFv/LTo1T9/INY= Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-37d5aedd177so514000f8f.1 for ; Fri, 11 Oct 2024 11:44:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728672278; x=1729277078; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kJlY7D92eFxnBPuC/RCxAbsE1oWiZkxuTjE/D/iB8UE=; b=D2zGz0VR5/jlM8bL3NZh1WEVeYZin4X/f7Bm81/vqh26qtHZrZyZJ/MdNaAl/He37T ONWtFXDhZGcntsEqlKa8XeCkPQ6MhW61w/kRigYwVX23QQwo6eeUV8n5BfCqH+S3Mn5v rMye759/2VZz0x9efHFC3W4JaCOhmufT+rQ/pWYgh3c0MwI28QACeuzf7DUV9B0IACUa XSMvIb9leneK4oj3XGiHaILKRRh0Se1K10CaTFbX04tnjqSTqV3TusPpUJ0yoqMCmTmj o0Ri6+fLNau6/cTu2PRcu2cMmZxjCkkDcYYemk4NbrRDtsbbTei3af7PBPQpN5EdAcrz BUpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728672278; x=1729277078; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kJlY7D92eFxnBPuC/RCxAbsE1oWiZkxuTjE/D/iB8UE=; b=ua3yR45lvK6eE8hd8SKhqfglE27Fqarr8VR8QZAS71GH3f3raKcplzEs7d+zZ3Zgk0 4PkwsEvFxEBT7Jq76HyTwiSylIECEpdPwiJvhss/XhaOYfcA03E4dRf7W/YkxkR4GIzy Ve1K9ZppATpl9Sg2M2fq7InbR40CGlX7pH+WZW6/JYBqkyj2wXpHDwDBxxXFBLhlGvjV mGBYDVwA3V5UkEd0lwl7tc6yJHUPS+v1xofOE2ZEPLHSzxaD2hj1gfyM3GrSUd7bRis7 n3+UMJAqMHNcVDAEYat0EuwM2eBAOpdt8YFZo/17p15I6Dv7h09r/eI9SKnhrJs5oDyB zKEQ== X-Forwarded-Encrypted: i=1; AJvYcCWdz4yGqy32p5unLLa+u03KTKnbtWqDc3oc3A5I746boTe9C33fGTCEV8JVK2+OBwMhKX3gFP3l8g==@kvack.org X-Gm-Message-State: AOJu0YwS+Ngg/HzaCs+s4vrb38T1MVYVihVnrBB66b/tVzpD296AWS0l DMhr1aI+9EjxLwb0AyApqQ7OWnajFF6fYrNVpks29HAC1X0/nXM3Wh4C9gHk+xCCJ6IPBOCQBIQ z82QbGJcWv8xthWemceBGF8f0VYg= X-Google-Smtp-Source: AGHT+IGer4tE3JXRYv/on6k/oAZwb6JtDpGBNPusLk2fluWmZ6+pw9WT94O2CzWTHs/krdveHa0QLGRLrJhVXgdYlzc= X-Received: by 2002:adf:f64f:0:b0:37d:49cc:cadc with SMTP id ffacd0b85a97d-37d551fc4e0mr2275480f8f.32.1728672277493; Fri, 11 Oct 2024 11:44:37 -0700 (PDT) MIME-Version: 1.0 References: <20241010232505.1339892-1-namhyung@kernel.org> <20241010232505.1339892-2-namhyung@kernel.org> In-Reply-To: <20241010232505.1339892-2-namhyung@kernel.org> From: Alexei Starovoitov Date: Fri, 11 Oct 2024 11:44:26 -0700 Message-ID: Subject: Re: [PATCH v5 bpf-next 1/3] bpf: Add kmem_cache iterator To: Namhyung Kim Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , LKML , bpf , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm , Arnaldo Carvalho de Melo , Kees Cook , "Paul E. McKenney" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: CD3AE40015 X-Stat-Signature: pcibba9emtry1ucf5pq9mm1mju3jzghc X-Rspam-User: X-HE-Tag: 1728672276-95756 X-HE-Meta: U2FsdGVkX1+r1kGgL1nmECzqA18Ydeps3ErZI042jrMK2EH59Ijb3iWoa99PnBaSTo3rKRO2RMmCFNpzYZb8GTOYlICZzo5nHakUi0y5FvF/WV/Axup1DMySwbXcDCpWeXgLXCuu1o9T2Ze/Nyyc50VoglcUSe50KyOAgwZ59wiDkAyy414Q+0aWaa1nDbWhNONy+bF9ududdXafe3dy4U250nbGUHN5N8w1FnfZ+kKb6oFR9eLbXUzzUy3mW/ElYg7vVOOxPuQjXRy9R+UE3feBAla7mDBSH4L+sMXXgZzK8qUaPLcL4gmRQDhzrx6bg12T1LOpS09pIi7N/7oFGHOXCK9eU/JoOY1oaYNSDq7GEgQ9gzUC3QFqg1lpxtbpu8CBy0VqgS+gE2IcG9V19jBNdfjn3WQVCw5/4ws0YvOUSq397K1Km3/4uIGBed0CTu1xtdzDX/1UjuifedTGIHbow9s4Pev7GZRJ3CgdiQ8VvgWteSC9zQIPEcl54Y/CwCnpQyycYcK0pDXN6vjtjldDnTxmFnRvlXMR56RQkaYcuir6KEf1to+c49iWya4C+zrZLFafkrBdBiTKSf279dUK+6p0Qwo6i2eOAuqZUDGDfPH1MiiWVxfDZRIsZBlgywXZkYrit5fLqFJQbepAsvY/CvgvPm9qq72eHw/UwNSzHbrw2VrY/pFuZmoc0kMeXsmCfL6N2WmlzAzTS+TyzhmqPAu/jan5rTz/4eyykrROwrpXenJC49vniF+PQeVfhGMZVZCSZoNMgzAM8j46BUyORtlhCLQqCNoeJjmJRDJ5TVpbfH+Ji7KTLT1JxjTsR5dSLBx5J069/1/KEA8iEqsDQ40jvm3blJ+mXIEo/FBLbtYDO+Dy9PjJCVaGO2Pr3CpkSIjVgni1+PjEGWjQdcv3pPYCIT//VjiuWcI4ZLygutkQdR71TmXuFdfHBFgB3Orkzm/SSpCt3vFhZNW oRYD379w kRvLfciv0OYQdd7magPfUJX2SpP3/lg0pngkD5jA8h8aOLS86yuWu9GIlenVP3iNWq1Y97Af4hYyebFxRbkucdUKNC7XPOPAC8nw9qSFlycn69lKPd3zNpw1McOBbmroz0rhDXKoByR0dBCYb6GbOGucK587se8ZKo1RpodLKXAn2dcu/oP6VZLLfIW58BCTF6pxwiJtPJztXdt7ZbkPYKc1BMh/hc2wHphFJb5zyT6Ymyc03zm9pj5SZpazYJsGgthJYCIwswDAnfuWX4GLIBDFqF4K6Ue7eSqmFiz+JW9NgtQIKbar+LnT4VqOaM0boWrSLIm+cv4Dsd8Fan2DaLDxqbYi/AWazbemZn5mWq1Y4yJsRh77ksIzQjEqbVCAXXO1HhTdMycjyUn7OLlYWDkrtt7VG4mLk9KtjLloQT3EQFHjWocg2Qk/bXLmR2+MiInF9PlLm2hV90V2uJAlZTVaG1IXSoaqdDQhfNgnoOAEtxF0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 10, 2024 at 4:25=E2=80=AFPM Namhyung Kim = wrote: > > +struct bpf_iter__kmem_cache { > + __bpf_md_ptr(struct bpf_iter_meta *, meta); > + __bpf_md_ptr(struct kmem_cache *, s); > +}; Just noticed this. Not your fault. You're copy pasting from bpf_iter__*. It looks like tech debt. Andrii, Song, do you remember why all iters are using this? __bpf_md_ptr() wrap was necessary in uapi/bpf.h, but this is kernel iters that go into vmlinux.h It should be fine to remove them all and progs wouldn't need to do the ugly dance of: #define bpf_iter__ksym bpf_iter__ksym___not_used #include "vmlinux.h" #undef bpf_iter__ksym