From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B47AC3ABC9 for ; Sat, 17 May 2025 00:25:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97B936B0082; Fri, 16 May 2025 20:25:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9031C6B0083; Fri, 16 May 2025 20:25:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77DA96B0085; Fri, 16 May 2025 20:25:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4F2FA6B0082 for ; Fri, 16 May 2025 20:25:12 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 75D5416048F for ; Sat, 17 May 2025 00:25:12 +0000 (UTC) X-FDA: 83450505264.25.89CAA07 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf09.hostedemail.com (Postfix) with ESMTP id BB99D14000E for ; Sat, 17 May 2025 00:25:10 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Z1Bj5DTV; spf=pass (imf09.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747441510; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4oOZcroL9pDTCrImg+h0BCJtERSmMeYUbJFw/m22M8A=; b=edV7BvdLNVZQXVUXYZR/HohkCwxt6RdYILi7ZKCIbS/zFvAngPWB/VNdJzOPHPPa0jLNxz 5JJM8aYtXcej9EaxYt5Mp9xkHoUUnNlv3hvnxSA7l/ox3+xtto5CeqGFcS0nOahRGYYHmU ulx6GRgmqp4UNJCDSWPju7wGYJPWFqk= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Z1Bj5DTV; spf=pass (imf09.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747441510; a=rsa-sha256; cv=none; b=NwcRohqk6obbKztaprpxlOuZc3Gv8PedF0K4l94oul0uBThcjfI9YvXz6ZwvczBZ0gcZmM gtGxxhM7n2d9BvvgYmIoJrStypSX5vVxyhDBpjTFZbrm73iH1uiQlIY+cBNHWzHpkTKfgn XwvRQ274+EjkU1uSqYwEwNi2RynneXU= Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-43cec5cd73bso17814465e9.3 for ; Fri, 16 May 2025 17:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747441509; x=1748046309; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4oOZcroL9pDTCrImg+h0BCJtERSmMeYUbJFw/m22M8A=; b=Z1Bj5DTVg8zcMHbY0nF8WjOEb01xsaskFAC88GRea0lJeokSPpexmcBI5JoxGGpVgV QTS3r9BtPqgkiAME1ZaAfweLUa4eNT/hrrK9ZRRfXKUDlDAEoRSZKBIWyCpHj5B+wfhA Z3Xo5PGSOCdv4rqgCfR1WIWuzk5OjGCr0LrySR0iYiCA7eYEgJVYXdHIjY5bdWDlETdJ uKL2zt/mRUSbx6hFpxo18ukSZ0nPLMRQd7urTgJ5oOainOtjYHkxhUpE2UVouJ661c/4 LgjH+NQquPTD9yqAKiStFboEVjetx85GItuW4XjSWYxt+N7jk/wWCAszCETMOTylkFxx T6GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747441509; x=1748046309; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4oOZcroL9pDTCrImg+h0BCJtERSmMeYUbJFw/m22M8A=; b=E+dLR0avSNSrrBNEQwjoaU8WQF/BwgjJTKy5du7orsRhue8QAaDzHZU8u2sNnFQCnK qEvSfEfCnllTwjJsQtR/QZATkAzO0M5rlyOJWA0DSnVdErkIOWNHWZtVmzN+thR+uxX4 rac+eAvsoQc/t7GDeLJF3O+mohwmifaOXyRqtLLbb3FioHKRKHb6RS833z5guw8Fwcno fGKwGuV+RILB6K48I6cKrwHhG1F4YC1VsNc+HRXEMlfXx77hX2NDJL2EiXxlVAIpxdjB /vgZco7En+T1Y2JloJY2Z6rCoD+5hrImjFM3IYs3nsAiDRR4aF0lUbd/QZhSHK6edDld 0ebA== X-Forwarded-Encrypted: i=1; AJvYcCVQVpD0JBREd+nzUbm+Fz7stG8tcHvagKgTlRuk0M1Z17waDhTCwBHSfKodw1enET7Ld+UUbj7NZw==@kvack.org X-Gm-Message-State: AOJu0YzfUq4x9lP9nNnzdgV2xP+3tB/bdUFVuMXimFjPhWT4wUyzfQvk js/BttUyLUJaErjEaeU35N44bIaXsFNMyaTn5tPoRyKEuBWde4jenlRuvH9UspOJ3LZyXoVA3wA QSp6+nDg9snoX+TzOhX+NHm1Vlv3I8rA= X-Gm-Gg: ASbGnct6jNp77YH4s6gPiSCEsLvnlbdQVnGUf52v8rhv5uaPZf5/TQGYPsRqWlve+7/ 9TwokX0YJAbh2VizaFy3f66YrW4L+Sb3Ha53bVlW0wVil2HcsQz5LR9URf2tocjSi/v30nbcEmH 0w/lMSQVO+p9u0mo4auENIP2PphBqKaJoBZXQjtTxBqa8dvxnH8+Peb6siUZvC5Q== X-Google-Smtp-Source: AGHT+IHDBDQOUrEVqoduv6ipIjFRPqEDCxoY3BbawJyJ71yHpe7/4KGFieaxXjUTK7EgTMViaD5tSlX97DWzKhg8ZUg= X-Received: by 2002:a05:6000:22c1:b0:3a2:35c:4474 with SMTP id ffacd0b85a97d-3a35c84d725mr5415633f8f.46.1747441508907; Fri, 16 May 2025 17:25:08 -0700 (PDT) MIME-Version: 1.0 References: <20250514184158.3471331-1-shakeel.butt@linux.dev> <20250514184158.3471331-2-shakeel.butt@linux.dev> <22f69e6e-7908-4e92-96ca-5c70d535c439@lucifer.local> In-Reply-To: <22f69e6e-7908-4e92-96ca-5c70d535c439@lucifer.local> From: Alexei Starovoitov Date: Fri, 16 May 2025 17:24:57 -0700 X-Gm-Features: AX0GCFt2-G58LKzfQ5yuhBPBvfaljiJP0swpn_ogR8ycZqKQVIHzNqom9pytzdk Message-ID: Subject: Re: [PATCH v2 1/7] memcg: memcg_rstat_updated re-entrant safe against irqs To: Lorenzo Stoakes Cc: Shakeel Butt , Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Vlastimil Babka , Alexei Starovoitov , Sebastian Andrzej Siewior , Harry Yoo , Yosry Ahmed , bpf , linux-mm , "open list:CONTROL GROUP (CGROUP)" , LKML , Meta kernel team Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam10 X-Stat-Signature: 3c3st5of7or94j5467cgodxrd7q6brmr X-Rspamd-Queue-Id: BB99D14000E X-Rspam-User: X-HE-Tag: 1747441510-26574 X-HE-Meta: U2FsdGVkX1+4tDWU5mNYQa3WurugT5uh7BmOqHdIzUJAFH63w3+l8cXe//xAeIYsinQhgPRe6Ipv+1jRc5zd6Wwqf4xxGj4mI25cQDE5uz9QoRzKt6Prp5laF3aO+G/XkqbwItoBTeg/hZSYIOM1ZaaHsA3RDtaFQlx90lpDrBEtfkOz/Ef0/q0kej/LDRd2GzQ4jrqG2voJOvV+Zqz4dCH3iwbNqnLDaQTksc0dF9L8mopdC+JM+Kav9HoXKnD/W/x9X8nqIJmylr6IuVl6B1w7P316QVW2uabQ8v7rioss/ewBqZ7YPaLleNyCYboQBJ05MqQEXnJGtqrD/ePRzPuAM/mPF+Tcuc4Fq+m729A2nyh8CXp56CzB6IVAF4x2wTGsyXj4VIWslEHfisF+EoesLGEjgQYx/EP+MBxZAWzFkoZrNhXzi0ZcpObk/gbW5TvchG60dsttLW1NmObslIX0Qt+W8/DNPgtrPjGflWiY8X98lBDkmJ7zivGIXZbI0VPPmAO+Ad6PRfrODaEUkP+03v/AjVxsD+k37yNy/lJsYEasnQxBoBdlMqYJR30jCh224mhaxr+uQTaFYghtIzCBLmIKpYJqe9z1LCzo2wp6xgs9YhARrQoxkrU9huTN0WE0z1v4yhCoKDc+YnNYrvHYNgGM4rq3NvNbbi6xc1RuMw2wqRrd9Biw77vfC1e2XWUf35YIS2Hwh0tzjfKnwT3Q8C4tx5YeDGXRPjRAKpXwmAdycstw/NEp0d7h9YQc4hLM9/1l5J80mnk945BCT8IrIpFdLyQcMUbYSW8eXNBY1orITs6m5otklFODkD2yJfxsvqZjwWju3bLOKHkY4dnRfSPXKxz7B86VuRJcrB5lGmtRoRrFOoL7nUbOwUyeOppXo3GzRDuCwZKkyy9SkzJxhAJpjOQY74KK8mUgBQUSElzpOWoSnzhpwi7Qz6W496hoKvL2APri8IdQtWG UHIWQc3W gO1CRWjJxiGYYrZrH+ein5g0Rujzkt+OKnM7zutC1qUbgM8it8ttgSpCF3w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 15, 2025 at 5:47=E2=80=AFAM Lorenzo Stoakes wrote: > > ----8<---- > From 28275e5d054506746d310cf5ebd1fafdb0881dba Mon Sep 17 00:00:00 2001 > From: Lorenzo Stoakes > Date: Thu, 15 May 2025 13:43:46 +0100 > Subject: [PATCH] fix > > Signed-off-by: Lorenzo Stoakes > --- > mm/memcontrol.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 2464a58fbf17..40fcc2259e5f 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -3697,7 +3697,8 @@ static void mem_cgroup_free(struct mem_cgroup *memc= g) > > static struct mem_cgroup *mem_cgroup_alloc(struct mem_cgroup *parent) > { > - struct memcg_vmstats_percpu *statc, __percpu *pstatc_pcpu; > + struct memcg_vmstats_percpu *statc; > + struct memcg_vmstats_percpu __percpu *pstatc_pcpu; > struct mem_cgroup *memcg; > int node, cpu; > int __maybe_unused i; > -- > 2.49.0 Tested-by: Alexei Starovoitov Andrew, Please pick up Lorenzo's fix into mm-new.