From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70812C5475B for ; Fri, 8 Mar 2024 16:33:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5ED46B03B9; Fri, 8 Mar 2024 11:33:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C0F926B03BA; Fri, 8 Mar 2024 11:33:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD6866B03BB; Fri, 8 Mar 2024 11:33:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9B54A6B03B9 for ; Fri, 8 Mar 2024 11:33:34 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 486F11A0C7C for ; Fri, 8 Mar 2024 16:33:34 +0000 (UTC) X-FDA: 81874417548.02.E958519 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by imf04.hostedemail.com (Postfix) with ESMTP id 5F5694002B for ; Fri, 8 Mar 2024 16:33:32 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PF7NnuhT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709915612; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DbgwgkAex3VYDxIBDZPuxNUeU8585DvkCZMxr6fhjg0=; b=AHhexAHHQfeXoItfUVuWQaQqsJI2qniueAFdwIJcvA6t1gNH9zDo/rd7cxOckFACCgtQbK EOOgCcixt3uK7OjcI3EjxLa4B3pK8cclXFBp1jE3/urfXSid85bggC4GZ15PdXVwEOmTMn BtQiFuG7lW5cMKQr4bkF/j+Swkwh9iw= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PF7NnuhT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709915612; a=rsa-sha256; cv=none; b=GchMA/K75mT+baUlwwaJsDYye7zjZvuMIkQjkvptnWv7F8s1XDws2EpE4gIGSt8xvL1nSL 77uiVQbghxnIypQDg+bhQFExZD34zB5JVg6+irQlXr0PGBJ+YHa0bntzPjCHrJcAAd7jn1 Ron8Ox+0QpqEXtZIZvvHLVyYEznJ5gQ= Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-33e5978fc1bso1094157f8f.3 for ; Fri, 08 Mar 2024 08:33:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709915611; x=1710520411; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DbgwgkAex3VYDxIBDZPuxNUeU8585DvkCZMxr6fhjg0=; b=PF7NnuhT1EiyGxc+Rojobm7/LmYZt6mJdZqRYrcG1EicFZLgqpXKrIZFypS9V4FwGK s9wmeDdXRPa3XMM/jj00H8L44T5gpde8Lm4Up0PCZmGtRe+K4nhe8Iaio2iZBALaXC/R yaDxQfwrarwNDMuIuSqMKr/CnRVxBXC01FyWPB0PZqBAr9fsoKNduPcRBbEXHRNX8cNl dhj2ZkxmRK24jRQvwd4ks+qlX4kWgIgzYAfLO1mr2uvpDVEeUv1pkn7QvbEwpmFhIhhX sA3J09xmiO0K/lYbc+DuZOVymoZ2R8GOtyrVEktaiArlAWJLCQaLAXvFOkGXvDAWbFDc o7Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709915611; x=1710520411; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DbgwgkAex3VYDxIBDZPuxNUeU8585DvkCZMxr6fhjg0=; b=dEOq8Elqfh3DFwqClvP6T/rXfJM6AUE1/Mwh3QuzaXPQc7xTY6aKPvfMMD8hbKKIU5 Hb57428zTx8XwjPhzLuFbBuHPbHL4uJl4Cd6g3/edvxculLu69WVGqd8gau9+aqB2joP t2U4HLP/MRfyh4oYjygNjSV1Gk8aGt6UHdx5MKhjaw8gOwgOvFcUOpJq5974JcQmBDip cfkoFl/jyip07qishcp7cG0w2Y8+zOrKJZxMb9LqAuRUInuSEdIul4IS0ra0xpjugxCw EB3rad9eF7/kpmCk/Qj06JwTMLmJunFjkzCCkCWsMmxzjJbOCsrw3yagKNQ5mMkoAZJC nNwg== X-Forwarded-Encrypted: i=1; AJvYcCXh7dxPSjw8aM8mw2CKwCkgAMly9KAVtKmWPs22qVOUHxZyQFo17rTSo558slQv7x1Ba6tpV213ianT8/q5/lXsL+A= X-Gm-Message-State: AOJu0Yy0jb04OiyoCx2zy/edC7tJl49/8ooASQkBeZTyNCVtYR7R7oDt cxc9WabGTj5xYpxQwZJAVqlLi1prC5CglCsorR5xXjqfr+q9aDeH/CQLvQ1jJNYYM9u98YGeeWL si4Gp3k7hieHBZ8J2ygheQpUvxFk= X-Google-Smtp-Source: AGHT+IHdxJaJ3BjN39OtK+VvOYPJJdb1YiSUT5r+TVfvi6+mlBgKf8nx4LtzsQUnK/CBhNNSbcZV6F417SAgTs8tOK0= X-Received: by 2002:adf:ca8a:0:b0:33d:9f58:8803 with SMTP id r10-20020adfca8a000000b0033d9f588803mr13484808wrh.18.1709915610478; Fri, 08 Mar 2024 08:33:30 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alexei Starovoitov Date: Fri, 8 Mar 2024 08:33:18 -0800 Message-ID: Subject: Re: vm_area at addr ffffffffc0800000 is not marked as VM_IOREMAP To: Christoph Hellwig Cc: Miguel Ojeda , Linus Torvalds , linux-mm , Andrew Morton , Catalin Marinas , Will Deacon , Linux ARM , Daniel Borkmann , bpf , Bjorn Helgaas , linux-pci@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5F5694002B X-Stat-Signature: ys7g5os6aij4umhzf8raoh91cfeodwjj X-HE-Tag: 1709915612-753484 X-HE-Meta: U2FsdGVkX1/TYS5XSHaWHi//qcIUigSJHMcBJMJsBdWgRTm1Vw40ZX4xor5QGKGz4IHo8xwWMXxY1yxzJdJuK3ElCQkWCIlMdNBsw1cV90pdv8784WxMI2EM+CmXJodg2wGGG8//21uYkP8aFpYaiSV7YpQ2aS/HbixRSFfI16jR38PFS8wYVHxmchlb/3zZOI74qOWyOmVXQcGk8On85v/DhC/kiBOKdXDX95+S4j7dTgcUvmJy1LaQT2r7DbX/lulCe73l3px5RklvLnuIZftqDxG0dzum882fjLe5HfUWlYKzXho060iwcKkulTo+YFFChWijRySsW3/qZIj4tHD9MERm8onNDPLGfD7Nlubu02FOAqd3GxzstvV0mQYQho+0caoMygOC1GR15lOd2sf0Tji5YA9+sP79oPb07c+JFfmB4EaQ7kOTYklF7IeNfgo6HxtE7vLD3S65ITO5mhzPwBwXn8UCMDGka711gddTV0MSwMgFmPXnyTJFBg52CaTYam0pWxYq/U+arG2Ku8xGVORvcQo8fMlvnLChhR7bR+Mq9/R/J1H6EGvCjZaBtAN9i2gDIa+YjAWsQzwWYYAEj9rDx0+JjqFGsMkwcFMx2LCz8pmhlG3Yf6BIBqnaytB5k9MgGPA067qsPoig3IARkCbFJ5xy2PYh0cy3kv7+5oLCxwHN0HJT+VhcGLr5TMlhdz5cTEmiP/6OWvesw51QjraH21ZTNOCJqIo76GU+RJECKjrP+S21tOxmxhVIw4h/ylLBSit+1RpsL+OJoNaLG01E9DPrTRbLWR1yCPJlCp8MOExN25M78H/7KFoE0nfKovU59KhcMzhvjfbDfRp/aCOziBaZ4rKWfGBZmpMKU3vKfl6lQoA4BcNx5jMXTIU6x88GP6lSIiCOOTh32+RcnDi23KzqPzwzB2Q9J2gLLV0AoNAVSDNF9Jy2WBL6m7wCVubiP35yTVLtjx+ Op/wNZvc 3pqnWEDwFEJZLa4bwFQpZUufol7tFnUY+0pfrUnvLn2NktaSm0JDR/udmSCOexqJSCsMG0hGdhjOnHcQ5VMaWNf1/h1JRY+o/cPNIyZGSIcJvfutJcZV/bD4y58N+UjlfckLyf6gLNJk6UOL8Lu085WgSTr1Dx+IzZf8oEuVLaO63WQ1wPyaaZwyhiZvAEQtjA2dBnUVpWoSUGj/2x5H1/NPpqjP3o+exmRmMj/x/XMyytcsb7mjZ0+hi4hNzPV2P1+rCxPb+RGpxkgoyfptfyxfndMBjeCGelZ4vX3s3Sn/YxFuYGWfvt+ZoasGTq+O//2t01UUz4jgGo+dKRYuvgzJmmSKWQO+3daRTnanXigJ9qrRaCu1aZ4HRqK1fhwldQIuDoJOk8+1T7TPj9YmLQWitmwML33+IjfQoEuduefOzN72e/mV8hZkc4192XxBhY3kU6sS5Z4UpudzH9HwwM+2D3y1/oW1jP8LJZ0epsBZcKGU4IGZw3sole4FftvD1n5AnkBtekenslHHUyGhTYmj2PwFRBCbXAfGXRKzupmdKpsh4P7AxasUu7AbUqLYl7ZHnGrnlRIiNtTc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 8, 2024 at 7:04=E2=80=AFAM Christoph Hellwig wrote: > > On Thu, Mar 07, 2024 at 07:49:16PM -0800, Alexei Starovoitov wrote: > > Ok. I think I figured it out. > > Please try the attached patch. > > I don't think this is the right thing. The probem is that > the PCI code shouldn't really be using ioremap_page_range if it is > not an ioremap area, but instead directly call into > vmap_range_noflush (or an added back vmap_range to avoid all the > duplication) similar to the vunmap case in vunmap_range. vmap_range_noflush() is static in mm/vmalloc.c There is vmap_pages_range_noflush() that is in mm/internal.h, but it needs pages instead of phys_addr_t. Newly introduced vm_area_map_pages() needs struct vm_struct *area and struct page **pages. In this PCI case there is no vm_struct and no pages. ioremap_page_range() is the only api that fits. afaict.