From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2ABCC54E58 for ; Tue, 26 Mar 2024 03:32:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D6E96B0089; Mon, 25 Mar 2024 23:32:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 439176B008A; Mon, 25 Mar 2024 23:32:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B2526B0092; Mon, 25 Mar 2024 23:32:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 157C76B0089 for ; Mon, 25 Mar 2024 23:32:57 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BFCCA1C071D for ; Tue, 26 Mar 2024 03:32:56 +0000 (UTC) X-FDA: 81937768752.15.2C2926B Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by imf27.hostedemail.com (Postfix) with ESMTP id E4F294000D for ; Tue, 26 Mar 2024 03:32:52 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HSO972mY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711423973; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lA5o6h754u6ODWqcXZI/yfZmhgXKlz5ceCEo4tpQucE=; b=O1Fy1aPZ75YILVUM096WREFrJVKjV4RMQenSJ6a3xrnU+Dq8Kfp7gPjU91J1kUcleoXkZl Ww3O0wfji053v7Z6Jxho6ss/bScGqVLS+TmjB1nINCO4Cy+UZ6D2DtKAOa+Zh7e4exmk/Z 8m+PlVHr+4bzjMcg/khO2hWM7eMcnYE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HSO972mY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711423973; a=rsa-sha256; cv=none; b=rtb/DLR0Eet6KFEiwfJJ9A/c17kEZRHZBa8+AgKqLxAUwuyNhSa5dyNbUjX63soRY+WX3/ RkR/G2jIKnPhkYeUjDBUw105Aavf7SF+/iTBPNAN22uoZ4fXOfOPPY2RsvyU9Ik7PN26BO NGQqrLNn65YGuGOVYcHiP5ao/QbEd6c= Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-341c9926f98so1435772f8f.1 for ; Mon, 25 Mar 2024 20:32:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711423971; x=1712028771; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lA5o6h754u6ODWqcXZI/yfZmhgXKlz5ceCEo4tpQucE=; b=HSO972mY9Caafa5sYIKo36i5GI4tf3y++Qqn1AbY7RHl88/f1LfURF2P65jHqb6dPF HbGDyv5t6xD82dirH1uijqJufcJjqLZIiYL2FrYJP/NpbG4JNzmdBf1/qF0Ig7GppulF el4ZfRMXVoUuSdYAx7EvmLgFOxmPj5YkFIXeuLO/lNLcWXdNFKlxTKYBeuS6/mNsGtJY zY6vZCRF73utInPO/71KExyQWAey89GLlOqRlV8lRe9zIZ+Qz22xX58YAOBpBb+ZChF3 wC0HnIgSxlQd1XV/8kQVujLnWd0d/rPKaDRCaDFY5Kph4NlshwLIZxY/Ueb8FBHlSZfh t3BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711423971; x=1712028771; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lA5o6h754u6ODWqcXZI/yfZmhgXKlz5ceCEo4tpQucE=; b=UjMIlcHAJCzENHXCxfUyfRSaCoXYj2IlpPlnrYtWwIn7AGA9+1IMob5Otudci7G62l bQr+0zid4g0qgbJhO3gYRvVACpegWNgEuTmTIIOvMyc5z5J/FOY43a6NbJnf3J0kwvHU gSUmRLFLHc5ykzsGPrG9mA4jSH42A2v8B3ztcwVRC0s901xXZmyBN/i1kagqAlDfEU9I OcYJwU7BWC2/11vTETTpsDgn1IHpEm2H65qz4LOkw/8QL5VrNl3ZGnpPGCqkJTi+G/DJ 7gBMWk/4KsEEthnbfMXtaIXxuW5DYpNe36jlSMkg6UeNk5PDZNvYchOZD/Vb89togsxO ROkA== X-Forwarded-Encrypted: i=1; AJvYcCV1GDZQ7ajzbSdfQTggg7fTtyBdHA9Q0o80L1J09j1OqscEAFWH344B4GtmOpHAM8wG8R5iTv84Wd9J7k5wZOFrgYI= X-Gm-Message-State: AOJu0Yz1Dsmb3rAHtlFEUkTayHSUjKAXJqL5Na8igMs/IA639aKtHhse 8PHC9tq1XqbURgrI6W2Id8V31KcHTordt6QHPVqNMrQCZRH9WKC6XVoHNt9WQM4gRceBXZeskmN +qZVNNTzJ9LIOPem5w6q/luKeK1U= X-Google-Smtp-Source: AGHT+IFQ9mbx3pz3lWDfK2p6wsj2aDG+6I6RjpqCge2Sd5poBB31E3vi/9DrtwhPj4IF4gJiiqaho8oQ5gTSaHJ4YJE= X-Received: by 2002:a05:6000:120d:b0:33e:a5e1:eccc with SMTP id e13-20020a056000120d00b0033ea5e1ecccmr5218777wrx.68.1711423971122; Mon, 25 Mar 2024 20:32:51 -0700 (PDT) MIME-Version: 1.0 References: <20240326021656.202649-1-rick.p.edgecombe@intel.com> <20240326021656.202649-3-rick.p.edgecombe@intel.com> In-Reply-To: <20240326021656.202649-3-rick.p.edgecombe@intel.com> From: Alexei Starovoitov Date: Mon, 25 Mar 2024 20:32:40 -0700 Message-ID: Subject: Re: [PATCH v4 02/14] mm: Switch mm->get_unmapped_area() to a flag To: Rick Edgecombe Cc: Liam.Howlett@oracle.com, Andrew Morton , Borislav Petkov , Mark Brown , Christophe Leroy , Dave Hansen , debug@rivosinc.com, "H. Peter Anvin" , Kees Cook , "Kirill A. Shutemov" , Andy Lutomirski , Ingo Molnar , Peter Zijlstra , Thomas Gleixner , X86 ML , LKML , linux-mm , linux-s390 , sparclinux@vger.kernel.org, linux-sgx@vger.kernel.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, Linux-Fsdevel , io-uring@vger.kernel.org, bpf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E4F294000D X-Stat-Signature: mwaauymriw8qrigfjeyj6bodq9pewrst X-HE-Tag: 1711423972-732775 X-HE-Meta: U2FsdGVkX1+MZuC0X6EdZVG2Q9khfS814jcuS0Z+wnK55C6NtkigB+DKiOXDhfUC0GNJZ22aKA9mVsxCQGYDdslnk0TFcBfuewaOOHWY14JCixjOhDNWB5oRL4L+XF+9s0HF64FTkoncmH3iCwIlmXzBB6ri7r/nHDndsTcmVN4/CK3HFRN32cmmRV5o96i6ex+4C4gu9s2YIWXtOLp/bQMFkxYIwyUv9Z2sSHRbHoBFKU2krgifcGpIkoGo0i2Tba8Ye4KjozaW3c5GG2Vp67npMoBp7wcaUNGvifN9WQ4gmQPACJeNJ0m/NnoqjVbItQKDgeHiRyqpa7IX6hHt76hISwOji2QsLIjbeYDKCZYKJFf9Gpy2QIE2x+MZN8JkUE/iZNWA0/LBENLb61U1/Hgodd1cpRgLlpEambj5X1xD5vg1ImeKbJhmtY9n4CMbkVKnvwYoSpI+pUUuvRamKQ8VF5OE9qVPSZ4kuTmOoAsVf4wBUROxwbRbwA8292Ddz8O+BOInj0gApDeWT0iRAvOA8vsVv9HgXkG1/1Jfr1bU3ohv8OfAndPV6r5w9yG4zMgXjjWpLt33c1T+FupJEHawnU2egdFjkGeR3S2D5bVQCWdzOWPag3RScHXDAO95s+EkFk6v9EN5OXlye6m3Jkdmu22R8CqHFaG4QHo2E3rNjLDd9Mq+pcCPFrzqAkJhqFTzaazKFExYxNGzh3bSr6Ungh4tnLPXHsdb3F05fXfhltJ9JriZSF9E34AMjomNh1JSRDCWRMJmRBsFEJmOLgeTZE0jHJQgmpCnh1GIxsQxg5HJ8Ps2rv8QS6RaVEu9M7DTDYUm75Pa/kzsqcYcGlgJU9Vf53Gyzh3V46n6gp7YTwEtgWtaRXA59iAAd1qvbNw5AfntIdfO+884T9qxM+v7XP4o2j1kPcEyL8+deYCwTgaftOUZljVt0DeTR0YsXRrfKswFi884IR7Ovhr nrBi23D2 gf6jGOSrj3/dkZLVf7pM9Ecc9GEXiNeWYSIWx4VcLsyu3Btz3iuXvrLicTvL8vBZz6o+DZGlyHJ6ew+pm4ewBixFjA0gb0pvFv7+umxCjTIXULMy6uVxpprn69bqnN1Xm5+9baT1YF2GuyJcr+EzeSFL6GPAuoa5AtW07zCW2MnD6FJBVkJX2I5A1QxdsjAGf7IoDp+v9C2+xQDcvDkvpqYzWaM1UNlsmyvm96vKseAxYbiSQjar9EVnuO+i93LmhFguQLIr9c2N448Eg4s+Z/eDBQ7/6GqZpE0h3GBzXsxlIkQGo6M0EzVwD9bKSnwCFEGrYN7K7ZH/UkzbReJA5WnWSCf29sQWPSrb1wBza043C25P8radPfaHe3zyPHCbE9P5s821dDimWPB+y+0xYHb795PsYJI5T5Wirpc+sK0c/jWPA3erRrV7IF/ozO1Ly1ZmOTSjj3C6CZaJlFSG5D1R3HhyjpKP5AkbosW4VeY818g94LAXtDZkYgMlfQlhGe7Ho/2AZTJqiuUs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 25, 2024 at 7:17=E2=80=AFPM Rick Edgecombe wrote: > > > diff --git a/mm/util.c b/mm/util.c > index 669397235787..8619d353a1aa 100644 > --- a/mm/util.c > +++ b/mm/util.c > @@ -469,17 +469,17 @@ void arch_pick_mmap_layout(struct mm_struct *mm, st= ruct rlimit *rlim_stack) > > if (mmap_is_legacy(rlim_stack)) { > mm->mmap_base =3D TASK_UNMAPPED_BASE + random_factor; > - mm->get_unmapped_area =3D arch_get_unmapped_area; > + clear_bit(MMF_TOPDOWN, &mm->flags); > } else { > mm->mmap_base =3D mmap_base(random_factor, rlim_stack); > - mm->get_unmapped_area =3D arch_get_unmapped_area_topdown; > + set_bit(MMF_TOPDOWN, &mm->flags); > } > } > #elif defined(CONFIG_MMU) && !defined(HAVE_ARCH_PICK_MMAP_LAYOUT) > void arch_pick_mmap_layout(struct mm_struct *mm, struct rlimit *rlim_sta= ck) > { > mm->mmap_base =3D TASK_UNMAPPED_BASE; > - mm->get_unmapped_area =3D arch_get_unmapped_area; > + clear_bit(MMF_TOPDOWN, &mm->flags); > } > #endif Makes sense to me. Acked-by: Alexei Starovoitov for the idea and for bpf bits.