* [PATCH bpf-next] mm/bpf_memcontrol: Add missing newline in pr_warn message
@ 2026-01-29 3:50 Hui Zhu
2026-01-30 2:32 ` Alexei Starovoitov
2026-01-30 17:44 ` Roman Gushchin
0 siblings, 2 replies; 3+ messages in thread
From: Hui Zhu @ 2026-01-29 3:50 UTC (permalink / raw)
To: Roman Gushchin, JP Kobryn, Shakeel Butt, Andrew Morton, bpf,
linux-mm, linux-kernel
Cc: Hui Zhu
From: Hui Zhu <zhuhui@kylinos.cn>
Add missing newline character at the end of pr_warn error message
in bpf_memcontrol_init() function. Kernel log messages should end
with a newline character for proper formatting in kernel logs.
This issue was pointed out in
https://github.com/kernel-patches/bpf/pull/10864#discussion_r2735018210
Signed-off-by: Hui Zhu <zhuhui@kylinos.cn>
---
mm/bpf_memcontrol.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mm/bpf_memcontrol.c b/mm/bpf_memcontrol.c
index 716df49d7647..20999a29820b 100644
--- a/mm/bpf_memcontrol.c
+++ b/mm/bpf_memcontrol.c
@@ -186,7 +186,8 @@ static int __init bpf_memcontrol_init(void)
err = register_btf_kfunc_id_set(BPF_PROG_TYPE_UNSPEC,
&bpf_memcontrol_kfunc_set);
if (err)
- pr_warn("error while registering bpf memcontrol kfuncs: %d", err);
+ pr_warn("error while registering bpf memcontrol kfuncs: %d\n",
+ err);
return err;
}
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH bpf-next] mm/bpf_memcontrol: Add missing newline in pr_warn message
2026-01-29 3:50 [PATCH bpf-next] mm/bpf_memcontrol: Add missing newline in pr_warn message Hui Zhu
@ 2026-01-30 2:32 ` Alexei Starovoitov
2026-01-30 17:44 ` Roman Gushchin
1 sibling, 0 replies; 3+ messages in thread
From: Alexei Starovoitov @ 2026-01-30 2:32 UTC (permalink / raw)
To: Hui Zhu
Cc: Roman Gushchin, JP Kobryn, Shakeel Butt, Andrew Morton, bpf,
linux-mm, LKML, Hui Zhu
On Wed, Jan 28, 2026 at 7:53 PM Hui Zhu <hui.zhu@linux.dev> wrote:
>
> From: Hui Zhu <zhuhui@kylinos.cn>
>
> Add missing newline character at the end of pr_warn error message
> in bpf_memcontrol_init() function. Kernel log messages should end
> with a newline character for proper formatting in kernel logs.
>
> This issue was pointed out in
> https://github.com/kernel-patches/bpf/pull/10864#discussion_r2735018210
Just spell it out that it was found by copilot.
pw-bot: cr
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next] mm/bpf_memcontrol: Add missing newline in pr_warn message
2026-01-29 3:50 [PATCH bpf-next] mm/bpf_memcontrol: Add missing newline in pr_warn message Hui Zhu
2026-01-30 2:32 ` Alexei Starovoitov
@ 2026-01-30 17:44 ` Roman Gushchin
1 sibling, 0 replies; 3+ messages in thread
From: Roman Gushchin @ 2026-01-30 17:44 UTC (permalink / raw)
To: Hui Zhu
Cc: JP Kobryn, Shakeel Butt, Andrew Morton, bpf, linux-mm,
linux-kernel, Hui Zhu
Hui Zhu <hui.zhu@linux.dev> writes:
> From: Hui Zhu <zhuhui@kylinos.cn>
>
> Add missing newline character at the end of pr_warn error message
> in bpf_memcontrol_init() function. Kernel log messages should end
> with a newline character for proper formatting in kernel logs.
>
> This issue was pointed out in
> https://github.com/kernel-patches/bpf/pull/10864#discussion_r2735018210
>
> Signed-off-by: Hui Zhu <zhuhui@kylinos.cn>
Acked-by: Roman Gushchin <roman.gushchin@linux.dev>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-30 17:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-29 3:50 [PATCH bpf-next] mm/bpf_memcontrol: Add missing newline in pr_warn message Hui Zhu
2026-01-30 2:32 ` Alexei Starovoitov
2026-01-30 17:44 ` Roman Gushchin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox