From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D666FC47077 for ; Thu, 11 Jan 2024 20:01:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A7626B00A1; Thu, 11 Jan 2024 15:01:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 58A236B00A2; Thu, 11 Jan 2024 15:01:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46D3E6B00A3; Thu, 11 Jan 2024 15:01:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 379916B00A1 for ; Thu, 11 Jan 2024 15:01:16 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 517B61C1464 for ; Thu, 11 Jan 2024 20:01:11 +0000 (UTC) X-FDA: 81668099142.05.8EDAD35 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by imf23.hostedemail.com (Postfix) with ESMTP id E6DFE140071 for ; Thu, 11 Jan 2024 20:01:03 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YWhl8C9E; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705003264; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HAL60ZiXYTrQWwc6XvTjBF7mU0s/R7MUfIaHS38evWw=; b=1WdGnT8C6VGNrfZ4VEP6xQqmoe8FVrpybXMp8XuVKDimojBObsBwzhNNl9FQoZKAUAMCTS BjabGvrOTFLjNqGHBhza2JwIFE2lFKvVxzaHdyOIYBy84+6psE+8gkHzJl6q0iu9sYGOqq 5GjSwjlur/J9BQZVh4YSrToc9K15rzM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YWhl8C9E; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705003264; a=rsa-sha256; cv=none; b=p5ElRnPP1bdFjA5XtgJlp47brLHImbDh2Pp7PmXFtAzkLTbpHlOTnb98Nge6biATUATAAB +A+0e4J3xz6PE8Y3qxyxLJh7O7KCIAwuQQGX3W/rsBz4Oaq5f3OuvfUVZKAA1d5I6aGo7Q +0t3eKRZTxhptEUNChL1/kquKOPrdHE= Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-40e60e135a7so8232455e9.0 for ; Thu, 11 Jan 2024 12:01:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705003262; x=1705608062; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HAL60ZiXYTrQWwc6XvTjBF7mU0s/R7MUfIaHS38evWw=; b=YWhl8C9EMtzxaeTIbkImKhkRyYA5tJDQ3aubGubtCxMaPOZYhX+YU2qS8R3fzSXYrB irWx4Arkft84ktlNAr37vKfo1Nxh+IQePhL7S0BRcGTumLcdywguT431ToQG8+HXU7Xh I7OheqcYmHS9KcExYQnhvi+fs4Re5Ssmsy+riPvOtoYBJDocTBab7thDUXqSGQ9groEv UcDVSaunprI+zo5zoAk0MV/QXla36dlHjiFx9b7EXIb36GdPdQ0U0C4TdPEGC87ADFAC 8AJzQ/fvj/7SC6T7m/09VCjgB5Yofv8zxNTb2IvKygGcpIEe1+T7Nz8OkgguEGLE7Kuc qWZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705003262; x=1705608062; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HAL60ZiXYTrQWwc6XvTjBF7mU0s/R7MUfIaHS38evWw=; b=dkuk0mZEY5yfJVKtP6xb68WohgfnXk7u/rjnBwMhB8W3VkYANoP5C0AsLvdN+ZpRv+ N9E4f+gbJ1E1HzFfHAz2mv910YQSLNy8nlbbljGLhESTzp8M8L3rrdMTsu3XJTLzBlJg bnCTFqMD5b3edBGgUXkFlYNAzd2EddK18sCFrrXdGfFG5G0k/fYmlsWGWGDvmjlFZWxf GlQKYeoZh4TTMwzN87gxJi64U5aQpweytrYijbPY6D9wxWfQEfBI5eY+Xs3WPrGhdMzQ tEa7CPl2zwIqnIPECkybEniTf3cfXPk00bTUaza8I87e9qVt8tLTRG0Pr28H+w+k5FCp cI0Q== X-Gm-Message-State: AOJu0Ywzv8PcVnDFpILh2fhXo40VaRlDc/9jkT3n6OU6Kbig3bzdkUMX gSdU3aEUJCo2+k/YrfTgEtIsyRYj6U2sD6Vpxd4= X-Google-Smtp-Source: AGHT+IEuD70YW9odmSJBW0ovp3CIEuHoCB7eupgpN0U69zefCCa6AEpsUHBsIEtkfYtc2dUZae2qy6ZzWQ5YfFTTiDA= X-Received: by 2002:a05:600c:6548:b0:40e:52a7:ac58 with SMTP id dn8-20020a05600c654800b0040e52a7ac58mr243439wmb.65.1705003261872; Thu, 11 Jan 2024 12:01:01 -0800 (PST) MIME-Version: 1.0 References: <20240109-update-llvm-links-v1-0-eb09b59db071@kernel.org> <20240109-update-llvm-links-v1-1-eb09b59db071@kernel.org> <6a655e9f-9878-4292-9d16-f988c4bdfc73@linux.dev> <20240111194001.GA3805856@dev-arch.thelio-3990X> In-Reply-To: <20240111194001.GA3805856@dev-arch.thelio-3990X> From: Alexei Starovoitov Date: Thu, 11 Jan 2024 12:00:50 -0800 Message-ID: Subject: Re: [PATCH 1/3] selftests/bpf: Update LLVM Phabricator links To: Nathan Chancellor Cc: Yonghong Song , Andrew Morton , clang-built-linux , patches@lists.linux.dev, linux-arm-kernel , LKML , ppc-dev , kvm@vger.kernel.org, linux-riscv , linux-trace-kernel@vger.kernel.org, linux-s390 , Linux Power Management , Linux Crypto Mailing List , linux-efi , amd-gfx list , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-arch , kasan-dev , linux-mm , bridge@lists.linux.dev, Network Development , LSM List , "open list:KERNEL SELFTEST FRAMEWORK" , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Mykola Lysenko , bpf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: E6DFE140071 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: oejs61yd41o1uxx4m3c3o6p9f4ju54su X-HE-Tag: 1705003263-294741 X-HE-Meta: U2FsdGVkX183Bnu7sewJZVW7vIW8ojhEcplOw7pU0MK06sTidulYlEEN6/izl6DD4aV2o8XD96FW0IwBZNHYaB5KQd9A3/hfcnsoB2XpmWyIphFo8OKtdVtxIFrAJdnYIznCAO9RATrhYkggu98ZdY+vSPP3qTssSXZjG3xwp+NcUTQbBTOjETv4hPHRxpy0yIAld7Cp1ZT3yrsVZ442aH+1YrYe7M2teS1MGSxlSEnxpmwrfpHb4O+ek3h9ykQayhb4sm8Lhgda20lbvT4eTOiPVyrIYZxpisBIEF2WMMhIObp4JzG90mylBDlMPpZXbPtEQem+njGpFUR5kEzNE64/zspeh3640dyv9bwz9qgBDLJyy5U+jg6dBKg1DtZ9Qht3gGlIhpGsk2bDrzCV3u+oAdEWMYNkoZ2u8BKJsk8ZqVTBMeKIoDg1pX0kk0Hm+VM+DL+zLwLuVSVz4UImIYCShVNf7kWMRz8vfqaZ4tzUdR1fsi4N65IjS+l0f+S8wMxFVfN53SPZ8l2HWw4lZ9YiIGTHltET5ZOaHj0WSdbKlIpEuLgZJsuOsOsMC8a/72QNNC90Oo3VkVACHvUIz7kQxTK8WCQpXIoLGRrRqO5yT6Wt2ymKBgHTno7oIXGxYwC8C5cBbT/BGR5qN3DJTDE78YVUynS+fn/EONc9ZBHBKzymLBVcvDTAIM9Yx/prIOkCF2l3NZ2qaJRIYPPhAgf55yNwwbY5gXOvSEI25Zefn5WE340sp/2XJn7TR8Goqf4fTxV4X7qI7FR8lYXnxXMg7oHUBna88SA8uYayu8vTnpaE9IXJD5ETiEAg7oifpusRCeX02FFCyIuFa/H7p4rmp6Oxjeo7SItOKSVVLJwTRxzfJRwhuNCYTa4x3H9VuOFXydLBntbFl7KkqfZaZUy86QI92f0YlieumGpZasVuBfdv/0YABKBTSUIPsfiPBpHThBp241ADGQ0Az+c fic5I6M1 GgswhnDCbzqi0eeshohyg52X8uk0RIdcYmUkwRHOb0CNm/AJnBJLxdeGpBpVSvY80lag3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001114, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 11, 2024 at 11:40=E2=80=AFAM Nathan Chancellor wrote: > > Hi Yonghong, > > On Wed, Jan 10, 2024 at 08:05:36PM -0800, Yonghong Song wrote: > > > > On 1/9/24 2:16 PM, Nathan Chancellor wrote: > > > reviews.llvm.org was LLVM's Phabricator instances for code review. It > > > has been abandoned in favor of GitHub pull requests. While the majori= ty > > > of links in the kernel sources still work because of the work Fangrui > > > has done turning the dynamic Phabricator instance into a static archi= ve, > > > there are some issues with that work, so preemptively convert all the > > > links in the kernel sources to point to the commit on GitHub. > > > > > > Most of the commits have the corresponding differential review link i= n > > > the commit message itself so there should not be any loss of fidelity= in > > > the relevant information. > > > > > > Additionally, fix a typo in the xdpwall.c print ("LLMV" -> "LLVM") wh= ile > > > in the area. > > > > > > Link: https://discourse.llvm.org/t/update-on-github-pull-requests/715= 40/172 > > > Signed-off-by: Nathan Chancellor > > > > Ack with one nit below. > > > > Acked-by: Yonghong Song > > > > > > @@ -304,6 +304,6 @@ from running test_progs will look like: > > > .. code-block:: console > > > - test_xdpwall:FAIL:Does LLVM have https://reviews.llvm.org/D109073?= unexpected error: -4007 > > > + test_xdpwall:FAIL:Does LLVM have https://github.com/llvm/llvm-proj= ect/commit/ea72b0319d7b0f0c2fcf41d121afa5d031b319d5? unexpected error: -400= 7 > > > -__ https://reviews.llvm.org/D109073 > > > +__ https://github.com/llvm/llvm-project/commit/ea72b0319d7b0f0c2fcf4= 1d121afa5d031b319d > > > > To be consistent with other links, could you add the missing last alnum= '5' to the above link? > > Thanks a lot for catching this and providing an ack. Andrew, could you > squash this update into selftests-bpf-update-llvm-phabricator-links.patch= ? Please send a new patch. We'd like to take all bpf patches through the bpf tree to avoid conflicts.