From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21F2CC4829E for ; Mon, 12 Feb 2024 18:23:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3D966B0081; Mon, 12 Feb 2024 13:23:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EDB36B0082; Mon, 12 Feb 2024 13:23:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B54C6B0083; Mon, 12 Feb 2024 13:23:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7C8AD6B0081 for ; Mon, 12 Feb 2024 13:23:54 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 50C6FA0930 for ; Mon, 12 Feb 2024 18:23:54 +0000 (UTC) X-FDA: 81783975588.03.A75902E Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by imf01.hostedemail.com (Postfix) with ESMTP id 7626240012 for ; Mon, 12 Feb 2024 18:23:52 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IGCdb58q; spf=pass (imf01.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707762232; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rOLcRqL4PWP5gx5t9V64UxQKQJUWLVYG/flknmF9Mus=; b=IigLcrbQJucaZiESEWishG9h3jkHgNpp5fBJ4ENRHPB9oqh5nvbxcNixQdvj8QxOgOstuv nyGuGK07dBrMT10EjFxquA5fBS/rrho/DQeLQgLe/YpmzQMiBA2DgwSbUgAB/qVAHscVFJ WEMnXdPiT7+U/4Tz8djBfvJKtzq5lZ8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707762232; a=rsa-sha256; cv=none; b=eWgWKt8ARfR0UBOARqPJWxd9QJQmgJebOqW3tkNh0UIdzCIYi+RDGe7ffSnRqS6cpNBndv LDrG+zWhAYG6E7UXBeeOEq7BJcsQg+9APcsrak6NZ8TeNWltV4871WTNJyMoyc8Ii9ujxU KwhNhaXcKmQ4g1HVRxS9CX96VZRQIa8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IGCdb58q; spf=pass (imf01.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-33b815b182fso881137f8f.3 for ; Mon, 12 Feb 2024 10:23:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707762231; x=1708367031; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rOLcRqL4PWP5gx5t9V64UxQKQJUWLVYG/flknmF9Mus=; b=IGCdb58qXPuv2cIxuiVSPx52N1gXv6OY5z0e0UhwBQUMtTVunBnkueu7Q03PyB3U4N /+47/9U89u76aMOz7nhpSTrOVAloiQHW9XdQWQiAieGH1m3yK7YsVAW5oKqILYtxFAN8 ng8p3rb18LcY140lvoPKqq1PkehFB0gunc+4tTeloEZpSxFZb/Kt/xSQsOwwLsFx8IAd diaUrhLXapFpdGyQX824h/p7XXH51aacIXQwgmpjUi5Q+aOVhtkIt1o/4Gb5g0WNVwJl oVxBEnpBpmfonhj1AGRHXNXQCIWs6azCLsamIMgzUdibTR7KNy5oRnKntf6njkEv0lh4 a2Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707762231; x=1708367031; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rOLcRqL4PWP5gx5t9V64UxQKQJUWLVYG/flknmF9Mus=; b=RFk1fSDGxO4os3vCqlMg9O1lK3/OHW06q7b9o6+75m/YRs8kqyW85A0UXAaQhd/OF8 xRtYYr05lsGVs3fSGyNymOyhTAGSGKeIxbfdtwAhh70GAl+VLVg3EYjZG9gmow/I7tUB ClMiUR/frvOejk6m0yNyG2JLcEDoPhd5xwcVwcdZsis8+f5s8+K7nQiem+h5WYuPXkmQ XZKggy5xihtcQ/qFqvjnc/PBXg+myume89DX+g9vRreAgzjRAe37Vr6iz0Y1Tm+IPRLH Kh9m28VpRRJnz9Latf6gDAmwQS6EnWEHQV8tpsXGRXdni2M5aA/v/9XKu+YNKfw28srk Dt6Q== X-Forwarded-Encrypted: i=1; AJvYcCUANrAOtRXhOIEauB9XQXNLXlF4DsEET7ztug7XZ/W/RREQfACO+l/hgrk1u/Mv2aQ97BcIsErYB5LYRWCZQGerR6I= X-Gm-Message-State: AOJu0Yxac6y1wPtF1F+XRiyNxZ2bSTSATnar7nWxsiHSc8b3CPSfFVG1 PcJqqL0kXOp6TQlqDitfqkzsudlSjLulXOa7mnb+AT7wCepAxB8gARqpIGOODgYG/vhQGVAL8bN i8UWpzlrfDBgRRvML9CTyU9nzBcw= X-Google-Smtp-Source: AGHT+IHM2kiH2B+Vz61Nscx+v9dwwpRLj4RZc73LknOKQi12kuv5pmc9W9ak75e4hQ/enHmOfvMF5hAAilnn4prauPY= X-Received: by 2002:a5d:4f85:0:b0:33b:14e8:c97d with SMTP id d5-20020a5d4f85000000b0033b14e8c97dmr5891367wru.48.1707762230837; Mon, 12 Feb 2024 10:23:50 -0800 (PST) MIME-Version: 1.0 References: <20240209040608.98927-1-alexei.starovoitov@gmail.com> <20240209040608.98927-6-alexei.starovoitov@gmail.com> <4ac1bea6-f1b0-4f9e-8b46-c181ce9413a9@google.com> In-Reply-To: <4ac1bea6-f1b0-4f9e-8b46-c181ce9413a9@google.com> From: Alexei Starovoitov Date: Mon, 12 Feb 2024 10:23:39 -0800 Message-ID: Subject: Re: [PATCH v2 bpf-next 05/20] bpf: Introduce bpf_arena. To: Barret Rhoden Cc: bpf , Daniel Borkmann , Andrii Nakryiko , Kumar Kartikeya Dwivedi , Eddy Z , Tejun Heo , Johannes Weiner , Lorenzo Stoakes , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , linux-mm , Kernel Team Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 7626240012 X-Rspam-User: X-Stat-Signature: ymwareak6iodcw5ergh96bh1i4pkqcrg X-Rspamd-Server: rspam03 X-HE-Tag: 1707762232-492968 X-HE-Meta: U2FsdGVkX18/FnHAwiRo24Q9EV/Whqfyr0Iv1eUopRcERlZSA8zZ1SCPySEKa/SchnEsH2NIvG9U9uQSIXPZrxe+vTQ5Rn8ZYbjAhfLodJiKe4mtTMm813pS0DSfetawAFw1J6K/pTsIP0NhvAJTFERGnF0Vm1/HA9OoUl1NImtM1kh8R2s9nbFqB5E6jd0/ec3DQ50sJgNtXqxQKY6nAUktKkL+JCGub99lm16uWRnpyVoKEy/fCtBKHUyI7euzudWxPuIJ+xuczfZEb40g5l2EVDiguB9xnSXZPWzfQElr+Sc1W5KDYL7m+XRPelfmv6y3d6o4sD2fFHbh0tLZT5KDwtvBCRKdvpQn9ZZULHPlZz2sexwEgJVwhbMyJjRISk76qMFuoves9zvkFRdV0enn/89P8SFaBlVTQ5W8WbwLxeAqe2pNcgkkVrAeRawFJDYZVe+J2yMkeJ137B0qiBJJM8sVWEd+Rshik3EYODrN97Nbxt10CNlIj00Rr122GCgDnmJ8fwZ1C8H4AXZFgxa01xQdJ5hT9qCICxAirU+axvRGDq3GXTQskAPxfloJeei48zOrEMVhPv0RHMUxdTZnqY/mGLQUCtdZaQqWH2rMBlFm5gsVhcRbc0+TuRrETTZGDr3qI3wc9SbWEk9lIjoOJtwEUz51ZE+xk3C/4H/bwMNDos3hJ0WhlpyktxWI78KFE6bT8/Fb7/X2oK/Jhf92XP37Grv6y+da7OG0gFMpjsnFsFJ++Ur2R4Ixs/Gn2aEs1dZJdXHD874/JvgdtXGkuTQzLoqxur9EeyQGE0KvdkE+A78SzY1e5ZF9dJC/VINScxFMNpzy5hPTtmORFGF7TjyHHzb/c7aH+KZN2rQZCN/gl9Tq7WrUmhYLVd6vUnDr216qupi0v2k07zw6Es0l8VEQS7YFafVlqsD7KRaJae0oWylmgw5mWyuvFn2NyYij2D/5YY6zt24n4UJ DmkhDbGv HDNa2PgUVnATddoPHnhGgF0r0JN9jfv+TptpKPBGqlGFqGungZPT/7ls6C53rOAMlk/c0B04jHh3IfwYs05IVfiwJYVAqMDTYHgEvStL/5cfdukGRAydMuMQHPQntofzh7zFY+1fMRWX0c4cRI50PChixWv9nxFld9F1i1G348xGoeUlNdDclIn/Elyb3Q+wmW1PHEFwlvXBmmQzEphbl9I8Mflgj3Wm8Le6v+cD4JGqsGTsRgTOet0JrrgeiyZg/qJdpZBGgdZbYKrkmSrVhtmv82oSgHHb4Wu/tDZO1vU4r7pyYKW/lPun68XNeHORTRFLd+WkV9Iw/9RsDVvf3rqFcKdNo8uHDO5xOTe0q2mKYGiDIMp4kW8XOFeEukUOGB45+5g8S1Jn1LEcRWcy4SP/CBIo5bLJgA96MNqxvDglTGgfiTBZOIVHGDzM+omJt6UWPfU4iQy5TE2l3OR3DDnK80uNp1U/tAhzeukwKydDeHKtrICh7QtuOC57UjwNB1oF0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 12, 2024 at 7:56=E2=80=AFAM Barret Rhoden wro= te: > > On 2/8/24 23:05, Alexei Starovoitov wrote: > > From: Alexei Starovoitov > > > > Introduce bpf_arena, which is a sparse shared memory region between the= bpf > > program and user space. > > > one last check - did you have a diff for the verifier to enforce > user_vm_{start,end} somewhere? didn't see it in the patchset, but also > highly likely that i just skimmed past it. =3D) Yes. It's in the patch 9: + if (!bpf_arena_get_user_vm_start(env->prog->aux->arena)) { + verbose(env, "arena's user address must be set via map_extra or mmap()\n"); + return -EINVAL; + } > Reviewed-by: Barret Rhoden Thanks a lot for thorough code reviews!