From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E057CC02180 for ; Thu, 16 Jan 2025 02:26:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DD406B0088; Wed, 15 Jan 2025 21:26:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 58E706B0089; Wed, 15 Jan 2025 21:26:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42E0D6B008A; Wed, 15 Jan 2025 21:26:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 252E06B0088 for ; Wed, 15 Jan 2025 21:26:14 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9290142F8D for ; Thu, 16 Jan 2025 02:26:13 +0000 (UTC) X-FDA: 83011725426.11.8399B3F Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by imf21.hostedemail.com (Postfix) with ESMTP id A4D6F1C0004 for ; Thu, 16 Jan 2025 02:26:11 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HLTHAvzf; spf=pass (imf21.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736994371; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yuDz3cqpq2JwZVFqTGS7uN/iiFiI7lTqmYWc56DBkkY=; b=iPZ8AjKJ7opLjaJoW0YO2Dsdtq7lfEnieFZSMD2BpVf0coUGoD7A1Ys/0+jEk3J7Ib9Zax hVmBrZ6tXse92JVy4aBjbMeUFVPKgaLc+gswqlSV9sSLCDBZVk788Fss0l86dOlBMohSPO hS35BBikieouJR5t1+Hh9WVDgoruGE8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736994371; a=rsa-sha256; cv=none; b=v6hiy7UT9jm4U2NNxzziHSOnAnYZScrAuh1T/nAdnVEDHlolvSKaxKAXM1BffahSwrPTN+ ak2kQ4iu9FAGg0IvLFO7zRRjU0BwLqVUciD5b1ZmFZtplomgZvr1KNryKBAnRlQdRVGyIf 10gYc77+bKAHIh+7QJQhVJJhIRD+Fg0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HLTHAvzf; spf=pass (imf21.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4364a37a1d7so3176495e9.3 for ; Wed, 15 Jan 2025 18:26:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736994370; x=1737599170; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yuDz3cqpq2JwZVFqTGS7uN/iiFiI7lTqmYWc56DBkkY=; b=HLTHAvzfOjqeGWdjsJ5cKfPiLBVlAT614vbG82SIpKr62GV4RaU2fKvB5ix/0+5URs nv0GZKBtknTsgwWFxwftA/QdoZmYj6m7lbMkmDgSf08Iv7nKxSwQHmbXNnBZFS3yr3tk w4CPLeXhm/sHRMpHGLjtlYHv+9espIEmCBGwD3Nz2/QRoSwpsfTqutKiJfhZ+5GiYAp2 7wmahR551C5BEqx8upIjc/kHCET6XW6+8bcLo6/qxBLlYveDmK9syfQiKwCj2pFW4siM dGstr6FZnt8n27ze4DcnYeCF2avCOWb+DtEM1toryAJISn3U0hc/si+wni80S7EUqqDE zBpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736994370; x=1737599170; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yuDz3cqpq2JwZVFqTGS7uN/iiFiI7lTqmYWc56DBkkY=; b=u8UeAcci6e1R2/TS6B515mFdt+f7Zc5fDX7G+vFlycoAnVthIvlGYXzPk5blkz6eW0 SeWbAdZvyf2p0FYKLwigLWKCAwMUHp+oE7mAaX+cRRo0h36lxY2XRADg9d+oSn2S1/Tm 3JXqhfyEOD3cquNQhmCYVqmSnHTw2yz2X2cY9ZIw/B9CbLG3CnilCN+kI5WzuuKGU2lp /81Ny0CJrE/PbuYjs8rZtbtknz51IgdUrr8HTtZbRYkf4L1ApQvMfz+2/xj0tafBTjbY ljinFxR6nsp70SV+oib3BF226q/CiKDiWeR6XzYhtpgAiwsP+pSZPKieyZUsGgm7dJEK TtIA== X-Forwarded-Encrypted: i=1; AJvYcCXGo56NimyODrhTGyu9aDvUTWjqhIJgiONlR4lmiKOCbkS5Of/ubZ3FA2cUlFem6sS+SqBMkvCg7w==@kvack.org X-Gm-Message-State: AOJu0YwHSuY6ePxnYdVaEMxV2+Ho+/I1a1AZ8Gs6lnuRzZYh855Qae5w xf1fH1Bb+Gwy48fAAsjpliHK4BtiVOQ6hkcpIHtLbns2RwNx/lXUzMJJ6hGR2wf7+zpiCRA9c/1 J/g2sdnaHxlO8ObOxvdqtX4NEBjY= X-Gm-Gg: ASbGncswUA1ZfibC6piWKvgyZuvfUCAW0dS+xVE+cRys44fy+10w/gqTgenh7n0cfTr PQ6MPSib+HiPsMgh3D2+3Yo3NzwOPLG6aNrGr9p0X2io4EkDosXQcUQ== X-Google-Smtp-Source: AGHT+IGH6xM/zfyALs2+uixuQYyWMWcPvMFUh5nV5Qea2Z4UuleMluZuXRFH7J4w1LDQOsbZbqQmqtZgFBXpe+5ooPY= X-Received: by 2002:a7b:c4c9:0:b0:436:f960:3428 with SMTP id 5b1f17b1804b1-436f96034b3mr153099105e9.29.1736994370093; Wed, 15 Jan 2025 18:26:10 -0800 (PST) MIME-Version: 1.0 References: <20250115021746.34691-1-alexei.starovoitov@gmail.com> <20250115021746.34691-8-alexei.starovoitov@gmail.com> <7418e422-ecd3-40c9-bf65-dd9b2fcebfa6@suse.cz> In-Reply-To: <7418e422-ecd3-40c9-bf65-dd9b2fcebfa6@suse.cz> From: Alexei Starovoitov Date: Wed, 15 Jan 2025 18:25:57 -0800 X-Gm-Features: AbW1kvbQOEX3Qz6gXFpg6QqzpKx8RcnbVv6I2lTLaS9ygpZ7hE19tTNbo6e89FI Message-ID: Subject: Re: [PATCH bpf-next v5 7/7] bpf: Use try_alloc_pages() to allocate pages for bpf needs. To: Vlastimil Babka Cc: bpf , Andrii Nakryiko , Kumar Kartikeya Dwivedi , Andrew Morton , Peter Zijlstra , Sebastian Sewior , Steven Rostedt , Hou Tao , Johannes Weiner , Shakeel Butt , Michal Hocko , Matthew Wilcox , Thomas Gleixner , Jann Horn , Tejun Heo , linux-mm , Kernel Team Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: wffe7ukc6eufgfk54n6q7nr9cdmkj7ku X-Rspam-User: X-Rspamd-Queue-Id: A4D6F1C0004 X-Rspamd-Server: rspam03 X-HE-Tag: 1736994371-495045 X-HE-Meta: U2FsdGVkX1/s+5Jgsq5lw13UNJL7hxoD9uiYIe9lDVZRwfX3uRqmY2dtZ4YR2kIuZ4vNWALOaMR904nq54EhbKwi0zn6yKy9WWENQxeqx3fTppxcFo3ekrBnrCsGfEBq5sQA0+yH6keRbbcmLNd+IewIBF+oU/zqyAVQrpD81/z3rhXjTcXHK8Q+PjyI5H5nQo0nkbyjn/vGkLeexjpBPUg3GRQONjunhtuvc9z4StL4iM8UzCWBB8iCBLJWZS1vNJt3CtTB4PSGn6mbzA3sEiYnIsiu3pXHfxx3miLozMyPLtnySylsB+DZkwwbh6H99lMGB28WApMRmwil7c4FYc7bCyXSLjve5hZmGcDZxjpKSASwRJcyEOztq6lK2gJT7PqmkN7Nn3vtJrXQf8ftn0fMRIOWtP6J3gVaXzF8hlBEE2mwLZbto1mBCqNVOyxm9tjBK9qiL7Z9r/CmYwfThpFFhCAsnIfY2J/kDCrxhLVskMzJZfE7X0sS+JDKlvkmePCHhr/Z3TkARhfdoL/TCUOixGPCwtDeJw4t4ZJfrSEZtxm99EacfyNrtq/5ZHCEwEnCKtstpJi++l7GZxsdfQWYxat0adAOjVK0h5CvJNv9XtpFhQq6ItPEjCkBj0HK8wo+NOl4d/303Sl9TnbTaFQW1s1rSwoct1XZvRtVYA0zRaVqjvFUbqwuKgwZYgVWFZ6yl7KwHhvrTb4QaaEBRJI5fo/BaaIwiYe/BPdf87oHn8Jne9I25nNjaY6AphSuHnQiw3yPhOXBhOUdCtPFc2O5zINLBq16+MG4iz1m5FkqD5e07AdDU7ODweR+ezCDRLa9jMguGhSE3iH1E5hFzeI+wj1BQicmWmzrGrqBh+yk1pjJ3AlbWqPkLQtf0oEJ7v/ACGYtpERCfNMXaLbfSIZk7Oqb3JBba1iSB2IQsWyzEWxENEw50HGNmqDRdwm+UrCERelK9g3YwVUWxJT 3lD0QyeB T0Oi/lG5axDNb29f5Rp4RAonOQh1yYywaUJgFP4xDAxrGBiFIB2V/E+z3wLRoUg01er4DRUwgAL0XUzJ8o6EcIhnuN5n99PkFTliz2j1lYv+rCu5oFAHkEJMarzNPMSaSVybYqHVrQLPEZIgUqWsKLENAC8/geip9PWWJFnTAiLj+CaPGpNTJLzoN5YNfxL3nIkp0B8HqIsVvqohlU2Gt2h/NF+9HBRFDzGgGQ0y1LEF0c6jTTsgpiEiCzWbzBA7GdCnVQ52KDoKmJ5QuwJ+JamadpPmUffUDmjtU+457t6LUSqkYV/P2nak/Bn8U2UG8obuZFDSd16b+ZepRoTCsC9iLSrrM9QOin6Gvr9vHbMWRfNnmdtOsO5USo4ENfYRNrlQzycXdmFSuNb62H6MN6opH//bfAvsB/GdxJMnampw5UJ8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 15, 2025 at 10:03=E2=80=AFAM Vlastimil Babka w= rote: > > On 1/15/25 03:17, Alexei Starovoitov wrote: > > From: Alexei Starovoitov > > > > Use try_alloc_pages() and free_pages_nolock() > > > > Signed-off-by: Alexei Starovoitov > > --- > > kernel/bpf/syscall.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c > > index 0daf098e3207..8bcf48e31a5a 100644 > > --- a/kernel/bpf/syscall.c > > +++ b/kernel/bpf/syscall.c > > @@ -582,14 +582,14 @@ int bpf_map_alloc_pages(const struct bpf_map *map= , gfp_t gfp, int nid, > > This makes the gfp parameter unused? And the callers are passing GFP_KERN= EL > anyway? Isn't try_alloc_pages() rather useful for some context that did n= ot > even try to allocate until now, but now it could? Correct. gfp arg is unused and currently it's only called from sleepable bpf kfunc with GFP_KERNEL. I have more patches on top that change all that: remove gfp argument, etc. Just didn't send them as part of this set, since it's all bpf internal stuff.