From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12DB6C4361B for ; Mon, 7 Dec 2020 22:44:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 66F9B239D4 for ; Mon, 7 Dec 2020 22:44:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66F9B239D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 809188D0002; Mon, 7 Dec 2020 17:44:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 794158D0001; Mon, 7 Dec 2020 17:44:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65B848D0002; Mon, 7 Dec 2020 17:44:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0040.hostedemail.com [216.40.44.40]) by kanga.kvack.org (Postfix) with ESMTP id 4B7208D0001 for ; Mon, 7 Dec 2020 17:44:36 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0B2301EE6 for ; Mon, 7 Dec 2020 22:44:36 +0000 (UTC) X-FDA: 77567966952.18.corn30_2107bbc273e2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id DCF84100EDBF6 for ; Mon, 7 Dec 2020 22:44:35 +0000 (UTC) X-HE-Tag: corn30_2107bbc273e2 X-Filterd-Recvd-Size: 6301 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Mon, 7 Dec 2020 22:44:35 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id q8so16817639ljc.12 for ; Mon, 07 Dec 2020 14:44:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=84NZyZiyC4OmRBVaSotinan5g5hCm7otD/hM6jLzgCE=; b=fsVrGztcKudL75OYLON1S5/amW5C1gnztHnfl2ajkJFdra0sd906St+Rg5dHEbJjv6 AdzdxrTy7vuBz1XF03Cpe7OTM8Q82YAnBwk7TWcyHGhBWMBc7iR4tBsypP57ydTs1BlK LC+d/DOZehBxwMMFn3A1hXSQF8DtRDVinDzabW9NeZHNveWxSdOCJmjL1bEuq2HyPq+z XuNr7u0Pt6uQKeVSHOkvWVyK4W/oqjxKoI/XwWTVNg8ZeQB3cRlsBISZMyNryUMbi/UF 1d4k8K097iroGBSjBJ4eK4Hz+9T/hI44cY+j6jW6ks/R4QHsPWQfil0zo03mZ7Psqcrd 0iaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=84NZyZiyC4OmRBVaSotinan5g5hCm7otD/hM6jLzgCE=; b=SNfLAZDPhLKsdjBD22WzyyRxl7Z1zdAYqvrB5LndI2Wm5SO6auxJnQXlP47Y03oWQP zia5EVQ0IhZClp9mN3mDK+4kdOUUeKd8ofE3tDz2q6fK1X/GVQP/u8JZo2Vwu5x05kyY cG8oHeco6OJKqb+0/g8KKiP1mPpclSNX6ZNkl9HI0++3HkxMsf5T3MF98rJ+/JlH+xe1 8dhS4FcD/dzYJmxiBc2jyeVv1doAWKJ5xnPnZN7MArLugYK7Ky5dy+q34jxvjEBvEFli QCqwiS+Dfekdxm3+OmVn/h8T4iveBd0PQ7Pn7GhZFSmJWbkMVpt4VnPiokYYANwlsLvr umMA== X-Gm-Message-State: AOAM530R6qxZlHmxzFrPXeC4P/YR8CgRw4MG2jxu+03clk6oBFqqd4EZ 6lERFHH+59zZ1fy/+R5OF1zk9ZKL8pva6VCuZj0= X-Google-Smtp-Source: ABdhPJx8I+D+uIgDpHwXbmfqMnBD3T9/NjWmEqKW6qsR4llivZuoaMfVvsqeEJhx5xCEOIwaaIDRq6POv7SrKW1v5iU= X-Received: by 2002:a2e:8891:: with SMTP id k17mr9048437lji.290.1607381073733; Mon, 07 Dec 2020 14:44:33 -0800 (PST) MIME-Version: 1.0 References: <1604661895-5495-1-git-send-email-alex.shi@linux.alibaba.com> <20201110115037.f6a53faec8d65782ab65d8b4@linux-foundation.org> <20201207081556.pwxmhgdxayzbofpi@lion.mk-sys.cz> In-Reply-To: From: Alexei Starovoitov Date: Mon, 7 Dec 2020 14:44:22 -0800 Message-ID: Subject: Re: [PATCH] mm/filemap: add static for function __add_to_page_cache_locked To: Justin Forbes , bpf Cc: Michal Kubecek , Alex Shi , Andrew Morton , Souptick Joarder , Linux-MM , LKML , Alexei Starovoitov , Daniel Borkmann , Josef Bacik Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 7, 2020 at 10:36 AM Justin Forbes wrote: > > On Mon, Dec 7, 2020 at 2:16 AM Michal Kubecek wrote: > > > > On Thu, Nov 12, 2020 at 08:18:57AM +0800, Alex Shi wrote: > > > > > > > > > =E5=9C=A8 2020/11/11 =E4=B8=8A=E5=8D=883:50, Andrew Morton =E5=86=99= =E9=81=93: > > > > On Tue, 10 Nov 2020 08:39:24 +0530 Souptick Joarder wrote: > > > > > > > >> On Fri, Nov 6, 2020 at 4:55 PM Alex Shi wrote: > > > >>> > > > >>> Otherwise it cause gcc warning: > > > >>> ^~~~~~~~~~~~~~~ > > > >>> ../mm/filemap.c:830:14: warning: no previous prototype for > > > >>> =E2=80=98__add_to_page_cache_locked=E2=80=99 [-Wmissing-prototype= s] > > > >>> noinline int __add_to_page_cache_locked(struct page *page, > > > >>> ^~~~~~~~~~~~~~~~~~~~~~~~~~ > > > >> > > > >> Is CONFIG_DEBUG_INFO_BTF enabled in your .config ? > > > > > > > > hm, yes. > > > > > > When the config enabled, compiling looks good untill pahole tool > > > used to get BTF info, but I still failed on a right version pahole > > > > 1.16. Sorry. > > > > > > > > > > >>> > > > >>> Signed-off-by: Alex Shi > > > >>> Cc: Andrew Morton > > > >>> Cc: linux-mm@kvack.org > > > >>> Cc: linux-kernel@vger.kernel.org > > > >>> --- > > > >>> mm/filemap.c | 2 +- > > > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > > > >>> > > > >>> diff --git a/mm/filemap.c b/mm/filemap.c > > > >>> index d90614f501da..249cf489f5df 100644 > > > >>> --- a/mm/filemap.c > > > >>> +++ b/mm/filemap.c > > > >>> @@ -827,7 +827,7 @@ int replace_page_cache_page(struct page *old,= struct page *new, gfp_t gfp_mask) > > > >>> } > > > >>> EXPORT_SYMBOL_GPL(replace_page_cache_page); > > > >>> > > > >>> -noinline int __add_to_page_cache_locked(struct page *page, > > > >>> +static noinline int __add_to_page_cache_locked(struct page *page= , > > > >>> struct address_space *map= ping, > > > >>> pgoff_t offset, gfp_t gfp= , > > > >>> void **shadowp) > > > > > > > > It's unclear to me whether BTF_ID() requires that the target symbol= be > > > > non-static. It doesn't actually reference the symbol: > > > > > > > > #define BTF_ID(prefix, name) \ > > > > __BTF_ID(__ID(__BTF_ID__##prefix##__##name##__)) > > > > > > > > > > The above usage make me thought BTF don't require the symbol, though > > > the symbol still exist in vmlinux with 'static'. > > > > > > So any comments of this, Alexei? Sorry. I've completely missed this thread. Now I have a hard time finding context in archives. If I understood what's going on the removal of "static" cases issues? Yes. That's expected. noinline alone is not enough to work reliably.