From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02E1AE77183 for ; Wed, 18 Dec 2024 06:37:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C7F56B009D; Wed, 18 Dec 2024 01:37:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8771D6B009E; Wed, 18 Dec 2024 01:37:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73EBA6B009F; Wed, 18 Dec 2024 01:37:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 56CFB6B009D for ; Wed, 18 Dec 2024 01:37:46 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 12F6EAF619 for ; Wed, 18 Dec 2024 06:37:46 +0000 (UTC) X-FDA: 82907121864.17.C8CD778 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by imf30.hostedemail.com (Postfix) with ESMTP id 1BC8480009 for ; Wed, 18 Dec 2024 06:36:43 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="f/Yt20uX"; spf=pass (imf30.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734503840; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t8Mk3izOcHmuKvHbpqkUDiWbVNW0WzoRhTWnOD8p5lk=; b=uNrqnZhnzW8jaUDU80bZGmKrXjomFnARMH2ch5YyyqL+G596ua63Ezics3LI8+8YfBEdWc 0PSp98tP/2D8tiRFlGC8fd+bIh0a1LR91UC3zyabY0aEg1K5hd/24SEboqKZnfRuW+Czll NB+cuPXez3kzO/ywiRCeKdCHSlOJMv4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="f/Yt20uX"; spf=pass (imf30.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734503840; a=rsa-sha256; cv=none; b=xnbZHTYs2l/9PXKuzXga88aE5sLWtfe/jE7p1FmZj1oAt75EFb3ILZXwTfRjI6reSVfiuC 2nNea348q55PnZSPX2AjPWsJaxj0QWYxWGGP/TRGtwHjCZoe5wddw84qyi0UNoRe1rkKWt oA4WJ+VBGvcNcBkhdagfErIDZAXldMI= Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3862d6d5765so4159612f8f.3 for ; Tue, 17 Dec 2024 22:37:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734503863; x=1735108663; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=t8Mk3izOcHmuKvHbpqkUDiWbVNW0WzoRhTWnOD8p5lk=; b=f/Yt20uXpTlMiBbScL61trcTVO86Tt9HUl5mH/bSGTz00flTxOQdjStiSHsGxX6nLV gFyWoSQnzJiD5OvEeqkGI8Xj41AIZjs2NvLq4SemX2mbhg3WNCQ7GFQxeGNOA+IsVq9V JWjo7s/qovruh8S4nV76zNT/DhuRDWzK+wubOfCMaCsBm8e7Z5KKg5VkjSR6gE1svsis 84zJFaomkhloCC0Dj2+Sg+icKuAOU71np+7rkdIshnnJ6TK5kkm6EDJcxIGYg7z40TC5 XCe5TM1sHdgrEe1Tav4ItUcFMgwce1jfboLzHQzANNUErPbWVVX1kqkUygsa8dt6pc4v 3v1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734503863; x=1735108663; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t8Mk3izOcHmuKvHbpqkUDiWbVNW0WzoRhTWnOD8p5lk=; b=sT1rFEoA8YwSVRjjpcQgzIFCJNwWQai5wijp392voDJB9im5MjDw5ptNLl7rb88Zvg 3f32nbXKgVuZ+xcwQOjvKtLhpwiKc56Lje0cqrP8l88NHeHyffbfGozW995iTTjJz05Z RSBnetGtKUPBHHorIIqRnbi9syhLoptNo1lisg9Kjq5ZC3oyfSL71kj2gofGsPIKtu/V is9oolYz/W0R/SzGJ8M+mV4q36hqpBSjWPiWkRelljZ/PzOhNWvFPdRfqeDVf0mles4g 4HeUwRga2Wtapw8UsMtH/fPHC99dKlGVjQzwfNdDoubiV17FjNzc9cs7TJfK6eXELYeb DBdw== X-Forwarded-Encrypted: i=1; AJvYcCXUuu+17955MRJovrajI6tpOW6K6z/YrRgzUwPBMMFjz17y9Q9jhURPT6vmplP5uBrOMNG/NzjFzw==@kvack.org X-Gm-Message-State: AOJu0YyFFyhpFJKm8XaP44fOb9Nl4xf/2/BUJ/594qw4borjTyrvaa2m CGBfu6DVAgB6jXdR0q6RpXqRbcxn61q1tkMx3LaTl5zSpC0ssEHJJH8/Z+Hpxn1GlAmCdspbNdH i31AUdQWBnTASosCMfe3u2HAHPiM= X-Gm-Gg: ASbGncsTYCzOZvfT+Tb/Au+sfgJjcllj+edeWrKWfmhvpOxsxF7j8cWjUEufAJSqW6Q rxeZZVYb9AzQn2k+pjKQ/5XPixIl0Olm49PskvsCF43mxSTDHCi8CPg== X-Google-Smtp-Source: AGHT+IElSBAJP50/md8YE2jcJ9Pr1Z0TrOnyzymBXoutCc/dlicjAbt8FCGAg7sKIl5ioTOa7sI+QErzdQfe/wIgSN4= X-Received: by 2002:a5d:64a9:0:b0:386:4034:f9a0 with SMTP id ffacd0b85a97d-388e4db7e85mr1033780f8f.52.1734503862370; Tue, 17 Dec 2024 22:37:42 -0800 (PST) MIME-Version: 1.0 References: <20241218030720.1602449-1-alexei.starovoitov@gmail.com> <20241218030720.1602449-3-alexei.starovoitov@gmail.com> In-Reply-To: From: Alexei Starovoitov Date: Tue, 17 Dec 2024 22:37:30 -0800 Message-ID: Subject: Re: [PATCH bpf-next v3 2/6] mm, bpf: Introduce free_pages_nolock() To: Yosry Ahmed Cc: bpf , Andrii Nakryiko , Kumar Kartikeya Dwivedi , Andrew Morton , Peter Zijlstra , Vlastimil Babka , Sebastian Sewior , Steven Rostedt , Hou Tao , Johannes Weiner , shakeel.butt@linux.dev, Michal Hocko , Matthew Wilcox , Thomas Gleixner , Jann Horn , Tejun Heo , linux-mm , Kernel Team Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 1BC8480009 X-Rspamd-Server: rspam12 X-Stat-Signature: uirugicr54nezfz6xm58jos9omd7q15e X-Rspam-User: X-HE-Tag: 1734503803-431150 X-HE-Meta: U2FsdGVkX19L7aWZC+toYgz5Xbh3/TsGd9+6YrSn38TeMUB372arckSwMyEHHglOevk+vecvORim6xzBWIrZEHC79tglMYE33oy+x7DcFe4C7CEtxGKonoyCpa2Q+wr0hCbKrMPrgZn7OXHumwJWnwIVStM7CFt8g2UTEfJslXGN5cQZijQY8KdWfFsbLcx3FIcJJjgq+mEsKuTWI3V2NtRksyzPeac5hJFe30eYpzOAvxCwTrQRpSjGoITsnD0nO5Hn2spOiWy8xkOqA+lkIlHM5/AL++88hdCWY85rfZxHTPXiJOETFtFGM08PWP8q2PE3EviTYOs75dCyf2j2/jM68QRBnT1wp8NCmzFEMUS0FaZQDPEvbMzaoZlbmBV09nO2CJFC0BOV4+he3xaZjOIU23E7rul4+H5miTCDpUyJDWdehoDwll7J8xnUMtnid8EwtUub3J2b9Jb/3rvFuOfPBS5h69Wn+hruwGxnIsG404EEROMggWj9a0GpQAbCrDZSqoVOYRRlRINli9i5VrqFF/GlozqNRSaEzt8G9qE4SLjYCbXhC7DS6AXFvICgPjAn2ANlTJKY1OzfUt/Z9tyal4Kl4HgzKpyN6trBx6GK7Ok85IJgZuHXX8wpMSHbl2K9oZcfENAL2U9d6QepjynBns9qOdkRd9IPltNsavfPFOJBU3+RfFUgsdtyQpen4BZ5Jq+A46UstgiHOs1gwEg4Tl7cRYRQRFzPLpqxhMBxI4yjY18UZFxEmTpfVDsmnu2PqG8rhLBJY7jJXrtgCUMsfVYr447D9fPp8xN/pw68ncB3fFkhRMHutzQaFtrWhNCnn+W2ahY6CiqpZSoE8z2RgLrb9JVR/8SX3TON2O+OgpmVVL+2C1bDOo/HzPggO81YlO0Aldu+bZOkhxZ73hsNPf3PccmtpTnJ42Xg3hGLZZ9Cs3g0qE6Yr4BctyU/5Twt5HLmkjYvEDVd+Vo BS61VjaI rXirYOuYe/+YRdHloCXH+cqbc7jwe9WZUqPIoIs23ibwFt8b0dmPcsVJI8zPRSvCql0FGC1T7ALen5fQP1UxuEhx1S/xaaj8FWNQaK8+TCGVCyl9El3NF4/Q+OxmEEId9oBodqAgQXZdHh+RQPN06QcENshO2ZYKE+lA60FXS+7UkRdA31BixiZ7Hd7DAWZSeqh/HTZR7aY6hHG4UNqwrg7HBgrTbejj4XLPeKD+KYWyb8YDpH1ICvWYeKSPIvXz9wadsfSb/R8i+pE9icvsdLzb0brIGpbaTCmQl5MfYallp2I+H4LgYxZFxvRlRYslULQMvwsDOBnUoXCTHTMrvtbwOh8dcE3CDf4On4nUh5RJscuEbVcSKCI6kh3IADG4rw4mFRHSwo6pQ6fr2QAt7HwEScv7+BHPSd/9ce5ul4j8j7qg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.289205, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 17, 2024 at 9:58=E2=80=AFPM Yosry Ahmed = wrote: > > What I mean is, functions like __free_unref_page() and > free_unref_page_commit() now accept fpi_flags, but any flags other > than FPI_TRYLOCK are essentially ignored, also not very clear. They're not ignored. They are just not useful in this context. The code rules over comment. If you have a concrete suggestion on how to improve the comment please say so.