From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78E17C4829A for ; Tue, 13 Feb 2024 22:01:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09D416B00A4; Tue, 13 Feb 2024 17:01:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 04F0D6B00A5; Tue, 13 Feb 2024 17:01:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E30226B00A6; Tue, 13 Feb 2024 17:01:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D041F6B00A4 for ; Tue, 13 Feb 2024 17:01:07 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9F88FA0CAC for ; Tue, 13 Feb 2024 22:01:07 +0000 (UTC) X-FDA: 81788151774.05.FC55EA8 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by imf16.hostedemail.com (Postfix) with ESMTP id A5BA718002B for ; Tue, 13 Feb 2024 22:01:05 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=m+CzgbeO; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707861665; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g4ASdg7dH70LPKeAXxCbwv0Td9T3hnc52HS9C0fPsF0=; b=xSY8uXbQQwINm37p/7DrLruRUhCnWbNjY4/sc62sChd293pl3S9+6rdWDv7RyLt8X/ElgS ho/RDuWlQeITpWdDYUNMvD1Zjb6Pyo4mfUjAWGeTd0/tgwzYScZXIPNqtoaH0e0l+iF0hl V0sityl0J9Ilz9BYZCx3NcFk/vjA5x8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=m+CzgbeO; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707861665; a=rsa-sha256; cv=none; b=8rPTW7IiRkUzT7t/nW+sUisZZwBL/lygvxNBdcCjbCu+oicetkwdxKvMEV9E3RLwSfqKAz oXbCcwmt2AnUr1yswnaHpu0K9McEm0HI2BOHnzmb48Ct4ak8KO/Jt+MX8XDlpb0aD09tsS IBHKHe22bcFRTkO8DWhq1YoIVO9am7s= Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-33b189ae5e8so2120875f8f.2 for ; Tue, 13 Feb 2024 14:01:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707861664; x=1708466464; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=g4ASdg7dH70LPKeAXxCbwv0Td9T3hnc52HS9C0fPsF0=; b=m+CzgbeOKP3DdyEtMYXOlsoscARTRF1CxWq+xXmJSRpTGxrNaZTl4djumw66vHtV9/ 2YmWdYIQctUTDaHYnuj0STddes6eluVhVT5RUtmIBuIyTHuR6AIsgwARLKTuG9M4IC8F xufcwL89i9SBuuiJ+StWBMRc6LZCrRFzHrM11b9YMjiu0AQ9tsED1ZPfzwub3apRc+0y MU3teCmVKhnb2CelesFw9k/WDpHal+DU1MwIJeIZgc6QApetbJcHR9GCtXXbLlEdcChV jJ8mJNk8LWsYnhqwP5JKDtyAtgMLeoHobE9eWiYIRGdI/zD52CWwHlT7TqmTYjzamVni gxEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707861664; x=1708466464; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g4ASdg7dH70LPKeAXxCbwv0Td9T3hnc52HS9C0fPsF0=; b=vy/CY7ahkJMnXrSWpfq/Q645aNTT2P4+lnyyZJsKm/X/dXMSJGpWUuu7BDYg/Gx+PI 4UCCFtBaDEkHUn/WGkh8BOtZ4QvkIAD2ZlnKqoIkQFbsveFtwNNFsQBUhBM4x1P3hgSX fUiSdyi4SjJIkA17IjnpdxWVccFrd+bKVK+JDX+nb9VY4xkdRLqkagh8Es5uNjTE6x/S lIg0tlaZfT94dZed44o6BEAr2T5rkq1LIko80D3apVNGm2UEDs1Bzz5jI8twWsJnfYDF auzNbMd9AYfsYoZvEBfkzOW4jnHJFsdoCUzrpZDzjYiF1IdpH0FmP/62bO3NOTx4MJ5F di2Q== X-Forwarded-Encrypted: i=1; AJvYcCXBxzOh6ogBE2dRIkrwo+RwTwlrlWO7Wx1/aWq3UD7Wit7CylM5pQdCO7mGJ3IvJ3MLdwTkHoEV5PK36lpFJbQcFD8= X-Gm-Message-State: AOJu0Yx5wtstJsYAVDPW/F3naVJMcjvwQ9OWq8I6HZwrxiyxAEqUQWG3 UJTqtID6uic9pnDvmTU1shdYx6MRILz2BjXWk3aG9yn/t5Dw1EnbrpR55yB3nShyUMrEHiJb4qc Y8rKsX9h5NhM/9VmAMyYy0aeKMRI= X-Google-Smtp-Source: AGHT+IHnKHMo9HhU4npy2BjCarpmQklf2P5Tw0ijUrIEquhnoUnTrzZskZQNrV5SRQ4GOEWwFM2Ci5QNAAFmiZR3q8U= X-Received: by 2002:adf:e549:0:b0:33b:4ac6:f73b with SMTP id z9-20020adfe549000000b0033b4ac6f73bmr402662wrm.23.1707861663811; Tue, 13 Feb 2024 14:01:03 -0800 (PST) MIME-Version: 1.0 References: <20240209040608.98927-1-alexei.starovoitov@gmail.com> <20240209040608.98927-8-alexei.starovoitov@gmail.com> In-Reply-To: From: Alexei Starovoitov Date: Tue, 13 Feb 2024 14:00:52 -0800 Message-ID: Subject: Re: [PATCH v2 bpf-next 07/20] bpf: Add x86-64 JIT support for PROBE_MEM32 pseudo instructions. To: Kumar Kartikeya Dwivedi Cc: bpf , Daniel Borkmann , Andrii Nakryiko , Eddy Z , Tejun Heo , Barret Rhoden , Johannes Weiner , Lorenzo Stoakes , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , linux-mm , Kernel Team Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A5BA718002B X-Stat-Signature: i4nihrzfyrc7ykba7zpdjactxe5yp6ip X-HE-Tag: 1707861665-583452 X-HE-Meta: U2FsdGVkX1/RnGGAYUnAlsf8i5Urws1gw77kW8YCf5By+CV4eMarvvXmLfpbpibNL2Ec2o4u5lC+PT+WzyNpoTfoE55jxbWaFzH0ketd/vg2bCEzGWrllLBdYj+sVSEnPE6NMQVY1zsJISW7wy8exacxE3LZ2rBDvFPgEUi03E3b3ivcaaP6+i8LSB/G+IS1Bh8Y4YMn9uZvJyP2V8JM/YA06eJGI5PgJBwhIrtEObFHFFG1d4kNxJAwkPbCqbz0uwpMtc1jrb49+hGWW7VTtzhXJcphqWU/JD8Az4Eu5SxF8xBCKhEqZqcPWsp1ojMi/L8+yFYGYNY2WURNeVbyns1rVgRv9/YMcWIbS9XJ05bcI1jZjQBWFliLcc5/U6yKlhFC6UZt5JRRGj7Em7PhcnV1vt8MK7jzV1vYV0nXqNDtirfA2JDz9RzelzUr8OcU6cdcWcIbs+fdl458Og+HQiPpolRYekgYEVgOX4Xwu45nj/rwTu+E3E81z1NIGS5Tr8sA/+hkKoqTzfnmE7vuQm8X8oLc7f21CUtY2f1gsiuSa7KsF75fo2/V+dbeQ2PV5jjNC9Je/i09NzxoIzQDyEj7SHQ4hMOvK7jiwlqAVDhwXuc5v2lNhx2+y+XvLmmBHap7nshizFu5OYMxgunaTDZvY3o1VKAFJirHtmaI3PoXaNefBffyaH2zNm3+HQX3YO1RRyG4WGVbRZvD4rv7sUoh8d/PCATR/T22j2vY0eXzlrp3lMwD6PnGPkKH/JeoOgCzSAV2ImqZwRz8EPqhPvJXm2MeOwd1gYP+L8y6KKVge5DJWXjIbiDmMDCZhbuht80xCbFD958t5AzqP9wckOjHwwKuze8xFJfAe1/VZna3P3SuHULkUnHLbd+iX5DxQ6hop9b0zl8Fa67mk4VbGNf9SU6REVG1sENzv4CVPWEmvJaSnIWF5UJVzZPyX6/1Wn94ojJqpc1vAXuhY+d MWccswsm I+0ADG7T+nUZNVZAeSzU5RzbEGvo+Z0cVo4o2bUUobj9jzvkoLJBh825PDNd59ufG1fBVlG/TL+kgudS3+27HC3cNa9Gg95Loj5kDtCDQcoqgFPGklJFUzg2FjFWmgNvPn5ry3qUV7msP3Z8CIHatLjKFhleHgoq9BpQ2CPTmLvQpKX3pp9csBcrgNNJeW47YTUMVunR5essMoZwehdi27isdUGa8uqBV9dwj5qkp0QpLp8RAutjppPirq9ev81D5XX7+QBkiYgYnxK9uF4vzFpGoGnJQMj2lS8TSh64Shkxea01GYBfp+cOelw2sw3+Ed1ZzpjZ2gLJu07iOcOe/xVqE54U5e/G3OWC8cWwX6XDFGqIVo+vVVtI7tOLg0rwWmrzcYqGnSaB7wA72aCTdKThKSLMkaf3SYJ1Gb2wytquumdRCbsadv/0g5YI2dtais1c9Evj9/L0QtC8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000569, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 9, 2024 at 10:49=E2=80=AFPM Kumar Kartikeya Dwivedi wrote: > > + if (arena_vm_start) > > + push_r12(&prog); > > I believe since this is done on entry for arena_vm_start, we need to > do matching pop_r12 in > emit_bpf_tail_call_indirect and emit_bpf_tail_call_direct before tail > call, unless I'm missing something. > Otherwise r12 may be bad after prog (push + set to arena_vm_start) -> > tail call -> exit (no pop of r12 back from stack). Good catch! Fixed.