From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 814BDC433F5 for ; Sat, 4 Dec 2021 16:46:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F32CE6B0080; Sat, 4 Dec 2021 11:46:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EE18E6B0081; Sat, 4 Dec 2021 11:46:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD0646B0082; Sat, 4 Dec 2021 11:46:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0179.hostedemail.com [216.40.44.179]) by kanga.kvack.org (Postfix) with ESMTP id CFC5F6B0080 for ; Sat, 4 Dec 2021 11:46:07 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 996728249980 for ; Sat, 4 Dec 2021 16:45:57 +0000 (UTC) X-FDA: 78880688754.18.5F08502 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf20.hostedemail.com (Postfix) with ESMTP id 42DBDD0000AB for ; Sat, 4 Dec 2021 16:45:57 +0000 (UTC) Received: by mail-pj1-f47.google.com with SMTP id j5-20020a17090a318500b001a6c749e697so6981535pjb.1 for ; Sat, 04 Dec 2021 08:45:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ou8MCZUKr64qRr/skxLC3cSf8qAEbYCJImJhLBz+XPg=; b=aP4Srzc3BqseYAo4mv4qrVDjpirw2ZULF1TPTFiy3P5lcuxGU4/q2Ez/bzVvegPok9 9K6/jag7mIxJxirlwSVjYfKzLqPKesXAdfkwopIiTKseWla39XCoskaNL/a8VRrOz+Km E5p8wsTq0Acbh3Ln7dtsvTBCwZlaRDnY5OQ2ukfXTi99efBIn9pMv2tGqs/n3xenMiaY G2hzPyQatvLRiedijOZ/gkoEVpyaZKB8ZqniwtfFCGylH0FakQatiK4AXyEl5YyszYih Rw3K8VsYcqXcWFFqwFiqi78csx4jXfxLLRl/LeGmqECMrqFAfWhPnduhSdvcSw5Ghlhv 5Ojg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ou8MCZUKr64qRr/skxLC3cSf8qAEbYCJImJhLBz+XPg=; b=7iEzIk/A+yZ98DRacfofnB07rSC715NQ68UkiupPTdQ0ZVY+4xQ1KED4WaaQpDrket SgYT2bwIC97lo2rd+2dvPcL+NI8CSjBlgtkY4DeXrLeFjMdnKoScKGPjNx5JqnvTBG9Q 4aKcilrBduGTr7C8+4oU33XaEImkIkKvpm109CO0lQIUaDnWr8nW7mMsaOJWJWhDLyzu 2gD5qO8w/et18PvxppSQ2P+3VHHuBL9frqoEzrys8cJxwxT5heps79QHRyrZqmBpGfwt /akCmUfsxYnbWWhcg0VoMIphGJ/PiQRRsjet1s1bJvhDZL/1LoG3a+7aky8PmbMagD0T 2DAQ== X-Gm-Message-State: AOAM533iOh5IOPpY+Cb9+a/AGYZrOaiK/pAcPXCDEFcqTwKrOX1smuFX 7vWQYk07UDZ0nKKbm3aJpQQ3lLhoB/RGXrY1nL8= X-Google-Smtp-Source: ABdhPJys2RkngGFtmTCazg47B4ViGpNE9hIzgYpzzqwZSUBXheVoeoJh9O21QqSQxzOnlPnE2IW9uVcPVl2w5VMXfIc= X-Received: by 2002:a17:902:b588:b0:143:b732:834 with SMTP id a8-20020a170902b58800b00143b7320834mr31432185pls.22.1638636356196; Sat, 04 Dec 2021 08:45:56 -0800 (PST) MIME-Version: 1.0 References: <20211204095256.78042-1-laoar.shao@gmail.com> <20211204095256.78042-4-laoar.shao@gmail.com> In-Reply-To: <20211204095256.78042-4-laoar.shao@gmail.com> From: Alexei Starovoitov Date: Sat, 4 Dec 2021 08:45:45 -0800 Message-ID: Subject: Re: [PATCH -mm 3/5] samples/bpf/tracex2: replace hard-coded 16 with TASK_COMM_LEN To: Yafang Shao Cc: Andrew Morton , Steven Rostedt , Kees Cook , Petr Mladek , david@redhat.com, Arnaldo Carvalho de Melo , Andrii Nakryiko , linux-mm , bpf , linux-perf-users@vger.kernel.org, Linux-Fsdevel , LKML , Mathieu Desnoyers , Michal Miroslaw , Peter Zijlstra , Matthew Wilcox , Al Viro Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 42DBDD0000AB X-Stat-Signature: f458huz33ia5u8111mho7uuuqm5otwu4 Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=aP4Srzc3; spf=pass (imf20.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1638636357-216318 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Dec 4, 2021 at 1:53 AM Yafang Shao wrote: > diff --git a/samples/bpf/tracex2_user.c b/samples/bpf/tracex2_user.c > index 1626d51dfffd..b728a946d83d 100644 > --- a/samples/bpf/tracex2_user.c > +++ b/samples/bpf/tracex2_user.c > @@ -12,6 +12,7 @@ > > #define MAX_INDEX 64 > #define MAX_STARS 38 > +#define TASK_COMM_LEN 16 > > /* my_map, my_hist_map */ > static int map_fd[2]; > @@ -28,7 +29,7 @@ static void stars(char *str, long val, long max, int width) > } > > struct task { > - char comm[16]; > + char comm[TASK_COMM_LEN]; Also Nack.