From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A95C0C54E41 for ; Fri, 8 Mar 2024 22:44:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC3526B024D; Fri, 8 Mar 2024 17:44:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B24E66B0250; Fri, 8 Mar 2024 17:44:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C4B46B0251; Fri, 8 Mar 2024 17:44:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8D66C6B024D for ; Fri, 8 Mar 2024 17:44:17 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 38A73A1BE7 for ; Fri, 8 Mar 2024 22:44:17 +0000 (UTC) X-FDA: 81875351754.22.D69CC54 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by imf06.hostedemail.com (Postfix) with ESMTP id 61DC918000A for ; Fri, 8 Mar 2024 22:44:15 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YvS261xW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709937855; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D3aJXRvY9D9HCzFxB6bg6tdOOq0PzsTOhGjNlR0CgaI=; b=x4bq3erdtvDgVlrHYAPg1kdc1sZ26roT1+nJl3PZK53i3tgeOzJwnwINSTOH63CbD4IPVR ikk5mgfjfSma4gXHmQ+MAZn3R4iU3OJBId25AG8RIH72C79nVKSL56G56oiScTHlZ2fMpD 5+QxU2+tYtsmXI2vznO1VatZ5JnU718= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YvS261xW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709937855; a=rsa-sha256; cv=none; b=mZshRhyxh6R+QcQLu6WomQNl7ZPGH1p4Y6wKZAiZ7nj9PWSVlwFr5KmV8myX6XbmVpXmXD cV1v0K52y3h6HfNW+rYoAfV3qGfrlU9ZJpbU1hdnIoG3HZ+1Iwpw7+dGEfUjgf7l1nubK5 C3UYW1X15N3/OEbjbfI0AspWa5LMubM= Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-412fc5f5152so18985505e9.0 for ; Fri, 08 Mar 2024 14:44:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709937854; x=1710542654; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=D3aJXRvY9D9HCzFxB6bg6tdOOq0PzsTOhGjNlR0CgaI=; b=YvS261xWXi409FVOwI+FITboG6IsRxpvC9IOJ/KpkpZWN+YU+bhT6mdxPsl2x5AgTh 7rEFvYd0zyiB586pusLHAfl1upr0qHbzR2SFO4oV2Fj3aaUle6qPr1z2nZhDhSzE3D6D xSpVO5GgGZhO/dvErzJsPJ37Q13yc2GCELJcsX0avI/eY6BLEbnuiaXoRO001MNmpWJV wfMDAB72V9JAbZc9FsAm3N6sfeSUR3T+kaHBuaRiioIH0cGattQjLkZxkvLQyz9trEW/ 7FXr+UAxsu6hraQ7oCPt1H4YQwFKTkSnRxAudV7OOBMi/9vCy69ruEcbkqCVhJ2aapHI af7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709937854; x=1710542654; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D3aJXRvY9D9HCzFxB6bg6tdOOq0PzsTOhGjNlR0CgaI=; b=lMbyIdCnKUfDS+4z2MuVah/14Sz3hqFJIBTqLj7vzgUCkUERhnZNXtHkM+0QJrj/+p 97N1p/WH//1b2g9KXRfU0kA6ofZwBKKe15Gza/zcHTHN8HrI0pEVAyor15D4xAa3SpOl X0Z6Efg/yg95MW7UJPcsUdBiZRxpuRgwQpYEoPW4zDyVlM38J5+1qJBjLU5M5uleWnzQ CqMTbrVV5YTehlkBMpTZEz4unIC9b+rry4xlc4haoqovBGhQ3N7fEKl2Bu4bTWg3k+QN lHgAJN6S0PvDRfOFUeFtx5nyLfNqmssr+ckVv21PQ//MEliGzcMm+4W/WPo9gu7/Fnrs TrkA== X-Forwarded-Encrypted: i=1; AJvYcCX4N8w8Af1jHFGTbM+s5811aClUt8dFAX3nf6MSEPjX2KECAnruOCDZva7cf2BGSLBQBVUrCbNe1gdXHhlExeF5f7c= X-Gm-Message-State: AOJu0YzMZWHi0p3bCKL/xis2OYXKxWmx50B63DzxhpjE0eGKyeLA8cpR DZxw2d9M6jk+0gn0D5GYNgu6gNuPnRaS8wZe4CChHrqzGLhm/OkPZfl7sXkmfFzTioFMB5j7Icv YDyQLcolfiHSullZOZzq6o8qI6TQ= X-Google-Smtp-Source: AGHT+IF29hP1nUphTx29aJJzjLnvSZ7w2MXv31LF0HDDrSpcFvBtG4aiKykokpKDa4jenS3QWggi3HNaLt+3GSV1b8w= X-Received: by 2002:a05:600c:b96:b0:412:ef25:aa91 with SMTP id fl22-20020a05600c0b9600b00412ef25aa91mr418338wmb.18.1709937853551; Fri, 08 Mar 2024 14:44:13 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alexei Starovoitov Date: Fri, 8 Mar 2024 14:44:02 -0800 Message-ID: Subject: Re: vm_area at addr ffffffffc0800000 is not marked as VM_IOREMAP To: Christoph Hellwig Cc: Miguel Ojeda , Linus Torvalds , linux-mm , Andrew Morton , Catalin Marinas , Will Deacon , Linux ARM , Daniel Borkmann , bpf , Bjorn Helgaas , linux-pci@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 61DC918000A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 1p3mc9izkd8dptzrp4aoxst1chcb6rfa X-HE-Tag: 1709937855-249861 X-HE-Meta: U2FsdGVkX1+2og0sz8kvRlaNt9WKfdwRjUOX4HMwNFVdrComCzDSmkuzF0RrsVd5yk+4xY3MbbcGMyC3UgC7myelQJ6WhVyWNGdYMIb5f+Q0wcVUvWlCF9fot6P1+L3wPb6nSq7IS4F92Qj8xWlxkIQzf2Vz19C6h/X0N6PWi0I8p2tOQSdrplW5gLDBi1wToj8yrTXJzQCxY2ySv32AitD6k92/OpaTBZDK9a4y+piEUCPWHTlBl622qZXMuDQM22V72cc2uoHCm1AdluZC/3CSAnyanlTJMXM+xriqVHIYGbiC43JIvvfYLfvN5/odCXnSZJVA0rHqnTU4iG9nDDxrOmex/X0HlMziBlSAy6m9KBtvTz634HSJDkt18b3E4cV0mmdVJrEyNSaqIOPM/G58WAUk+OUfC17D1TmNTVDMjdPpeWudz3neQWZvFovoWa8zQi+RZgfnLeipW7La/oXFI4y23hxatrYGrmME/8Xc4TGZMWJCzw+uxDwrDU0YBjjwn2iiu2ouJlEXEF4VfKRL9a7vrcXsGkq1TBItxkNd4+YjlYayL1htF4uvNDsbrv9Jw8PASM3zp1pe6n5qq9EoYFvMBAwKL6EV7d7jXvcldUZALsSRDgoyrFzYoAiLusMDIwzUdE7oMT1tRCd6gHb3JxLGNYNRTIATLh7ERQuP+MvPG8AbuIqX4+3e+/XsFkqRe91oGXk8WUb3d5gCrUYREVpNADjPB59HmKLi83cYVJgV66duOVGI1+EUUrDQd6wGpeNrkGujdHnKribk0X9IfEVDWWAVlJo+1zUBK8f4+P7zQ2i0JLBjdkP0O2Qu3HOH/gTt1PjeLpfMUcrL3R1YvShdXaut4GUDF/PjynBp/cTYzLaDJeRRk73lLHCZ8EF+uM95wfV7CDbgcxZj2HeFkmvIMd42tFvffmOO7UoZwFE92kXxCpiS+qptR/MeBJZdJmnwSK0+GXlhlHU SR99Wv91 eJBzO9g/j1kiRHf+Lt0U7C0QdejMc00wn6/VFkOKvEzQ94MG/JookC+GEHOhNeTZjwRdQzFWMWl3HRln7yp6jtg5covx82r+WI063x3Slhz1z7g3pkfSGqHIsFVoP3jpuOH8uSEFrfgkLosVSfELxIZndltkiorI32Q1PLiae/OVUEwkvqAoUdVV3bBdOeT4JXpG4SDLoRUUYfBsfr97ksndgefm3+BrusnrpyjZ4bw5vBGfkgeGPqUameZHv3aGmGHBulgdoZfFKwtGgKLGSePrbo6oKzgWM6LBPIlQyCTt9OtdlqmZhf0GVjXEF0FGl+YPNEgFFJwuOVoAfKj9uMQgbjMaAlfsoT41T7LVq8pFzaUfK5Nq6kRxm+tBhyU2Uo49EWmuEBFbmuk4WAyYyErnRazGwj9A3HHeWoqtWXLV4UVfmq1G98FVeLoVnB+4s7OviNRxAiAqGrMk+J7dkj4hg19id62iM9xwuo1YlOd2Pjd+XeU3acHh4gZSeSSm259p9oFKFfg0o3BRpWf6ZUPOtnKd5VhCY5MUV0xSWYtGMWkLykat0ghjDtXVVgLhhZoN0Dw5TpvYejn0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 8, 2024 at 9:53=E2=80=AFAM Alexei Starovoitov wrote: > > On Fri, Mar 8, 2024 at 9:24=E2=80=AFAM Christoph Hellwig wrote: > > > > On Fri, Mar 08, 2024 at 09:20:24AM -0800, Alexei Starovoitov wrote: > > > ok. Like the attached patch? > > > > Looks sensibe, but I think the powerpc callers of ioremap_page_range > > will need the same treatment. > > Good point. Only one of the callers in arch/powerpc needs adjusting. > Found few other similar arch users. > See attached patch. > > ioremap_page() in arch/arm/mm/ioremap.c is an interesting case. > It is EXPORT_SYMBOL, but there are no in-tree users. > I think we shouldn't apply checks to it, > since some out-of-tree module may fail. > I have no arm boards to test, I suggest we play safe than sorry. I double checked on my newly setup arm64 VM that the fix works. I believe the regression needs to be fixed today, but looks like Chritoph is out for today. So I can either revert the offending commit or apply the proposed fix to bpf-next. I'm going to do the latter soon if no one objects.