From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "Jakub Kicinski" <kuba@kernel.org>, bpf <bpf@vger.kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Peter Chen" <peter.chen@kernel.org>,
"SeongJae Park" <sj@kernel.org>,
"Jani Nikula" <jani.nikula@intel.com>,
"Jens Axboe" <axboe@kernel.dk>,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, "David Airlie" <airlied@linux.ie>,
daniel@ffwll.ch, "Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
yuq825@gmail.com, robdclark@gmail.com, sean@poorly.run,
christian.koenig@amd.com, ray.huang@amd.com,
"Sunil Goutham" <sgoutham@marvell.com>,
gakula@marvell.com, sbhatta@marvell.com, hkelam@marvell.com,
jingoohan1@gmail.com, lorenzo.pieralisi@arm.com, robh@kernel.org,
bhelgaas@google.com, krzysztof.kozlowski@canonical.com,
mani@kernel.org, pawell@cadence.com, rogerq@kernel.org,
a-govindraju@ti.com, "Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Martin KaFai Lau" <kafai@fb.com>,
"Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>,
"John Fastabend" <john.fastabend@gmail.com>,
"KP Singh" <kpsingh@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
thomas.hellstrom@linux.intel.com,
"Matthew Auld" <matthew.auld@intel.com>,
colin.king@intel.com, "Geert Uytterhoeven" <geert@linux-m68k.org>,
linux-block@vger.kernel.org, dri-devel@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, lima@lists.freedesktop.org,
linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
linux-pci@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org,
linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH bpf v2] treewide: add missing includes masked by cgroup -> bpf dependency
Date: Fri, 3 Dec 2021 11:09:13 -0800 [thread overview]
Message-ID: <CAADnVQJXSksytrk5aLGQzgzaoGB9xFWqXWSTj0AmkEWiEs2jWg@mail.gmail.com> (raw)
In-Reply-To: <YanDM7hD9KucIRq6@kroah.com>
On Thu, Dec 2, 2021 at 11:11 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Thu, Dec 02, 2021 at 12:34:00PM -0800, Jakub Kicinski wrote:
> > cgroup.h (therefore swap.h, therefore half of the universe)
> > includes bpf.h which in turn includes module.h and slab.h.
> > Since we're about to get rid of that dependency we need
> > to clean things up.
> >
> > v2: drop the cpu.h include from cacheinfo.h, it's not necessary
> > and it makes riscv sensitive to ordering of include files.
> >
> > Link: https://lore.kernel.org/all/20211120035253.72074-1-kuba@kernel.org/ # v1
> > Link: https://lore.kernel.org/all/20211120165528.197359-1-kuba@kernel.org/ # cacheinfo discussion
> > Acked-by: Krzysztof Wilczyński <kw@linux.com>
> > Acked-by: Peter Chen <peter.chen@kernel.org>
> > Acked-by: SeongJae Park <sj@kernel.org>
> > Acked-by: Jani Nikula <jani.nikula@intel.com>
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
I'm not sure how to test that it helps to reduce build deps,
but it builds and passes tests, so applied to bpf tree.
Jakub, you'll soon get it back via bpf tree PR :)
next prev parent reply other threads:[~2021-12-03 19:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 20:34 Jakub Kicinski
2021-12-03 6:59 ` Christoph Hellwig
2021-12-03 7:11 ` Greg KH
2021-12-03 19:09 ` Alexei Starovoitov [this message]
2021-12-03 19:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAADnVQJXSksytrk5aLGQzgzaoGB9xFWqXWSTj0AmkEWiEs2jWg@mail.gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=a-govindraju@ti.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=bpf@vger.kernel.org \
--cc=christian.koenig@amd.com \
--cc=colin.king@intel.com \
--cc=daniel@ffwll.ch \
--cc=daniel@iogearbox.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=gakula@marvell.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=hkelam@marvell.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jani.nikula@linux.intel.com \
--cc=jingoohan1@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=kuba@kernel.org \
--cc=kw@linux.com \
--cc=lima@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mani@kernel.org \
--cc=matthew.auld@intel.com \
--cc=mripard@kernel.org \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
--cc=ray.huang@amd.com \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=rogerq@kernel.org \
--cc=sbhatta@marvell.com \
--cc=sean@poorly.run \
--cc=sgoutham@marvell.com \
--cc=sj@kernel.org \
--cc=songliubraving@fb.com \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tzimmermann@suse.de \
--cc=yhs@fb.com \
--cc=yuq825@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox