From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47D81C43334 for ; Thu, 7 Jul 2022 15:46:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB7936B0073; Thu, 7 Jul 2022 11:46:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D679A900003; Thu, 7 Jul 2022 11:46:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C08B8900002; Thu, 7 Jul 2022 11:46:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B09E86B0073 for ; Thu, 7 Jul 2022 11:46:00 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8D94E60A59 for ; Thu, 7 Jul 2022 15:46:00 +0000 (UTC) X-FDA: 79660729680.07.2B2FDD3 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by imf06.hostedemail.com (Postfix) with ESMTP id 3B792180013 for ; Thu, 7 Jul 2022 15:46:00 +0000 (UTC) Received: by mail-ej1-f52.google.com with SMTP id l23so1351018ejr.5 for ; Thu, 07 Jul 2022 08:45:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AGEBbie67q5TXwVzOJXE7BN9/2n5IbFsl2IvZ4cbCcE=; b=goedwjqoQ2sWlaUqLeZOrUhs9AKIg6BJq+VcnIzpR1u4OlsdoPmMpxHBA9CcgJ9MX5 PmHiYlknW7+KelZITx2/4lh2ZDUAnpw7fAJJFeKYeVsmH38K89R19JRmSOj3YDv1jFKp 2RBHLdGI3tfrNTKyxXrZ69PzqvIWdKuuPnWa2yOX9l0lY5wnEDnn5ti/DZhRtfHy8b+v IZPIqjGYppqtz85aS79S3+ghWXUfwPpXo4NCiGmJHR64TZcFomqUaKB/IwFHi/ePliVE nsiK1IgzHoz99SPUGNpom4RH+INBgM5xZl19Na5tWdpHaL31LladA73UBA8Y6E/cY2So Mp+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AGEBbie67q5TXwVzOJXE7BN9/2n5IbFsl2IvZ4cbCcE=; b=40zINkPRsNp5MWpLl4teqL25M3x6i5P2QSaIBANi4ISO3FcJ5riLukIdq1UU8tAgNO k2eqauM6uPqyqbOAnySaPuOGrsmKtpvfC4HfKgTU3MDoc0W4YzTPRRCnM/v3YwNTajon /hCrM9iKrtn8opr1FvPHAehRtica5v5fdSORvhdhT/Rm4sWwxJo6hFzj50axyZ0WKGHW IvYxKW4+0v3owlzrW5klSjv1nTP9dQKJxmi/elcSNRRBZM2VWHMMNGRA4tG/V87U+T3p RTezk5N01PM4JOhvp8HgObsKG7VeF0YHMAcApz/HM4wekpuGS8xc66VrDUHD0YddKmXt DGhQ== X-Gm-Message-State: AJIora9tdVpKV7hLEtP9GNGIbKM0+Q+ot96Vc86As3+G5xSS4CLUDKMy ES5eClz2KOLnZIo3lwfDpJyOwcwaTEuCZGBSbYA= X-Google-Smtp-Source: AGRyM1ulov115nvGKkxiMqWRfqRf9lMLJAh+4WYm5LVfsH1/Jtb5ZM5HC+/wR6bk6c3DyxMzSfz2E2Z0x67JEWIJWPc= X-Received: by 2002:a17:906:5189:b0:722:dc81:222a with SMTP id y9-20020a170906518900b00722dc81222amr45443816ejk.502.1657208759039; Thu, 07 Jul 2022 08:45:59 -0700 (PDT) MIME-Version: 1.0 References: <20220706155848.4939-1-laoar.shao@gmail.com> <20220706155848.4939-3-laoar.shao@gmail.com> In-Reply-To: From: Alexei Starovoitov Date: Thu, 7 Jul 2022 08:45:47 -0700 Message-ID: Subject: Re: [PATCH bpf-next v2 2/2] bpf: Warn on non-preallocated case for missed trace types To: Yafang Shao Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Quentin Monnet , Roman Gushchin , Hao Luo , bpf , linux-mm Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657208760; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AGEBbie67q5TXwVzOJXE7BN9/2n5IbFsl2IvZ4cbCcE=; b=SWNcEUvN3TzIQa9LHShkhEFnCSG/8WRoxO/Gez7hJdZJhJtaRBH7xlw9XlYjf+AuJ4tZC0 yS/ngrtL+L4bgxv62CmPqfriZFVew99JqMxv/Ulj007ATdDr3OeHd/GSi+OD3gv8ERJ9/5 /yFg/KLDB5l0e2CBZ+zGSh2qlbX4Ny4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657208760; a=rsa-sha256; cv=none; b=5dViOJ9CxHnwU0V4W6KP14TFAzm+u0Qfxm7MA5BfHW9JajyM3wfuyK3XO6cknKiSaU5k8u B2HzjXUMEGlSTjb1ShsYj2ZTSL8KavE74WtkCa762YJ9JNnW+9tszeeW3LmB247yQqu72v rkP4pUQQ89RfVkjn+QDYI9/MUV3+TC4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=goedwjqo; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com X-Stat-Signature: pwu99ggrwj7nq7f781ppuxbgjhkn9cjw X-Rspamd-Queue-Id: 3B792180013 X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=goedwjqo; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com X-Rspamd-Server: rspam10 X-HE-Tag: 1657208760-652409 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000045, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 7, 2022 at 3:30 AM Yafang Shao wrote: > > On Thu, Jul 7, 2022 at 12:50 AM Alexei Starovoitov > wrote: > > > > On Wed, Jul 6, 2022 at 8:59 AM Yafang Shao wrote: > > > > > > BPF_PROG_TYPE_RAW_TRACEPOINT_WRITABLE and BPF_PROG_TYPE_TRACING are > > > trace type as well, which may also cause unexpected memory allocation if > > > we set BPF_F_NO_PREALLOC. > > > Let's also warn on both of them. > > > > > > Signed-off-by: Yafang Shao > > > --- > > > kernel/bpf/verifier.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c > > > index df3ec6b05f05..f9c0f4889a3a 100644 > > > --- a/kernel/bpf/verifier.c > > > +++ b/kernel/bpf/verifier.c > > > @@ -12570,6 +12570,8 @@ static bool is_tracing_prog_type(enum bpf_prog_type type) > > > case BPF_PROG_TYPE_TRACEPOINT: > > > case BPF_PROG_TYPE_PERF_EVENT: > > > case BPF_PROG_TYPE_RAW_TRACEPOINT: > > > + case BPF_PROG_TYPE_RAW_TRACEPOINT_WRITABLE: > > > + case BPF_PROG_TYPE_TRACING: > > > > BPF_TRACE_ITER should probably be excluded. > > Right, I have verified that BPF_TRACE_ITER can be excluded. > Will change it. Probably more than that. See that your change broke BPF CI and selftests are failing. Which means it breaks existing bpf programs.