From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63EE2C64E7C for ; Thu, 3 Dec 2020 02:55:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C0C0421D91 for ; Thu, 3 Dec 2020 02:55:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0C0421D91 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3C2D66B005D; Wed, 2 Dec 2020 21:55:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 398436B0068; Wed, 2 Dec 2020 21:55:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D6676B006C; Wed, 2 Dec 2020 21:55:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0145.hostedemail.com [216.40.44.145]) by kanga.kvack.org (Postfix) with ESMTP id 172D06B005D for ; Wed, 2 Dec 2020 21:55:00 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D2887362B for ; Thu, 3 Dec 2020 02:54:59 +0000 (UTC) X-FDA: 77550453918.23.tin99_4609c7f273b8 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id B3F2A37604 for ; Thu, 3 Dec 2020 02:54:59 +0000 (UTC) X-HE-Tag: tin99_4609c7f273b8 X-Filterd-Recvd-Size: 3449 Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Thu, 3 Dec 2020 02:54:59 +0000 (UTC) Received: by mail-lf1-f68.google.com with SMTP id l11so588414lfg.0 for ; Wed, 02 Dec 2020 18:54:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Dd5jcZ3oN6nUA0AzCxuEUhXY3oArZGfneGe61iHNKCk=; b=p0NbHKpET7bJ46d00bRrLX6JtATMfRM1z1ULVYd3qkkrWfAl6OccKIVcFlJn8H5AT4 bYqCEpavljJCulBxGyeHWRjNFWynmskZBB/bYLr0Vk9Hd/Om3VvygIPIUxrK79emwGJQ URuFawvDubEOnY6fBuTnQaBPtvgo6ssQSSYEKs2DzEDHeaPiEUKXaCEUMbSI/4qQ/xLb SSM3zjuWYYmcTlE0Jgw37PpidobZSwS2cG8lZxkrnMAEhYimkfQRAQ9jDnO3m08PHyzm EkwIypk9vs11fq3KSqCpp+CL3MlF9Lnd7ycoSVKnjjaK/e/q0Nc4HsrgG141EqUYACfW k3Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Dd5jcZ3oN6nUA0AzCxuEUhXY3oArZGfneGe61iHNKCk=; b=kOYi5x5qZFOG+rV4m6sLDxh+lEUthR3YeVvVfo501caAoi9KK1WYMv/rbdqyaVEDHC pyOeUna2PJPUayG8AiZZwOfgfrRfCfguMZ898DHNGnHsLodz94Qtt0YtZZSW3b9/dn9w z91Z6D6vQDwFWoug6pn9a5qfbdu9Zl70YL+ToRmgG4zgO3jjU5jRz0QTyYxmwfutfYiP +7InunB6Hv9gPUqNncnNfiW0MY5UvXoMDDHgZ3YYfvXZ92AGk3yk7tmLHkJQIYfx5tQ9 Wry/gERakQa/9qXFvUa05EpngqSvQGZR31yFjNY+hsbQE7Je0u0rFr7fVMxrkTWc4eS0 FFXg== X-Gm-Message-State: AOAM532J0fca126Qsz8fQkm9Sv4WZgRLH5LO6kXWHKH4igqbzxNHZ1VL MBxN21htSfZIXl+QXDv2DD+nJKtbjR6MnWRyXEM= X-Google-Smtp-Source: ABdhPJztbEPrSr+1MMuVD1akFGR77xCipHpKdbOhyw4y3xpE+e4w1OglzAIV4fKukIOdnPyRVJ44BXXdPr5hXfuxDic= X-Received: by 2002:ac2:431a:: with SMTP id l26mr469141lfh.196.1606964097754; Wed, 02 Dec 2020 18:54:57 -0800 (PST) MIME-Version: 1.0 References: <20201201215900.3569844-1-guro@fb.com> In-Reply-To: <20201201215900.3569844-1-guro@fb.com> From: Alexei Starovoitov Date: Wed, 2 Dec 2020 18:54:46 -0800 Message-ID: Subject: Re: [PATCH bpf-next v9 00/34] bpf: switch to memcg-based memory accounting To: Roman Gushchin Cc: bpf , Alexei Starovoitov , Daniel Borkmann , Network Development , Andrii Nakryiko , Andrew Morton , linux-mm , LKML , Kernel Team Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 1, 2020 at 1:59 PM Roman Gushchin wrote: > > 5) Cryptic -EPERM is returned on exceeding the limit. Libbpf even had > a function to "explain" this case for users. ... > v9: > - always charge the saved memory cgroup, by Daniel, Toke and Alexei > - added bpf_map_kzalloc() > - rebase and minor fixes This looks great. Applied. Please follow up with a change to libbpf's pr_perm_msg(). That helpful warning should stay for old kernels, but it would be misleading for new kernels. libbpf probably needs a feature check to make this warning conditional. Thanks!