From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 045CFC3ABBC for ; Tue, 6 May 2025 17:18:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D90F6B000A; Tue, 6 May 2025 13:18:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 286506B0083; Tue, 6 May 2025 13:18:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 174B46B0085; Tue, 6 May 2025 13:18:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EDBAE6B000A for ; Tue, 6 May 2025 13:18:34 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BE5901CC1E0 for ; Tue, 6 May 2025 17:18:36 +0000 (UTC) X-FDA: 83413142232.01.274BB99 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by imf01.hostedemail.com (Postfix) with ESMTP id C98C04000F for ; Tue, 6 May 2025 17:18:34 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="g25TdH/c"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746551914; a=rsa-sha256; cv=none; b=nLBWwBm3E0ucNzZtMQDzEoNCrBLNrIweojQRoTTVbYQsz4XOu/9e/DoqAK+EudpVxCCu3c 7qYMJyagyk+oBkTHak8cHrx+sGUSHm39NhMAd6uAKy9RifgF/WZtX1/NKedC6KNM+Z6fEg YmF8K93Rt8/OsXEczIMMOYvo7tqnv0o= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="g25TdH/c"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746551914; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I1GUKXRG1sS0I2MpQXF5etwohdHLhGjvcYGHi1qYNI8=; b=vUP801JX1dl9J/L2t2ff6Bkc1SRSmiDogV6+dEW/eiuWcpYtKTo5ZM9L+Vll/ptDcuZiMc RUk/b4SbIdRiaqIVySDZz2FShht+tVWVZPD/lZQjt6Edc+Y8SH+CgiQu/wLMEbsFNrExii dm/MeVE6moPDjVxDf0c4qfrw+uMawqI= Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-43cf05f0c3eso37429295e9.0 for ; Tue, 06 May 2025 10:18:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746551913; x=1747156713; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=I1GUKXRG1sS0I2MpQXF5etwohdHLhGjvcYGHi1qYNI8=; b=g25TdH/c8jxuz7nprQvuHHY7r+ayIk172klqAHW5z+cb/Ct2aYMTwvxk2I7UXJM/cD K0yskXFIQlhYTsbeEvEvGakALJnRHiu68oBwJw+ESxoOTiSR4/0HOl8HViWp0LMV6O38 gmS5J25yaqQ4Qr6DAywvm2RD3R3JKVc4v7py7mAKqXw0b2AXQRM3WSTitkWOJgiYNfOT cmQLX/MsiN+QneNn1u68NZ1sDkLlEq6C9MxZrNBShRJhC8xNGpRjRozObhdsQdDHMGIO G/eN/EMvscV1pvr+FBlSW8kY+I0LFftZxJlpFog1mg6zXLa/yiLZ/g5speY7ik/dAgUn FM+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746551913; x=1747156713; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I1GUKXRG1sS0I2MpQXF5etwohdHLhGjvcYGHi1qYNI8=; b=jvf2wgluTX1n1dUn6kJyvdLnra3niVSlLVW6YljpJmGooJ1NlgM+SYzU+JjXCBOLKC LYHxC6z57T8LCZPGKhJXFQRsQ1AG5GG61yWQUgWlP1woQYuh9xfxoyQG4HrtDGFKvrWk 8SNPxgOvTSaEuBBOt2J8licHTcz0TuVLfFjZA6UqAJHbRgQOK/W/Y7NM2pWBDUX5bJ/V MhL1yuYQzFz1luzlJm6TmJ51kh3qx8bkSOKZ1JblOatpsUZ5rjoT27PRxSAv/TN1Pqmy sfqA4U22miTpwn8GnBsxxvFZrKnLw56AMayZOuh/84wjK9lmlNP29GWtu/lRD1S3FMzs RZ3A== X-Forwarded-Encrypted: i=1; AJvYcCUDgeDEoZQ/7pf0NRtjvMujb5OJLcFQOM2wY9HfWLWFuv/2OcV2ITSdnHRrl0FLLnxxJ+VwKlPrPQ==@kvack.org X-Gm-Message-State: AOJu0YzOXTTTRxa6pLtrRdyhowXF2AZ5TyYtBuy8HxuXnu2YOk+6ojV5 W3aX87fG7p425anS50GFkvflTrk6hjih0tljTfeioGuuxoOxR0N9/jUUIruzy3ODBs0OyPX17Ae u0oMglden9M+lX63j14tnqXcABUw= X-Gm-Gg: ASbGncsU5MI0pmXilRdjmQVZ0q5OUmf9qEvDjMwh7zp8UUst5RvHzsvzs3XRnQF1eoG KOc4d9W9V8+AVZkqN9ZFMuwiMF3fO7sRMPyZa9OdX1eTn6a5JoFBoFfz1qyDjxdJyIbGFvAyg9X yR1EAC8GCvvgfPVhtTQz1/S9BfiC+bjLy9ixyHug== X-Google-Smtp-Source: AGHT+IHQuJXcdGhW4RBQiLlShD7u+LNmA51eDaVMk8p5aLAsflo1j9UpfI+KpsgbKf6Fl3aQPBcsLRNXOtKLMLQaDQ4= X-Received: by 2002:a05:600c:5491:b0:43d:fa59:cc8f with SMTP id 5b1f17b1804b1-441c4948909mr87467725e9.33.1746551912968; Tue, 06 May 2025 10:18:32 -0700 (PDT) MIME-Version: 1.0 References: <20250506112509.905147-1-kirill.shutemov@linux.intel.com> <20250506112509.905147-2-kirill.shutemov@linux.intel.com> In-Reply-To: <20250506112509.905147-2-kirill.shutemov@linux.intel.com> From: Alexei Starovoitov Date: Tue, 6 May 2025 10:18:21 -0700 X-Gm-Features: ATxdqUE1cPmGJ_z0_R-l8WcbQujf2UehrtXW9TqppyzEM5gu5W70jKsdFwzwy6M Message-ID: Subject: Re: [PATCH 1/2] mm/page_alloc: Ensure try_alloc_pages() plays well with unaccepted memory To: "Kirill A. Shutemov" Cc: Andrew Morton , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Borislav Petkov , Thomas Gleixner , David Hildenbrand , Alexei Starovoitov , linux-mm , linux-coco@lists.linux.dev, LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C98C04000F X-Stat-Signature: pt3ga3rmhp45oqik3m1db16351meqsdp X-Rspam-User: X-HE-Tag: 1746551914-854770 X-HE-Meta: U2FsdGVkX19O4JfIpIhYOO0kxfPdcMJ0FooPy7WOeBC/CkQr5vNnsV7uLFQ+Ee4cbA6sQMCM3AT1i8RUdk6HNxzN1w+RxbZOA1OLiBuJsyaeA6N93HepQTMncQksqgmrl8S9UYim4uJ65sdFPYbKpfgH0U2pgKZxrFQ6HkTIcRLVXbg4Esnt5VSrHrx51YvV8PjcMKQAtJ1q2m000EIPXslSgYW39lH3Amf+v9T0eK3JuvhtSEtE5PUNnyFL+bIiptylBL/PDry3Nm2UNIOk6Z/KxoaZxCMv6AtXa5UADd0WfOtCNgUQ8ymF3qMsYHNSkbg538p4bBP+P+J/jx0WORVRnTljl62OaWlir/4VJEewdPjwWdlT1jB3NZaw+Zyzr1UCLPkxDySBfuXUxnjax8X4bb4UoU/8dxJ6RhND2qDI3WCaDyW0U1r15Uu2sf7WhCH4z6LJKJ+BbcLjvES+bOIjANWl3J/FAAU9G3u0zbdKfuF/+TGQrKPsrhLTiZVxPDULLvV6CYZPY1CbcYXEnVmgNMYhffdSrd4f838PfJ8UdS9RMTTuOIRvxMb8idCQOBKpw0d94GpOmmW5id3b4nXykkB//SdQbjIgyt/mKsMbjG0GAuuJQhqrZyBcKSWagxV7vw0xaz5oWyE7rY7eCQRgOAJ8HtMtSFmPxo3N3Uxw96dA4M0lqO3RM2Gu/SiZ+vP5W9zar5oZdGma9wZ8A4G9NtmlQq9dlWraR042rqh0fXlj8uUYzS+lyJhc1PZgIk1fmpf6QoNm2diL400fSQhwgFkhts3EFq0+kBaOSL0UOr2PkhGZiSjEC1S0RLqEjRzlXbuAwUIkE5Xdz4antnN30c56pjNAuSxtlp93qxmFHxwY32ZAHpf6/ptpbxr+sS8ym8VFLAiN5279Rl5hGoBNF1MG6jbsZQZ4oNaksByRyu5n9v1ZmIUByhJw74xyclFK3ZO9284NkAFCS/N MIvbHEb1 NFlf21Dm/YMJ6XqxTzLrToQyX2SpUlm5TqTf5yEGzldSQgQZaeHxtn1r2eLNbt7soU+vjcU4pQcP6AmPfcg4mtcCLbD0ph91BDBolfIWk+MWqvMpGvRxZqFaQh+FYBu82GK6odMl2krvzCUm5WW/yANYcz7ogmB92q+ESW2gn87PdJqS27nFexXoyYB4EQ+cXwXiiMSpgZtYmUqf4GnSgz6iNzdrie9rSbWppgUOtBsYLHFV45px+UB7SagoV6JUPsUPQnXePxIWDeQH2b6shXKmtStuE13GPwAQ6q2C40IerwqiVt3GIfY+JclhcUTrAfRKG/FwqqHEuQlE0ns9IRzQu7btICY6zNgosMNA0dI0MrMTwF3rwVeKiovRXUIJ1twxjb/kOPYwL6yOXeD57tKqYTJvvfYalICGeh9kULlWITjNUd1DbFhoRz77s51jgKC1nq1dykwNdgcwlvv1yNyoFUplrkQg9wjDZdC4M2bCYrOMALifsFPyYgA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 6, 2025 at 4:25=E2=80=AFAM Kirill A. Shutemov wrote: > > try_alloc_pages() will not attempt to allocate memory if the system has > *any* unaccepted memory. Memory is accepted as needed and can remain in > the system indefinitely, causing the interface to always fail. > > Rather than immediately giving up, attempt to use already accepted > memory on free lists. > > Pass 'alloc_flags' to cond_accept_memory() and do not accept new memory > for ALLOC_TRYLOCK requests. > > Signed-off-by: Kirill A. Shutemov > Fixes: 97769a53f117 ("mm, bpf: Introduce try_alloc_pages() for opportunis= tic page allocation") Thanks for working on this, but the fixes tag is overkill. This limitation is not causing any issues in our setups. Improving it is certainly better, of course. Acked-by: Alexei Starovoitov