From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDAE1C4829B for ; Thu, 8 Feb 2024 02:59:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 529D26B0078; Wed, 7 Feb 2024 21:59:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DA4B6B007D; Wed, 7 Feb 2024 21:59:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A1066B007E; Wed, 7 Feb 2024 21:59:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 26E666B0078 for ; Wed, 7 Feb 2024 21:59:19 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E3EF3807F1 for ; Thu, 8 Feb 2024 02:59:18 +0000 (UTC) X-FDA: 81767130396.09.1081E0A Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf25.hostedemail.com (Postfix) with ESMTP id 3C645A0008 for ; Thu, 8 Feb 2024 02:59:16 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YPeMNDeX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707361157; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C3PiS1b99aSmkX7dYRgJE89NBaUaPOmZB+2Ux50Yp14=; b=guvmTSgTbrrhsF81MTGcWtMEg6J+8U7uS6GIBnc1UKV2m2mTBgqyyzfK6H+bRRuLJhQqU2 LQfCL8hcXTyERs3+VQNSLOQ3CnHvG4h5x9sM7+EiKShNZ4rec25z/MDAkMoXk8ZWbaMRZ1 EnYrFQ9lYLtQh+P1cyesV5d9L/6Ivy8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YPeMNDeX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707361157; a=rsa-sha256; cv=none; b=VHsuHqCmPZqMIMpFs4Ee+croho+dgEemVY4Vs2MHpX3Z2Qbj9H2TYtXAbYZE2BGi1BXOpC P8Jmtmk38vere86pI/lsY59W2LzUQZ48V7fkVaG3PwtXEm2nk8iNdVbc2P483UC9cZxkmM beWlelMvW5MBbusckumxKYGUiG8puO8= Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4101d4c5772so2462845e9.0 for ; Wed, 07 Feb 2024 18:59:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707361155; x=1707965955; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=C3PiS1b99aSmkX7dYRgJE89NBaUaPOmZB+2Ux50Yp14=; b=YPeMNDeXHVc1GAK8pe0Vic99u3CEzAJcycQHN8k0sHEuaet4ETaVHJDn8dx5LmuHbW +DuONs2DzJMpDUB8lYjOY28/k0GFENfwdhdiREKb26Sk9OwOK3M4qlJhHMjyX/xEbTSd X75KMPngoJrMFkzaR5RA2G5CdwTRYDc/DXYI2sN9QqrYUTbTLO8By7dhqs74AZIgfPGz eDe0WZglW8/Xx9i4bZl7NgtAz5ClGWBnz3x3m65qmE1hTNtOd9wwrCF7NaIJ8R4FHDhe 1cqUX3DVF6MjKlpieohW3abEvuTGC1JGTDgpQrVxE3QoLai+PglYKou22IyVSwzg7pQG OWTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707361156; x=1707965956; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C3PiS1b99aSmkX7dYRgJE89NBaUaPOmZB+2Ux50Yp14=; b=CUYS2AoaiFTXtQzBsreUa78XNBrZG7TQwVvoAE0JKf/gd06wI5bTP6EmhaAInJHjPk 9fO7WVhtVW6oMSkFaCp15dY4jjlhZ8mkX/Waz6w4r9zYzfLuH+ksC9y8M65oi15PYXQc RW+arW2VSMQ0u44wWNu2mXPs1jPKfiGzbKDO1pRdnfAokERQ4BIt1HdxEtTsKMen4Icy 3AxGSiY9fP7dlLsfzCy3fkh7/RnJ2Bl5fLxMs3bAvIfPGDgHrI1+4hfMQTehvMOk8qxu pUhbfDFZERqYsRHdLYze61kRO9m6UeMdNJhKp5XYJS5QsCii9EWjM6OsDuXDQSxdyG9r HPDQ== X-Gm-Message-State: AOJu0Yym7OED6ncy/xEi8gkXqW7DeiEncEyb/l8DjJ/Qs4zT+3B0jiTd ly+TIWcNGdbGdHbxLgtO5wJWRDxlEmGWCV5byqL0VrCMfGC34Pr6F3/yBE130CpOqUXlNnISLQ9 3nuNBV7jcVrglBfmNlOiWHoGzxec= X-Google-Smtp-Source: AGHT+IGKxAZPXhM0mf+tQ51rZWA3KExGsBCXl8HVYbDDkZgMnpJ5Y6sEX5AiMNJHIZmYB4UMRerZtXlp/VQHhVkXr30= X-Received: by 2002:a05:600c:4fd3:b0:40f:d145:63cb with SMTP id o19-20020a05600c4fd300b0040fd14563cbmr798966wmq.9.1707361155500; Wed, 07 Feb 2024 18:59:15 -0800 (PST) MIME-Version: 1.0 References: <20240206220441.38311-1-alexei.starovoitov@gmail.com> <20240206220441.38311-16-alexei.starovoitov@gmail.com> <3115274419b6bf0a27facdc0b41094842fc61c84.camel@gmail.com> In-Reply-To: <3115274419b6bf0a27facdc0b41094842fc61c84.camel@gmail.com> From: Alexei Starovoitov Date: Wed, 7 Feb 2024 18:59:04 -0800 Message-ID: Subject: Re: [PATCH bpf-next 15/16] selftests/bpf: Add bpf_arena_list test. To: Eduard Zingerman Cc: bpf , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Kumar Kartikeya Dwivedi , Tejun Heo , Barret Rhoden , Johannes Weiner , linux-mm , Kernel Team Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3C645A0008 X-Stat-Signature: fg3xoup3pm9p139yai9st8wxrwxxjhpc X-Rspam-User: X-HE-Tag: 1707361156-321502 X-HE-Meta: U2FsdGVkX1+Ng3oPG0gi53KCTtpZMv1rha0kTBbHJi/VVzyCSX2rGEzzR+O0zBumWSu5DdWh2kAaEwNApsHlO5VwkaDKnKKBUKe6IsSKpTyqHJ4Y+TVTf7P1v16Qtr/wtImaf+kB1Br9/zdRMX7EUWz/QPdRKoszyIOeWYVaWSJsaKaCVz/taSDFDXIwtr8RgZ+14Gs//Eqg4Fl4hoBcA8pbKliFOfQ4Bnqt45bKtJ68EfAtuIDGldkWGcF922/DoklzAORWlsViFglefGW3ksFIY6W9grAotqBu4M/agb2Gu15ASWpLoyAcAvjofgzZMGQr33+4BurTRoWF4BpbpQy1RAj+jMjdZsxH9QW2Q7yN9Mbm7K+U3pBw6z1No4EDEKBoiOgfuFPhoPWkzCugVH6ZHr00UDTlNYKoAJjjgiNtowAgwYEFaRYGONPhUQsRgrKi8kGwvtaD4ql1ZHyiScPiuvR/oX7OESG5zaHoiecDCbsBnOYp46R0Oi+jQdn/G0ftXLFu2VmZOCbvztGW0OVqcFSamQ0xcukD0/TtkQwT/urwS1NMGwWSF0YF3Ovq8yyXVb/sg6ygaM085My5IaHdiPzdSw7aXyjTeEOHwqAl5o9ybKbU5vOCRXXYJ+VkGsrLhknC00Y3dFLQU+47NdziQvggR7WLaDwHfKImlAptKmV5/9cmARDd32yqWZbq9WMXsGItCrv0JdZ8/qebXNCNMovAR8BHqIHiud8F3zGk1xK98UhZH3XIxTs6hVL08MkAQGJfnKSt648sb8xHnAwqLWUOFWPIE+gqBO7uLG24vhlWjKhDSGZvcljaOLN80TjWoUH9mg5E6Zh99P0aq1PSSecjOZPtFFvNcZwFic078Gs2odb9tDWGqtWthn706qj9zav9xtIjDJw8HXwnGl+/5Czq0B0H9Uucz+1y/l2QCy3MKfhj9e+DjHUNJrylIu4v7PnR89Q23GLC72/ MnMbPd4o EgKY0bkix/OzXFTkR8G+jhZne3xARqAYR+9w8OeYh3Yj75q4SwYGTOkbqbhx3EK27nIgbl0BmFXOmkEKi9g44hK/YoFoC2HyZsWwm6dhmRJEydVo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000969, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 7, 2024 at 9:04=E2=80=AFAM Eduard Zingerman = wrote: > > On Tue, 2024-02-06 at 14:04 -0800, Alexei Starovoitov wrote: > [...] > > > diff --git a/tools/testing/selftests/bpf/bpf_arena_list.h b/tools/testi= ng/selftests/bpf/bpf_arena_list.h > > new file mode 100644 > > index 000000000000..9f34142b0f65 > > --- /dev/null > > +++ b/tools/testing/selftests/bpf/bpf_arena_list.h > > [...] > > > +#ifndef __BPF__ > > +static inline void *bpf_iter_num_new(struct bpf_iter_num *, int, int) = { return NULL; } > > +static inline void bpf_iter_num_destroy(struct bpf_iter_num *) {} > > +static inline bool bpf_iter_num_next(struct bpf_iter_num *) { return t= rue; } > > +#endif > > Note: when compiling using current clang 'main' (make test_progs) this re= ports the following errors: > > In file included from tools/testing/selftests/bpf/prog_tests/arena_list.c= :9: > ./bpf_arena_list.h:28:59: error: omitting the parameter name in a functio= n > definition is a C23 extension [-Werror,-= Wc23-extensions] > 28 | static inline void *bpf_iter_num_new(struct bpf_iter_num *, int, = int) { return NULL; } > ... > > So I had to give parameter names for the above functions. Thanks. Fixed. Too bad gcc 12 didn't catch it.