From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0485ECF6497 for ; Sun, 29 Sep 2024 17:04:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68383900004; Sun, 29 Sep 2024 13:04:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 633E58D0002; Sun, 29 Sep 2024 13:04:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 521B6900004; Sun, 29 Sep 2024 13:04:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 357178D0002 for ; Sun, 29 Sep 2024 13:04:16 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9EBCD160AEB for ; Sun, 29 Sep 2024 17:04:15 +0000 (UTC) X-FDA: 82618398870.16.27A6AAF Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf24.hostedemail.com (Postfix) with ESMTP id CC40618000A for ; Sun, 29 Sep 2024 17:04:13 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bf9hGtIO; spf=pass (imf24.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727629329; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+KNmNodar/eEa8xt2lx9x8Ctw0w3iXIFOpWndbX0j5o=; b=GEQe59CsN2Pj/m3kjtwU8doYBEOU1BwcxXoSgmuoObE8Cl70ZOBhPUXyAOQVv9bLLfk/c5 zCYQ8XaBe2zCwLuet6Y+M6RAOqPBOBkonCw73S6fwjxN2eGrLLFkoQThcaWzc6jrS4Nh+Q vi8GEYgTsmSOXgkcT4+FBFpVkQcNqFA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727629329; a=rsa-sha256; cv=none; b=Gm6o9oSHUf+nidfwQW19+vMzlMrf8zEs8u97UW7JYCVFpRAh37BWPieJU2WDPppVK774xs K7DBRWWZ53Nz7QWRSPONJCaCtfazV3C2A3wV4YCZah6E+CQMczyFrmE9w8XVt0l0dcfzEd GBBvx7ua33OUOFfeuOgOIGZjA8/Fb3w= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bf9hGtIO; spf=pass (imf24.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-42cc8782869so33796775e9.2 for ; Sun, 29 Sep 2024 10:04:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727629452; x=1728234252; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+KNmNodar/eEa8xt2lx9x8Ctw0w3iXIFOpWndbX0j5o=; b=bf9hGtIOFriO15WVZr8ZGnyguvwnBoeSisNP2DMujd6tq/wMqGk1AwFRMxJrGIi60J jq1Le7KRC/Pe1r+N4EEuea2Eki7+ydPm39vaQpsVVlfXdIM7GUKiVNtaB6e2U+uni43M SEUcOIFx8QsYspMgS1U9LhULAJq/kpoyQ/ey6AiB4SESs+DvJ1q51WpjuvBbuam3LvPB ADZQFIx3FIUwazZhZiiCD+JwmOMg5cVh2fFUR+h01D2cuIcLH1ha6sLT9ea9M5tfjA6C IlLey8/WEZxqvYI64YCueFLQGmYSzfbZ62zTSgo+/evdTUPpXXuLP5iKbuLKWTWN6abj ItMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727629452; x=1728234252; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+KNmNodar/eEa8xt2lx9x8Ctw0w3iXIFOpWndbX0j5o=; b=jNN9yCJxx9swT8hNJ+ZzWBVzpm8dmDjs1P4mUE9VGU5v7Q84xGL4uKPiKCNLKAgNBr AXrxjN/XY0mEMr7wUvzFzExhn9S04FikbjqsZmrQi6Gs0pMYNipEBcJC6EwTFx785OBT tdSmbciOymYxy1ikQKyzXbh68CFKJo7Du8duMpp11pAq4bLhyxMfdZHgOGnpC5M2e9sK Q4AZZdKYNwxEsZFnKjSyIkmZal2z38m/v3mLG0vj94711ShStkr84gW6plq/5J+JnD1R WzW5Toxyxz52O3vffaRPeUZqBNdLKkDOX9uaNFjnet/7u7ZTxYUormNkdpl9B714TLqi qvLw== X-Forwarded-Encrypted: i=1; AJvYcCVLoQ6oAwn0rGvDLgzW1895+1zMf8u/Ip3F0CRQ7SUvEEF/lyX943QpDY6Lcufsd7SVkL7EXmgP5Q==@kvack.org X-Gm-Message-State: AOJu0Yx4U9Tk0eYc8rY+KG+Mvtl8Xc3w3dgsfZ9a8AgSZDetMxeeDx8V 3+0xLSu6lOHjKTkbz5BRh9pyw08ieILxWfRNbTDsAgncBLqrMeuoi+kaq8MYA9GFZ82re6F//Wo DkE6kM5Z2VYxPFX/Bx772Nujmnjk= X-Google-Smtp-Source: AGHT+IG9fdMIzAIyKzOuEVwQI+qzk40+S2RJR82r0eUZgTURwnbYJ2CkT++ONN6gi3TikMVmUxg04i3XP94jUBvFjOM= X-Received: by 2002:a05:600c:5125:b0:42c:b22e:fc2e with SMTP id 5b1f17b1804b1-42f5844b601mr73121615e9.15.1727629451995; Sun, 29 Sep 2024 10:04:11 -0700 (PDT) MIME-Version: 1.0 References: <20240927184133.968283-1-namhyung@kernel.org> <20240927184133.968283-2-namhyung@kernel.org> In-Reply-To: <20240927184133.968283-2-namhyung@kernel.org> From: Alexei Starovoitov Date: Sun, 29 Sep 2024 10:04:00 -0700 Message-ID: Subject: Re: [RFC/PATCH bpf-next 1/3] bpf: Add kmem_cache iterator To: Namhyung Kim Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , LKML , bpf , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm , Arnaldo Carvalho de Melo Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CC40618000A X-Stat-Signature: 436qjtpcd3crzmnxdjrtzsg6wc3n8nhr X-HE-Tag: 1727629453-497282 X-HE-Meta: U2FsdGVkX19m+jCsJwKz6uPfOOBh/YRe/76y55FAO51ZFCR7NstGZdANRhUEj9Fqexpq+w+IvQhd8QhWL1OtLEBA5bX4AuPKoExJBZTxsj12XKrCSuIF1/7K/oPXkWtc9OP/7rLXe/Oh4MZapUHQr9NSit2szPH18/TG3JSOXsLZVOsJno8qyE35/N+AZ58oYS2i3f/cMK0IXI+88Hg8PeDZPJoyRgtrxMzdLd7U7p3fI0O9nBj4FKON7Gsovkj05jgEoCZkuQtdSIblEZ5tft3V/EPbsWW/Wo5VNO7y4PQLnCEfhG6R6GriAU6OO1LAbrPbUCTbU2nfxEfkMlhgdm+KpzOvj3F2FUHlUhQItwV28jMA7KpIjMkKkART0jtP5MJF2m6QTsNIauCiM/29NA+hGkbU+LLEcyqUnu+O3f/T6oA62pdWFOSP3Lo7UyGFwdt8YvO1kL57l6n6LxrNFPztq1qTWyBFjEvTRmcSMt2XgiIp5/0HpMmJpyfG2B14iJzYPdklIWDXWpyRr8qSLNJgsKOaQrE+rbKFQ//47yM4aAsGFeBwVm+xBMdKGB2SjsD7ntCS204iVbHMGzL3uAGWCjnCu1i2EFZUnbfFYv1Nrmk7ppJIsU3wIntJ4rsfNUmY2n3uxkujJOzJC22pht+fm/w2GH7y5TsNJrvWCcRqqJgtGK977FI2YV+xk7KSQZKVre7tdTre6taD+2u96Zjf4CcJMNsEcFtHhbcI4KARKv3DSuPHHMwJLf+/Y9/tEW9sgHy5trsiAOtQ7g5UomVrt1Z0+c41RXBCLAa2AfGyd/JCf34zViycjm0zihO1W6L8btZMXuX4Vx8DJjmeUWcyeHQOUFKtooPqufRsF1RJlVGztZYSkZp/IiAQVsBacjopwsmQSOcOFAgK1KSq1Tvt7YDTWu+MjHawmr0/z+h3sqBTISDxc95Zod1nCe8TotVRh1KgCRSAgGL3y9i QxP28msG i3SFlY771tE13CQ03jdjTyMY9QMuU7P/Vta8oM7RLU7ri1JjDOb/CEix9eW7K4yMMagZ8x+Mt8z8yVmS0Xry0x5qcW6xCY8slT5j1GcB0mfEwtn9Int6diMMaslLdRraONUTnbmjcsFQGpjXLMce78/ozl/I1P95e6khZjr+YsalsusXYOfifeS/l/J3mHnKRKpPYvOtl/cF6ygyCiQeVcm8e/AhWOlXpmU/JzLKaBiTPMDMuZKrKff4abqS/5kxR/h+W1//+GxQ+yUA4jZXH//UGdKdwUU1sLIalHvyAaC8NdLFS3Mn+0LQrOoHluoi1Ytc6WPd8FsgZ0Ahi4lRE2dkVOiKhZiAvjbYLfEQajpSVpskSfiNu5tELTFBoTwfVP/v/ROu9Y44paynEJPPIzZo/ILyvw7+aeJ3qt9pI5h6xGaPPV9Ovw3L9QlaQq7xgSjRHtbmjz1q34UaXEiJhq8A90f4YADqJ7P3RKj/NkyXAS+G4aZbyJZP75SiX5wD6cMcmROFB2wvgwx4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 27, 2024 at 11:41=E2=80=AFAM Namhyung Kim = wrote: > +static void *kmem_cache_iter_seq_start(struct seq_file *seq, loff_t *pos= ) > +{ > + loff_t cnt =3D 0; > + struct kmem_cache *s =3D NULL; > + > + mutex_lock(&slab_mutex); It would be better to find a way to iterate slabs without holding the mutex for the duration of the loop. Maybe use refcnt to hold the kmem_cache while bpf prog is looking at it?