From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ABDCC4829A for ; Sat, 10 Feb 2024 04:38:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C31936B007D; Fri, 9 Feb 2024 23:38:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C08B26B0080; Fri, 9 Feb 2024 23:38:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADAF46B007D; Fri, 9 Feb 2024 23:38:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 99F256B007D for ; Fri, 9 Feb 2024 23:38:47 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 458AFA1036 for ; Sat, 10 Feb 2024 04:38:47 +0000 (UTC) X-FDA: 81774638694.02.E48475A Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by imf20.hostedemail.com (Postfix) with ESMTP id 6DF721C0002 for ; Sat, 10 Feb 2024 04:38:44 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Aj5PsaPR; spf=pass (imf20.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707539924; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z6Zlup8iomPkzs8TJs5tn797XN1N7V8PDpjald6vSBk=; b=MpyTSEevuDQcSkeaVK3Tq1xi4XLFxujXNCi27F5JwfVQ3m39qWT03cwRI1s+jNzZh+S/pl Qo6mUzDqGzw2ttAm1aG18clwCA+TVTJBaBABh5v8awFSJ81Hx8Fc1cNh6bPsBgvY0iuUPG ZUD54757DRWuNRFpWcmsxBNldBn7biE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707539924; a=rsa-sha256; cv=none; b=do/KiqFupAVcubRyPUzQuk0lzQYzmy6zWZoFhgVRDMN9C3xbi9guFiFf6jKA7UvFtR9lvK BEUAnhxbSeyIPeVWzwoR2QX9N8Y2Y9zt9bLm14/C9GXMj9DeG46FRfOtjMFmJ/nJ7ZUYgw S6/mJoIgRiXbTOrTjFp8aKSJm4wycnU= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Aj5PsaPR; spf=pass (imf20.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-41090edfeb3so1096275e9.2 for ; Fri, 09 Feb 2024 20:38:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707539923; x=1708144723; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Z6Zlup8iomPkzs8TJs5tn797XN1N7V8PDpjald6vSBk=; b=Aj5PsaPRoQvJ01KnqDtW+mpszzAhbNS+svifO0TxRFhpi/ElxK2CG2l99S2mh+4dH5 Ar3US/qe8Dx0SUcamkAlE09GTKcN/kTiF5Ux3+DmzWfMwsAUi4bHGCTQ8rkbtE8fo+8T Rlkjc3yxVB3ywl4UijTkQVBT24SeC6SHiAxWEE2rcjObgs24Z74dJ05wAk5N3Xl8jNS9 L94vmV+3Ed2Me1IRimGHqHoAqYQwOkPVix02NHpQJVGVuWNN79IIKGEeCqHkX/0SEx1x fa1hLunh5DD2yVbfwmh7PeHK2G/GoKgEHMokWsNypNj2l7pBLDGxrrFCCknCNUcp0SFx WulA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707539923; x=1708144723; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z6Zlup8iomPkzs8TJs5tn797XN1N7V8PDpjald6vSBk=; b=kylTZRnb1osq5EMEWqBly02hER43koLIDvwDmSn65grtqbp6z6UeDL+PWEYkAT9NDP +2cRKlN8WcF6PW9x71tx/sjrqyUCKbJAMxjcbQ2km7BSCDmo2N8DJjO4WCBKo0vll/Ud hY57hzgZS3rNlME5Gcz6u+LpiOaEFVmxmtSQzbf+yVAIFb1y3+fDIylAATYL3hA2uLZ1 jDAbgjpNKuQbClMkvVqaeM2UIu+vCa+RO2+z/n7ej0F3ZA4wzWeuJMAk0nyqIN3eV58j 05dOLaVKs4V0nhrj5uYyVeJcVTnuefg28fV2HOtfnLuybUMbN5ZuQCl8HugxXVx2lZc8 nLYg== X-Gm-Message-State: AOJu0YyJ9jjxRjeiHT5NR/tNb/YhvuGVT3vmdxEwHMnGtQqNbOkP8a19 i/s9B0li2mX6jdIUgD6uw0VrAvOBtc+3Cv/IUnTcnLRgK6S5bVZHt7Z+sSI9O/RWCXpef4fiV08 Us/m0YAaZ7U8NwolnCdZTwqKJfOY= X-Google-Smtp-Source: AGHT+IEckgyJXtExzgMpqKsN7RM+kh6aI/P91uoCSe0NeawVq/NvTH4M2i5t+5WcZvbV/QSKhoZCcaVxPEmVxeHIYqo= X-Received: by 2002:adf:ce92:0:b0:33b:5b10:acc2 with SMTP id r18-20020adfce92000000b0033b5b10acc2mr510961wrn.28.1707539922801; Fri, 09 Feb 2024 20:38:42 -0800 (PST) MIME-Version: 1.0 References: <20240209040608.98927-1-alexei.starovoitov@gmail.com> <20240209040608.98927-6-alexei.starovoitov@gmail.com> <20240209203634.GA3615691@maniforge.lan> In-Reply-To: <20240209203634.GA3615691@maniforge.lan> From: Alexei Starovoitov Date: Fri, 9 Feb 2024 20:38:31 -0800 Message-ID: Subject: Re: [PATCH v2 bpf-next 05/20] bpf: Introduce bpf_arena. To: David Vernet Cc: bpf , Daniel Borkmann , Andrii Nakryiko , Kumar Kartikeya Dwivedi , Eddy Z , Tejun Heo , Barret Rhoden , Johannes Weiner , Lorenzo Stoakes , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , linux-mm , Kernel Team Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 6DF721C0002 X-Rspam-User: X-Stat-Signature: rr978rjjb1j6rtm5wn9k6edw6yaewzkf X-Rspamd-Server: rspam03 X-HE-Tag: 1707539924-289705 X-HE-Meta: U2FsdGVkX18+AscWM05y6Pptw3BlIsiTF7wigJVHNFjR4jAdInlEI3ekjP0Vvfggs2L5RWm0IIfO1z4h5iPYJP1xCR7XKMPtOE0t5+vsk9eol3BKXdajJA4x8RUrMfGxm/G0NqWgqSlx5a43Ly/v8XCV28LxCXqheeSzpTRkOA5ilGcKDck49g/q4bprKsdS9TphVDDYuPHvYaz1XI1EiicSwPTPmL8M8DCVAF5xMw6Jwnx31muBjaPeAE5jWKdYFUQTWmALLke3lchUUEld2O0fBrWqycfphApHnUyIp/2Zw3aJk+rngNqAL0I+aIXumZQPNOypG/atfcIzfBxT0MWnjyY7bxpO+qRDsPsLexsJt3Im9ErdMN0z46XVPfUbSTLwAjP+kL4+3qEJJpgY74yhlWmD9FvZIeEV2nPOYoEF94o/H9t1u2afqb5KIb8BTNSUJBrDUCGAgEkhukRrOxwSZ2qI/t33xs9i7Ru9hUGWMTPdrLeuUgEfPVUknoEHsnix5hqvrHksmj2xSIDBrNwjapN7R3Y3oadddX4PoqJdHa89F805A2DMKHtfGglH6vQipyJPYPqQcyiWKMY6TBIOL5JyqBq0X4yDOUfnO0SiS7BiuvDYqD56k1hA4vjR4/Q/10YUfTvZCQHPADsFTI4FvJcojrQWsC8z0cYzhGXOauwD7Q3HKtpeJkbQDEBL1u88nBen7dNibG8Xvf9BD5ht0hUptr4i7o/PoGAmIA+iRjsHnTba+w8Jpf3ht2LFG262e5iw0VnOXf9FwwqdvxOZdnX9CSUu2ioHa3UXHnNExXJarBYneORrUJ9TsNOALpNUW2mGvc0Ql6thWcqbXoUDm56dEVWzDNsP3V9K3x3eRNvTyTO8vh//7y9D9peBY/kEJJnyIckRwzwjjd8xYKco02m6ibDlqYa9JZBOF6Yw6TkbipbrlXKBeji8sXhgjZas9t+S/uG5E3FpJFg u9J5Ii73 JqaHbNyELTFKk0r9Gt2Jz57gb2a7fKuvopCuqgG75/pJ0OpG0KM5RH0q6TiRAMoWIdMrLTa/cT/vI/VdFKBlxXBSIEA6N8BtX2oOrRUoTpGdQFp41XPluBtkrdRKTenFpRE6uU19T8HHnhL3Zhzf5TuEKPAnVOXPA45Fq5UV6GyXNiTrYe0/ctgdypICaXO6UkS93JGKovLT4E5v3eNXY0KQHkiKK61d6FllJ2cnVnUnDi66XjhpnfelsbFRvijt0nufTcI07vLg3v5ne9cae1GKTyp7oJ+4eoHannrM2QNyB43t+28skW7zApZxSyAmgnbfORApKKJI0mSSxsEt7VM4HTpgEwglgwIUNW2vHCPv1ZpbBBrWw2jdfI2MtOowhtA7XPQpt5GkUt3GmT0HiD8ABL43i8IQzflgpA4FAamJBDXFxeVhlgrXgn2W9lK69ZOVQKPu379/v7L47HjABGPYxYGNBlGoBeDFMfTeA2V+7IHiqJ/AAz/+ZaPbo5SEk8KwscxliN7MjZjVRUA4v3LYIGE9oVmJTeqR9SLcQrYpJ8yk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000304, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 9, 2024 at 12:36=E2=80=AFPM David Vernet w= rote: > > + if (attr->map_extra & ~PAGE_MASK) > > + /* If non-zero the map_extra is an expected user VMA star= t address */ > > + return ERR_PTR(-EINVAL); > > So I haven't done a thorough review of this patch, beyond trying to > understand the semantics of bpf arenas. On that note, could you please > document the semantics of map_extra with arena maps where map_extra is > defined in [0]? > > [0]: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/tre= e/include/uapi/linux/bpf.h#n1439 Good point. Done.